D3665: graph: improve graph output by using Unicode characters

johnstiles added a comment. OK, I've fixed the latest nits in this diff, as well as changing the circle characters as discussed to: U+25CB○ <- changeset U+25CC◌ <- obsolete (as before) U+25CD◍ <- active REPOSITORY rHG Mercurial REVISION DETAIL

D3671: advanceboundary: add dryrun parameter

khanchi97 added inline comments. INLINE COMMENTS > khanchi97 wrote in phases.py:371 > I thought we would calculate `rejected` only when we are in dryrun mode. okay its fine. I will remove this unnecessary condition. Because I think `rejected` value can also be used in `phase` method of

D3671: advanceboundary: add dryrun parameter

khanchi97 updated this revision to Diff 8940. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3671?vs=8928=8940 REVISION DETAIL https://phab.mercurial-scm.org/D3671 AFFECTED FILES mercurial/phases.py CHANGE DETAILS diff --git a/mercurial/phases.py

Re: D3673: grep: enables passing wdir as a revision in grep

> --- a/mercurial/commands.py > +++ b/mercurial/commands.py > @@ -2513,19 +2513,27 @@ > @util.cachefunc > def binary(): > flog = getfile(fn) > -return stringutil.binary(flog.read(ctx.filenode(fn))) > +try: > +content =

D3673: grep: enables passing wdir as a revision in grep

yuja added a comment. > - a/mercurial/commands.py +++ b/mercurial/commands.py @@ -2513,19 +2513,27 @@ @util.cachefunc def binary(): flog = getfile(fn) > - return stringutil.binary(flog.read(ctx.filenode(fn))) +try: + content = flog.read(ctx.filenode(fn)) +

D3444: tests: comprehensively test exit handling

durin42 accepted this revision. durin42 added a comment. This revision is now accepted and ready to land. This LG, esp with https://phab.mercurial-scm.org/D3445 which appears to be its child, but https://phab.mercurial-scm.org/D3445 still needs rebased AFAICT REPOSITORY rHG Mercurial

D3445: dispatch: validate return type from dispatch() return value

durin42 requested changes to this revision. durin42 added a comment. (derp, that was me, but my password vault mis-fired and I got admin instead of me.) REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3445 To: indygreg, #hg-reviewers, admin, durin42 Cc:

D3639: remotenames: add paths argument to remotenames revset

durin42 added a comment. I like the literal/re pattern idea. I think if this lands I can stop maintaining remotebranches, so I'd very much like to see it land. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3639 To: pulkit, #hg-reviewers Cc: durin42, yuja,

D3650: serve: add an option to open in the default browser

durin42 added a comment. I don't love the flag name, and am -0 on the feature in general. All terminal emulators I've used in the last 10 years have URL detection logic and make clicking the link trivial... REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3650

D3532: wireprotov2: define and implement "rawstorefile" command

durin42 added a comment. I'm...not thrilled by the abstraction leak in this, but as long as it's strictly temporary on the path to saner partial clones I can live with it. INLINE COMMENTS > wireprotocol.txt:1935 > + (unsigned integer) Number of files being included in the payload. >

D3445: dispatch: validate return type from dispatch() return value

admin requested changes to this revision. admin added a comment. This revision now requires changes to proceed. This looks good, but needs rebased. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3445 To: indygreg, #hg-reviewers, admin Cc: admin, yuja,

[PATCH STABLE] lfs: bypass wrapped functions when reposetup() hasn't been called (issue5902)

# HG changeset patch # User Matt Harbison # Date 1527772749 14400 # Thu May 31 09:19:09 2018 -0400 # Branch stable # Node ID 0572b9d0ebd0a57c18140a2e6294cecb6e4d8961 # Parent a3b4ccbec269a4ffabdcc681212a36bbbdc4cca8 lfs: bypass wrapped functions when reposetup() hasn't been called

[PATCH 2 of 2] tests: adapt test-check-pylint to run on Windows

# HG changeset patch # User Matt Harbison # Date 1527819352 14400 # Thu May 31 22:15:52 2018 -0400 # Node ID 7164b44b0dbef0923363f9f3f493bdfd37592e27 # Parent 0de423ecd560edaa0f1eb25cc265c3b2e8caf0f0 tests: adapt test-check-pylint to run on Windows The line endings are explicitly converted

[PATCH 1 of 2] hghave: avoid a deadlock reading the child process's output

# HG changeset patch # User Matt Harbison # Date 1527819107 14400 # Thu May 31 22:11:47 2018 -0400 # Node ID 0de423ecd560edaa0f1eb25cc265c3b2e8caf0f0 # Parent 7fa3408f83ef1a04e2d23ab6f8498833b450e589 hghave: avoid a deadlock reading the child process's output The output of `pylint` is

[Bug 5905] New: Receiving inconsistent heads / phases data can result in mass phase advancement

https://bz.mercurial-scm.org/show_bug.cgi?id=5905 Bug ID: 5905 Summary: Receiving inconsistent heads / phases data can result in mass phase advancement Product: Mercurial Version: default branch Hardware: All

[Bug 5904] New: evolve 8.0 crashes with 4.5.3

https://bz.mercurial-scm.org/show_bug.cgi?id=5904 Bug ID: 5904 Summary: evolve 8.0 crashes with 4.5.3 Product: Mercurial Version: 4.5.3 Hardware: All OS: All Status: UNCONFIRMED Severity: bug

[PATCH 1 of 5] spartan: add missing closing tags

# HG changeset patch # User Anton Shestakov # Date 1527756722 -28800 # Thu May 31 16:52:02 2018 +0800 # Node ID 5763aad1f7b9643c761d82a757ee0504a32b7c41 # Parent 5a87bf0bd34377f10b19d770acb943d7fda250f3 spartan: add missing closing tags Browsers apparently don't care about this, but let's

[PATCH 3 of 5] gitweb: don't show '[up]' in file view when in root directory already

# HG changeset patch # User Anton Shestakov # Date 1527762829 -28800 # Thu May 31 18:33:49 2018 +0800 # Node ID d588869f4819d644a448456535f5f860be3d0aca # Parent 75ffc56c904c74db5f77643de8bfe8c84a31ccbf gitweb: don't show '[up]' in file view when in root directory already diff --git

[PATCH 4 of 5] monoblue: don't show '[up]' in file view when in root directory already

# HG changeset patch # User Anton Shestakov # Date 1527763175 -28800 # Thu May 31 18:39:35 2018 +0800 # Node ID 376f6749677c4490644fef7590df666f66f0a47d # Parent d588869f4819d644a448456535f5f860be3d0aca monoblue: don't show '[up]' in file view when in root directory already diff --git

[PATCH 5 of 5] spartan: don't show '[up]' in file view when in root directory already

# HG changeset patch # User Anton Shestakov # Date 1527764008 -28800 # Thu May 31 18:53:28 2018 +0800 # Node ID a9591fc50eb394454125df2807c1fcd8f3cd8193 # Parent 376f6749677c4490644fef7590df666f66f0a47d spartan: don't show '[up]' in file view when in root directory already diff --git

[PATCH 2 of 5] paper: don't show '[up]' in file view when in root directory already

# HG changeset patch # User Anton Shestakov # Date 1527760914 -28800 # Thu May 31 18:01:54 2018 +0800 # Node ID 75ffc56c904c74db5f77643de8bfe8c84a31ccbf # Parent 5763aad1f7b9643c761d82a757ee0504a32b7c41 paper: don't show '[up]' in file view when in root directory already diff --git