D5043: hgdemandimport: vendor CPython 3.7 tokenizer modules

2018-10-13 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I have an evil plan to leverage the Python 3 tokenizer on Python 2.7. The added files are Lib/token.py and Lib/tokenize.py from cpython's Git

D5045: hgdemandimport: remove unused functionality from vendored modules

2018-10-13 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We'll never use this. It is just bloating the files. The PSF license section 3 stipulates that derived works... "include in any such work a brief summary of

D4850: store: pass matcher to store.datafiles() and filter files according to it

2018-10-13 Thread indygreg (Gregory Szorc)
indygreg added a comment. Another conceptual problem with this is that it assumes `data/` and `meta/` are used for tracking just filelogs and manifestlogs. In theory, other revlogs / data files could be stored there. For files / `data/` paths, I think we're OK making this assumption.

D5056: closehead: use correct format string for rev numbers

2018-10-13 Thread mbthomas (Mark Thomas)
mbthomas created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Python 3 requires %d for numbers. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D5056 AFFECTED FILES

D5056: closehead: use correct format string for rev numbers

2018-10-13 Thread pulkit (Pulkit Goyal)
pulkit added a comment. I took care of this in https://phab.mercurial-scm.org/D5040 ;) REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5056 To: mbthomas, #hg-reviewers, pulkit Cc: mercurial-devel ___ Mercurial-devel

D5057: test-bookmarks-pushpull: use correct tmp dir for no-bm-move.sh

2018-10-13 Thread mbthomas (Mark Thomas)
mbthomas created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY test-bookmarks-pushpull.t writes a temporary file in $TESTDIR instead of $TESTTMP. Make it use $TESTTMP instead. REPOSITORY rHG Mercurial BRANCH default

D5044: hgdemandimport: add PSF license and copyright notice to vendored files

2018-10-13 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This seems to be required per the PSFv2 license text. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5044 AFFECTED FILES

D5006: py3: three new passing tests

2018-10-13 Thread durin42 (Augie Fackler)
durin42 updated this revision to Diff 12001. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5006?vs=11917=12001 REVISION DETAIL https://phab.mercurial-scm.org/D5006 AFFECTED FILES contrib/python3-whitelist CHANGE DETAILS diff --git

D5052: mercurial: strip function return type annotations (RFC)

2018-10-13 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: hg-reviewers. REVISION SUMMARY THIS IS SUPER HACKY. DO NOT EVEN THINK ABOUT LANDING YET. Now that we have a custom module importer on Python 2 and that importer is using Python

D4849: store: introduce a function to get tracked path from a fncache entry

2018-10-13 Thread indygreg (Gregory Szorc)
indygreg requested changes to this revision. indygreg added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > store.py:36-37 > +return path[5:-2] > +elif path.startswith('dh/'): > +return path[3:-2] > +elif path.startswith('meta/'): The

D5004: tests: add lots of globs and conditional output lines

2018-10-13 Thread durin42 (Augie Fackler)
durin42 added a comment. The new quotes are from Python: they added the quotes in their import error messages. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5004 To: durin42, #hg-reviewers, indygreg Cc: indygreg, mjpieters, mercurial-devel

D5048: hgdemandimport: port line consuming to Python 2

2018-10-13 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This commit rewrites the line consuming to use next() on a generator in order to appease Python 2. With this commit, we are now able to emit some tokens on

D5046: hgdemandimport: adjust imports to reflect vendored module

2018-10-13 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The "token" module is renamed in our local copy. Import it appropriately. This angered test-check-module-imports due to attempting relative import

D5047: hgdemandimport: remove re.ASCII

2018-10-13 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is a Python 3'ism. Our intent is to only use this code from Python 2 and Python 2's behavior is essentially the same as re.ASCII AFAIK. REPOSITORY rHG

D5054: releasenotes: fix remaining bytes/unicode issues caught by tests

2018-10-13 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY All tests now pass. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5054 AFFECTED FILES hgext/releasenotes.py CHANGE DETAILS

D5053: relnotes: port to Python 3

2018-10-13 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The big annoyance here was having to feed textwrap unicodes instead of bytes, but it all seems to work. REPOSITORY rHG Mercurial REVISION DETAIL

D5056: closehead: use correct format string for rev numbers

2018-10-13 Thread mbthomas (Mark Thomas)
mbthomas updated this revision to Diff 12013. mbthomas added a comment. Herald added a reviewer: pulkit. Add whitelist for test this fixes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5056?vs=12012=12013 BRANCH default REVISION DETAIL

D4995: tests: disable one check on Python 3

2018-10-13 Thread durin42 (Augie Fackler)
durin42 updated this revision to Diff 11997. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4995?vs=11900=11997 REVISION DETAIL https://phab.mercurial-scm.org/D4995 AFFECTED FILES contrib/python3-whitelist tests/test-extension.t CHANGE DETAILS

D5050: tests: add test verifying our Python 3 tokenizer works

2018-10-13 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Our vendored Python 3.7 tokenizer is now fully working on Python 2.7. Let's verify that by adding a test that ensures we can tokenize all .py files

D5051: mercurial: implement custom module importer for Python 2.7 (RFC)

2018-10-13 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: hg-reviewers. REVISION SUMMARY THIS IS SUPER HACKY. IT DOESN'T INVALIDATE .pyc FILES, WHICH MEANS SOURCE CHANGES AREN'T PICKED UP. DO NOT LAND. REPOSITORY rHG Mercurial REVISION

D5049: hgdemandimport: don't use str.isidentifier()

2018-10-13 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This method doesn't exist in Python 2.7. The new code is equivalent to what Python was doing up until isidentifier() was introduced to Lib/tokenize.py in

D4849: store: introduce a function to get tracked path from a fncache entry

2018-10-13 Thread indygreg (Gregory Szorc)
indygreg added a comment. ... And the fncache tracks the paths that are fed into the vfs. I'm not sure why you'd want to strip the "data/" and "meta/" prefixes in this function. If you are operating on a filelog, you "know" that its path should be prefixed with "data/". REPOSITORY

D5055: py3: moar passing tests

2018-10-13 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a reviewer: pulkit. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5055 AFFECTED FILES contrib/python3-whitelist CHANGE DETAILS diff

D5025: py3: make test-contrib-perf.t work on python 3

2018-10-13 Thread pulkit (Pulkit Goyal)
pulkit added a comment. >> def perfstartup(ui, repo, **opts): >> opts = _byteskwargs(opts) >> timer, fm = gettimer(ui, opts) >> >> - cmd = sys.argv[0] +cmd = fsencode(sys.argv[0]) > > Applying fsencode() on sys.argv is probably wrong on Windows, but it's

D5056: closehead: use correct format string for rev numbers

2018-10-13 Thread mbthomas (Mark Thomas)
mbthomas abandoned this revision. mbthomas added a comment. In https://phab.mercurial-scm.org/D5056#75750, @pulkit wrote: > I took care of this in https://phab.mercurial-scm.org/D5040 ;) D'oh! REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5056 To:

D5058: match: optimize matcher when all patterns are of rootfilesin kind

2018-10-13 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Internally at Google, we use narrowspecs with only rootfilesin-kind patterns. Sometimes there are thousands of such patterns (i.e. thousands of tracked

Re: [PATCH 1 of 2] py3: pass in system string to vars(branchmap).__contains__()

2018-10-13 Thread Pulkit Goyal
On Sat, Oct 13, 2018 at 12:12 PM Yuya Nishihara wrote: > # HG changeset patch > # User Yuya Nishihara > # Date 1539421086 -7200 > # Sat Oct 13 10:58:06 2018 +0200 > # Node ID 7e85eb3b267f431106e6f523786712ca6a9ec4df > # Parent 0b46e1aa77609c48e77f73ef987807f4a123d6a5 > py3: pass in system

D5059: contrib: fix up output in check-config.py to use strs to avoid b prefixes

2018-10-13 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a reviewer: pulkit. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5059 AFFECTED FILES contrib/check-config.py

D5025: py3: make test-contrib-perf.t work on python 3

2018-10-13 Thread yuja (Yuya Nishihara)
yuja added a comment. > >> - cmd = sys.argv[0] +cmd = fsencode(sys.argv[0]) > > > > Applying fsencode() on sys.argv is probably wrong on Windows, but it's perf.py, > > I don't care. > > What's the right way to do it on windows? I think `encoding.strtolocal()`

[PATCH] graft: introduce --base option for using custom base revision for merge

2018-10-13 Thread Mads Kiilerich
# HG changeset patch # User Mads Kiilerich # Date 1539424786 -7200 # Sat Oct 13 11:59:46 2018 +0200 # Node ID 167e7e7bbead47fadfe4072143cc53b409e3d8b9 # Parent 38ac525b44c93fcadb3680d4ded56f1e5a0029b2 graft: introduce --base option for using custom base revision for merge The graft command

D5060: releasenotes: fix dumb whitespace bug I missed

2018-10-13 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5060 AFFECTED FILES hgext/releasenotes.py CHANGE DETAILS diff --git a/hgext/releasenotes.py

D5064: style: run black on a subset of mercurial

2018-10-13 Thread mjpieters (Martijn Pieters)
mjpieters created this revision. mjpieters added reviewers: indygreg, durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This applied black to the 20 smallest files in mercurial/: ls -S1 mercurial/*.py | tail -n20 | xargs black

D5069: help: adding a proper declaration for shortlist/basic commands

2018-10-13 Thread rdamazio (Rodrigo Damazio Bovendorp)
rdamazio added a comment. Done now. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5069 To: rdamazio, #hg-reviewers Cc: mercurial-devel ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org

D5071: run-tests: run tests with as many processes as cores by default

2018-10-13 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGe7e70c033783: run-tests: run tests with as many processes as cores by default (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5070: run-tests: print number of tests and parallel process count

2018-10-13 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG1039404c5e1d: run-tests: print number of tests and parallel process count (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5072: tests: fix last failure in test-tools.t

2018-10-13 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGbe0a5d2d5c78: tests: fix last failure in test-tools.t (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5072?vs=12038=12055

D5073: archival: don't try and fsdecode non-{bytes,str} objects

2018-10-13 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG844deb408a5b: archival: dont try and fsdecode non-{bytes,str} objects (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5068: help: assigning topic categories

2018-10-13 Thread rdamazio (Rodrigo Damazio Bovendorp)
rdamazio updated this revision to Diff 12063. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5068?vs=12042=12063 REVISION DETAIL https://phab.mercurial-scm.org/D5068 AFFECTED FILES doc/gendoc.py mercurial/help.py tests/test-globalopts.t

D5076: help: allow commands to be hidden

2018-10-13 Thread rdamazio (Rodrigo Damazio Bovendorp)
rdamazio created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is useful in enterprise environments where some workflows are discouraged. REPOSITORY rHG Mercurial REVISION DETAIL

D5082: py3: 3 more passing tests

2018-10-13 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a reviewer: pulkit. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5082 AFFECTED FILES contrib/python3-whitelist CHANGE DETAILS diff

D5083: tests: fix inline extension in test-fncache.t for Python 3

2018-10-13 Thread durin42 (Augie Fackler)
durin42 updated this revision to Diff 12077. Herald added a reviewer: pulkit. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5083?vs=12076=12077 REVISION DETAIL https://phab.mercurial-scm.org/D5083 AFFECTED FILES contrib/python3-whitelist

D5078: py3: fix infinitepush extension tests

2018-10-13 Thread mbthomas (Mark Thomas)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG090e5f3900b7: py3: fix infinitepush extension tests (authored by mbthomas, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5078?vs=12075=12078

D5084: py3: fix test-parse-date.t

2018-10-13 Thread mbthomas (Mark Thomas)
mbthomas created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D5084 AFFECTED FILES mercurial/utils/dateutil.py CHANGE DETAILS diff --git

D5084: py3: fix test-parse-date.t

2018-10-13 Thread mbthomas (Mark Thomas)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGd4d2c567bb72: py3: fix test-parse-date.t (authored by mbthomas, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D5084?vs=12080=12081#toc REPOSITORY rHG Mercurial CHANGES

D5080: context: open files in bytes mode

2018-10-13 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG2f47703c5489: context: open files in bytes mode (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5080?vs=12072=12085

[PATCH 3 of 5 V3] rust: exposing in parsers module

2018-10-13 Thread Georges Racinet
# HG changeset patch # User Georges Racinet # Date 1538060175 -7200 # Thu Sep 27 16:56:15 2018 +0200 # Node ID b1d2b4a4684a51ba9bfc3ea5bc6e177be65e4b69 # Parent 4b490e500a3551b03c41dc06f16aa506523719c6 # EXP-Topic rustancestors-contains rust: exposing in parsers module To build with the

[PATCH 5 of 5 V3] rust: rustlazyancestors.__contains__

2018-10-13 Thread Georges Racinet
# HG changeset patch # User Georges Racinet # Date 1539018701 -7200 # Mon Oct 08 19:11:41 2018 +0200 # Node ID 5c3f0974b9afb074df9acd626813064eb6f2ffec # Parent 98f0f668f63b143eba344a74c8b22a0588f46935 # EXP-Topic rustancestors-contains rust: rustlazyancestors.__contains__ This changeset

D5075: tests: accept slightly different zip file in Python 3

2018-10-13 Thread indygreg (Gregory Szorc)
indygreg added a comment. Behavior changed between Python 3.6 and Python 3.7. We should add `pyXX` hghave capabilities to differentiate on Python versions. Or we could annotate all possible lines with `(?)` (optional output). The hghave approach is better. REPOSITORY rHG Mercurial

[PATCH 1 of 2] py3: pass in system string to vars(branchmap).__contains__()

2018-10-13 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1539421086 -7200 # Sat Oct 13 10:58:06 2018 +0200 # Node ID 7e85eb3b267f431106e6f523786712ca6a9ec4df # Parent 0b46e1aa77609c48e77f73ef987807f4a123d6a5 py3: pass in system string to vars(branchmap).__contains__() diff --git

[PATCH 2 of 2] py3: use __code__ instead of func_code to test if func is cachable

2018-10-13 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1539421298 -7200 # Sat Oct 13 11:01:38 2018 +0200 # Node ID 3475487059e51d5ef768f5d2ade29bddf6bbd21f # Parent 7e85eb3b267f431106e6f523786712ca6a9ec4df py3: use __code__ instead of func_code to test if func is cachable Surprisingly, this

D5057: test-bookmarks-pushpull: use correct tmp dir for no-bm-move.sh

2018-10-13 Thread mbthomas (Mark Thomas)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG58d785679e15: test-bookmarks-pushpull: use correct tmp dir for no-bm-move.sh (authored by mbthomas, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5053: relnotes: port to Python 3

2018-10-13 Thread indygreg (Gregory Szorc)
indygreg added a comment. I'm OK with assuming release notes are UTF-8 until we need to cross that bridge. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5053 To: durin42, #hg-reviewers Cc: indygreg, mjpieters, mercurial-devel

D5054: releasenotes: fix remaining bytes/unicode issues caught by tests

2018-10-13 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG85773222127d: releasenotes: fix remaining bytes/unicode issues caught by tests (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

Re: D5025: py3: make test-contrib-perf.t work on python 3

2018-10-13 Thread Yuya Nishihara
> >> - cmd = sys.argv[0] +cmd = fsencode(sys.argv[0]) > > > > Applying fsencode() on sys.argv is probably wrong on Windows, but it's > perf.py, > > I don't care. > > What's the right way to do it on windows? I think `encoding.strtolocal()` is close, but I have no idea what's

D5062: churn: fix stack traces on Python 3

2018-10-13 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5062 AFFECTED FILES hgext/churn.py CHANGE DETAILS diff --git a/hgext/churn.py b/hgext/churn.py ---

D5059: contrib: fix up output in check-config.py to use strs to avoid b prefixes

2018-10-13 Thread durin42 (Augie Fackler)
durin42 updated this revision to Diff 12027. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5059?vs=12017=12027 REVISION DETAIL https://phab.mercurial-scm.org/D5059 AFFECTED FILES contrib/check-config.py contrib/python3-whitelist CHANGE DETAILS

D5060: releasenotes: fix dumb whitespace bug I missed

2018-10-13 Thread yuja (Yuya Nishihara)
yuja added a comment. Oops, I've fixed this in flight. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5060 To: durin42, #hg-reviewers Cc: yuja, mercurial-devel ___ Mercurial-devel mailing list

D5064: style: run black on a subset of mercurial

2018-10-13 Thread mjpieters (Martijn Pieters)
mjpieters added a comment. The `import` parentheses collapsing is described here: https://github.com/ambv/black#parentheses. The behavior is not configurable. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5064 To: mjpieters, indygreg, durin42, #hg-reviewers

D5066: help: splitting the topics by category

2018-10-13 Thread rdamazio (Rodrigo Damazio Bovendorp)
rdamazio created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5066 AFFECTED FILES mercurial/help.py mercurial/hgweb/webcommands.py CHANGE DETAILS diff --git

D5065: help: adding support for command categories

2018-10-13 Thread rdamazio (Rodrigo Damazio Bovendorp)
rdamazio updated this revision to Diff 12039. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5065?vs=12031=12039 REVISION DETAIL https://phab.mercurial-scm.org/D5065 AFFECTED FILES doc/gendoc.py mercurial/configitems.py mercurial/help.py

D5066: help: splitting the topics by category

2018-10-13 Thread rdamazio (Rodrigo Damazio Bovendorp)
rdamazio updated this revision to Diff 12040. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5066?vs=12032=12040 REVISION DETAIL https://phab.mercurial-scm.org/D5066 AFFECTED FILES mercurial/help.py mercurial/hgweb/webcommands.py CHANGE DETAILS

Re: [PATCH] graft: introduce --base option for using custom base revision for merge

2018-10-13 Thread Augie Fackler
> On Oct 13, 2018, at 12:02, Mads Kiilerich wrote: > > # HG changeset patch > # User Mads Kiilerich > # Date 1539424786 -7200 > # Sat Oct 13 11:59:46 2018 +0200 > # Node ID 167e7e7bbead47fadfe4072143cc53b409e3d8b9 > # Parent 38ac525b44c93fcadb3680d4ded56f1e5a0029b2 > graft: introduce

D5058: match: optimize matcher when all patterns are of rootfilesin kind

2018-10-13 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG19ed212de2d1: match: optimize matcher when all patterns are of rootfilesin kind (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5075: tests: accept slightly different zip file in Python 3

2018-10-13 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a reviewer: pulkit. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I added some `unzip -t` here and I *think* the only change is from Python 3 having more data in the zip file headers or

[PATCH 2 of 2] py3: build help of compression engines in bytes

2018-10-13 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1539433045 -7200 # Sat Oct 13 14:17:25 2018 +0200 # Node ID 921feabe152110773b8b85818b149a99166b9f74 # Parent b8a16cf84c34d254df7ff276e49e6d5fd327eb8b py3: build help of compression engines in bytes Removes "b''" from help. diff --git

D5069: help: adding a proper declaration for shortlist/basic commands

2018-10-13 Thread rdamazio (Rodrigo Damazio Bovendorp)
rdamazio updated this revision to Diff 12064. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5069?vs=12043=12064 REVISION DETAIL https://phab.mercurial-scm.org/D5069 AFFECTED FILES contrib/perf.py hgext/absorb.py hgext/blackbox.py

D5061: f: fix a Python 3 bytes/string issue

2018-10-13 Thread durin42 (Augie Fackler)
durin42 updated this revision to Diff 12070. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5061?vs=12026=12070 REVISION DETAIL https://phab.mercurial-scm.org/D5061 AFFECTED FILES tests/f CHANGE DETAILS diff --git a/tests/f b/tests/f --- a/tests/f

D5059: contrib: fix up output in check-config.py to use strs to avoid b prefixes

2018-10-13 Thread durin42 (Augie Fackler)
durin42 updated this revision to Diff 12071. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5059?vs=12049=12071 REVISION DETAIL https://phab.mercurial-scm.org/D5059 AFFECTED FILES contrib/check-config.py contrib/python3-whitelist CHANGE DETAILS

D5064: style: run black on a subset of mercurial

2018-10-13 Thread indygreg (Gregory Szorc)
indygreg added inline comments. INLINE COMMENTS > check-commit:43 > -(r"\n\+\n( |\+)\n", "adds double empty line"), > -(r"\n \n\+\n", "adds double empty line"), > # Forbid "_" in function name. I think we'll want to send this chunk as a separate commit, as it is a policy change.

Re: [PATCH] py3: get around unicode docstrings in test-encoding-textwrap.t and test-help.t

2018-10-13 Thread Augie Fackler
> On Oct 12, 2018, at 19:36, Yuya Nishihara wrote: > > # HG changeset patch > # User Yuya Nishihara > # Date 1539365108 -7200 > # Fri Oct 12 19:25:08 2018 +0200 > # Node ID fc11940aeb629be72d144cf77cea245c3369c850 > # Parent ba70e3acf58a6a929a23f5b80e08c98a4ad776d4 > py3: get around

Re: [PATCH] obsolete: don't translate internal error message

2018-10-13 Thread Augie Fackler
> On Oct 12, 2018, at 17:08, Yuya Nishihara wrote: > > # HG changeset patch > # User Yuya Nishihara > # Date 1539355871 -7200 > # Fri Oct 12 16:51:11 2018 +0200 > # Node ID 21a0028bb28eeb4c3d2af807934fd22382594ce2 > # Parent 5b8bab9a7e07692e8d827c5315502301a11e4803 > obsolete: don't

D5083: tests: fix inline extension in test-fncache.t for Python 3

2018-10-13 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGc8f164061212: tests: fix inline extension in test-fncache.t for Python 3 (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5087: help: displaying documented aliases by default

2018-10-13 Thread rdamazio (Rodrigo Damazio Bovendorp)
rdamazio created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This makes aliases be displayed in "hg help" when they have a :doc config entry, and also allows them to be assigned to a category with :category. REPOSITORY

D5088: hghave: add pyXY features for Python version numbers

2018-10-13 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This will allow us to sniff for Python >= versions in tests. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5088 AFFECTED FILES

D5088: hghave: add pyXY features for Python version numbers

2018-10-13 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 12096. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5088?vs=12095=12096 REVISION DETAIL https://phab.mercurial-scm.org/D5088 AFFECTED FILES tests/hghave.py CHANGE DETAILS diff --git a/tests/hghave.py

D5006: py3: three new passing tests

2018-10-13 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG2553306c10b9: py3: one new passing tests (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5006?vs=12001=12022 REVISION

D5061: f: fix a Python 3 bytes/string issue

2018-10-13 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I suspect we should test this tool in isolation, but we don't yet. Oh well. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5061

D5065: help: adding support for command categories

2018-10-13 Thread rdamazio (Rodrigo Damazio Bovendorp)
rdamazio created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5065 AFFECTED FILES doc/gendoc.py mercurial/configitems.py mercurial/help.py

D5068: help: assigning topic categories

2018-10-13 Thread rdamazio (Rodrigo Damazio Bovendorp)
rdamazio created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5068 AFFECTED FILES doc/gendoc.py mercurial/help.py tests/test-globalopts.t tests/test-help.t

D5072: tests: fix last failure in test-tools.t

2018-10-13 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a reviewer: pulkit. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5072 AFFECTED FILES contrib/python3-whitelist tests/f CHANGE

D5063: churn: use integer division consistently

2018-10-13 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG81e4f039a0cd: churn: use integer division consistently (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5063?vs=12029=12045

D5062: churn: fix stack traces on Python 3

2018-10-13 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG6f3e733848ae: churn: fix stack traces on Python 3 (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5062?vs=12028=12044

D5074: webcommands: use stringutil.pprint() to repr invalid archive types

2018-10-13 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5074 AFFECTED FILES mercurial/hgweb/webcommands.py CHANGE DETAILS diff --git

D5073: archival: don't try and fsdecode non-{bytes,str} objects

2018-10-13 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This function accepts both bytes and file-like objects. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5073 AFFECTED FILES

[PATCH 1 of 2] py3: do I/O in bytes in test-help.t

2018-10-13 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1539432672 -7200 # Sat Oct 13 14:11:12 2018 +0200 # Node ID b8a16cf84c34d254df7ff276e49e6d5fd327eb8b # Parent 8603435ad64c35c4472726350e391076ad25c3aa py3: do I/O in bytes in test-help.t diff --git a/tests/test-help.t b/tests/test-help.t

D5066: help: splitting the topics by category

2018-10-13 Thread rdamazio (Rodrigo Damazio Bovendorp)
rdamazio updated this revision to Diff 12061. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5066?vs=12040=12061 REVISION DETAIL https://phab.mercurial-scm.org/D5066 AFFECTED FILES mercurial/help.py mercurial/hgweb/webcommands.py CHANGE DETAILS

D5065: help: adding support for command categories

2018-10-13 Thread rdamazio (Rodrigo Damazio Bovendorp)
rdamazio updated this revision to Diff 12060. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5065?vs=12039=12060 REVISION DETAIL https://phab.mercurial-scm.org/D5065 AFFECTED FILES doc/gendoc.py mercurial/help.py mercurial/registrar.py CHANGE

D5067: help: assigning categories to existing commands

2018-10-13 Thread rdamazio (Rodrigo Damazio Bovendorp)
rdamazio updated this revision to Diff 12062. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5067?vs=12041=12062 REVISION DETAIL https://phab.mercurial-scm.org/D5067 AFFECTED FILES hgext/absorb.py hgext/amend.py hgext/blackbox.py

D5079: py3: use py3 as the test tag, dropping the k

2018-10-13 Thread pulkit (Pulkit Goyal)
pulkit accepted this revision. pulkit added a comment. I feel priviliged to review my mentors patch and push it. :) REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5079 To: mjpieters, #hg-reviewers, pulkit Cc: pulkit, mercurial-devel

D5079: py3: use py3 as the test tag, dropping the k

2018-10-13 Thread pulkit (Pulkit Goyal)
pulkit added a comment. There are few more occurences of py3k if you rebase it on @, can you please have a look. :) REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5079 To: mjpieters, #hg-reviewers, pulkit Cc: pulkit, mercurial-devel

Re: [PATCH] crecord: make enter move cursor down to the next item of the same type

2018-10-13 Thread Augie Fackler
> On Oct 13, 2018, at 12:08, Anton Shestakov wrote: > > # HG changeset patch > # User Anton Shestakov > # Date 1539424350 -7200 > # Sat Oct 13 11:52:30 2018 +0200 > # Node ID 652b73cc2aa892cf2c2a5988a339ee242d2e1696 > # Parent 8278491d01838a2062ba7202be9b79cc6b243c83 > crecord: make

D5085: tests: fix up test-hghave for recent run-tests change to use more CPUs

2018-10-13 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5085 AFFECTED FILES tests/test-hghave.t CHANGE DETAILS diff --git a/tests/test-hghave.t

D5059: contrib: fix up output in check-config.py to use strs to avoid b prefixes

2018-10-13 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG5519697b71b3: contrib: fix up output in check-config.py to use strs to avoid b prefixes (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5075: tests: accept slightly different zip file in Python 3

2018-10-13 Thread yuja (Yuya Nishihara)
yuja added a comment. > - body: size=1377, sha1=677b14d3d048778d5eb5552c14a67e6192068650 + body: size=1377, sha1=677b14d3d048778d5eb5552c14a67e6192068650 (no-py3k !) + body: size=1461, sha1=be6d3983aa13dfe930361b2569291cdedd02b537 (py3k !) For some reason, my Python 3 says

[PATCH 4 of 5 V3] rust: hooking into Python code

2018-10-13 Thread Georges Racinet
# HG changeset patch # User Georges Racinet # Date 1538060144 -7200 # Thu Sep 27 16:55:44 2018 +0200 # Node ID 98f0f668f63b143eba344a74c8b22a0588f46935 # Parent b1d2b4a4684a51ba9bfc3ea5bc6e177be65e4b69 # EXP-Topic rustancestors-contains rust: hooking into Python code We introduce a new

[PATCH 2 of 5 V3] rust: iterator bindings to C code

2018-10-13 Thread Georges Racinet
# HG changeset patch # User Georges Racinet # Date 1538059896 -7200 # Thu Sep 27 16:51:36 2018 +0200 # Node ID 4b490e500a3551b03c41dc06f16aa506523719c6 # Parent 41b32e06629466bbe671c6ebfc1c5a4133c8af99 # EXP-Topic rustancestors-contains rust: iterator bindings to C code In this changeset,

D5004: tests: add lots of globs and conditional output lines

2018-10-13 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGff9ea4a1d0f6: tests: add lots of globs and conditional output lines (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5005: tests: expand our coverage of errors in Python 3 for bad extensions

2018-10-13 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG58ee456df096: tests: expand our coverage of errors in Python 3 for bad extensions (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5067: help: assigning categories to existing commands

2018-10-13 Thread rdamazio (Rodrigo Damazio Bovendorp)
rdamazio created this revision. Herald added a reviewer: durin42. Herald added a reviewer: martinvonz. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I'm separating this into its own commit so people can bikeshed over the actual

D5069: help: adding a proper declaration for shortlist/basic commands

2018-10-13 Thread rdamazio (Rodrigo Damazio Bovendorp)
rdamazio updated this revision to Diff 12043. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5069?vs=12035=12043 REVISION DETAIL https://phab.mercurial-scm.org/D5069 AFFECTED FILES contrib/perf.py hgext/absorb.py hgext/blackbox.py

  1   2   >