[Bug 6224] New: When window is resized, the ncurses histedit UI does not adapt

https://bz.mercurial-scm.org/show_bug.cgi?id=6224 Bug ID: 6224 Summary: When window is resized, the ncurses histedit UI does not adapt Product: Mercurial Version: 4.9 Hardware: PC OS: Linux

Re: Line buffering not supported in binary mode on Python 3

On 2019-11-19 05:22, Gregory Szorc wrote: On Sat, Nov 16, 2019 at 4:26 PM Manuel Jacob wrote: Python 3’s IO implementation doesn’t support line buffering in binary mode. On Python 3.8, this results in a RuntimeWarning, breaking test-ssh-proto.t. Here are the tracebacks for the two occurences

D7457: shelve: fix a missing variable in the exception handler for delete

mharbison72 added a comment. This and the next one should probably go on stable. I'm a bit surprised there's no test coverage, at least for the next one. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7457/new/ REVISION DETAIL

D7459: lock: pass "success" boolean to _afterlock callbacks

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This lets the callback decide if it should actually run or not. I suspect that most callbacks (and hooks) *should not* run in this scenario, but I'm trying to

[PATCH stable] py3: use pycompat.bytestr() instead of pycompat.sysstr()

# HG changeset patch # User Manuel Jacob # Date 1574161183 -3600 # Tue Nov 19 11:59:43 2019 +0100 # Branch stable # Node ID c5bcd946a34b77d7680d62ea329542a06d48b5df # Parent 0f82b29f7494399c93920543ce65bf9258459cd5 py3: use pycompat.bytestr() instead of pycompat.sysstr() pycompat.sysstr()

D7441: match: remove explicitdir attribute

This revision is now accepted and ready to land. pulkit added a comment. pulkit accepted this revision. Queued the series, many thanks! Thanks @Alphare for reviewing :) REPOSITORY rHG Mercurial BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7441/new/

D7438: commit: drop unused "vdirs" argument from repo.checkcommitpatterns()

Closed by commit rHGf965b1027fb0: commit: drop unused vdirs argument from repo.checkcommitpatterns() (authored by martinvonz). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D7437: commit: rewrite check for `hg ci ` being a directory

Closed by commit rHG7f443cce2972: commit: rewrite check for `hg ci path` being a directory (authored by martinvonz). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D7439: dirstate: include explicit matches in match.traversedir calls

Closed by commit rHG95d2eab0a7b9: dirstate: include explicit matches in match.traversedir calls (authored by martinvonz). martinvonz marked an inline comment as done. This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D7441: match: remove explicitdir attribute

Closed by commit rHG5e1b0470cee7: match: remove explicitdir attribute (authored by martinvonz). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7441?vs=18176=18238 CHANGES SINCE

D7252: dirs: reject consecutive slashes in paths

Alphare added a comment. Sorry to necropost, but since this broke the Rust implementation, I was wondering what the best approach would be to replicate this behavior, and I am starting to think that this should be reverted. IIUC, currently any new path passes through the `pathauditor`

D7440: dirstate: stop caring about match.explicitdir

Closed by commit rHGdeacffd227e2: dirstate: stop caring about match.explicitdir (authored by martinvonz). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7440?vs=18175=18237 CHANGES

Re: [PATCH stable] py3: use pycompat.bytestr() instead of pycompat.sysstr()

On Tue, 19 Nov 2019 11:59:53 +0100, Manuel Jacob wrote: > # HG changeset patch > # User Manuel Jacob > # Date 1574161183 -3600 > # Tue Nov 19 11:59:43 2019 +0100 > # Branch stable > # Node ID c5bcd946a34b77d7680d62ea329542a06d48b5df > # Parent 0f82b29f7494399c93920543ce65bf9258459cd5 > py3:

[PATCH 1 of 2] rust-cpython: import utils::files::* function at module level

# HG changeset patch # User Yuya Nishihara # Date 1574172976 -32400 # Tue Nov 19 23:16:16 2019 +0900 # Node ID 3a542e3823dda716ec473bf5ef9f4c5b60e8a368 # Parent 039fbd14d4e2889be830cc114957c31972c6ea04 rust-cpython: import utils::files::* function at module level IIRC, it's common in Rust

D7252: dirs: reject consecutive slashes in paths

durin42 added a comment. In D7252#109656 , @durin42 wrote: > In D7252#109627 , @Alphare wrote: > >> Sorry to necropost, but since this broke the Rust implementation, I was wondering what the

[PATCH 2 of 2] rust-cpython: do not convert warning pattern to utf-8 bytes

# HG changeset patch # User Yuya Nishihara # Date 1574173197 -32400 # Tue Nov 19 23:19:57 2019 +0900 # Node ID 1a80d721cba5db045de98bf2cf51f5d72f4958ae # Parent 3a542e3823dda716ec473bf5ef9f4c5b60e8a368 rust-cpython: do not convert warning pattern to utf-8 bytes On Unix, both Rust Path and

[PATCH 2 of 2] typing: fix return type of logcmdutil.getrevs()

# HG changeset patch # User Yuya Nishihara # Date 1574175192 -32400 # Tue Nov 19 23:53:12 2019 +0900 # Node ID 835d415c5a17258e2cf11e9fcd650441690dfbd4 # Parent 75589cc751d7053a9852f7de88b35ec64909a46a typing: fix return type of logcmdutil.getrevs() Fixes the following errors: Invalid

D7252: dirs: reject consecutive slashes in paths

Alphare added a comment. > Oh, you mean the Rust version doesn't do the same rejection? It does not, currently. > Given that you're about to do a hash lookup, I'm a little skeptical that a `endswith('/')` check would show up meaningfully in a profiler, but I'm willing to be proven

Re: [PATCH 1 of 2] rust-cpython: import utils::files::* function at module level

Nit: I prefer to nest the imports. I don't have any issue with the intent of this patch, namespacing might be clearer. On 11/19/19 4:20 PM, Yuya Nishihara wrote: # HG changeset patch # User Yuya Nishihara # Date 1574172976 -32400 # Tue Nov 19 23:16:16 2019 +0900 # Node ID

D7297: cleanup: remove now-obsolete wrong-arg-type annotations

durin42 updated this revision to Diff 18241. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7297?vs=18079=18241 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7297/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7297 AFFECTED FILES

D7296: pycompat: kludge around pytype being confused by __new__

durin42 edited the summary of this revision. durin42 updated this revision to Diff 18240. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7296?vs=18170=18240 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7296/new/ REVISION DETAIL

D7295: pytype: add a (very slow) test that executes pytype

mharbison72 added inline comments. INLINE COMMENTS > test-check-pytype.t:22 > + >-x mercurial/lsprof.py \ > + >-x mercurial/policy.py > + >-x mercurial/pycompat.py \ Needs a trailing slash here. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION

[PATCH 1 of 2] typing: consolidate "if not globals():" trick

# HG changeset patch # User Yuya Nishihara # Date 1574174945 -32400 # Tue Nov 19 23:49:05 2019 +0900 # Node ID 75589cc751d7053a9852f7de88b35ec64909a46a # Parent 1a80d721cba5db045de98bf2cf51f5d72f4958ae typing: consolidate "if not globals():" trick Removes redundant inline comments. I think

D7252: dirs: reject consecutive slashes in paths

durin42 added a comment. In D7252#109627 , @Alphare wrote: > Sorry to necropost, but since this broke the Rust implementation, I was wondering what the best approach would be to replicate this behavior, and I am starting to think that this

D7296: pycompat: kludge around pytype being confused by __new__

durin42 updated this revision to Diff 18243. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7296?vs=18240=18243 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7296/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7296 AFFECTED FILES

Re: [PATCH 2 of 2] typing: fix return type of logcmdutil.getrevs()

Yuya Nishihara a écrit : > # HG changeset patch > # User Yuya Nishihara > # Date 1574175192 -32400 > # Tue Nov 19 23:53:12 2019 +0900 > # Node ID 835d415c5a17258e2cf11e9fcd650441690dfbd4 > # Parent 75589cc751d7053a9852f7de88b35ec64909a46a > typing: fix return type of logcmdutil.getrevs() >

[Bug 6225] New: phabread yields KeyError

https://bz.mercurial-scm.org/show_bug.cgi?id=6225 Bug ID: 6225 Summary: phabread yields KeyError Product: Mercurial Version: 4.9 Hardware: PC OS: Linux Status: UNCONFIRMED Severity: bug

D7296: pycompat: kludge around pytype being confused by __new__

This revision now requires changes to proceed. dlax added a comment. dlax requested changes to this revision. Sorry, still not ok afaict :/ INLINE COMMENTS > pycompat.py:305 > > +bytestr = _bytestr # type: Callable[[Union[bytes, str], bytestr]] > + `]` is still at the wrong place, I

D7296: pycompat: kludge around pytype being confused by __new__

durin42 added a comment. In D7296#109672 , @dlax wrote: > Sorry, still not ok afaict :/ So, I tried fixing this and it actually made things worse? dagparser.py no longer typechecks if I correct the syntax? Try the pytype invocation from

D7295: pytype: add a (very slow) test that executes pytype

durin42 updated this revision to Diff 18242. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7295?vs=18104=18242 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7295/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7295 AFFECTED FILES

D7296: pycompat: kludge around pytype being confused by __new__

dlax added a comment. dlax added a subscriber: yuja. In D7296#109683 , @durin42 wrote: > In D7296#109672 , @dlax wrote: > >> Sorry, still not ok afaict :/ > > So, I tried fixing this and it

D7296: pycompat: kludge around pytype being confused by __new__

dlax added a comment. In D7296#109684 , @dlax wrote: > Looking closer at the error above, it mentions `bytestr.__init__`, not `__new__` (and there is in fact no type annotation for `__new__` in typeshed

mercurial@43710: 33 new changesets (1 on stable)

33 new changesets (1 on stable) in mercurial: https://www.mercurial-scm.org/repo/hg/rev/52e4bfebc4ba changeset: 43678:52e4bfebc4ba parent: 43676:6a5dc4d767a0 user:Matt Harbison date:Sat Nov 16 12:19:43 2019 -0500 summary: setup: conditionalize access to `sys.dllhandle`

D7457: shelve: fix a missing variable in the exception handler for delete

mharbison72 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Caught by pytype. I haven't paid much attention to the progress of this extension, but I *think* this was the intent. REPOSITORY rHG Mercurial REVISION

D7455: revset: add an assertion to help pytype

mharbison72 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7455 AFFECTED FILES mercurial/revset.py CHANGE DETAILS diff --git a/mercurial/revset.py

D7456: scmutil: add assertions to help pytype

mharbison72 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7456 AFFECTED FILES mercurial/scmutil.py CHANGE DETAILS diff --git a/mercurial/scmutil.py

D7458: shelve: add the missing `create` parameter to the bundlerepo constructor

mharbison72 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Caught by pytype. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7458 AFFECTED FILES mercurial/shelve.py CHANGE DETAILS