Re: [PATCH 1 of 5 chg-tests-fix V2] procutils: don't try to get `.buffer` if sys.stdin is None

2020-12-10 Thread Pulkit Goyal
On Wed, Dec 9, 2020 at 4:17 PM Yuya Nishihara wrote: > > On Tue, 08 Dec 2020 19:12:20 +0530, Pulkit Goyal wrote: > > # HG changeset patch > > # User Pulkit Goyal <7895pul...@gmail.com> > > # Date 1606897517 -19800 > > # Wed Dec 02 13:55:17 2020 +0530 > > # Node ID

[PATCH 2 of 2 chg-tests-fix V3] procutil: don't assign stdin to None, use os.devnull instead

2020-12-10 Thread Pulkit Goyal
# HG changeset patch # User Pulkit Goyal <7895pul...@gmail.com> # Date 1607589226 -19800 # Thu Dec 10 14:03:46 2020 +0530 # Node ID 9123fc028ed21e8aa39a353ea6ec9e102cf3dad0 # Parent 96c66ca3f189d522dd53c736919e7343c29e6116 # EXP-Topic chg-test procutil: don't assign stdin to None, use

[PATCH 1 of 2 chg-tests-fix V3] dispatch: move IOError handling and flushing of streams to `dispatch()`

2020-12-10 Thread Pulkit Goyal
# HG changeset patch # User Pulkit Goyal <7895pul...@gmail.com> # Date 1607588516 -19800 # Thu Dec 10 13:51:56 2020 +0530 # Node ID 96c66ca3f189d522dd53c736919e7343c29e6116 # Parent 6de68a9dd7302f077edd73ea6d639d725ecf89b9 # EXP-Topic chg-test dispatch: move IOError handling and flushing of

Re: [PATCH 1 of 2 chg-tests-fix V3] dispatch: move IOError handling and flushing of streams to `dispatch()`

2020-12-10 Thread Yuya Nishihara
On Thu, 10 Dec 2020 14:41:44 +0530, Pulkit Goyal wrote: > # HG changeset patch > # User Pulkit Goyal <7895pul...@gmail.com> > # Date 1607588516 -19800 > # Thu Dec 10 13:51:56 2020 +0530 > # Node ID 96c66ca3f189d522dd53c736919e7343c29e6116 > # Parent 6de68a9dd7302f077edd73ea6d639d725ecf89b9 >

Re: [PATCH 2 of 2 chg-tests-fix V3] procutil: don't assign stdin to None, use os.devnull instead

2020-12-10 Thread Yuya Nishihara
On Thu, 10 Dec 2020 14:41:45 +0530, Pulkit Goyal wrote: > # HG changeset patch > # User Pulkit Goyal <7895pul...@gmail.com> > # Date 1607589226 -19800 > # Thu Dec 10 14:03:46 2020 +0530 > # Node ID 9123fc028ed21e8aa39a353ea6ec9e102cf3dad0 > # Parent 96c66ca3f189d522dd53c736919e7343c29e6116 >

D9560: histedit: tweak `edit` message to try and guide users to our workflow

2020-12-10 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY histedit predates evolve, so it drops you on an _uncommitted_ version of the commit you're amending/splitting, which is in contrast to git which expects you

D9561: histedit: adjust comment describing `edit` action for clarity

2020-12-10 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D9561 AFFECTED FILES hgext/histedit.py tests/test-histedit-arguments.t

D9562: diff: describe behavior by using --from/--to instead of varying revision count

2020-12-10 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY I very recently updated the documentation to prefer `--from`/`--to` over `-r`, but I missed the plain-text description of how the command behaves when

D9563: diff: update synopsis to use --from/--to instead of -r

2020-12-10 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D9563 AFFECTED FILES mercurial/commands.py tests/test-help.t CHANGE DETAILS

D9564: diff: deprecate -r option

2020-12-10 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY The new `--from`/`--to` options should be enough to support all the uses cases and are easier to understand, so there is no reason that I'm aware of to use