Re: Please make a python-glib release - is there a hold up?

2016-12-30 Thread Augie Fackler
> On Dec 29, 2016, at 4:44 PM, Idan K wrote: > > I don't have commit access to the repo though, so can't tag a release. > > Happy to make whatever changes to the package on PyPI. If you add `durin42` on PyPI as an owner, I can add the other people that are able to make hg

Re: ideas: chg repo preloading, and new changelog index

2016-12-30 Thread Sean Farley
Jun Wu writes: > chg repo preloading > > I have been thinking about speeding up repo loading for a long time. > Previous ideas are persistent radix tree, hidden bitmap, mmap changelog.i. > > Recently I realized that chg (after the uisetup refactoring) could be an >

Re: [PATCH 01 of 10] check-code: add AST check for mutable default argument values

2016-12-30 Thread Jun Wu
I have gone through all the changes and didn't find small functions being used in tight loops. So the performance concern is less important. I think we can enable the check. Excerpts from Jun Wu's message of 2016-12-30 17:29:23 +: > Excerpts from Augie Fackler's message of 2016-12-28 12:18:51

Re: [PATCH] Makefile: drop old deployment rules

2016-12-30 Thread Sean Farley
Pierre-Yves David writes: > # HG changeset patch > # User Pierre-Yves David > # Date 1483091528 -3600 > # Fri Dec 30 10:52:08 2016 +0100 > # Node ID 7dc955330c55b8cea601edd9e3d77a1b40883b05 > # Parent

Re: [PATCH 2 of 5 flagprocessor v6] revlog: add 'raw' argument to revision and _addrevision

2016-12-30 Thread Pierre-Yves David
On 12/30/2016 06:09 PM, Augie Fackler wrote: On Dec 30, 2016, at 12:04 PM, Rémi Chaintron wrote: Following discussion with marmoute on IRC, I'll drop the rawrevision() method for now. OOC, what’s the rationale for preferring the boolean parameter instead of

Re: [PATCH 01 of 10] check-code: add AST check for mutable default argument values

2016-12-30 Thread Jun Wu
Excerpts from Augie Fackler's message of 2016-12-28 12:18:51 -0500: > > - Slower, extra tests and GCs (especially in a tight loop) > Py_None will at worst get decref'd. It’s a singleton, so there won’t be > any extra GC’ing. `is` checks in cpython are extremely fast (they’re exact > pointer

Re: chg pager refactoring

2016-12-30 Thread Jun Wu
Excerpts from Augie Fackler's message of 2016-12-28 18:17:00 -0500: > A thought: it's (notionally) optional for clients of the cmdserver to > ignore the pager operation, right? That is, it's totally valid to drop > the "start a pager now" message on the floor and act like no pager is > in play.

Re: [PATCH 2 of 5 flagprocessor v6] revlog: add 'raw' argument to revision and _addrevision

2016-12-30 Thread Rémi Chaintron
Following discussion with marmoute on IRC, I'll drop the rawrevision() method for now. On Fri, 30 Dec 2016 at 11:12 Augie Fackler wrote: > > > On Dec 30, 2016, at 10:46 AM, Rémi Chaintron > wrote: > > > > The actual rawrevision() method is simply a

Re: [PATCH 3 of 5 flagprocessor v6] revlog: pass revlog flags to addrevision

2016-12-30 Thread Rémi Chaintron
You're right, this is a mistake on my part. The reasoning behind dropping this code is that in my current implementation, processflags() handles checking whether the flags are known (both for revision() and _addrevision()) so I moved this snippet to processflags(). Still makes sense to not spread

Re: [PATCH 2 of 5 flagprocessor v6] revlog: add 'raw' argument to revision and _addrevision

2016-12-30 Thread Rémi Chaintron
Long story short, we need to pass the raw argument to processflags() so that it can determine which transform use. This allows to differentiate the regular use case (transform operations such as reading from a remote store in lfs's case) from changegroup generation and debug commands. The only way

Re: [PATCH 2 of 5 flagprocessor v6] revlog: add 'raw' argument to revision and _addrevision

2016-12-30 Thread Augie Fackler
> On Dec 30, 2016, at 5:25 AM, Pierre-Yves David > wrote: > >> This patch adds a new 'rawrevision()' method setting the 'raw' argument to >> True >> in the revlog.revision() call that is used to differentiate changegroup >> generation and debugdata related

Re: [PATCH 3 of 3 V2] revset: add a changes(file, fromline, toline[, rev]) revset

2016-12-30 Thread Denis Laxalde
Just sent a V3 of this series with: * rename of the revset function into "followlines"; * change of its signature into followlines(file, fromline, toline[, rev=.) so that future handling of multiple line ranges be possible without bw compat breakage; * added support for file

[PATCH 2 of 3 V3] context: add a `blockancestors(fctx, fromline, toline)` function

2016-12-30 Thread Denis Laxalde
# HG changeset patch # User Denis Laxalde # Date 1482962617 -3600 # Wed Dec 28 23:03:37 2016 +0100 # Node ID 5e2582bb20e2328f296a415834acdd401164283a # Parent 17eee60ccbafe46f539a75484ebf110377781fb1 # EXP-Topic linerange-log/revset context: add a

Re: [PATCH] Makefile: drop old deployment rules

2016-12-30 Thread Pierre-Yves David
That should be flagged 'website', but I messed up. On 12/30/2016 10:55 AM, Pierre-Yves David wrote: # HG changeset patch # User Pierre-Yves David # Date 1483091528 -3600 # Fri Dec 30 10:52:08 2016 +0100 # Node ID 7dc955330c55b8cea601edd9e3d77a1b40883b05 #

Re: [PATCH 2 of 5 flagprocessor v6] revlog: add 'raw' argument to revision and _addrevision

2016-12-30 Thread Pierre-Yves David
On 12/24/2016 05:36 PM, Remi Chaintron wrote: # HG changeset patch # User Remi Chaintron # Date 1482539184 18000 # Fri Dec 23 19:26:24 2016 -0500 # Node ID d0476160913323da1dada49ae46e72d6a7c17d78 # Parent c1bd9b7750cdfe1f2a1437e4ba0ed8f6e48b2dd1 revlog: add 'raw' argument

Re: [PATCH 3 of 5 flagprocessor v6] revlog: pass revlog flags to addrevision

2016-12-30 Thread Pierre-Yves David
On 12/24/2016 05:36 PM, Remi Chaintron wrote: # HG changeset patch # User Remi Chaintron # Date 1482451731 18000 # Thu Dec 22 19:08:51 2016 -0500 # Node ID b1d220e584e6fc861a40a5aeefa0c3b19ae09126 # Parent d0476160913323da1dada49ae46e72d6a7c17d78 revlog: pass revlog flags

Re: [PATCH 1 of 5 flagprocessor v6] documentation: better censor flag documentation

2016-12-30 Thread Pierre-Yves David
On 12/28/2016 05:25 PM, Augie Fackler wrote: (bcc adgar in case he can provide insight, but I don’t know if he remembers or if he’s on vacation this/next week at all) On Dec 28, 2016, at 11:20 AM, Pierre-Yves David > wrote:

[PATCH] Makefile: drop old deployment rules

2016-12-30 Thread Pierre-Yves David
# HG changeset patch # User Pierre-Yves David # Date 1483091528 -3600 # Fri Dec 30 10:52:08 2016 +0100 # Node ID 7dc955330c55b8cea601edd9e3d77a1b40883b05 # Parent ef6da0fd2a0cdfbc59503c7a3c221efe59f7e609 Makefile: drop old deployment rules We use a different