Re: [PATCH 3 of 3] run-tests: accept '\' vs '/' path differences without '(glob)'

Patch here: https://phab.mercurial-scm.org/D1699 On Thu, Dec 14, 2017 at 10:02 PM, Martin von Zweigbergk wrote: > On Thu, Dec 14, 2017 at 8:57 PM, Kevin Bullock > wrote: >>> On Dec 14, 2017, at 22:55, Martin von Zweigbergk

D1082: split: new extension to split changesets

martinvonz added a comment. I'd like to get this queued. Jun, can you rebase this and make sure tests still pass? INLINE COMMENTS > quark wrote in test-split.t:487-493 > > It would also be reasonable to evolve/stabilize them. > > Only if we know that would not cause conflicts. Otherwise

D1699: tests: avoid echo with backslash escapes

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Some shells' echo (e.g. Bash's) do not interpret backslash escapes by default, while others shells' do (e.g. Dash's). This led to a failure in

Re: [PATCH] lfs: add an experimental config to masquerade as git for the blob transfer

Matt Harbison writes: > On Thu, 14 Dec 2017 19:51:37 -0500, Sean Farley wrote: > >> >> Augie Fackler writes: >> On Dec 13, 2017, at 6:20 PM, Matt Harbison wrote: On Dec 13, 2017, at 9:48 AM,

[PATCH] hgweb: stop using HTML comments in

# HG changeset patch # User Anton Shestakov # Date 1513311358 -28800 # Fri Dec 15 12:15:58 2017 +0800 # Node ID dc231e0cdccd7aa632b9787bcfbb216cb7bfb39b # Parent b24e015797a6d4654369636987efaf9c8000375e hgweb: stop using HTML comments in Once upon a time, in 1995, there

Re: [PATCH 3 of 3] run-tests: accept '\' vs '/' path differences without '(glob)'

On Thu, Dec 14, 2017 at 8:57 PM, Kevin Bullock wrote: >> On Dec 14, 2017, at 22:55, Martin von Zweigbergk >> wrote: >> >> Could you point me to the build output? > >

Re: [PATCH 3 of 3] run-tests: accept '\' vs '/' path differences without '(glob)'

> On Dec 14, 2017, at 22:55, Martin von Zweigbergk > wrote: > > Could you point me to the build output? https://buildbot.mercurial-scm.org/builders/hg%20tests/builds/1361/steps/run-tests.py%20%28python%202.7.10%29/logs/stdio > Do you also know which shell is used by it?

Re: [PATCH 3 of 3] run-tests: accept '\' vs '/' path differences without '(glob)'

Could you point me to the build output? Do you also know which shell is used by it? On Thu, Dec 14, 2017 at 8:50 PM, Kevin Bullock wrote: >> On Dec 13, 2017, at 12:28, Martin von Zweigbergk via Mercurial-devel >> wrote: >> >>

Re: [PATCH 3 of 3] run-tests: accept '\' vs '/' path differences without '(glob)'

> On Dec 13, 2017, at 12:28, Martin von Zweigbergk via Mercurial-devel > wrote: > > I think the problem is in this line from the test (that you changed): > > $ echo " saved backup bundle to \$TESTTMP\foo.hg" >> test-failure.t > > The '\' there probably

Re: [PATCH] lfs: add an experimental config to masquerade as git for the blob transfer

On Thu, 14 Dec 2017 19:51:37 -0500, Sean Farley wrote: Augie Fackler writes: On Dec 13, 2017, at 6:20 PM, Matt Harbison wrote: On Dec 13, 2017, at 9:48 AM, Augie Fackler > wrote:

D1695: copies: always respect matcher arg to _forwardcopies()

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The function would ignore the matcher if the dirstate copies were requested. It doesn't matter in practice because all callers used the returned map only for

D1698: copies: group wdir-handling in one place

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I think this makes it both easier to follow and shorter. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1698 AFFECTED FILES

D1697: copies: extract method for getting non-wdir forward copies

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I may add an alternative way of getting copy metadata (from changelog, not filelog) but the chaining with the dirstate copy metadata will be the same, so it

D1696: copies: consistently use """ for docstrings

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1696 AFFECTED FILES mercurial/copies.py CHANGE DETAILS diff --git a/mercurial/copies.py

Re: [PATCH] lfs: add an experimental config to masquerade as git for the blob transfer

Augie Fackler writes: >> On Dec 13, 2017, at 6:20 PM, Matt Harbison wrote: >> >> >> On Dec 13, 2017, at 9:48 AM, Augie Fackler > > wrote: >> >>> >>> I don't either. Do whichever of the versions that

[PATCH v3] outgoing: respect ":pushurl" paths (issue5365)

# HG changeset patch # User Hollis Blanchard # Date 1513292635 28800 # Thu Dec 14 15:03:55 2017 -0800 # Node ID a71c6d5ea84933324e0c516ea2e4967e06616c31 # Parent 4937db58b663faa6893c51a41cec28114a165dd0 outgoing: respect ":pushurl" paths (issue5365) Make 'hg

D1678: revset: pass pre-optimized tree in revset.matchany()

pulkit added a comment. In https://phab.mercurial-scm.org/D1678#28729, @yuja wrote: > In https://phab.mercurial-scm.org/D1678#28686, @pulkit wrote: > > > @yuja am I headed in the right direction? (I am not sure about whether the API's I changed are used by extensions or not) > >

D1692: debugdiscovery: drop reference to non-existent --serverlog option

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY It seems like it didn't even exist when debugdiscovery was introduced in https://phab.mercurial-scm.org/rHGcb98fed5249517b558fa07c7d0414c14cdfe4e4d

D1693: debugdiscovery: drop reference to non-existent --remote-head option

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY It seems like it didn't even exist when debugdiscovery was introduced in https://phab.mercurial-scm.org/rHGcb98fed5249517b558fa07c7d0414c14cdfe4e4d

D1691: debugdiscovery: drop reference to invalid --branch option

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY It seems like it didn't even exist when debugdiscovery was introduced in https://phab.mercurial-scm.org/rHGcb98fed5249517b558fa07c7d0414c14cdfe4e4d

D1694: debugcommands: replace opts.get('foo') by opts['foo']

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1694 AFFECTED FILES mercurial/debugcommands.py CHANGE DETAILS diff --git

Re: That pesky windows run-tests failure on the buildbot

On Dec 14, 2017, at 5:04 PM, Kevin Bullock wrote: >> On Dec 14, 2017, at 11:14, Matt Harbison wrote: >> >> On Dec 13, 2017, at 7:02 PM, Matt Harbison wrote: >>> >>> I wonder if an upper case path is

Re: That pesky windows run-tests failure on the buildbot

On Dec 14, 2017, at 5:04 PM, Kevin Bullock wrote: >> On Dec 14, 2017, at 11:14, Matt Harbison wrote: >> >> On Dec 13, 2017, at 7:02 PM, Matt Harbison wrote: >>> >>> I wonder if an upper case path is

Re: That pesky windows run-tests failure on the buildbot

> On Dec 14, 2017, at 11:14, Matt Harbison wrote: > > >> On Dec 13, 2017, at 7:02 PM, Matt Harbison wrote: > >> I wonder if an upper case path is leaking through buildbot somehow. I >> lowercased the driver letter 'basedir' in buildbot.tac, and

mercurial@35411: 6 new changesets

6 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/76dcdc4e707b changeset: 35406:76dcdc4e707b user:Anton Shestakov date:Fri Dec 08 21:50:11 2017 +0800 summary: hgweb: filter graphmod.colored() output before iterating over it

D1689: statprof: remove a line of deadcode

This revision was automatically updated to reflect the committed changes. Closed by commit rHGc8e8e14a5ee9: statprof: remove a line of deadcode (authored by alex_gaynor, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1689?vs=4436=4437

D1689: statprof: remove a line of deadcode

durin42 accepted this revision. durin42 added a comment. This revision is now accepted and ready to land. deleted code is best code REPOSITORY rHG Mercurial BRANCH unused-code (bookmark) on default (branch) REVISION DETAIL https://phab.mercurial-scm.org/D1689 To: alex_gaynor,

D1689: statprof: remove a line of deadcode

alex_gaynor created this revision. alex_gaynor added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial BRANCH unused-code (bookmark) on default (branch) REVISION DETAIL https://phab.mercurial-scm.org/D1689

D1679: rebase: fix for hgsubversion

phillco added a comment. @yuja is that just because of the `_manifest` property cache, or are there others as well? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1679 To: phillco, #hg-reviewers, yuja Cc: yuja, mercurial-devel

[PATCH 2 of 2 V3] lfs: add an experimental config to override User-Agent for the blob transfer

# HG changeset patch # User Matt Harbison # Date 1513109762 18000 # Tue Dec 12 15:16:02 2017 -0500 # Node ID a2ae07e57a0c91274018299afb250f0b921e4eb4 # Parent 5482c3c48da7a5e8050aa0a39670a4ce3e5f8a79 lfs: add an experimental config to override User-Agent for the

[PATCH 1 of 2 V3] lfs: add git to the User-Agent header for blob transfers

# HG changeset patch # User Matt Harbison # Date 1513274648 18000 # Thu Dec 14 13:04:08 2017 -0500 # Node ID 5482c3c48da7a5e8050aa0a39670a4ce3e5f8a79 # Parent 4937db58b663faa6893c51a41cec28114a165dd0 lfs: add git to the User-Agent header for blob transfers As we

Re: That pesky windows run-tests failure on the buildbot

> On Dec 13, 2017, at 7:02 PM, Matt Harbison wrote: > I wonder if an upper case path is leaking through buildbot somehow. I > lowercased the driver letter 'basedir' in buildbot.tac, and we'll see what > that does. Looks like this was the case. No test-run-tests.t

D1426: logtoprocess: add the possibility to not start a shell

lothiraldan added a comment. It works when passing `CREATE_NEW_CONSOLE` instead of `DETACHED_PROCESS | CREATE_NEW_PROCESS_GROUP`. My concern now is about changing the behavior, do we want to keep the improvement under a config knob. REPOSITORY rHG Mercurial REVISION DETAIL

D1683: sshpeer: allow for additional environment passing to ssh exe

mbthomas accepted this revision. mbthomas added a comment. Looks reasonable to me. This could also be achieved by making SSH a script which sets the environment up and invokes the real SSH, but that's clumsy, whereas this allows use of config to set the env vars. REPOSITORY rHG Mercurial

Re: [PATCH 2 of 4] hgweb: calculate width and height client-side

On Thu, 14 Dec 2017 23:01:18 +0900 Yuya Nishihara wrote: > On Thu, 14 Dec 2017 21:10:06 +0800, Anton Shestakov wrote: > > On Thu, 14 Dec 2017 21:07:38 +0900 > > Yuya Nishihara wrote: > > > I'm okay with this change, but it might be bad in UX as the resize occurs

D1683: sshpeer: allow for additional environment passing to ssh exe

ikostia created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We already have the ability to customize the ssh command line arguments, let's add the ability to customize its environment as well. Example use-case is

Re: [PATCH 2 of 4] hgweb: calculate width and height client-side

On Thu, 14 Dec 2017 21:10:06 +0800, Anton Shestakov wrote: > On Thu, 14 Dec 2017 21:07:38 +0900 > Yuya Nishihara wrote: > > I'm okay with this change, but it might be bad in UX as the resize occurs > > very late. > > I don't think the way it's resized now would cause any problems:

[PATCH 2 of 2] phases: initialize number of loaded revisions to 0

# HG changeset patch # User Yuya Nishihara # Date 1513258630 -32400 # Thu Dec 14 22:37:10 2017 +0900 # Node ID a1744bbbec20259e7d2fed8733fd07031abbeb43 # Parent 54f71d88d66d59e557a7224d5d96164bded3292d phases: initialize number of loaded revisions to 0 As it isn't a revision

[PATCH 1 of 2] phases: rename _phasemaxrev to _loadedrevslen to clarify it isn't max value

# HG changeset patch # User Yuya Nishihara # Date 1513258537 -32400 # Thu Dec 14 22:35:37 2017 +0900 # Node ID 54f71d88d66d59e557a7224d5d96164bded3292d # Parent 5d3302425a6e4f4bd9e4af7877f58090daece3f0 phases: rename _phasemaxrev to _loadedrevslen to clarify it isn't max

[PATCH] check-code: remove unused variable 'winglobmsg'

# HG changeset patch # User Yuya Nishihara # Date 1513258006 -32400 # Thu Dec 14 22:26:46 2017 +0900 # Node ID 5d3302425a6e4f4bd9e4af7877f58090daece3f0 # Parent 83014fa95435e4c3c24da45d80f5b3c616cd0dea check-code: remove unused variable 'winglobmsg' Follows up 5feb782c7a95.

Re: [PATCH] hgweb: update graph function docstring

On Thu, 14 Dec 2017 21:34:24 +0800, Anton Shestakov wrote: > # HG changeset patch > # User Anton Shestakov > # Date 1513258200 -28800 > # Thu Dec 14 21:30:00 2017 +0800 > # Node ID b24e015797a6d4654369636987efaf9c8000375e > # Parent

[PATCH] hgweb: update graph function docstring

# HG changeset patch # User Anton Shestakov # Date 1513258200 -28800 # Thu Dec 14 21:30:00 2017 +0800 # Node ID b24e015797a6d4654369636987efaf9c8000375e # Parent 865e71e7184410b60e2dd2912407d3884514e437 hgweb: update graph function docstring diff --git

[PATCH STABLE] debugssl: convert port number to int (issue5757)

# HG changeset patch # User Yuya Nishihara # Date 1513256866 -32400 # Thu Dec 14 22:07:46 2017 +0900 # Branch stable # Node ID 88572b7e50fd5f0e86329943795f6a3e38a2ec31 # Parent 7b73bf1a48d430986e8561db9070634c1923df70 debugssl: convert port number to int (issue5757) It

Re: [PATCH 4 of 4] hgweb: render next pages on /graph incrementally

On Thu, 14 Dec 2017 21:11:35 +0900 Yuya Nishihara wrote: > On Wed, 13 Dec 2017 00:27:49 +0800, Anton Shestakov wrote: > > # HG changeset patch > > # User Anton Shestakov > > # Date 1512978236 -28800 > > # Mon Dec 11 15:43:56 2017 +0800 > > # Node ID

Re: [PATCH 2 of 4] hgweb: calculate width and height client-side

On Thu, 14 Dec 2017 21:07:38 +0900 Yuya Nishihara wrote: > On Wed, 13 Dec 2017 00:27:47 +0800, Anton Shestakov wrote: > > # HG changeset patch > > # User Anton Shestakov > > # Date 1512892582 -28800 > > # Sun Dec 10 15:56:22 2017 +0800 > > # Node ID

D1679: rebase: fix for hgsubversion

This revision was automatically updated to reflect the committed changes. Closed by commit rHG83014fa95435: rebase: fix for hgsubversion (authored by phillco, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1679?vs=4415=4428 REVISION

D1679: rebase: fix for hgsubversion

yuja accepted this revision. yuja added a comment. This revision is now accepted and ready to land. Queued, thanks. In https://phab.mercurial-scm.org/D1679#28741, @phillco wrote: > A better way might just be to use `None` for `self.wtcx` when rebasing on disk, Yeah, it might

mercurial@35405: 16 new changesets (1 on stable)

16 new changesets (1 on stable) in mercurial: https://www.mercurial-scm.org/repo/hg/rev/7b73bf1a48d4 changeset: 35390:7b73bf1a48d4 branch: stable parent: 35386:fdd09d87635b user:Boris Feld date:Tue Dec 12 18:22:11 2017 +0100 summary:

Re: [PATCH 4 of 4] hgweb: render next pages on /graph incrementally

On Wed, 13 Dec 2017 00:27:49 +0800, Anton Shestakov wrote: > # HG changeset patch > # User Anton Shestakov > # Date 1512978236 -28800 > # Mon Dec 11 15:43:56 2017 +0800 > # Node ID 865e71e7184410b60e2dd2912407d3884514e437 > # Parent

Re: [PATCH 1 of 4] hgweb: filter graphmod.colored() output before iterating over it

On Wed, 13 Dec 2017 00:27:46 +0800, Anton Shestakov wrote: > # HG changeset patch > # User Anton Shestakov > # Date 1512741011 -28800 > # Fri Dec 08 21:50:11 2017 +0800 > # Node ID e35959da063b5944369277f3b2c69c3af06e2710 > # Parent

Re: [PATCH 2 of 4] hgweb: calculate width and height client-side

On Wed, 13 Dec 2017 00:27:47 +0800, Anton Shestakov wrote: > # HG changeset patch > # User Anton Shestakov > # Date 1512892582 -28800 > # Sun Dec 10 15:56:22 2017 +0800 > # Node ID 2319d0216460c6f3b91f174a5027190aa80e07b7 > # Parent

[Bug 5758] New: Misleading hint suggesting using [hostsecurity]

https://bz.mercurial-scm.org/show_bug.cgi?id=5758 Bug ID: 5758 Summary: Misleading hint suggesting using [hostsecurity] Product: Mercurial Version: 4.4.1 Hardware: PC OS: Windows Status: UNCONFIRMED

[Bug 5757] New: unknown exception encountered using "hg debugssl"

https://bz.mercurial-scm.org/show_bug.cgi?id=5757 Bug ID: 5757 Summary: unknown exception encountered using "hg debugssl" Product: Mercurial Version: 4.4.1 Hardware: PC OS: Windows Status: UNCONFIRMED