D1726: githelp: replace suggestion of `hg record`

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY `hg record` is deprecated in favor of `hg commit --interactive`. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1726 AFFECTED

D1728: githelp: improve help for "reset"

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The previous help referenced a `hg reset`, which is a Facebook-ism. We convert that to `hg update`. We also recognize --soft. REPOSITORY rHG Mercurial

D1729: githelp: don't reference 3rd party commands for `git show`

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY `hg show` is a Facebook-ism. Reference functionality in core. The logic here isn't terrific. But it is better than nothing. REPOSITORY rHG Mercurial

D1727: githelp: clean up reflog help

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This referenced commands that don't exist in core. The new help isn't great since it references an experimental extension. But it is better than nothing.

D1722: githelp: vendor Facebook authored extension

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This commit vendors the Facebook-authored "githelp" extension. This extension provides a "githelp" command that can be used to try to convert a `git` command

D1725: githelp: remove reference to tweakdefaults

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is a Facebook-ism. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1725 AFFECTED FILES hgext/githelp.py CHANGE DETAILS

D1723: githelp: improve help for `git add`

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The old code was referencing record and crecord, which are deprecated. `hg commit --interactive` is the preferred mechanism to use. In addition, there was

D1724: githelp: remove help for `git am`

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This referenced a third party extension. It doesn't feel appropriate to do that from a core extension. REPOSITORY rHG Mercurial REVISION DETAIL

D1713: tests: update expected output of svn encoding test

This revision was automatically updated to reflect the committed changes. Closed by commit rHGd624c8558c61: tests: update expected output of svn encoding test (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D1717: lfs: fix committing deleted files caused by e0a1b9ee93cd

This revision was automatically updated to reflect the committed changes. Closed by commit rHG488634db5928: lfs: fix committing deleted files caused by e0a1b9ee93cd (authored by quark, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D1718: worker: handle interrupt on windows

This revision was automatically updated to reflect the committed changes. Closed by commit rHG44fd4cfc6c0a: worker: handle interrupt on windows (authored by wlis, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1718?vs=4533=4540 REVISION

D1719: debug: remove an 'if ui.debug()' that is not doing anything

spectral added a comment. In https://phab.mercurial-scm.org/D1719#29390, @quark wrote: > I think it should be `ui.debugflag`. I agree that's probably what was intended, but is it helpful to have it if it's never once been activated in 5 years? (added:

D1718: worker: handle interrupt on windows

krbullock accepted this revision. krbullock added a comment. This revision is now accepted and ready to land. Whoops, queued, thanks. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1718 To: wlis, #hg-reviewers, krbullock Cc: krbullock, mercurial-devel

D1717: lfs: fix committing deleted files caused by e0a1b9ee93cd

krbullock accepted this revision. krbullock added a comment. This revision is now accepted and ready to land. Queued per Matt's review, thanks. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1717 To: quark, #hg-reviewers, mharbison72, krbullock Cc: krbullock,

D1713: tests: update expected output of svn encoding test

krbullock accepted this revision. krbullock added a comment. This revision is now accepted and ready to land. LGTM, thanks. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1713 To: durin42, #hg-reviewers, krbullock Cc: krbullock, mercurial-devel

D1719: debug: remove an 'if ui.debug()' that is not doing anything

quark added a comment. I think it should be `ui.debugflag`. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1719 To: spectral, #hg-reviewers Cc: quark, mercurial-devel ___ Mercurial-devel mailing list

D1720: debug: add newlines at the end of three locations that appear to need it

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1720 AFFECTED FILES hgext/patchbomb.py mercurial/bundle2.py mercurial/dispatch.py CHANGE DETAILS

D1721: debug: customizable timestamp when printing ui.debug text

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Sometimes users report "X is slow", where X is usually something that has some debug output, like `hg push`. Having timestamps as part of the ui.debug() output

D1719: debug: remove an 'if ui.debug()' that is not doing anything

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY ui.debug() does not return a value. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1719 AFFECTED FILES

D1717: lfs: fix committing deleted files caused by e0a1b9ee93cd

mharbison72 added a comment. LGTM. Sorry about that. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1717 To: quark, #hg-reviewers, mharbison72 Cc: mercurial-devel ___ Mercurial-devel mailing list

D1082: split: new extension to split changesets

quark updated this revision to Diff 4534. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1082?vs=2827=4534 REVISION DETAIL https://phab.mercurial-scm.org/D1082 AFFECTED FILES hgext/split.py tests/test-split.t CHANGE DETAILS diff --git

D1718: worker: handle interrupt on windows

wlis created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY After applying suggestions from https://phab.mercurial-scm.org/D1564 to catch all exceptions in the same way I actually broke the handling of KeyboardInterrupt on

D1717: lfs: fix committing deleted files caused by e0a1b9ee93cd

quark created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY https://phab.mercurial-scm.org/rHGe0a1b9ee93cdfb40ba43e8838a1edf4ea3ea24f3 (lfs: add a repo requirement for this extension once an lfs file is committed)

D1716: completion: add support for new "amend" command

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The command is now shipped with Mercurial, but completion should be helpful (and accurate) for users of the amend command shipped with the evolve extension

D1715: completion: don't suggest clean files to revert

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY It looks like we used to suggest only modified, added, removed and deleted files to revert until

mercurial@35450: 22 new changesets (2 on stable)

22 new changesets (2 on stable) in mercurial: https://www.mercurial-scm.org/repo/hg/rev/0279c2267d00 changeset: 35429:0279c2267d00 branch: stable parent: 35425:88572b7e50fd user:Yuya Nishihara date:Sun Dec 17 18:28:15 2017 +0900 summary: hgweb:

D1564: worker: make windows workers daemons

wlis added inline comments. INLINE COMMENTS > worker.py:285 > +threads.remove(t) > +except Exception: # re-raises > +trykillworkers() I forgot to update this diff with KeyboardInterrupt again which doesn't derive from Exception, but BaseException instead. I will try

D1713: tests: update expected output of svn encoding test

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The changes I see on the buildbot match the ones I see on my laptop, and all look reasonable. REPOSITORY rHG Mercurial REVISION DETAIL

Re: [PATCH 2 of 2 STABLE] diff: disable diff.noprefix option for diffstat (issue5759)

> On Dec 18, 2017, at 09:52, Kevin Bullock > wrote: > >> On Dec 17, 2017, at 05:50, Yuya Nishihara wrote: >> >> # HG changeset patch >> # User Yuya Nishihara >> # Date 1513503785 -32400 >> # Sun Dec 17 18:43:05 2017 +0900

Re: [PATCH 2 of 2 STABLE] diff: disable diff.noprefix option for diffstat (issue5759)

> On Dec 17, 2017, at 05:50, Yuya Nishihara wrote: > > # HG changeset patch > # User Yuya Nishihara > # Date 1513503785 -32400 > # Sun Dec 17 18:43:05 2017 +0900 > # Branch stable > # Node ID 21f4da606ff71e45725bd35db1982e3b02b7127c > # Parent

Re: [PATCH 2 of 2] run-tests: use context managers for file descriptors

On Mon, 18 Dec 2017 10:44:31 +0100, Boris Feld wrote: > The patches looks good to me, but I'm not an expert in the Windows > world. > > On Sun, 2017-12-17 at 17:25 -0500, Matt Harbison wrote: > > # HG changeset patch > > # User Matt Harbison > > # Date 1513537609 18000 >

Re: [PATCH V3] debuginstall: add a line about re2 availability

On Mon, 18 Dec 2017 13:28:21 +0100, Boris Feld wrote: > # HG changeset patch > # User Boris Feld > # Date 1511826516 18000 > # Mon Nov 27 18:48:36 2017 -0500 > # Node ID 2cb08cc4da195acbbbd69139619710404576f683 > # Parent 71427ff1dff8c8af665a4c4a1605d7ec9a77 > #

[PATCH V3] debuginstall: add a line about re2 availability

# HG changeset patch # User Boris Feld # Date 1511826516 18000 # Mon Nov 27 18:48:36 2017 -0500 # Node ID 2cb08cc4da195acbbbd69139619710404576f683 # Parent 71427ff1dff8c8af665a4c4a1605d7ec9a77 # EXP-Topic debugpyre2 # Available At

D1591: visibility: improve the message when accessing filtered obsolete rev

lothiraldan marked an inline comment as done. lothiraldan added inline comments. INLINE COMMENTS > pulkit wrote in test-obshistory.t:190 > This one looks odd. Please make this one similar to other split message. Fixed, thank you for the catch! REPOSITORY rHG Mercurial REVISION DETAIL

D1591: visibility: improve the message when accessing filtered obsolete rev

lothiraldan updated this revision to Diff 4527. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1591?vs=4250=4527 REVISION DETAIL https://phab.mercurial-scm.org/D1591 AFFECTED FILES mercurial/context.py mercurial/obsutil.py tests/test-log.t

Re: [PATCH 2 of 2] run-tests: use context managers for file descriptors

The patches looks good to me, but I'm not an expert in the Windows world. On Sun, 2017-12-17 at 17:25 -0500, Matt Harbison wrote: > # HG changeset patch > # User Matt Harbison > # Date 1513537609 18000 > #  Sun Dec 17 14:06:49 2017 -0500 > # Node ID