[PATCH 3 of 3] lfs: prefetch lfs blobs during revert

2018-02-03 Thread Matt Harbison
# HG changeset patch # User Matt Harbison # Date 1517722408 18000 # Sun Feb 04 00:33:28 2018 -0500 # Node ID 702a3c1d6335cd8f7cf7916029e10e22691e3091 # Parent e779b0c34d6989e45cabbf8da8cdfeb060134dbd lfs: prefetch lfs blobs during revert The revert command oddly prints out what it will do b

[PATCH 2 of 3] lfs: prefetch lfs blobs when applying merge updates

2018-02-03 Thread Matt Harbison
# HG changeset patch # User Matt Harbison # Date 1517711172 18000 # Sat Feb 03 21:26:12 2018 -0500 # Node ID e779b0c34d6989e45cabbf8da8cdfeb060134dbd # Parent 359c61b92d8b47b866a8b527829643f45bba8970 lfs: prefetch lfs blobs when applying merge updates In addition to merge, this method ultim

[PATCH 1 of 3] lfs: factor out a method for extracting the pointer of a single file

2018-02-03 Thread Matt Harbison
# HG changeset patch # User Matt Harbison # Date 1517082796 18000 # Sat Jan 27 14:53:16 2018 -0500 # Node ID 359c61b92d8b47b866a8b527829643f45bba8970 # Parent a9802c9ecfb5aa20d89480763ae15b03f78f3a88 lfs: factor out a method for extracting the pointer of a single file This will be useful fo

D2010: check-commit: allow foo_bar naming in functions

2018-02-03 Thread av6 (Anton Shestakov)
av6 added a comment. As opposed to 11 words smashed together, function names in Mercurial usually are 2 or 3 words (if not just one), which is not at all bad. I think breaking inconsistency with the existing code base would be worse than making people get used to no-spaces style (the one tha

D2011: filemerge: support passing labels to external merge tools

2018-02-03 Thread spectral (Kyle Lippincott)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG9037c29e9f53: filemerge: support passing labels to external merge tools (authored by spectral, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2011

D2012: merge: use operation-provided labels (ex: dest/source) in several merge-tools

2018-02-03 Thread spectral (Kyle Lippincott)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGa9802c9ecfb5: merge: use operation-provided labels (ex: dest/source) in several merge-tools (authored by spectral, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mer

Re: [PATCH V2] bookmarks: drop deprecated methods (API)

2018-02-03 Thread Yuya Nishihara
On Sat, 03 Feb 2018 12:53:53 -0500, Matt Harbison wrote: > # HG changeset patch > # User Matt Harbison > # Date 1517631655 18000 > # Fri Feb 02 23:20:55 2018 -0500 > # Node ID bd31f3bf6824a6dd7d296f73f0b91e35d19f963a > # Parent ed3a7300b7b5a427bdcffefd0c80aab65824bf4b > bookmarks: drop depre

mercurial@35881: 32 new changesets

2018-02-03 Thread Mercurial Commits
32 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/079b27b5a869 changeset: 35850:079b27b5a869 user:Joerg Sonnenberger date:Thu Jan 25 22:40:19 2018 +0100 summary: patch: avoid repeated binary checks if all files in a patch are text https://www.mercur

D2022: ui: improve ui.write performance when not coloring on Windows

2018-02-03 Thread joerg.sonnenberger (Joerg Sonnenberger)
joerg.sonnenberger created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2022 AFFECTED FILES mercurial/logcmdutil.py mercurial/ui.py CHANGE DETAILS diff --git a/

Re: [PATCH 1 of 9] py3: replace "if ispy3" by encoding.strtolocal()

2018-02-03 Thread Gregory Szorc
On Sat, Feb 3, 2018 at 12:36 AM, Yuya Nishihara wrote: > # HG changeset patch > # User Yuya Nishihara > # Date 1517026189 -32400 > # Sat Jan 27 13:09:49 2018 +0900 > # Node ID f4250fa75585535cd97f378d27b4d999d4ccc359 > # Parent c8e2d6ed1f9ea4eee7b28250b5aff22433d538b6 > py3: replace "if is

[PATCH V2] bookmarks: drop deprecated methods (API)

2018-02-03 Thread Matt Harbison
# HG changeset patch # User Matt Harbison # Date 1517631655 18000 # Fri Feb 02 23:20:55 2018 -0500 # Node ID bd31f3bf6824a6dd7d296f73f0b91e35d19f963a # Parent ed3a7300b7b5a427bdcffefd0c80aab65824bf4b bookmarks: drop deprecated methods (API) The ProgrammingError prevents accidental usage of

[PATCH 9 of 9] archive: rewrite default metadata template as a multi-line bytes literal

2018-02-03 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1517639173 -32400 # Sat Feb 03 15:26:13 2018 +0900 # Node ID d04fb3e17bb06003d0e16cb1a4be782cb7820f79 # Parent c1752bc1026f6388a83793b2fcf2eb6cddae53e1 archive: rewrite default metadata template as a multi-line bytes literal This fixes test-

[PATCH 5 of 9] py3: build repr() of smartset as bytes then convert to str

2018-02-03 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1517040755 -32400 # Sat Jan 27 17:12:35 2018 +0900 # Node ID 6fe094beb24e69c9a34331a2e10fc4b79c6d7669 # Parent 85ed4b6e56fdceaae2a7deb5b129ea8ee24ee8c5 py3: build repr() of smartset as bytes then convert to str This isn't pretty, but we have

[PATCH 2 of 9] py3: replace "if ispy3" by pycompat.bytestr()

2018-02-03 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1517026306 -32400 # Sat Jan 27 13:11:46 2018 +0900 # Node ID ab13ecb04e6665222ad3e10308dc7c2b84b3138b # Parent f4250fa75585535cd97f378d27b4d999d4ccc359 py3: replace "if ispy3" by pycompat.bytestr() diff --git a/mercurial/dispatch.py b/mercur

[PATCH 3 of 9] py3: replace "if ispy3" by pycompat.sysbytes() or util.forcebytestr()

2018-02-03 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1517026446 -32400 # Sat Jan 27 13:14:06 2018 +0900 # Node ID 9b3d33f9e615002d0a7da4d0d04ec04ae5c04cff # Parent ab13ecb04e6665222ad3e10308dc7c2b84b3138b py3: replace "if ispy3" by pycompat.sysbytes() or util.forcebytestr() diff --git a/mercur

[PATCH 7 of 9] py3: always drop b'' prefix from repr() of bytestr

2018-02-03 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1517041885 -32400 # Sat Jan 27 17:31:25 2018 +0900 # Node ID d6dc55d17ec2df28f544701cb97dce4a7641a1ed # Parent 6ac5670c4d6cf51930af9bd63981c3f5ef986699 py3: always drop b'' prefix from repr() of bytestr Perhaps this is what we wanted for py2

[PATCH 8 of 9] py3: drop b'' from repr() of smartset

2018-02-03 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1517042797 -32400 # Sat Jan 27 17:46:37 2018 +0900 # Node ID c1752bc1026f6388a83793b2fcf2eb6cddae53e1 # Parent d6dc55d17ec2df28f544701cb97dce4a7641a1ed py3: drop b'' from repr() of smartset cmdutil._maybebytestr() is moved to pycompat. diff

[PATCH 6 of 9] py3: format revision number as '%d' in debugrevspec

2018-02-03 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1517040831 -32400 # Sat Jan 27 17:13:51 2018 +0900 # Node ID 6ac5670c4d6cf51930af9bd63981c3f5ef986699 # Parent 6fe094beb24e69c9a34331a2e10fc4b79c6d7669 py3: format revision number as '%d' in debugrevspec Now "hg debugrevspec" works on Python

[PATCH 4 of 9] py3: factor out helpers to apply string conversion recursively

2018-02-03 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1517027611 -32400 # Sat Jan 27 13:33:31 2018 +0900 # Node ID 85ed4b6e56fdceaae2a7deb5b129ea8ee24ee8c5 # Parent 9b3d33f9e615002d0a7da4d0d04ec04ae5c04cff py3: factor out helpers to apply string conversion recursively diff --git a/mercurial/cmd

[PATCH 1 of 9] py3: replace "if ispy3" by encoding.strtolocal()

2018-02-03 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1517026189 -32400 # Sat Jan 27 13:09:49 2018 +0900 # Node ID f4250fa75585535cd97f378d27b4d999d4ccc359 # Parent c8e2d6ed1f9ea4eee7b28250b5aff22433d538b6 py3: replace "if ispy3" by encoding.strtolocal() diff --git a/mercurial/lock.py b/mercuri

D2010: check-commit: allow foo_bar naming in functions

2018-02-03 Thread yuja (Yuya Nishihara)
yuja added a comment. I'm kinda -1 on this because of inconsistency with the 10-year codebase. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2010 To: indygreg, #hg-reviewers, pulkit, durin42 Cc: yuja, durin42, pulkit, mercurial-devel ___

D1939: ui: Improve performance for multi-component writes

2018-02-03 Thread joerg.sonnenberger (Joerg Sonnenberger)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGe49c39ffeac2: ui: improve performance for multi-component writes (authored by joerg.sonnenberger, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1

Re: [PATCH 4 of 4] cmdutil: drop aliases for logcmdutil functions (API)

2018-02-03 Thread Yuya Nishihara
On Fri, 2 Feb 2018 17:14:13 -0500, Augie Fackler wrote: > I wonder if we should have a check-code rule to limit the size of .py files > in mercurial/ and hgext/? Maybe, but I don't wanna blame someone who adds a single line to a file which was about to exceed the hard limit. __

Re: [PATCH 1 of 8] bookmarks: drop deprecated methods (API)

2018-02-03 Thread Yuya Nishihara
On Sat, 03 Feb 2018 01:34:57 -0500, Matt Harbison wrote: > # HG changeset patch > # User Matt Harbison > # Date 1517631655 18000 > # Fri Feb 02 23:20:55 2018 -0500 > # Node ID d293af8e5a4a48a38ff9103e129c1af5719081c1 > # Parent c8e2d6ed1f9ea4eee7b28250b5aff22433d538b6 > bookmarks: drop depre

D1973: bdiff: write a native version of splitnewlines

2018-02-03 Thread yuja (Yuya Nishihara)
yuja requested changes to this revision. yuja added a comment. This revision now requires changes to proceed. Looks mostly good to me. I hesitated to fix minor nits in flight because it's C. INLINE COMMENTS > bdiff.c:185 > > +bool sliceintolist(PyObject *list, Py_ssize_t destidx, > +