Re: [PATCH STABLE] setup: only allow Python 3 from a source checkout (issue5804)

2018-02-23 Thread Yuya Nishihara
On Fri, 23 Feb 2018 18:02:20 -0800, Gregory Szorc wrote: > # HG changeset patch > # User Gregory Szorc > # Date 1519437424 28800 > # Fri Feb 23 17:57:04 2018 -0800 > # Branch stable > # Node ID 5b80235fd920c02ff430d8b0989fc55a58f11a0c > # Parent 5da7b8cb6f751fa7a331ed501d26f336e1bbc8f9 > set

Re: [PATCH 03 of 11] py3: use pycompat.bytestr to convert str returned by getpass.getuser to bytes

2018-02-23 Thread Yuya Nishihara
On Fri, 23 Feb 2018 23:45:16 +0530, Pulkit Goyal wrote: > # HG changeset patch > # User Pulkit Goyal <7895pul...@gmail.com> > # Date 1519386265 -19800 > # Fri Feb 23 17:14:25 2018 +0530 > # Node ID dbcf3a406cf79d296d7e29ea2786fd647facd367 > # Parent 70c096e42cb8a63a62efe69b87cd7ccc5c539dba >

Re: [PATCH 08 of 11] py3: pass ctx.rev() instead of ctx in range()

2018-02-23 Thread Yuya Nishihara
On Fri, 23 Feb 2018 18:54:53 -0800, Gregory Szorc wrote: > Speaking of __int__, it is only defined in one place in the repo: on > context.basectx. I think we should consider removing it: it is too much > coercion magic for my liking. +1 for removing int(ctx) and '%d' % ctx. Actually it doesn't alw

Re: [PATCH] namespace: fastpath name lookup on invalid name

2018-02-23 Thread Yuya Nishihara
On Thu, 22 Feb 2018 20:33:36 +0100, Boris Feld wrote: > # HG changeset patch > # User Boris Feld > # Date 1519313522 -3600 > # Thu Feb 22 16:32:02 2018 +0100 > # Node ID b65a85952c09cf4c71a1458fbc4ec77c49683314 > # Parent 428de1a59f2df3d6d07ff1d7164c8ee56cbb7825 > # EXP-Topic noname > # Avai

Re: [PATCH] tests: add HTTP POST and PUT support to the $LOGDATE$ substitution

2018-02-23 Thread Yuya Nishihara
On Fri, 23 Feb 2018 22:02:10 -0500, Matt Harbison wrote: > # HG changeset patch > # User Matt Harbison > # Date 1519437010 18000 > # Fri Feb 23 20:50:10 2018 -0500 > # Node ID 14510712ffab7d3b779fe3eeba6b94f003ca10f7 > # Parent 762820292aea1fe3948e05b3ac65f2d448386626 > tests: add HTTP POST

[PATCH] tests: add HTTP POST and PUT support to the $LOGDATE$ substitution

2018-02-23 Thread Matt Harbison
# HG changeset patch # User Matt Harbison # Date 1519437010 18000 # Fri Feb 23 20:50:10 2018 -0500 # Node ID 14510712ffab7d3b779fe3eeba6b94f003ca10f7 # Parent 762820292aea1fe3948e05b3ac65f2d448386626 tests: add HTTP POST and PUT support to the $LOGDATE$ substitution The lfs serving code use

Re: [PATCH 08 of 11] py3: pass ctx.rev() instead of ctx in range()

2018-02-23 Thread Gregory Szorc
On Fri, Feb 23, 2018 at 10:15 AM, Pulkit Goyal <7895pul...@gmail.com> wrote: > # HG changeset patch > # User Pulkit Goyal <7895pul...@gmail.com> > # Date 1519389273 -19800 > # Fri Feb 23 18:04:33 2018 +0530 > # Node ID a2b469c5995b4c2602f1bb1c3959d67ee9c08141 > # Parent 457aea9470d03f8e69c87

Re: [PATCH 01 of 11] py3: add b'' prefixes in test-dispatch.py

2018-02-23 Thread Gregory Szorc
On Fri, Feb 23, 2018 at 10:15 AM, Pulkit Goyal <7895pul...@gmail.com> wrote: > # HG changeset patch > # User Pulkit Goyal <7895pul...@gmail.com> > # Date 1519236803 -19800 > # Wed Feb 21 23:43:23 2018 +0530 > # Node ID ea8a43155c3d51289609afeda8659b4d604b2e1e > # Parent b8d0761a85c7421071750

D2403: stack: remove destutil.stackbase

2018-02-23 Thread indygreg (Gregory Szorc)
indygreg added a comment. Oh, I guess the series never did formerly define a revset for stack :/ I think there is room for one. We have the ability to mark revsets as experimental or internal, right? Could/should we do that so we don't need `hg debugstack`? Anyway, I could probably

D2398: histedit: use the new stack definition for histedit

2018-02-23 Thread indygreg (Gregory Szorc)
indygreg requested changes to this revision. indygreg added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > destutil.py:345 > """Default base revision to edit for `hg histedit`.""" > -default = ui.config('histedit', 'defaultrev', histeditdefaultrevset) >

D2399: stack: return a sorted smartrev by default

2018-02-23 Thread indygreg (Gregory Szorc)
indygreg requested changes to this revision. indygreg added a comment. This revision now requires changes to proceed. Looks good. But only marking as needing changes because I think we may get rid of `hg debugstack`. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org

D2396: stack: import Evolve stack test file

2018-02-23 Thread indygreg (Gregory Szorc)
indygreg added a comment. I haven't looked at the remainder of the series, but it feels weird to basically reinvent a special case of `hg log` as a debug command. I do see there is a commit introducing a revset for `stack`. Perhaps we could move it up in the series so we don't need what migh

D2395: stack: add a new module for stack-related commands

2018-02-23 Thread indygreg (Gregory Szorc)
indygreg requested changes to this revision. indygreg added a comment. This revision now requires changes to proceed. Requires a minor style change. But I like where this is going... INLINE COMMENTS > stack.py:10 > + > +from . import revsetlang, scmutil > + Nit: this doesn't following our im

D2392: debugcommands: add debugwireproto command

2018-02-23 Thread indygreg (Gregory Szorc)
indygreg planned changes to this revision. indygreg added inline comments. INLINE COMMENTS > debugcommands.py:2630 > +# separation. This prevents a whole class of potential bugs around > +# shared state from interfering with server operation. > + I'm having second thoughts about

[PATCH STABLE] setup: only allow Python 3 from a source checkout (issue5804)

2018-02-23 Thread Gregory Szorc
# HG changeset patch # User Gregory Szorc # Date 1519437424 28800 # Fri Feb 23 17:57:04 2018 -0800 # Branch stable # Node ID 5b80235fd920c02ff430d8b0989fc55a58f11a0c # Parent 5da7b8cb6f751fa7a331ed501d26f336e1bbc8f9 setup: only allow Python 3 from a source checkout (issue5804) People are ru

[Bug 5804] New: Simple pull causes: AttributeError: 'str' object has no attribute 'decode'

2018-02-23 Thread mercurial-bugs
https://bz.mercurial-scm.org/show_bug.cgi?id=5804 Bug ID: 5804 Summary: Simple pull causes: AttributeError: 'str' object has no attribute 'decode' Product: Mercurial Version: unspecified Hardware: PC OS: Lin

D2404: util: enable observing of util.bufferedinputpipe

2018-02-23 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 6025. indygreg edited the summary of this revision. indygreg retitled this revision from "util: enable observing of os.read() from bufferedinputpipe" to "util: enable observing of util.bufferedinputpipe". REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2406: debugcommands: allow sending of simple commands with debugwireproto

2018-02-23 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 6026. indygreg edited the summary of this revision. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2406?vs=6023&id=6026 REVISION DETAIL https://phab.mercurial-scm.org/D2406 AFFECTED FILES mercurial/debugcommands.

D2408: debugcommands: support for sending "batch" requests

2018-02-23 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Let's teach `hg debugwireproto` to send "batch" requests. The easiest way to implement this was as a pair of instructions to begin and end a batched operatio

D2404: util: enable observing of os.read() from bufferedinputpipe

2018-02-23 Thread indygreg (Gregory Szorc)
indygreg planned changes to this revision. indygreg added a comment. I have some revisions to this... REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2404 To: indygreg, #hg-reviewers Cc: mercurial-devel ___ Mercurial-de

mercurial@36363: 5 new changesets

2018-02-23 Thread Mercurial Commits
5 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/df3f7f00a3fc changeset: 36359:df3f7f00a3fc user:Boris Feld date:Wed Feb 21 12:13:16 2018 +0100 summary: perfbranchmap: display 'unfiltered' for unfiltered performance https://www.mercurial-scm.org/repo

D2406: debugcommands: allow sending of simple commands with debugwireproto

2018-02-23 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Previously, we only had support for low-level "raw" operations. A goal of `hg debugwireproto` is to allow easily performing higher-level primitives, such as

D2405: wireproto: sort response to listkeys

2018-02-23 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The listkeys protocol is defined to produce a dictionary. pushkey.decodekeys() uses a plain dict to hold the decoded results of the wire protocol response. So o

D2404: util: enable observing of os.read() from bufferedinputpipe

2018-02-23 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Our file object proxy is useful. But it doesn't capture all I/O. The "os" module offers low-level interfaces to various system calls. For example, os.read() exp

D2407: tests: add low-level SSH protocol tests for listkeys

2018-02-23 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We previously lacked test coverage of the low-level output of the "listkeys" wire protocol command. We add basic testing for the "namespaces," "bookmarks," a

[PATCH 09 of 11] py3: add missing b'' in test-arbitraryfilectx.t

2018-02-23 Thread Pulkit Goyal
# HG changeset patch # User Pulkit Goyal <7895pul...@gmail.com> # Date 1519389740 -19800 # Fri Feb 23 18:12:20 2018 +0530 # Node ID 1e72b28e804b014573a8e156ae46129f44979c51 # Parent a2b469c5995b4c2602f1bb1c3959d67ee9c08141 py3: add missing b'' in test-arbitraryfilectx.t # skip-blame as just

[PATCH 03 of 11] py3: use pycompat.bytestr to convert str returned by getpass.getuser to bytes

2018-02-23 Thread Pulkit Goyal
# HG changeset patch # User Pulkit Goyal <7895pul...@gmail.com> # Date 1519386265 -19800 # Fri Feb 23 17:14:25 2018 +0530 # Node ID dbcf3a406cf79d296d7e29ea2786fd647facd367 # Parent 70c096e42cb8a63a62efe69b87cd7ccc5c539dba py3: use pycompat.bytestr to convert str returned by getpass.getuser t

[PATCH 10 of 11] py3: replace types.NoneType with type(None)

2018-02-23 Thread Pulkit Goyal
# HG changeset patch # User Pulkit Goyal <7895pul...@gmail.com> # Date 1519390431 -19800 # Fri Feb 23 18:23:51 2018 +0530 # Node ID c8124f3591d41903f701df60f6786db8c77fb13d # Parent 1e72b28e804b014573a8e156ae46129f44979c51 py3: replace types.NoneType with type(None) types.NoneType is not pre

[PATCH 08 of 11] py3: pass ctx.rev() instead of ctx in range()

2018-02-23 Thread Pulkit Goyal
# HG changeset patch # User Pulkit Goyal <7895pul...@gmail.com> # Date 1519389273 -19800 # Fri Feb 23 18:04:33 2018 +0530 # Node ID a2b469c5995b4c2602f1bb1c3959d67ee9c08141 # Parent 457aea9470d03f8e69c873b9aec845256abf9023 py3: pass ctx.rev() instead of ctx in range() diff --git a/hgext/acl.

[PATCH 06 of 11] py3: add b'' prefixes in test-revset.t

2018-02-23 Thread Pulkit Goyal
# HG changeset patch # User Pulkit Goyal <7895pul...@gmail.com> # Date 1519387005 -19800 # Fri Feb 23 17:26:45 2018 +0530 # Node ID 1e72a81291eaee764c8cf7d0a40ea950bf92735c # Parent 66968eaf19d62767cbdb446d0c173e67d5a925ce py3: add b'' prefixes in test-revset.t # skip-blame because it's just

[PATCH 04 of 11] py3: fix keyword arguments handling in hgext/acl.py

2018-02-23 Thread Pulkit Goyal
# HG changeset patch # User Pulkit Goyal <7895pul...@gmail.com> # Date 1519386336 -19800 # Fri Feb 23 17:15:36 2018 +0530 # Node ID 6610c379cb0f90d9dbdc787e3d7982fce07ded86 # Parent dbcf3a406cf79d296d7e29ea2786fd647facd367 py3: fix keyword arguments handling in hgext/acl.py # skip-blame beca

[PATCH 02 of 11] py3: add b'' prefixes in test-abort-checkin.t

2018-02-23 Thread Pulkit Goyal
# HG changeset patch # User Pulkit Goyal <7895pul...@gmail.com> # Date 1519385237 -19800 # Fri Feb 23 16:57:17 2018 +0530 # Node ID 70c096e42cb8a63a62efe69b87cd7ccc5c539dba # Parent ea8a43155c3d51289609afeda8659b4d604b2e1e py3: add b'' prefixes in test-abort-checkin.t # skip-blame because we

[PATCH 11 of 11] py3: make regex bytes in hgweb/webcommands.py

2018-02-23 Thread Pulkit Goyal
# HG changeset patch # User Pulkit Goyal <7895pul...@gmail.com> # Date 1519391846 -19800 # Fri Feb 23 18:47:26 2018 +0530 # Node ID f22ce7b97364996db41168e4386329a4b223e0ed # Parent c8124f3591d41903f701df60f6786db8c77fb13d py3: make regex bytes in hgweb/webcommands.py # skip-blame because ju

[PATCH 07 of 11] py3: add b'' prefixes in test-alias.t

2018-02-23 Thread Pulkit Goyal
# HG changeset patch # User Pulkit Goyal <7895pul...@gmail.com> # Date 1519389238 -19800 # Fri Feb 23 18:03:58 2018 +0530 # Node ID 457aea9470d03f8e69c873b9aec845256abf9023 # Parent 1e72a81291eaee764c8cf7d0a40ea950bf92735c py3: add b'' prefixes in test-alias.t # skip-blame as it's just b'' p

[PATCH 05 of 11] py3: make sure we use bytes in generate-working-copy-states.py

2018-02-23 Thread Pulkit Goyal
# HG changeset patch # User Pulkit Goyal <7895pul...@gmail.com> # Date 1519386951 -19800 # Fri Feb 23 17:25:51 2018 +0530 # Node ID 66968eaf19d62767cbdb446d0c173e67d5a925ce # Parent 6610c379cb0f90d9dbdc787e3d7982fce07ded86 py3: make sure we use bytes in generate-working-copy-states.py diff -

[PATCH 01 of 11] py3: add b'' prefixes in test-dispatch.py

2018-02-23 Thread Pulkit Goyal
# HG changeset patch # User Pulkit Goyal <7895pul...@gmail.com> # Date 1519236803 -19800 # Wed Feb 21 23:43:23 2018 +0530 # Node ID ea8a43155c3d51289609afeda8659b4d604b2e1e # Parent b8d0761a85c7421071750de23228415306852d69 py3: add b'' prefixes in test-dispatch.py # skip-blame because this i

D2393: cleanup: say goodbye to manifestv2 format

2018-02-23 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG0147a4730420: cleanup: say goodbye to manifestv2 format (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2393?vs=6019&id=6020

D2394: histedit: make histedit's commands accept revsets (issue5746)

2018-02-23 Thread krbullock (Kevin Bullock)
krbullock added a comment. Oh sorry, I see you're already on the case. Carry on! REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2394 To: sangeet259, durin42, #hg-reviewers Cc: krbullock, rishabhmadan96, mercurial-devel ___

D2394: histedit: make histedit's commands accept revsets (issue5746)

2018-02-23 Thread krbullock (Kevin Bullock)
krbullock added a comment. Can we get some test coverage on this? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2394 To: sangeet259, durin42, #hg-reviewers Cc: krbullock, rishabhmadan96, mercurial-devel ___ Mercurial-

D2393: cleanup: say goodbye to manifestv2 format

2018-02-23 Thread durin42 (Augie Fackler)
durin42 updated this revision to Diff 6019. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2393?vs=6006&id=6019 REVISION DETAIL https://phab.mercurial-scm.org/D2393 AFFECTED FILES mercurial/configitems.py mercurial/help/internals/requirements.txt

[PATCH evolve-ext V2] obsdiscovery: include units in ui.progress() calls (issue5773)

2018-02-23 Thread Anton Shestakov
# HG changeset patch # User Anton Shestakov # Date 1519388837 -28800 # Fri Feb 23 20:27:17 2018 +0800 # Node ID 82551a1622d4240668da3f8958391705d2795578 # Parent 25155eb05f5f1657e325e7b77e3f190f72d25577 obsdiscovery: include units in ui.progress() calls (issue5773) diff --git a/hgext3rd/evo

D2391: sshpeer: factor out code for creating peers from pipes

2018-02-23 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 6018. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2391?vs=6004&id=6018 REVISION DETAIL https://phab.mercurial-scm.org/D2391 AFFECTED FILES mercurial/sshpeer.py CHANGE DETAILS diff --git a/mercurial/sshpeer.p

Re: [PATCH] diff: do not split function name if character encoding is unknown

2018-02-23 Thread Josef 'Jeff' Sipek
On Fri, Feb 23, 2018 at 23:53:18 +0900, Yuya Nishihara wrote: > # HG changeset patch > # User Yuya Nishihara > # Date 1519394998 -32400 > # Fri Feb 23 23:09:58 2018 +0900 > # Node ID 98cfd7926442dc0a649e0359455ad6962815bd13 > # Parent b8d0761a85c7421071750de23228415306852d69 > diff: do not s

[PATCH] diff: do not split function name if character encoding is unknown

2018-02-23 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1519394998 -32400 # Fri Feb 23 23:09:58 2018 +0900 # Node ID 98cfd7926442dc0a649e0359455ad6962815bd13 # Parent b8d0761a85c7421071750de23228415306852d69 diff: do not split function name if character encoding is unknown Only ASCII characters c

[PATCH evolve-ext RFC] obsdiscovery: include units in ui.progress() calls (issue5773)

2018-02-23 Thread Anton Shestakov
# HG changeset patch # User Anton Shestakov # Date 1519388837 -28800 # Fri Feb 23 20:27:17 2018 +0800 # Node ID 24a9c27666d2f33851647324a8632f3f07afbbd6 # Parent 25155eb05f5f1657e325e7b77e3f190f72d25577 obsdiscovery: include units in ui.progress() calls (issue5773) diff --git a/hgext3rd/evo

D2399: stack: return a sorted smartrev by default

2018-02-23 Thread lothiraldan (Boris Feld)
lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Most stack customers will display a list of revisions, sort it by default. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2399 A

D2400: stack: begin to make the stack revset configurable

2018-02-23 Thread lothiraldan (Boris Feld)
lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY First extrat the not-merge part in its own configuration knob `stack.not- merge`. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org

D2401: stack: introduce an option to disable the restriction on ancestor

2018-02-23 Thread lothiraldan (Boris Feld)
lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The default stack revset restrict on only the ancestors of a revision. Some tools might want to display the current stack even if the working directory paren

D2398: histedit: use the new stack definition for histedit

2018-02-23 Thread lothiraldan (Boris Feld)
lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Now that we have a common stack definition, use it in the hg histedit command. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D239

D2402: stack: introduce an option to limit the selection on the current branch

2018-02-23 Thread lothiraldan (Boris Feld)
lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2402 AFFECTED FILES mercurial/configitems.py mercurial/stack.py tests/test-stack.t CHANGE DETA

D2396: stack: import Evolve stack test file

2018-02-23 Thread lothiraldan (Boris Feld)
lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Import Evolve stack test file for starting to have good coverage on stack definition. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm

D2403: stack: remove destutil.stackbase

2018-02-23 Thread lothiraldan (Boris Feld)
lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Use directly stack.getstack in show stack command. Remove destutil.stackbase. Import a TODO from the show stack in the code. REPOSITORY rHG Mercurial REVIS

D2397: show: use the new stack definition for show stack

2018-02-23 Thread lothiraldan (Boris Feld)
lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Now that we have a common stack definition, use it in the hg show stack command. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/

D2395: stack: add a new module for stack-related commands

2018-02-23 Thread lothiraldan (Boris Feld)
lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Bootstrap the module with a function that returns the stack for the current revision. The definition of the stack is ihnerited from histedit default revset a

[Bug 5803] New: Update repo with Cyrillic characters on APFS (High Sierra)

2018-02-23 Thread mercurial-bugs
https://bz.mercurial-scm.org/show_bug.cgi?id=5803 Bug ID: 5803 Summary: Update repo with Cyrillic characters on APFS (High Sierra) Product: Mercurial Version: default branch Hardware: Macintosh OS: Mac OS