Re: hg archive (files) performance regression.

2018-03-02 Thread Vincent Parrett
On 3/03/2018 1:32 PM, Matt Harbison wrote: AFAICT, the code prior to this vfs call didn't do atomic files, and didn't mention why the atomic aspect changed. I guess it's just something that was overlooked during refactoring to use the vfs? It looks like archive doesn't check for an empty

[PATCH] profile: colorize output on Windows

2018-03-02 Thread Matt Harbison
# HG changeset patch # User Matt Harbison # Date 1520055359 18000 # Sat Mar 03 00:35:59 2018 -0500 # Node ID 57af2e6a832eabb2e584977a11cc34c97092cfcd # Parent ed77050177498aff4ff4db94f30d5bdeefd8f76e profile: colorize output on Windows Previously, the ANSI codes

[PATCH 3 of 3] py3: make test-basic.t pass on Python 3

2018-03-02 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1520048289 18000 # Fri Mar 02 22:38:09 2018 -0500 # Node ID 19279a4054f6d095ae6877f01ec0c117f1054b68 # Parent 93fda19cf79e6f5d40b27720a0d65cd862f3a9f9 py3: make test-basic.t pass on Python 3 diff --git

[PATCH 2 of 3] py3: silence the final IOError by closing stdout/err slightly early

2018-03-02 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1520048120 18000 # Fri Mar 02 22:35:20 2018 -0500 # Node ID 93fda19cf79e6f5d40b27720a0d65cd862f3a9f9 # Parent c0193f6ec467af81491d0e7c8c46fe0f676f3018 py3: silence the final IOError by closing stdout/err slightly early Fixes

[PATCH 1 of 3] py3: conditionalize initialization of stdio flags

2018-03-02 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1520046636 18000 # Fri Mar 02 22:10:36 2018 -0500 # Node ID c0193f6ec467af81491d0e7c8c46fe0f676f3018 # Parent a007db19dc4d889dda54014f8dd3eb8a1c1ef08b py3: conditionalize initialization of stdio flags Since Python 3 doesn't

mercurial@36562: 7 new changesets

2018-03-02 Thread Mercurial Commits
7 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/63fe5ca93b13 changeset: 36556:63fe5ca93b13 user:Augie Fackler date:Thu Mar 01 17:46:34 2018 -0500 summary: pycompat: add support for encoding argument to our wrapper

Re: hg archive (files) performance regression.

2018-03-02 Thread Matt Harbison
On Fri, 02 Mar 2018 02:13:18 -0500, Vincent Parrett wrote: On 2/03/2018 4:31 PM, Vincent Parrett wrote: I'm not a python dev (mostly c# and delphi), so still getting my head around the hg code base, but I'm curious why the atomictemp=true is used in

D2570: tests: add missing b prefixes in test-atomictempfile.py

2018-03-02 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGa007db19dc4d: tests: add missing b prefixes in test-atomictempfile.py (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2576: xdiff: add a python wrapper

2018-03-02 Thread quark (Jun Wu)
quark added a comment. Traditionally things under `mercurial.cext` has a pure equivalent. So it's cleaner to either make the changes directly in `mercurial.cext.bdiff`, or `mercurial/bdiff.c`. Or add a xdiff pure shim. REPOSITORY rHG Mercurial REVISION DETAIL

mercurial@36555: 41 new changesets

2018-03-02 Thread Mercurial Commits
41 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/e71a3c0a90b0 changeset: 36515:e71a3c0a90b0 user:Yuya Nishihara date:Sun Feb 25 16:35:34 2018 +0900 summary: templatekw: factor out function to build a list of files per status

D2573: xdiff: remove patience and histogram diffs

2018-03-02 Thread ryanmce (Ryan McElroy)
ryanmce created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY They are greedy algorithms that yields suboptimal results. Patience diff has been advertised as "slower, but generating better results sometimes" for a long

D2575: xdiff: add a bdiff hunk mode

2018-03-02 Thread ryanmce (Ryan McElroy)
ryanmce created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY xdiff generated hunks for the differences (ex. questionmarks in the `@@ -?,? +?,? @@` part from `diff --git` output). However, bdiff generates matched hunks

D2578: xdiff: enable indent heuristic unconditionally

2018-03-02 Thread ryanmce (Ryan McElroy)
ryanmce created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Enable the indent heuristic feature unconditionally, since it provides nice visual improvements. See the added test, and [1]. [1]:

D2577: mdiff: prefer xdiff for diff calculation

2018-03-02 Thread ryanmce (Ryan McElroy)
ryanmce created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Let's switch to xdiff for its better diff quality and faster performance! bdiff is still used as a fallback for cases xdiff isn't built, or the pure Python

D2576: xdiff: add a python wrapper

2018-03-02 Thread ryanmce (Ryan McElroy)
ryanmce created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Implement a `mercurial.cext.xdiff` module that exposes the xdiff algorithm. `xdiff.blocks` should be a drop-in replacement for `bdiff.blocks`. In theory

Re: [PATCH 1 of 7 V2] revbranchcache: add a public function to update the data

2018-03-02 Thread Yuya Nishihara
On Thu, 01 Mar 2018 15:44:16 -0500, Boris Feld wrote: > # HG changeset patch > # User Boris Feld > # Date 1516281665 -3600 > # Thu Jan 18 14:21:05 2018 +0100 > # Node ID 9072a7903a7890cc61a6b7d0c7fa95e6d6db5b27 > # Parent 4b9e9e3f450c7c8a8717e0a2ed9573a067903ce6 > #

Re: [PATCH 6 of 7 V2] revbranchcache: disable the new part for narrow hg bundle

2018-03-02 Thread Yuya Nishihara
On Thu, 01 Mar 2018 15:44:21 -0500, Boris Feld wrote: > # HG changeset patch > # User Boris Feld > # Date 1519237601 -3600 > # Wed Feb 21 19:26:41 2018 +0100 > # Node ID 2811d9ca31137ca7a9cc7c8a37862cdbff87bbec > # Parent 56f869a852230bdbcff6ae3c366cb0d83f6cf757 > #

mercurial@36514: 5 new changesets (1 on stable)

2018-03-02 Thread Mercurial Commits
5 new changesets (1 on stable) in mercurial: https://www.mercurial-scm.org/repo/hg/rev/0a7c59a4c835 changeset: 36510:0a7c59a4c835 branch: stable parent: 36386:fb39f6a8a864 user:Yuya Nishihara date:Wed Feb 21 21:14:05 2018 +0900 summary: annotate: do

D2513: wireproto: only expose "between" to version 1 of wire protocols

2018-03-02 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGed7705017749: wireproto: only expose between to version 1 of wire protocols (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2486: wireproto: don't expose changegroupsubset capability if not available

2018-03-02 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGe89959970a08: wireproto: dont expose changegroupsubset capability if not available (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2550: tests: add more tests around hook output and getbundle

2018-03-02 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG1fa02265fae2: tests: add more tests around hook output and getbundle (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2571: sshpeer: don't read from stderr when that behavior is disabled

2018-03-02 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG1151c731686e: sshpeer: dont read from stderr when that behavior is disabled (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2484: wireprotoserver: identify requests via version 2 of SSH protocol as such

2018-03-02 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGaf0d38f015bb: wireprotoserver: identify requests via version 2 of SSH protocol as such (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2483: wireproto: allow wire protocol commands to declare transport support

2018-03-02 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGabc3b9801563: wireproto: allow wire protocol commands to declare transport support (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2485: wireproto: don't expose legacy commands to version 2 of wire protocol

2018-03-02 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG6906547c8476: wireproto: dont expose legacy commands to version 2 of wire protocol (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2512: wireproto: add transport specific capabilities in the transport

2018-03-02 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG6e585bca962e: wireproto: add transport specific capabilities in the transport (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2486: wireproto: don't expose changegroupsubset capability if not available

2018-03-02 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 6405. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2486?vs=6339=6405 REVISION DETAIL https://phab.mercurial-scm.org/D2486 AFFECTED FILES mercurial/wireproto.py tests/test-debugcommands.t

D2571: sshpeer: don't read from stderr when that behavior is disabled

2018-03-02 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We previously prevented the creation of doublepipe instances when we're not supposed to automatically read from stderr. However, there were other automatic

D2550: tests: add more tests around hook output and getbundle

2018-03-02 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 6406. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2550?vs=6346=6406 REVISION DETAIL https://phab.mercurial-scm.org/D2550 AFFECTED FILES tests/test-ssh-proto-unbundle.t CHANGE DETAILS diff --git

D2570: tests: add missing b prefixes in test-atomictempfile.py

2018-03-02 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY 1. skip-blame just some b prefixes REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2570 AFFECTED FILES

D2095: clone: updates the help text for hg clone -r (issue5654) [bugzilla] and hg clone -b

2018-03-02 Thread sangeet259 (Sangeet Kumar Mishra)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG4de15c54e59f: clone: updates the help text for hg clone -{r,b} (issue5654) (authored by sangeet259, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D2095?vs=5371=6401#toc

D2282: util: extract all date-related utils in utils/dateutil module

2018-03-02 Thread lothiraldan (Boris Feld)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGc6061cadb400: util: extract all date-related utils in utils/dateutil module (authored by lothiraldan, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D2282?vs=6400=6402#toc

D2282: util: extract all date-related utils in utils/dateutil module

2018-03-02 Thread lothiraldan (Boris Feld)
lothiraldan updated this revision to Diff 6400. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2282?vs=5767=6400 REVISION DETAIL https://phab.mercurial-scm.org/D2282 AFFECTED FILES contrib/synthrepo.py hgext/blackbox.py hgext/churn.py

D2569: py3: whitelist more passing tests

2018-03-02 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGebaf11969ab7: py3: whitelist more passing tests (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2569?vs=6392=6399 REVISION

D2568: lfs: convert hexdigest to bytes using sysbytes

2018-03-02 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGcda13ec1a228: lfs: convert hexdigest to bytes using sysbytes (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

[PATCH 1 of 3] templater: allow dynamically switching the default dict/list formatting

2018-03-02 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1519909642 18000 # Thu Mar 01 08:07:22 2018 -0500 # Node ID 09b7cc4c0d6e56e77553789225a2039f3de427fd # Parent c9dcc379e2dcc8d7718bdae3aa9df23ed54ff358 templater: allow dynamically switching the default dict/list formatting

[PATCH 3 of 3] test-command-template: glob out detailed "invalid escape" message

2018-03-02 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1519946719 18000 # Thu Mar 01 18:25:19 2018 -0500 # Node ID 5c58b3c471dac34967aeaf32c6a165efbb15bf63 # Parent 2c41855dbd2c20dedb97ac68a1909a9ffa9c0774 test-command-template: glob out detailed "invalid escape" message Python 3

[PATCH 2 of 3] templater: byte-stringify dict/list values before passing to default format

2018-03-02 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1519910094 18000 # Thu Mar 01 08:14:54 2018 -0500 # Node ID 2c41855dbd2c20dedb97ac68a1909a9ffa9c0774 # Parent 09b7cc4c0d6e56e77553789225a2039f3de427fd templater: byte-stringify dict/list values before passing to default format

D2568: lfs: convert hexdigest to bytes using sysbytes

2018-03-02 Thread durin42 (Augie Fackler)
durin42 updated this revision to Diff 6397. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2568?vs=6391=6397 REVISION DETAIL https://phab.mercurial-scm.org/D2568 AFFECTED FILES hgext/lfs/wrapper.py CHANGE DETAILS diff --git a/hgext/lfs/wrapper.py

D2567: lfs: use %d to encode int, not str()

2018-03-02 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGdcb6fbaa43a8: lfs: use %d to encode int, not str() (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2567?vs=6390=6396

D2566: lfs: use byteskwargs() on some **kwargs for python 3 compat

2018-03-02 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGe30be4d2ac60: lfs: use byteskwargs() on some **kwargs for python 3 compat (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2565: lfs: add some bytestring wrappers in blobstore.py

2018-03-02 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG4da09b46451e: lfs: add some bytestring wrappers in blobstore.py (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2564: lfs: add missing b prefixes on some regular expressions

2018-03-02 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG95bd9e396774: lfs: add missing b prefixes on some regular expressions (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2568: lfs: convert hexdigest to bytes using sysbytes

2018-03-02 Thread indygreg (Gregory Szorc)
indygreg requested changes to this revision. indygreg added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > wrapper.py:89 > # git-lfs only supports sha256 > -oid = hashlib.sha256(text).hexdigest() > +oid =

D2565: lfs: add some bytestring wrappers in blobstore.py

2018-03-02 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2565 AFFECTED FILES hgext/lfs/blobstore.py CHANGE DETAILS diff --git a/hgext/lfs/blobstore.py

D2569: py3: whitelist more passing tests

2018-03-02 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a reviewer: pulkit. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2569 AFFECTED FILES contrib/python3-whitelist CHANGE DETAILS diff

D2564: lfs: add missing b prefixes on some regular expressions

2018-03-02 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY 1. skip-blame just some b prefixes REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2564 AFFECTED FILES hgext/lfs/pointer.py

D2568: lfs: convert hexdigest to bytes using sysbytes

2018-03-02 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2568 AFFECTED FILES hgext/lfs/wrapper.py CHANGE DETAILS diff --git a/hgext/lfs/wrapper.py

D2567: lfs: use %d to encode int, not str()

2018-03-02 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2567 AFFECTED FILES hgext/lfs/wrapper.py CHANGE DETAILS diff --git a/hgext/lfs/wrapper.py

D2566: lfs: use byteskwargs() on some **kwargs for python 3 compat

2018-03-02 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2566 AFFECTED FILES hgext/lfs/pointer.py CHANGE DETAILS diff --git a/hgext/lfs/pointer.py

Re: [PATCH 10 of 10] templatekw: deprecate showdict() and showlist() (API)

2018-03-02 Thread Augie Fackler
On Thu, Mar 01, 2018 at 08:52:00PM -0500, Yuya Nishihara wrote: > # HG changeset patch > # User Yuya Nishihara > # Date 1519554875 -32400 > # Sun Feb 25 19:34:35 2018 +0900 > # Node ID d6bbe8dfafaeb32e48b38c1815dda69ca0854a5e > # Parent

Re: [PATCH] py3: silence "bad escape" warning emitted by re.sub()

2018-03-02 Thread Gregory Szorc
On Fri, Mar 2, 2018 at 3:32 PM, Yuya Nishihara wrote: > # HG changeset patch > # User Yuya Nishihara > # Date 1519946556 18000 > # Thu Mar 01 18:22:36 2018 -0500 > # Node ID b9a4498025f901cce6a5ceaedf027173e11d6a59 > # Parent

Re: [PATCH] py3: bail on ratcheting tests forward on 3.6.0 and 3.6.1

2018-03-02 Thread Gregory Szorc
On Fri, Mar 2, 2018 at 3:38 PM, Kevin Bullock < kbullock+mercur...@ringworld.org> wrote: > # HG changeset patch > # User Kevin Bullock > # Date 1520023077 18000 > # Fri Mar 02 15:37:57 2018 -0500 > # Node ID 71a83808184245c86280ede647e18e6cc7945594 > #

[PATCH] py3: bail on ratcheting tests forward on 3.6.0 and 3.6.1

2018-03-02 Thread Kevin Bullock
# HG changeset patch # User Kevin Bullock # Date 1520023077 18000 # Fri Mar 02 15:37:57 2018 -0500 # Node ID 71a83808184245c86280ede647e18e6cc7945594 # Parent dfcf589a4031211a67bab022e0a1b414f364bc39 py3: bail on ratcheting tests forward on 3.6.0 and 3.6.1

[PATCH] py3: silence "bad escape" warning emitted by re.sub()

2018-03-02 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1519946556 18000 # Thu Mar 01 18:22:36 2018 -0500 # Node ID b9a4498025f901cce6a5ceaedf027173e11d6a59 # Parent dfcf589a4031211a67bab022e0a1b414f364bc39 py3: silence "bad escape" warning emitted by re.sub() Since we pass user

D2561: util: work around Python 3 returning None at EOF instead of ''

2018-03-02 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG26a6b62919e2: util: work around Python 3 returning None at EOF instead of (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2560: util: add missing r prefix on some __setattr__ calls

2018-03-02 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGf5427483eebe: util: add missing r prefix on some __setattr__ calls (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2559: tests: add some re and globs for test-revset on python3

2018-03-02 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGedf736c3c064: tests: add some re and globs for test-revset on python3 (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2563: debugcommands: add some strkwargs love to some **args calls

2018-03-02 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGdfcf589a4031: debugcommands: add some strkwargs love to some **args calls (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2562: debugcommands: add an r prefix to make file mode for fdopen a sysstr

2018-03-02 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGff6b8484400b: debugcommands: add an r prefix to make file mode for fdopen a sysstr (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2563: debugcommands: add some strkwargs love to some **args calls

2018-03-02 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2563 AFFECTED FILES mercurial/debugcommands.py CHANGE DETAILS diff --git

D2561: util: work around Python 3 returning None at EOF instead of ''

2018-03-02 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2561 AFFECTED FILES mercurial/util.py CHANGE DETAILS diff --git a/mercurial/util.py

D2562: debugcommands: add an r prefix to make file mode for fdopen a sysstr

2018-03-02 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY 1. skip-blame just an r prefix REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2562 AFFECTED FILES mercurial/debugcommands.py

D2552: py3: whitelist more passing tests

2018-03-02 Thread durin42 (Augie Fackler)
durin42 updated this revision to Diff 6381. durin42 retitled this revision from "py3: sixteen more passing tests" to "py3: whitelist more passing tests". REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2552?vs=6372=6381 REVISION DETAIL

D2560: util: add missing r prefix on some __setattr__ calls

2018-03-02 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY 1. skip-blame just a pair of r prefixes REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2560 AFFECTED FILES mercurial/util.py

D2559: tests: add some re and globs for test-revset on python3

2018-03-02 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY At this point we're down to two deprecation warnings (which I suspect are showing a bug in the test?) and one weird-looking failure. Progress! REPOSITORY rHG

D2535: py3: use pycompat.bytestr() to convert error messages to bytes

2018-03-02 Thread yuja (Yuya Nishihara)
yuja requested changes to this revision. yuja added a comment. This revision now requires changes to proceed. Some of them have to be forcebytestr(). REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2535 To: pulkit, durin42, #hg-reviewers, yuja Cc: yuja,

D2549: debugcommands: fix repr in debugignore print with pycompat.bytestr

2018-03-02 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG149fd142f498: debugcommands: fix repr in debugignore print with pycompat.bytestr (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2552: py3: sixteen more passing tests

2018-03-02 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGbe27c4e310bd: py3: sixteen more passing tests (authored by durin42, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D2552?vs=6348=6372#toc REPOSITORY rHG Mercurial CHANGES

D2558: tests: add missing b prefixes and fix a %s to %d in test-revset.t

2018-03-02 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG27911e0fb50e: tests: add missing b prefixes and fix a %s to %d in test-revset.t (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2557: revset: use %d to turn an int into a bytestr

2018-03-02 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGb755eab7e677: revset: use %d to turn an int into a bytestr (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2557?vs=6367=6374

D2556: revset: use {force,}bytestr to fix some %r formatting issues

2018-03-02 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG04e50037d957: revset: use {force,}bytestr to fix some %r formatting issues (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2541: verify: fix exception formatting bug in Python 3

2018-03-02 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGd85ef895d5f6: verify: fix exception formatting bug in Python 3 (authored by durin42, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D2541?vs=6364=6370#toc REPOSITORY rHG

Re: [PATCH] get-with-headers: use bytes stdout thoroughly

2018-03-02 Thread Gregory Szorc
On Fri, Mar 2, 2018 at 2:07 PM, Yuya Nishihara wrote: > # HG changeset patch > # User Yuya Nishihara > # Date 1520016631 18000 > # Fri Mar 02 13:50:31 2018 -0500 > # Node ID b71dad3502643ade9b01166ab6657d216c46c221 > # Parent

D2541: verify: fix exception formatting bug in Python 3

2018-03-02 Thread yuja (Yuya Nishihara)
yuja accepted this revision. yuja added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > verify.py:76 > +fmsg = pycompat.byterepr(inst) > self.err(linkrev, "%s: %s" % (msg, inst), filename) > s/inst/fmsg/ and queued, thanks. REPOSITORY

D2555: py3: two more passing tests

2018-03-02 Thread durin42 (Augie Fackler)
durin42 abandoned this revision. durin42 added a comment. going to fold this someplace else REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2555 To: durin42, pulkit, #hg-reviewers Cc: mercurial-devel ___

D2548: exchange: remove dead assignment or forcebundle1

2018-03-02 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGdf7b7d5033a5: exchange: remove dead assignment or forcebundle1 (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

[PATCH] get-with-headers: use bytes stdout thoroughly

2018-03-02 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1520016631 18000 # Fri Mar 02 13:50:31 2018 -0500 # Node ID b71dad3502643ade9b01166ab6657d216c46c221 # Parent 45f149bf08d12750cc4993fd3d4e6f1bb999e8d5 get-with-headers: use bytes stdout thoroughly On Python 3,

D2282: util: extract all date-related utils in utils/dateutil module

2018-03-02 Thread durin42 (Augie Fackler)
durin42 added a comment. I'm happy to land this, but it's going to need rebased. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2282 To: lothiraldan, #hg-reviewers, durin42 Cc: durin42, dlax, martinvonz, mercurial-devel

D2282: util: extract all date-related utils in utils/dateutil module

2018-03-02 Thread martinvonz (Martin von Zweigbergk)
martinvonz added a comment. In https://phab.mercurial-scm.org/D2282#41464, @durin42 wrote: > I'm fine with this but would like someone else to ack it. Ack REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2282 To: lothiraldan, #hg-reviewers, durin42

D2282: util: extract all date-related utils in utils/dateutil module

2018-03-02 Thread durin42 (Augie Fackler)
durin42 accepted this revision as: durin42. durin42 added a comment. I'm fine with this but would like someone else to ack it. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2282 To: lothiraldan, #hg-reviewers, durin42 Cc: durin42, dlax, martinvonz,

D2557: revset: use %d to turn an int into a bytestr

2018-03-02 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2557 AFFECTED FILES mercurial/revset.py CHANGE DETAILS diff --git a/mercurial/revset.py

D2549: debugcommands: fix repr in debugignore print with pycompat.bytestr

2018-03-02 Thread durin42 (Augie Fackler)
durin42 updated this revision to Diff 6365. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2549?vs=6345=6365 REVISION DETAIL https://phab.mercurial-scm.org/D2549 AFFECTED FILES mercurial/debugcommands.py CHANGE DETAILS diff --git

D2558: tests: add missing b prefixes and fix a %s to %d in test-revset.t

2018-03-02 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY 1. skip-blame just b prefixes and a %d instead of %s REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2558 AFFECTED FILES

D2556: revset: use {force,}bytestr to fix some %r formatting issues

2018-03-02 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2556 AFFECTED FILES mercurial/revset.py CHANGE DETAILS diff --git a/mercurial/revset.py

D2541: verify: fix exception formatting bug in Python 3

2018-03-02 Thread durin42 (Augie Fackler)
durin42 updated this revision to Diff 6364. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2541?vs=6331=6364 REVISION DETAIL https://phab.mercurial-scm.org/D2541 AFFECTED FILES mercurial/verify.py CHANGE DETAILS diff --git a/mercurial/verify.py

D2546: tests: port test-bookmarks.t extension to Python 3

2018-03-02 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG4df06d2f60e1: tests: port test-bookmarks.t extension to Python 3 (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2547: purge: apply byteskwargs to opts, fixing all python3 issues here

2018-03-02 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG5a3f8da663e5: purge: apply byteskwargs to opts, fixing all python3 issues here (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2545: scmutil: fix a repr in an error message on Python 3

2018-03-02 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGbb5f5c1c3c1b: scmutil: fix a repr in an error message on Python 3 (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2554: templatekw: fix dict construction in _showlist to not mix bytes and strs

2018-03-02 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG45f149bf08d1: templatekw: fix dict construction in _showlist to not mix bytes and strs (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2551: match: some minimal pycompat fixes guided by test-hgignore.t

2018-03-02 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG9adfa48792a7: match: some minimal pycompat fixes guided by test-hgignore.t (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2553: templatefilters: avoid infinite recursion bug in stringify

2018-03-02 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG9b6b02a5b589: templatefilters: avoid infinite recursion bug in stringify (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2544: bookmarks: fix a repr in a message on Python 3

2018-03-02 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGa5eefc95: bookmarks: fix a repr in a message on Python 3 (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2543: py3: add missing b prefixes in test-debugextensions.t

2018-03-02 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG19ec5da944d5: py3: add missing b prefixes in test-debugextensions.t (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2542: tests: help dummysmtpd work on python 3

2018-03-02 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGed96d1116302: tests: help dummysmtpd work on python 3 (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2542?vs=6333=6355

D2539: tests: add missing b prefix in test python in test-issue2137.t

2018-03-02 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGc4ccc73f9d49: tests: add missing b prefix in test python in test-issue2137.t (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2538: templatefilters: convert arguments to sysstrs for unicode() ctor

2018-03-02 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG9d71bd25554b: templatefilters: convert arguments to sysstrs for unicode() ctor (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2540: tests: port helper script revlog-formatv0.py to python 3

2018-03-02 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG9805c906aaad: tests: port helper script revlog-formatv0.py to python 3 (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2549: debugcommands: fix repr in debugignore print with pycompat.bytestr

2018-03-02 Thread yuja (Yuya Nishihara)
yuja requested changes to this revision. yuja added a comment. This revision now requires changes to proceed. `pycompat.byterepr()` or `"%r\n" %` is preferred. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2549 To: durin42, #hg-reviewers, yuja Cc: yuja,

D2537: tests: make get-with-headers flush after print() calls

2018-03-02 Thread yuja (Yuya Nishihara)
yuja requested changes to this revision. yuja added a comment. This revision now requires changes to proceed. Appears that this disclosed some weird issue: --- tests/test-hgweb-commands.t +++ tests/test-hgweb-commands.t.err @@ -2116,7 +2116,10 @@ $ get-with-headers.py

  1   2   >