av6 requested changes to this revision.
av6 added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> templatefilters.py:293-294
> def person(author):
> -"""Any text. Returns the name before an email address,
> -interpreting it as per RFC 5322.
> -
Don't re
av6 added inline comments.
INLINE COMMENTS
> stringutil.py:310
> +'''
> +return bool(_correctauthorformat.match(author))
Nit: `is not None` is more pythonic.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2959
To: sheehan, #hg-reviewers
Cc: av6, mercurial
yeah, It's not working with largefiles. I am trying to solve this issue.
On Sat, Mar 24, 2018 at 8:19 AM, Yuya Nishihara wrote:
> On Sat, 24 Mar 2018 01:32:13 +0530, Sushil khanchi wrote:
> > # HG changeset patch
> > # User Sushil khanchi
> > # Date 1521655571 -19800
> > # Wed Mar 21 23:36
# HG changeset patch
# User Matt Harbison
# Date 1522117116 14400
# Mon Mar 26 22:18:36 2018 -0400
# Node ID f9c8f2bd9362baaeba828f8d6eb7559a748fcc3f
# Parent aaabd709df720e456d7f93a1c790a0dbed051b38
lfs: respect narrowmatcher when testing to add 'lfs' requirement (issue5794)
There's a simi
rdamazio updated this revision to Diff 7346.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2678?vs=7331&id=7346
REVISION DETAIL
https://phab.mercurial-scm.org/D2678
AFFECTED FILES
hgext/show.py
mercurial/configitems.py
mercurial/dispatch.py
mer
rdamazio added a comment.
Sorry about that, I had fixed this one and forgot to re-upload. Try now.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2678
To: rdamazio, #hg-reviewers, durin42, pulkit
Cc: mharbison72, spectral, pulkit, mercurial-devel
___
sheehan updated this revision to Diff 7345.
sheehan marked 5 inline comments as done.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2904?vs=7163&id=7345
REVISION DETAIL
https://phab.mercurial-scm.org/D2904
AFFECTED FILES
mercurial/templatefuncs.py
sheehan created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
The regular expression for this function formerly lived at
https://hg.mozilla.org/hgcustom/version-control-tools/file/tip/hghooks/mozhghooks/author_format.py#l13
sheehan created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Move the person function from template filters to the stringutil
module, so it can be reused in the mailmap template function.
REPOSITORY
rHG Mercurial
REVISIO
yuja added inline comments.
INLINE COMMENTS
> martinvonz wrote in state.py:84
> Oh, and I should clarify that I think the root of the problem is that you're
> mixing the class for reading with state itself (but only the top-level items
> of it). Let's say someone realizes they want to iterate o
yuja accepted this revision.
yuja added a comment.
This revision is now accepted and ready to land.
Queued, thanks. Adjusted the commit message to close " (issue3885)".
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2943
To: sangeet259, #hg-reviewers, yuja
Cc:
martinvonz added inline comments.
INLINE COMMENTS
> martinvonz wrote in state.py:84
> If it's up to me, I'd definitely say that you should change it. I don't see
> any benefits of the current proposal. I'd be happy to hear what other
> reviewers think.
Oh, and I should clarify that I think the
martinvonz added inline comments.
INLINE COMMENTS
> pulkit wrote in state.py:84
> I don't feel convinced on what can be the benefit of it and my opinion can be
> influenced by how I used it in evolve extension. But I can change it the
> other way around too, let me know if you want me to change
sangeet259 updated this revision to Diff 7342.
sangeet259 edited the summary of this revision.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2943?vs=7321&id=7342
REVISION DETAIL
https://phab.mercurial-scm.org/D2943
AFFECTED FILES
mercurial/commands.p
sangeet259 added a comment.
@yuja rebase it on which revision?
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2943
To: sangeet259, #hg-reviewers, yuja
Cc: yuja, mercurial-devel
___
Mercurial-devel mailing list
Mercuria
yuja added inline comments.
INLINE COMMENTS
> state.py:55
> +def __nonzero__(self):
> +return self.exists()
> +
Nit: this seems too clever. I wouldn't expect `if state` issues a system call.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2591
To: pulk
yuja added a comment.
Perhaps the version shouldn't be in the CBOR data structure, because future
state file might not be a superset of CBOR.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2855
To: pulkit, #hg-reviewers
Cc: yuja, mercurial-devel
__
yuja added a comment.
I think the magic has to vary depending on the current state file format.
The state file must be backward/forward compatible with the older/newer
formats.
If the current magic is `2\n` (and is parsed as `int(f.readline())`) for
example, the
CBOR preamble would h
pulkit added a comment.
In https://phab.mercurial-scm.org/D2096#43544, @indygreg wrote:
> Per discussion at sprint, Pulkit will follow up by deleting yet more code
around workspaces and scratch branches. We're going to focus on the "try
server" use case for the initial landing.
>
> W
pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This patch introduces a new config option for server
`infinitepush.pushtobundlestore` which if sets to True, the server will route
each incoming push to the bundl
pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This patch adds dirty logic to check whether we are processing `hg unbundle`
instead of an `hg incoming` to prevent the wrapping of bundle2.processparts
function.
pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Recently in core, util.py is splitted into various modules in
mercurial/utils/.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2956
pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
The extension wraps update command to client side to add functionality to pull
and checkout to a revision if it does not present locally. There is a twist to
that
pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2955
AFFECTED FILES
hgext/infinitepush/__init__.py
hgext/infinitepush/bundleparts.py
tests/test-infi
pulkit updated this revision to Diff 7334.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2108?vs=5369&id=7334
REVISION DETAIL
https://phab.mercurial-scm.org/D2108
AFFECTED FILES
hgext/infinitepush/__init__.py
tests/test-infinitepush-bundlestore.t
pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This patch drops infinitepushcommands.py and the tests which were related to
the
command `debugfillinfinitepushmetadata` introduced in the commit.
The patch a
pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This patch deletes the config option infinitepush.fillmetadatabranchpattern
which if set to true sets a background process which will save metadata in
infinitepus
yuja requested changes to this revision.
yuja added a comment.
This revision now requires changes to proceed.
> This patch keeps the matches dictionary until
> the end of this window and clears it at once when this window ends.
This is really helpful while reading the patch. Perhaps it'
On Mon, 26 Mar 2018 23:14:05 -0400, Matt Harbison wrote:
> # HG changeset patch
> # User Matt Harbison
> # Date 1522117116 14400
> # Mon Mar 26 22:18:36 2018 -0400
> # Node ID 19b73408a618666979209b9654182e6fa72364d2
> # Parent aaabd709df720e456d7f93a1c790a0dbed051b38
> lfs: respect narrowma
On Mon, 26 Mar 2018 23:14:06 -0400, Matt Harbison wrote:
> # HG changeset patch
> # User Matt Harbison
> # Date 1522119770 14400
> # Mon Mar 26 23:02:50 2018 -0400
> # Node ID 544761f9f8ee47e6b35b2b3fad0b69914e10341d
> # Parent 19b73408a618666979209b9654182e6fa72364d2
> lfs: move the 'suppor
pulkit added inline comments.
INLINE COMMENTS
> martinvonz wrote in state.py:84
> > I don't have a strong reason. I just found this an easy way.
>
> It seems the other way is still slightly easier :) You'd replace this:
>
> def __getitem__(self, key):
> return self.opts[key]
>
> de
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGd30810d09d6f: obsolete: refactor function for getting
obsolete options (authored by indygreg, committed by ).
CHANGED PRIOR TO COMMIT
https://phab.mercurial-scm.org/D2667?vs=6608&id=7333#toc
REPOSITOR
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGa1d2d0420e22: setup: install cbor packages (authored by
indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2949?vs=7322&id=7332
REVISION DE
pulkit added a comment.
:(
--- /home/foobar/repo/pushaccess/tests/test-paths.t
+++ /home/foobar/repo/pushaccess/tests/test-paths.t.err
@@ -132,10 +132,52 @@
zeroconf wraps ui.configitems(), which shouldn't crash at least:
$ hg paths --config extensions.zeroconf=
34 matches
Mail list logo