Re: [PATCH 5 of 6] lfs: add support for serving blob files

2018-03-29 Thread Matt Harbison
On Thu, 29 Mar 2018 08:35:19 -0400, Yuya Nishihara wrote: On Mon, 19 Mar 2018 00:08:28 -0400, Matt Harbison wrote: # HG changeset patch # User Matt Harbison # Date 1521266024 14400 # Sat Mar 17 01:53:44 2018 -0400 # Node ID

Re: [PATCH V2] sslutil - add tls 1.3 support - done during IETF101 Hackathon

2018-03-29 Thread Matt Harbison
On Thu, 29 Mar 2018 11:51:20 -0400, Codarren Velvindron wrote: Hello Yuya, As usual, thank you for your review. Could you elaborate on below statement please? "Can you narrow the scope of '#if tls1.3'? It requires very recent versions of Python." Best Regards,

Re: [PATCH 1 of 2] server: add an error feedback mechanism for when the daemon fails to launch

2018-03-29 Thread Matt Harbison
On Thu, 29 Mar 2018 07:26:04 -0400, Yuya Nishihara wrote: On Wed, 28 Mar 2018 22:45:30 -0400, Matt Harbison wrote: # HG changeset patch # User Matt Harbison # Date 1522210269 14400 # Wed Mar 28 00:11:09 2018 -0400 # Node ID

[PATCH V3] test-lfs-test-server: add a testcase for `hg serve`

2018-03-29 Thread Matt Harbison
# HG changeset patch # User Matt Harbison # Date 1521268666 14400 # Sat Mar 17 02:37:46 2018 -0400 # Node ID 2c5755e3d9832cba3dd46b4eb296b5733ce10dfe # Parent 0348c778bf70ae096707e2fd39fd1c79e694dfab test-lfs-test-server: add a testcase for `hg serve` I haven't

[PATCH V2] test-lfs-test-server: add a testcase for `hg serve`

2018-03-29 Thread Matt Harbison
# HG changeset patch # User Matt Harbison # Date 1521268666 14400 # Sat Mar 17 02:37:46 2018 -0400 # Node ID c55981fe1afb8e6e310bcbd0094cfd7ba571921b # Parent 0348c778bf70ae096707e2fd39fd1c79e694dfab test-lfs-test-server: add a testcase for `hg serve` I haven't

D2897: fix: new extension for automatically modifying file contents

2018-03-29 Thread hooper (Danny Hooper)
hooper updated this revision to Diff 7366. hooper marked an inline comment as done. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2897?vs=7329=7366 REVISION DETAIL https://phab.mercurial-scm.org/D2897 AFFECTED FILES hgext/fix.py

D2897: fix: new extension for automatically modifying file contents

2018-03-29 Thread hooper (Danny Hooper)
hooper added inline comments. INLINE COMMENTS > pulkit wrote in test-fix.t:813 > This should respect `experimental.evolution.allowunstable` and error out if > set to False. Maybe the comment is poorly worded. I mean that an incorrect implementation could create an orphan in this case, even

D2897: fix: new extension for automatically modifying file contents

2018-03-29 Thread hooper (Danny Hooper)
hooper added a comment. In https://phab.mercurial-scm.org/D2897#47944, @yuja wrote: > In https://phab.mercurial-scm.org/D2897#47875, @pulkit wrote: > > > The code except of minor nits looks good to me. I will like others to chime in on whether we should rename the command and

[PATCH] evolve: do not exit 1 when there are no troubled changesets (issue5823)

2018-03-29 Thread Kyle Lippincott via Mercurial-devel
# HG changeset patch # User Kyle Lippincott # Date 1522353665 25200 # Thu Mar 29 13:01:05 2018 -0700 # Node ID 1607ec1973108d156e41aa75db6fc571fa99c0ac # Parent 9ad461df4d4d1696fe15086f6afea9cebb24a617 evolve: do not exit 1 when there are no troubled changesets

D2965: push: use "repo['.']" instead of old form "repo['']"

2018-03-29 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG0348c778bf70: push: use repo[.] instead of old form repo[] (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2964: context: change default changeid from old form '' to '.'

2018-03-29 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG05c13e5aa9ec: context: change default changeid from old form to . (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2933: repository: define interface for local repositories

2018-03-29 Thread durin42 (Augie Fackler)
durin42 added inline comments. INLINE COMMENTS > repository.py:273 > + > +class completelocalrepository(zi.Interface): > +"""Monolithic interface for local repositories. I'm unclear: are all the methods supposed to be abstract, or are some of them default implementations? >

Re: D2948: wireproto: syntax for encoding CBOR into frames

2018-03-29 Thread Gregory Szorc
On Thu, Mar 29, 2018 at 9:36 AM, Josef 'Jeff' Sipek wrote: > On Wed, Mar 28, 2018 at 22:06:17 +, indygreg (Gregory Szorc) wrote: > > indygreg updated this revision to Diff 7352. > > > > REPOSITORY > > rHG Mercurial > > > > CHANGES SINCE LAST UPDATE > >

D2964: context: change default changeid from old form '' to '.'

2018-03-29 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I don't think I've seen repo[''] in the codebase at least in the last two years. REPOSITORY rHG Mercurial REVISION DETAIL

D2965: push: use "repo['.']" instead of old form "repo['']"

2018-03-29 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Note that this does not conflict with the commit message of my previous patch: I found this after writing the previous patch (besides, I very easily forget

Re: D2948: wireproto: syntax for encoding CBOR into frames

2018-03-29 Thread Josef 'Jeff' Sipek
On Wed, Mar 28, 2018 at 22:06:17 +, indygreg (Gregory Szorc) wrote: > indygreg updated this revision to Diff 7352. > > REPOSITORY > rHG Mercurial > > CHANGES SINCE LAST UPDATE > https://phab.mercurial-scm.org/D2948?vs=7327=7352 > > REVISION DETAIL >

Re: [PATCH V2] sslutil - add tls 1.3 support - done during IETF101 Hackathon

2018-03-29 Thread Codarren Velvindron
Hello Yuya, As usual, thank you for your review. Could you elaborate on below statement please? "Can you narrow the scope of '#if tls1.3'? It requires very recent versions of Python." Best Regards, Codarren On Mon, Mar 26, 2018 at 5:18 PM, Yuya Nishihara wrote: > On Mon, 26

D2904: templatefuncs: add mailmap template function

2018-03-29 Thread sheehan (Connor Sheehan)
sheehan updated this revision to Diff 7361. sheehan marked 3 inline comments as done. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2904?vs=7345=7361 REVISION DETAIL https://phab.mercurial-scm.org/D2904 AFFECTED FILES mercurial/templatefuncs.py

D2960: stringutil: move person function from templatefilters

2018-03-29 Thread sheehan (Connor Sheehan)
sheehan updated this revision to Diff 7360. sheehan marked an inline comment as done. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2960?vs=7344=7360 REVISION DETAIL https://phab.mercurial-scm.org/D2960 AFFECTED FILES mercurial/templatefilters.py

D2959: stringutil: add isauthorwellformed function

2018-03-29 Thread sheehan (Connor Sheehan)
sheehan updated this revision to Diff 7359. sheehan marked 3 inline comments as done. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2959?vs=7343=7359 REVISION DETAIL https://phab.mercurial-scm.org/D2959 AFFECTED FILES mercurial/utils/stringutil.py

D2897: fix: new extension for automatically modifying file contents

2018-03-29 Thread yuja (Yuya Nishihara)
yuja added a comment. In https://phab.mercurial-scm.org/D2897#47875, @pulkit wrote: > The code except of minor nits looks good to me. I will like others to chime in on whether we should rename the command and extension to `format` because `fix` is too generic. I agree the

Re: [PATCH 3 of 6] lfs: add basic routing for the server side wire protocol processing

2018-03-29 Thread Yuya Nishihara
On Thu, 29 Mar 2018 09:10:46 -0400, Matt Harbison wrote: > > On Mar 29, 2018, at 8:13 AM, Yuya Nishihara wrote: > >> +if op == 'upload': > >> +if req.method != 'PUT': > >> +msg = 'upload requires PUT request' > >> +raise

Re: [PATCH 3 of 6] lfs: add basic routing for the server side wire protocol processing

2018-03-29 Thread Matt Harbison
> On Mar 29, 2018, at 8:13 AM, Yuya Nishihara wrote: > >> On Mon, 19 Mar 2018 00:08:26 -0400, Matt Harbison wrote: >> # HG changeset patch >> # User Matt Harbison >> # Date 1521264181 14400 >> # Sat Mar 17 01:23:01 2018 -0400 >> # Node ID

Re: [PATCH 6 of 6] test-lfs-test-server: add a testcase for `hg serve`

2018-03-29 Thread Matt Harbison
> On Mar 29, 2018, at 8:45 AM, Yuya Nishihara wrote: > >> On Mon, 19 Mar 2018 00:08:29 -0400, Matt Harbison wrote: >> # HG changeset patch >> # User Matt Harbison >> # Date 1521268666 14400 >> # Sat Mar 17 02:37:46 2018 -0400 >> # Node ID

Re: [PATCH V4] remove: add dry-run functionality

2018-03-29 Thread Yuya Nishihara
On Thu, 29 Mar 2018 17:59:48 +0530, sushil khanchi wrote: > Shall I send a new patch which will remove opts from scmutil.addremove() ? Yes, please. (And make sure all tests pass before sending out the patch.) ___ Mercurial-devel mailing list

Re: [PATCH V5] remove: add dry-run functionality

2018-03-29 Thread Yuya Nishihara
On Thu, 29 Mar 2018 17:56:49 +0530, Sushil khanchi wrote: > # HG changeset patch > # User Sushil khanchi > # Date 1521655571 -19800 > # Wed Mar 21 23:36:11 2018 +0530 > # Node ID a041e00e5d8978decf09c6f40fd54bbaf8933f97 > # Parent

Re: [PATCH 6 of 6] test-lfs-test-server: add a testcase for `hg serve`

2018-03-29 Thread Yuya Nishihara
On Mon, 19 Mar 2018 00:08:29 -0400, Matt Harbison wrote: > # HG changeset patch > # User Matt Harbison > # Date 1521268666 14400 > # Sat Mar 17 02:37:46 2018 -0400 > # Node ID 9c23ccfd5b210bc5d214e13b2bf26535e73fef78 > # Parent

Re: [PATCH 4 of 6] lfs: add server side support for the Batch API

2018-03-29 Thread Yuya Nishihara
On Mon, 19 Mar 2018 00:08:27 -0400, Matt Harbison wrote: > # HG changeset patch > # User Matt Harbison > # Date 1521265677 14400 > # Sat Mar 17 01:47:57 2018 -0400 > # Node ID a21db2355b92a6725ec51cd853d44a511a569bb7 > # Parent

Re: [PATCH 1 of 6] lfs: add a blob verification method to the local store

2018-03-29 Thread Yuya Nishihara
On Mon, 26 Mar 2018 20:45:07 -0400, Matt Harbison wrote: > On Mon, 19 Mar 2018 00:08:24 -0400, Matt Harbison > wrote: > > > # HG changeset patch > > # User Matt Harbison > > # Date 1519360432 18000 > > # Thu Feb 22 23:33:52 2018 -0500 > > #

Re: [PATCH 5 of 6] lfs: add support for serving blob files

2018-03-29 Thread Yuya Nishihara
On Mon, 19 Mar 2018 00:08:28 -0400, Matt Harbison wrote: > # HG changeset patch > # User Matt Harbison > # Date 1521266024 14400 > # Sat Mar 17 01:53:44 2018 -0400 > # Node ID 7901a210c0c3c4a1f84fd21ff6e7c9b29454d6bc > # Parent

Re: [PATCH 3 of 6] lfs: add basic routing for the server side wire protocol processing

2018-03-29 Thread Yuya Nishihara
On Mon, 19 Mar 2018 00:08:26 -0400, Matt Harbison wrote: > # HG changeset patch > # User Matt Harbison > # Date 1521264181 14400 > # Sat Mar 17 01:23:01 2018 -0400 > # Node ID b3d23eed96ea829a4b201f6857cb3195fc308aca > # Parent

Re: [PATCH 1 of 6] lfs: add a blob verification method to the local store

2018-03-29 Thread Yuya Nishihara
On Mon, 19 Mar 2018 00:08:24 -0400, Matt Harbison wrote: > # HG changeset patch > # User Matt Harbison > # Date 1519360432 18000 > # Thu Feb 22 23:33:52 2018 -0500 > # Node ID 793636c45477f81af6fddacc458979fecc84ae3a > # Parent

[Bug 5831] New: Please consider splitting huge pushes

2018-03-29 Thread mercurial-bugs
https://bz.mercurial-scm.org/show_bug.cgi?id=5831 Bug ID: 5831 Summary: Please consider splitting huge pushes Product: Mercurial Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity:

Re: [PATCH V4] remove: add dry-run functionality

2018-03-29 Thread sushil khanchi
Shall I send a new patch which will remove opts from scmutil.addremove() ? Perhaps opts should be removed from scmutil.addremove(), but that's out > of the scope of this patch. > ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org

[PATCH V5] remove: add dry-run functionality

2018-03-29 Thread Sushil khanchi
# HG changeset patch # User Sushil khanchi # Date 1521655571 -19800 # Wed Mar 21 23:36:11 2018 +0530 # Node ID a041e00e5d8978decf09c6f40fd54bbaf8933f97 # Parent b6a4881cec1937a8d9cd2e9bbbdf5ca31cfa73dd remove: add dry-run functionality diff -r b6a4881cec19 -r

Re: [PATCH V4] remove: add dry-run functionality

2018-03-29 Thread Yuya Nishihara
On Wed, 28 Mar 2018 22:22:14 +0530, Sushil khanchi wrote: > # HG changeset patch > # User Sushil khanchi > # Date 1521655571 -19800 > # Wed Mar 21 23:36:11 2018 +0530 > # Node ID d4a3c5969df336e556463a1b0b49132dc907f536 > # Parent

Re: [PATCH 1 of 2] server: add an error feedback mechanism for when the daemon fails to launch

2018-03-29 Thread Yuya Nishihara
On Wed, 28 Mar 2018 22:45:30 -0400, Matt Harbison wrote: > # HG changeset patch > # User Matt Harbison > # Date 1522210269 14400 > # Wed Mar 28 00:11:09 2018 -0400 > # Node ID 7a6eccc3b43dd8f6090b23aa38b2f71d33f5bbdc > # Parent

Re: [PATCH 2 of 2] tests: conditionalize printed environment variable output in test-alias

2018-03-29 Thread Yuya Nishihara
On Wed, 28 Mar 2018 22:45:31 -0400, Matt Harbison wrote: > # HG changeset patch > # User Matt Harbison > # Date 1522291081 14400 > # Wed Mar 28 22:38:01 2018 -0400 > # Node ID 52a792d66f2f14dd75af06981dcfbb3678daf094 > # Parent