Re: [PATCH STABLE] test-push-http: do not clear pid file

2018-04-27 Thread Matt Harbison
On Fri, 27 Apr 2018 22:39:32 -0400, Yuya Nishihara wrote: On Fri, 27 Apr 2018 21:49:33 -0400, Matt Harbison wrote: I also wonder, given the persistent nagging address in use failure on Windows when relaunching `hg serve` in some tests, if we should just have some way of

D3432: hgweb: guard against empty Content-Length header

2018-04-27 Thread mharbison72 (Matt Harbison)
mharbison72 added a comment. LGTM. Here's the PEP reference allowing that: https://www.python.org/dev/peps/pep-/#environ-variables I'm not sure why this isn't working as expected:

Re: [PATCH STABLE] test-push-http: do not clear pid file

2018-04-27 Thread Yuya Nishihara
On Fri, 27 Apr 2018 21:49:33 -0400, Matt Harbison wrote: > I also wonder, given the persistent nagging address in use failure on > Windows when relaunching `hg serve` in some tests, if we should just have > some way of sending an exit command over the socket, so that it can > shutdown

Re: [PATCH STABLE] test-push-http: do not clear pid file

2018-04-27 Thread Matt Harbison
On Thu, 26 Apr 2018 13:27:32 -0400, Gregory Szorc wrote: On Apr 26, 2018, at 10:17, Augie Fackler wrote: On Apr 26, 2018, at 08:34, Yuya Nishihara wrote: # HG changeset patch # User Yuya Nishihara # Date

Re: [PATCH STABLE] test-push-http: do not clear pid file

2018-04-27 Thread Yuya Nishihara
On Fri, 27 Apr 2018 15:24:27 +0200, Joerg Sonnenberger wrote: > On Fri, Apr 27, 2018 at 08:11:58PM +0900, Yuya Nishihara wrote: > > FWIW, it might cause a problem on Windows to kill and start new daemon > > frequently because SO_REUSEADDR is off. > > Does Windows leave behind purely local

D3432: hgweb: guard against empty Content-Length header

2018-04-27 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Discussion in issue 5860 seems to indicate this can occur. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3432 AFFECTED FILES

[PATCH accept-scripts V2] land: fix bug we see when we merge, rather than rebase

2018-04-27 Thread Augie Fackler
# HG changeset patch # User Augie Fackler # Date 1524713796 14400 # Wed Apr 25 23:36:36 2018 -0400 # Node ID 214aea0ce91528a7b22ba34ab991c43963872d23 # Parent 66e6638d2a6e78f3af813a274eadbd90679b888e land: fix bug we see when we merge, rather than rebase I triggered this

Re: [PATCH accept-scripts] land: fix bug we see when we merge, rather than rebase

2018-04-27 Thread Augie Fackler
> On Apr 27, 2018, at 11:30, Kevin Bullock > wrote: > >> On Apr 26, 2018, at 10:59, Augie Fackler wrote: >> >> # HG changeset patch >> # User Augie Fackler >> # Date 1524713796 14400 >> # Wed Apr 25 23:36:36 2018

[Bug 5860] New: Client side wire protocol changes in 4.6rc break SCM Manager + subrepos

2018-04-27 Thread mercurial-bugs
https://bz.mercurial-scm.org/show_bug.cgi?id=5860 Bug ID: 5860 Summary: Client side wire protocol changes in 4.6rc break SCM Manager + subrepos Product: Mercurial Version: 4.6rc0 Hardware: All OS: All

Re: [PATCH STABLE] test-push-http: do not clear pid file

2018-04-27 Thread Joerg Sonnenberger
On Fri, Apr 27, 2018 at 08:11:58PM +0900, Yuya Nishihara wrote: > FWIW, it might cause a problem on Windows to kill and start new daemon > frequently because SO_REUSEADDR is off. Does Windows leave behind purely local sockets? I know that Linux has that bug. Joerg

Re: [PATCH accept-scripts] land: fix bug we see when we merge, rather than rebase

2018-04-27 Thread Kevin Bullock
> On Apr 26, 2018, at 10:59, Augie Fackler wrote: > > # HG changeset patch > # User Augie Fackler > # Date 1524713796 14400 > # Wed Apr 25 23:36:36 2018 -0400 > # Node ID c8dd55d63f9e56d62db3ff1e1b0a8fef228fd19f > # Parent

Re: [PATCH STABLE] test-push-http: do not clear pid file

2018-04-27 Thread Yuya Nishihara
On Thu, 26 Apr 2018 10:27:32 -0700, Gregory Szorc wrote: > > On Apr 26, 2018, at 10:17, Augie Fackler wrote: > >> On Apr 26, 2018, at 08:34, Yuya Nishihara wrote: > >> > >> # HG changeset patch > >> # User Yuya Nishihara > >> # Date 1524744656

[PATCH 1 of 3 evolve-ext] obshistory: use a more appropriate type for obslog entries

2018-04-27 Thread Anton Shestakov
# HG changeset patch # User Anton Shestakov # Date 1524816850 -28800 # Fri Apr 27 16:14:10 2018 +0800 # Node ID 65ddff799cfd4d8c47b246350f8df8581c0c3c78 # Parent 3f26434bdf5cfcff3cf09aba84cc6121e5ffae32 obshistory: use a more appropriate type for obslog entries cand is

[PATCH 3 of 3 evolve-ext] tests: test that `hg obslog wdir()` aborts with a useful message

2018-04-27 Thread Anton Shestakov
# HG changeset patch # User Anton Shestakov # Date 1524817714 -28800 # Fri Apr 27 16:28:34 2018 +0800 # Node ID f7eb6844f979e476e272672d50718dd589562b83 # Parent 73e62fe390ee02620c30878b333a20fa18d644b1 tests: test that `hg obslog wdir()` aborts with a useful message

[PATCH 2 of 3 evolve-ext] obshistory: make obslog work when a commit doesn't have any description

2018-04-27 Thread Anton Shestakov
# HG changeset patch # User Anton Shestakov # Date 1524817185 -28800 # Fri Apr 27 16:19:45 2018 +0800 # Node ID 73e62fe390ee02620c30878b333a20fa18d644b1 # Parent 65ddff799cfd4d8c47b246350f8df8581c0c3c78 obshistory: make obslog work when a commit doesn't have any