D4428: zsh_completion: complete shelve and unshelve

av6 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4428 AFFECTED FILES contrib/zsh_completion CHANGE DETAILS diff --git a/contrib/zsh_completion

D4427: zsh_completion: handle --rev as well as -r for diff and revert

av6 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Completion for hg diff and revert should suggest all files in context of a non-current revision. The script used to look only for `-r foo`, and now it also

D4426: zsh_completion: use revsets to exclude this rev from suggestions to hg merge

av6 created this revision. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: hg-reviewers. REVISION SUMMARY One of the most important aspects of a completion system is its speed, so 2 calls to hg is definitely better than 4. Sorting by rev (descending) is to

Re: [PATCH] lfs: add a progress bar when searching for blobs to upload

On Thu, Aug 30, 2018 at 10:14 PM Martin von Zweigbergk < martinv...@google.com> wrote: > > > On Wed, Aug 29, 2018 at 8:18 PM Matt Harbison > wrote: > >> On Fri, 24 Aug 2018 18:18:32 -0400, Matt Harbison >> >> wrote: >> >> > # HG changeset patch >> > # User Matt Harbison >> > # Date 1535147146

Re: [PATCH] lfs: add a progress bar when searching for blobs to upload

On Wed, Aug 29, 2018 at 8:18 PM Matt Harbison wrote: > On Fri, 24 Aug 2018 18:18:32 -0400, Matt Harbison > > wrote: > > > # HG changeset patch > > # User Matt Harbison > > # Date 1535147146 14400 > > # Fri Aug 24 17:45:46 2018 -0400 > > # Node ID 76eca3ae345b261c0049d16269cdf991a31af21a >

Re: [PATCH] lfs: add a progress bar when searching for blobs to upload

On Thu, 30 Aug 2018 07:41:02 -0400, Yuya Nishihara wrote: On Wed, 29 Aug 2018 23:17:45 -0400, Matt Harbison wrote: On Fri, 24 Aug 2018 18:18:32 -0400, Matt Harbison wrote: > # HG changeset patch > # User Matt Harbison > # Date 1535147146 14400 > # Fri Aug 24 17:45:46 2018 -0400 > #

Re: [PATCH] run-tests: replace '/dev/null' with os.devnull for Windows

On Thu, Aug 30, 2018 at 7:24 PM Matt Harbison wrote: > # HG changeset patch > # User Matt Harbison > # Date 1535600398 14400 > # Wed Aug 29 23:39:58 2018 -0400 > # Node ID af23d7eb2666528e52baaa0d3a2d6d4ae2061646 > # Parent 6827d3f47d4f1bab01a0cc92d7d9bfc52ee9f535 > run-tests: replace

[PATCH] run-tests: replace '/dev/null' with os.devnull for Windows

# HG changeset patch # User Matt Harbison # Date 1535600398 14400 # Wed Aug 29 23:39:58 2018 -0400 # Node ID af23d7eb2666528e52baaa0d3a2d6d4ae2061646 # Parent 6827d3f47d4f1bab01a0cc92d7d9bfc52ee9f535 run-tests: replace '/dev/null' with os.devnull for Windows Many of the *.py tests were

D4399: stringutil: teach pprint() to indent

This revision was automatically updated to reflect the committed changes. Closed by commit rHG0f549da54379: stringutil: teach pprint() to indent (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4399?vs=10600=10681

D4399: stringutil: teach pprint() to indent

martinvonz accepted this revision. martinvonz added a comment. This revision is now accepted and ready to land. > Again, I'm not crazy about the verbosity of the code and there is > room to consolidate logic for "print a collection." But this isn't > the most complicated code in the

mercurial@39350: 37 new changesets

37 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/7f5e6d3e9032 changeset: 39314:7f5e6d3e9032 user:Gregory Szorc date:Mon Aug 27 10:15:15 2018 -0700 summary: manifest: proxy to revlog instance instead of inheriting

D4362: zsh_completion: complete merge tools for -t/--tool

This revision was automatically updated to reflect the committed changes. Closed by commit rHGb4e7e1f09c09: zsh_completion: complete merge tools for -t/--tool (authored by av6, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4380: revert: fix the inconsistency of status msgs in --interactive mode

khanchi97 added a comment. Made changes. Ready to review. In https://phab.mercurial-scm.org/D4380#67537, @yuja wrote: > > $ hg revert a > > > > + undeleting a > > As you can see, there was no status message if "a" is an explicitly specified > file. Oh yes,

Re: [PATCH 09 of 10] shelve: use the internal phase when possible

> On Aug 29, 2018, at 12:30 PM, Boris Feld wrote: > > # HG changeset patch > # User Boris Feld > # Date 1527588738 -7200 > # Tue May 29 12:12:18 2018 +0200 > # Node ID ccb9572516145a1b6f11a8d199c4a7da4774898b > # Parent 5726fcca7837180c0f25ed345236625797725aa5 > # EXP-Topic

D4380: revert: fix the inconsistency of status msgs in --interactive mode

khanchi97 updated this revision to Diff 10679. khanchi97 edited the summary of this revision. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4380?vs=10578=10679 REVISION DETAIL https://phab.mercurial-scm.org/D4380 AFFECTED FILES mercurial/cmdutil.py

Re: [PATCH 5 of 5] templatekw: add {path} keyword to host documentation

On Thu, Aug 30, 2018 at 6:10 AM Yuya Nishihara wrote: > # HG changeset patch > # User Yuya Nishihara > # Date 1533454410 -32400 > # Sun Aug 05 16:33:30 2018 +0900 > # Node ID 28b0bc2ae464037066cb2c329e1f61648d9669d2 > # Parent ac97d9eb599ae018b73338cbfa2cd2062221b20d > templatekw: add

D4416: copies: improve logic of deciding copytracing on based of config options

This revision was automatically updated to reflect the committed changes. Closed by commit rHGa41497b5117c: copies: improve logic of deciding copytracing on based of config options (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4416: copies: improve logic of deciding copytracing on based of config options

yuja added a comment. Queued, thanks. > +elif boolctrace is False: > +# stringutil.parsebool() returns None when it is unable to parse the > +# value, so we should rely on making sure copytracing is on such cases Yep. Maybe we can add a helper function

Re: D4416: copies: improve logic of deciding copytracing on based of config options

Queued, thanks. > +elif boolctrace is False: > +# stringutil.parsebool() returns None when it is unable to parse the > +# value, so we should rely on making sure copytracing is on such > cases Yep. Maybe we can add a helper function that returns truthy value if copytracing

[PATCH 2 of 5] templatekw: alias {name} of file copies dict to {path}

# HG changeset patch # User Yuya Nishihara # Date 1533454029 -32400 # Sun Aug 05 16:27:09 2018 +0900 # Node ID ff16764c1db7beeb262f88302516ae97f55fa858 # Parent d40742d48fd54a0c3de03d4f4365008cd740a927 templatekw: alias {name} of file copies dict to {path} For the same reason as the

[PATCH 4 of 5] status: rename {copy} to {source} for compatibility with {file_copies} (BC)

# HG changeset patch # User Yuya Nishihara # Date 1533455485 -32400 # Sun Aug 05 16:51:25 2018 +0900 # Node ID ac97d9eb599ae018b73338cbfa2cd2062221b20d # Parent 1fd4bcc235cd6c3615a1fe398d4df23fcc60d43e status: rename {copy} to {source} for compatibility with {file_copies} (BC) .. bc::

[PATCH 5 of 5] templatekw: add {path} keyword to host documentation

# HG changeset patch # User Yuya Nishihara # Date 1533454410 -32400 # Sun Aug 05 16:33:30 2018 +0900 # Node ID 28b0bc2ae464037066cb2c329e1f61648d9669d2 # Parent ac97d9eb599ae018b73338cbfa2cd2062221b20d templatekw: add {path} keyword to host documentation It's hidden since I'm not sure if

[PATCH 3 of 5] formatter: rename {abspath}/{file} to {path}, and drop relative {path} (BC)

# HG changeset patch # User Yuya Nishihara # Date 1533455056 -32400 # Sun Aug 05 16:44:16 2018 +0900 # Node ID 1fd4bcc235cd6c3615a1fe398d4df23fcc60d43e # Parent ff16764c1db7beeb262f88302516ae97f55fa858 formatter: rename {abspath}/{file} to {path}, and drop relative {path} (BC) Note that

D4416: copies: improve logic of deciding copytracing on based of config options

pulkit updated this revision to Diff 10677. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4416?vs=10643=10677 REVISION DETAIL https://phab.mercurial-scm.org/D4416 AFFECTED FILES mercurial/copies.py CHANGE DETAILS diff --git a/mercurial/copies.py

D4384: narrow: update the narrowspecs to new ones after pulling when widening

pulkit added inline comments. INLINE COMMENTS > martinvonz wrote in narrowcommands.py:310 > This means we're now setting it twice in some cases, but that's probably > okay. We can always improve it later. Let me see if can remove the other place where we set it. REPOSITORY rHG Mercurial

D4385: tests: add flat manifest case in test-narrow-widen-non-ellipsis.t

pulkit added inline comments. INLINE COMMENTS > martinvonz wrote in test-narrow-widen-non-ellipsis.t:127 > I know that you're just copying this from other test, but I wonder why we > didn't just use `{rev}` instead of `{node|short}` so we didn't have to glob > it out. It makes more sense to

D4383: narrow: add server logic to send cg while widening without ellipsis

pulkit added inline comments. INLINE COMMENTS > martinvonz wrote in narrowbundle2.py:319 > Yeah, that does seem harder than I had hoped :( I don't see much harm in > adding the `widen` argument to the protocol, so let's just do it as you have > done it here for now. It's probably pretty easy

D4423: tests: rename test-narrow-widen-non-ellipsis to match current names

This revision was automatically updated to reflect the committed changes. Closed by commit rHG048333ef0169: tests: rename test-narrow-widen-non-ellipsis to match current names (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4420: shortest: fix an off-by-1 when disambiguating against revnums

This revision was automatically updated to reflect the committed changes. Closed by commit rHG570fca90d556: shortest: fix an off-by-1 when disambiguating against revnums (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4424: narrow: rename getbundlechangegrouppart_nonellipsis function

This revision was automatically updated to reflect the committed changes. Closed by commit rHG3433e8f39905: narrow: rename getbundlechangegrouppart_nonellipsis function (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4422: contrib: byteify perf.py file

This revision was automatically updated to reflect the committed changes. Closed by commit rHG438f3932a432: contrib: byteify perf.py file (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4422?vs=10667=10673 REVISION

D4421: tests: use {rev} instead of {node|short} and (glob) in narrow tests

This revision was automatically updated to reflect the committed changes. Closed by commit rHG5ebfb7cc6f2c: tests: use {rev} instead of {node|short} and (glob) in narrow tests (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4425: relnotes: enable extension when running releasenotes command

This revision was automatically updated to reflect the committed changes. Closed by commit rHG659e2bbd0c20: relnotes: enable extension when running releasenotes command (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

Re: [PATCH] lfs: add a progress bar when searching for blobs to upload

On Wed, 29 Aug 2018 23:17:45 -0400, Matt Harbison wrote: > On Fri, 24 Aug 2018 18:18:32 -0400, Matt Harbison > wrote: > > > # HG changeset patch > > # User Matt Harbison > > # Date 1535147146 14400 > > # Fri Aug 24 17:45:46 2018 -0400 > > # Node ID

Re: [PATCH] run-tests: conditionalize HGCATAPULTSERVERPIPE for Windows

On Wed, 29 Aug 2018 23:55:22 -0400, Matt Harbison wrote: > # HG changeset patch > # User Matt Harbison > # Date 1535600398 14400 > # Wed Aug 29 23:39:58 2018 -0400 > # Node ID cf1e74e80f0123f9a9fc4876035474d6dc525a3b > # Parent 6827d3f47d4f1bab01a0cc92d7d9bfc52ee9f535 > run-tests:

Re: [PATCH] filemerge: fix an i18n comment typo

On Wed, 29 Aug 2018 23:01:43 -0400, Matt Harbison wrote: > # HG changeset patch > # User Matt Harbison > # Date 1535597624 14400 > # Wed Aug 29 22:53:44 2018 -0400 > # Node ID 6827d3f47d4f1bab01a0cc92d7d9bfc52ee9f535 > # Parent 8ff329f68f9a1b11eb877eafc4a539dce7096199 > filemerge: fix an

D4425: relnotes: enable extension when running releasenotes command

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Last night, when I was working on different machine, the test worked, now on a different machine it does not. Looks like we should make sure releasenotes

D4423: tests: rename test-narrow-widen-non-ellipsis to match current names

pulkit created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The test is renamed to test-narrow-widen-no-ellipsis (note non -> no), to match with test-narrow-clone-no-ellipsis.t.

D4424: narrow: rename getbundlechangegrouppart_nonellipsis function

pulkit created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The function is renamed to getbundlechangegrouppart_widen as per suggestion in https://phab.mercurial-scm.org/D4383. The

D4422: contrib: byteify perf.py file

pulkit created this revision. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is done using contrib/byteify-strings.py. There is just one extra change done to make sure lines don't get longer than 80 chars. 1. skip-blame