[PATCH 2 of 4] lfs: use a context manager to control the progress bar lifetime

# HG changeset patch # User Matt Harbison # Date 1535215318 14400 # Sat Aug 25 12:41:58 2018 -0400 # Node ID f01ec535806db02e65db9845d80914de7663a1bd # Parent bcd44b97559a0150b988f812ffc28be1f7f9d452 lfs: use a context manager to control the progress bar lifetime diff --git a/hgext/lfs/blob

[PATCH 3 of 4] largefiles: use a context manager to control the progress bar lifetime

# HG changeset patch # User Matt Harbison # Date 1535216964 14400 # Sat Aug 25 13:09:24 2018 -0400 # Node ID 9a5c52a1933072c6d88ba33d64ccc14f24472115 # Parent f01ec535806db02e65db9845d80914de7663a1bd largefiles: use a context manager to control the progress bar lifetime diff --git a/hgext/l

[PATCH 4 of 4] tests: conditionalize narrow-widen error output for Windows

# HG changeset patch # User Matt Harbison # Date 1535781715 14400 # Sat Sep 01 02:01:55 2018 -0400 # Node ID 4542da498ea27f2f9d75b84b3fbf3fd7727da601 # Parent 9a5c52a1933072c6d88ba33d64ccc14f24472115 tests: conditionalize narrow-widen error output for Windows diff --git a/tests/test-narrow-

[PATCH 1 of 4] hg: ensure the progress bar is completed when copying the store

# HG changeset patch # User Matt Harbison # Date 1535214404 14400 # Sat Aug 25 12:26:44 2018 -0400 # Node ID bcd44b97559a0150b988f812ffc28be1f7f9d452 # Parent a7e22dd31f540916e79fbf23ff9f1c5baf380c53 hg: ensure the progress bar is completed when copying the store This is just a block indent

Re: Wire protocol futures

I don't know much about the wire protocol, so this is mostly for my understanding... On Fri, 31 Aug 2018 18:47:34 -0400, Gregory Szorc wrote: Another problem that seemingly becomes simpler is large file storage. I argue that largefiles and LFS today is effectively a hack to facilitate non

Re: [PATCH] lfs: add a progress bar when searching for blobs to upload

On Fri, 31 Aug 2018 02:23:47 -0400, Martin von Zweigbergk wrote: On Thu, Aug 30, 2018 at 11:16 PM Martin von Zweigbergk < martinv...@google.com> wrote: On Thu, Aug 30, 2018 at 11:02 PM Matt Harbison wrote: On Aug 31, 2018, at 1:19 AM, Martin von Zweigbergk wrote: On Thu, Aug 30

Re: [PATCH STABLE] hgweb: load revcount + 1 entries to fill nextentry in log page (issue5972)

On Fri, 31 Aug 2018 21:52:08 +0900 Yuya Nishihara wrote: > # HG changeset patch > # User Yuya Nishihara > # Date 1535719464 -32400 > # Fri Aug 31 21:44:24 2018 +0900 > # Branch stable > # Node ID ede3bf31fe63677fdf5bd8db687977d4e3d792ed > # Parent d750a6c9248d9dd97de089f7d7e8da7dd99a0ebf >

[PATCH 2 of 4] test-check-py3-compat: exclude thirdparty and cffi which are known to fail

# HG changeset patch # User Yuya Nishihara # Date 1535764428 -32400 # Sat Sep 01 10:13:48 2018 +0900 # Node ID 1f867d70459c469dcd78e214b6cda41e2f2873e7 # Parent 875e635c201c1d1cf1c3f8d511ed32b791e8c419 test-check-py3-compat: exclude thirdparty and cffi which are known to fail Otherwise the

[PATCH 1 of 4] test-check-py3-compat: remove false output from "python3 check-py3-compat.py"

# HG changeset patch # User Yuya Nishihara # Date 1535764718 -32400 # Sat Sep 01 10:18:38 2018 +0900 # Node ID 875e635c201c1d1cf1c3f8d511ed32b791e8c419 # Parent a7e22dd31f540916e79fbf23ff9f1c5baf380c53 test-check-py3-compat: remove false output from "python3 check-py3-compat.py" If python3

[PATCH 4 of 4] fastannotate: use stringutil.pprint() to dump diffopts to be hashed

# HG changeset patch # User Yuya Nishihara # Date 1535766048 -32400 # Sat Sep 01 10:40:48 2018 +0900 # Node ID f6485547bb05391915fdf520836d3dd65367f161 # Parent 570df3c1e1e7bb7592cd61b6bb41f961afdb59ba fastannotate: use stringutil.pprint() to dump diffopts to be hashed diff --git a/hgext/fa

[PATCH 3 of 4] test-check-py3-compat: update "python3 check-py3-compat.py" output

# HG changeset patch # User Yuya Nishihara # Date 1535764993 -32400 # Sat Sep 01 10:23:13 2018 +0900 # Node ID 570df3c1e1e7bb7592cd61b6bb41f961afdb59ba # Parent 1f867d70459c469dcd78e214b6cda41e2f2873e7 test-check-py3-compat: update "python3 check-py3-compat.py" output diff --git a/tests/tes

D4426: zsh_completion: use revsets to exclude this rev from suggestions to hg merge

av6 added a comment. It probably would make sense, but you don't need to exclude current branch, because `hg merge mybranch` works when you have more than one branch head (except when you stand on the newest head, unfortunately: "abort: merging with a working directory ancestor has no effect

D4428: zsh_completion: complete shelve and unshelve

av6 added inline comments. INLINE COMMENTS > spectral wrote in zsh_completion:1272 > Mine has a --cleanup flag. Not sure where that came from, and I think it's > dangerous as heck and I don't like it, but ... should we list it? (I'm 100% > fine with the answer being "no, it's too scary" :))

D4430: tests: update test-casefolding.t with recent changes

This revision was automatically updated to reflect the committed changes. Closed by commit rHGf5e9d074d70a: tests: update test-casefolding.t with recent changes (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4430?vs=106

D4431: py3: don't use dict.iterkeys() in hgext/fastannotate/context.py

This revision was automatically updated to reflect the committed changes. Closed by commit rHG1099d9bbdf9a: py3: don't use dict.iterkeys() in hgext/fastannotate/context.py (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D

Re: [PATCH] test: add a test file that displays ssh behavior in front of various errors

On Fri, 31 Aug 2018 16:35:10 +0200, Boris Feld wrote: > # HG changeset patch > # User Boris Feld > # Date 1533106375 -7200 > # Wed Aug 01 08:52:55 2018 +0200 > # Node ID 6af5b6f05e931fbab5baec1bef2a78d1e86acb90 > # Parent 6f38284b23f426b55d9375919f63ab4bd0fa81c0 > # EXP-Topic ssh-error > # A

Re: D4432: py3: do .decode(), .encode() dance in runtests.py

> def toggletrace(cmd): > -quoted = shellquote(cmd.strip()).replace(b'\\', b'') > +cmd = cmd.decode('ascii') > +quoted = shellquote(cmd.strip()).encode('ascii') > +quoted = quoted.replace(b'\\', b'') Perhaps _bytespath/_strpath can b

D4432: py3: do .decode(), .encode() dance in runtests.py

yuja added a comment. > def toggletrace(cmd): > > - quoted = shellquote(cmd.strip()).replace(b'\\', b'') +cmd = cmd.decode('ascii') +quoted = shellquote(cmd.strip()).encode('ascii') +quoted = quoted.replace(b'\\', b'') Perhaps _bytespat

D4443: internals: extract frame-based protocol docs to own document

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY wireprotocol.txt is quite long and difficult to digest. The frame-based protocol is effectively a standalone concept (and could even be used outside of Mercuria

D4438: httppeer: add TODO about delayed handling of ^C

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY When testing wire protocol v2 with large responses, I noticed that ^C doesn't result in immediate termination. I'm not sure what the root cause is. Let's add a

D4434: cborutil: add a buffering decoder

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The sansiodecoder leaves it up to the callers to feed in data that wasn't fully consumed last time. This commit implements a decoder that performs buffering

D4440: wireprotov2peer: report exceptions in frame handling against request future

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Otherwise the future may never resolve, which could cause deadlock. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4440 AFFECTED FI

D4436: httppeer: expose capabilities for each command

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This will help code using peers to sniff out exactly what servers support. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4436 AF

D4442: internals: extract wire protocol version 2 commands to standalone doc

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY wireprotocol.txt is a bit long and unwieldy. I think splitting it up will help aid comprehension. Let's start by extracting wire protocol version 2 commands

D4435: wireprotov2peer: add TODO about streaming responses

indygreg created this revision. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is a pretty big deficiency in the current implementation. We don't want to forget about this. REPOSITORY rHG Mercurial REVISION DETAIL https:

D4439: wireprotov2peer: split responsedata handling into separate function

indygreg created this revision. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: hg-reviewers. REVISION SUMMARY So we don't have so much logic inside an if/elif block. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4439 AFFECTED FILE

D4441: wireprotov2peer: properly format errors

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY formatrichmessage() expects an iterable containing dicts with well-defined keys. We were passing in something else. This caused an exception. Change the co

D4437: httppeer: log commands for version 2 peer

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This will aid testing and debugging. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4437 AFFECTED FILES mercurial/httppeer.py CH

D4433: cborutil: remove readindefinitebytestringtoiter()

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This was implemented as part of implementing streaming encoding. It was never used outside of tests. Now that we have a full CBOR decoder, it can be used for

Wire protocol futures

This is a long post and I apologize in advance for that. I've been spending a lot of company-sponsored time on the wire protocol and storage this year in order to get partial clones in a place where Mozilla can start using them heavily. I realized that I haven't done a good job articulating the ove

D4428: zsh_completion: complete shelve and unshelve

spectral added a comment. (Not marking accepted, though I'm fine with it going in as is, so that we get a chance to answer the questions before it lands) INLINE COMMENTS > zsh_completion:1272 > + > + _arguments -s -S : $_hg_global_opts $_hg_pat_opts \ > + '(--addremove -A)'{-A,--addremove}

D4426: zsh_completion: use revsets to exclude this rev from suggestions to hg merge

spectral added a comment. Would it make sense to combine this into one hg invocation? I think it wouldn't be that hard (hmm, not as trivial as I thought, but.. not the worst thing ever? :)) allheads=(${(f)"$(_hg_cmd log -r 'sort(head(), -rev)' --template '{ifcontains(rev, revset(\".\

D4432: py3: do .decode(), .encode() dance in runtests.py

pulkit updated this revision to Diff 10689. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4432?vs=10688&id=10689 REVISION DETAIL https://phab.mercurial-scm.org/D4432 AFFECTED FILES tests/run-tests.py CHANGE DETAILS diff --git a/tests/run-tests.py b

D4432: py3: do .decode(), .encode() dance in runtests.py

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY shlex.quote() is not happy to work on bytes in Python 3. Let's feed that with unicodes. This should make the py3 buildbot green. REPOSITORY rHG Mercurial R

D4431: py3: don't use dict.iterkeys() in hgext/fastannotate/context.py

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY dict.iterkeys() is not present on Python 3. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4431 AFFECTED FILES hgext/fastannotate/c

D4430: tests: update test-casefolding.t with recent changes

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is caught by the mac-buildbot. This was not found initially because this test requires a case insensitive filesystem. I have edited the test file by hand

D4429: narrow: demonstrate that widening is still broken

pulkit added a comment. I am not sure whether this is a bug or not. If this is a bug, this patch is not review and just for discussion purpose. Sorry if abused phabricator for sharing patches. If this is not a bug, I will like to get this pushed with some comments added on why this is the ri

D4429: narrow: demonstrate that widening is still broken

pulkit created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4429 AFFECTED FILES tests/test-narrow-widen.t CHANGE DETAILS diff --

[PATCH] test: add a test file that displays ssh behavior in front of various errors

# HG changeset patch # User Boris Feld # Date 1533106375 -7200 # Wed Aug 01 08:52:55 2018 +0200 # Node ID 6af5b6f05e931fbab5baec1bef2a78d1e86acb90 # Parent 6f38284b23f426b55d9375919f63ab4bd0fa81c0 # EXP-Topic ssh-error # Available At https://bitbucket.org/octobus/mercurial-devel/ #

[Bug 5976] New: Multiple performance regression on perfchangegroupchangelog in 4.7

https://bz.mercurial-scm.org/show_bug.cgi?id=5976 Bug ID: 5976 Summary: Multiple performance regression on perfchangegroupchangelog in 4.7 Product: Mercurial Version: default branch Hardware: PC OS: Linux

[Bug 5975] New: Performance regression on unbundle in 4.7

https://bz.mercurial-scm.org/show_bug.cgi?id=5975 Bug ID: 5975 Summary: Performance regression on unbundle in 4.7 Product: Mercurial Version: default branch Hardware: PC OS: Linux Status: UNCONFIRMED Sever

mercurial@39376: 26 new changesets

26 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/4cfd1eebe6aa changeset: 39351:4cfd1eebe6aa user:Augie Fackler date:Wed Jul 25 13:45:28 2018 -0400 summary: hghave: move from requiring the PYTHON3 env var to looking for `python3` https://www.mercuri

[PATCH STABLE] hgweb: load revcount + 1 entries to fill nextentry in log page (issue5972)

# HG changeset patch # User Yuya Nishihara # Date 1535719464 -32400 # Fri Aug 31 21:44:24 2018 +0900 # Branch stable # Node ID ede3bf31fe63677fdf5bd8db687977d4e3d792ed # Parent d750a6c9248d9dd97de089f7d7e8da7dd99a0ebf hgweb: load revcount + 1 entries to fill nextentry in log page (issue5972)

[PATCH] shelve: fix crash on unshelve without .shelve metadata file

# HG changeset patch # User Yuya Nishihara # Date 1535717428 -32400 # Fri Aug 31 21:10:28 2018 +0900 # Node ID 1eae14fe0f9b3ed85929b6ce806c6d5a6a355117 # Parent b64d36e5ca31cc25e159f0fc3e710dbf46b89546 shelve: fix crash on unshelve without .shelve metadata file Follow up for c67c94c0e7ae an

Re: D4380: revert: fix the inconsistency of status msgs in --interactive mode

> @@ -3034,7 +3035,19 @@ > prefetch(repo, [ctx.rev()], > matchfiles(repo, > [f for sublist in oplist for f in sublist])) > -_performrevert(repo, parents, ctx, actions, interactive, > tobackup) > +# give sta

Re: D4380: revert: fix the inconsistency of status msgs in --interactive mode

> > +if ui.verbose or not exact: > > +if not isinstance(msg, bytes): > > +msg = msg(abs) > > Does this conditional doing something useful because I don't see any change > in the tests if I remove line 3023,3024?

D4380: revert: fix the inconsistency of status msgs in --interactive mode

yuja added a comment. >> +if ui.verbose or not exact: > > +if not isinstance(msg, bytes): > > +msg = msg(abs) > > Does this conditional doing something useful because I don't see any change in the te

D4380: revert: fix the inconsistency of status msgs in --interactive mode

yuja added a comment. > @@ -3034,7 +3035,19 @@ > > prefetch(repo, [ctx.rev()], >matchfiles(repo, > [f for sublist in oplist for f in sublist])) > > - _performrevert(repo, parents, ctx, actions, interactive, tobackup) + # give status

Re: [PATCH] lfs: add a progress bar when searching for blobs to upload

On Fri, 31 Aug 2018 00:49:09 -0400, Matt Harbison wrote: > On Thu, 30 Aug 2018 07:41:02 -0400, Yuya Nishihara wrote: > > > On Wed, 29 Aug 2018 23:17:45 -0400, Matt Harbison wrote: > >> On Fri, 24 Aug 2018 18:18:32 -0400, Matt Harbison > >> > >> wrote: > >> > >> > # HG changeset patch > >> > #