[PATCH] tests: stabilize change for handling not quoting non-empty-directory

2018-09-12 Thread Matt Harbison
# HG changeset patch # User Matt Harbison # Date 1536808259 14400 # Wed Sep 12 23:10:59 2018 -0400 # Node ID c8514f858788ffebee5f5e01a24d20e00e9d68a8 # Parent 5e78c100a21586dfdc622a86537c0a0231652e1d tests: stabilize change for handling not quoting non-empty-directory The change originated

D4557: hg: don't reuse repo instance after unshare()

2018-09-12 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Unsharing a repository is a pretty invasive procedure and fundamentally changes the behavior of the repository. Currently, hg.unshare() calls into

D4555: bundlerepo: dynamically create repository type from base repository

2018-09-12 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Previously, bundlerepository inherited from localrepo.localrepository. You simply instantiated a bundlerepository and its __init__ called

D4556: unionrepo: dynamically create repository type from base repository

2018-09-12 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is basically the same thing we just did for bundlerepo except for union repositories. .. api:: ``unionrepo.unionrepository()`` is no longer

D4554: bundlerepo: factor out code for instantiating a bundle repository

2018-09-12 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This code will soon become a bit more complicated. So extract to its own function. And change both instantiators of bundlerepository to use it. REPOSITORY

D4553: bundlerepo: pass create=True

2018-09-12 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I don't want to know how this came to be. Maybe a holdover from the days before Python had a bool type? REPOSITORY rHG Mercurial REVISION DETAIL

D4552: shelve: use bundlerepo.instance() to construct a repo object

2018-09-12 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The instance() functions are preferred over cls.__init__ for creating repo instances. It doesn't really matter now. But future commits will refactor the

D4346: hg: wrap the highest layer in the `hg` script possible in trace event

2018-09-12 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG5e78c100a215: hg: wrap the highest layer in the `hg` script possible in trace event (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4549: localrepo: move check for existing repo into createrepository()

2018-09-12 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGe471cb2852ea: localrepo: move check for existing repo into createrepository() (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4550: localrepo: use urllocalpath() for path to create repo too

2018-09-12 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG76b58f240821: localrepo: use urllocalpath() for path to create repo too (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2883: revlogstore: create and implement an interface for repo files storage

2018-09-12 Thread indygreg (Gregory Szorc)
indygreg abandoned this revision. indygreg added a comment. I'm not actively working on this. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2883 To: indygreg, #hg-reviewers Cc: mharbison72, mercurial-devel ___

Re: [PATCH] py3: add b'' to some run-tests.py strings for Windows

2018-09-12 Thread Gregory Szorc
On Wed, Sep 12, 2018 at 6:36 PM Matt Harbison wrote: > # HG changeset patch > # User Matt Harbison > # Date 1536802328 14400 > # Wed Sep 12 21:32:08 2018 -0400 > # Node ID dfb052baace5510876f56e67f49b082273ebb858 > # Parent 2105ed5ef206052a5ff093fba8cbd44bef470f20 > py3: add b'' to some

[PATCH] py3: add b'' to some run-tests.py strings for Windows

2018-09-12 Thread Matt Harbison
# HG changeset patch # User Matt Harbison # Date 1536802328 14400 # Wed Sep 12 21:32:08 2018 -0400 # Node ID dfb052baace5510876f56e67f49b082273ebb858 # Parent 2105ed5ef206052a5ff093fba8cbd44bef470f20 py3: add b'' to some run-tests.py strings for Windows Things go seriously off the rails

D4551: wireprotov1peer: forward __name__ of wrapped method in batchable decorator

2018-09-12 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGf15a587d2dfc: wireprotov1peer: forward __name__ of wrapped method in batchable decorator (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4546: tests: handle Python 3 not quoting non-empty-directory error

2018-09-12 Thread mharbison72 (Matt Harbison)
mharbison72 added a comment. This motivated me to install py3, and give it a try. But the test runner keeps crashing on str/bytes issues. I fixed a couple, but it looks like treating everything as bytes can be a problem, since environment stuff internally wants to uppercase, which wants a

D4551: wireprotov1peer: forward __name__ of wrapped method in batchable decorator

2018-09-12 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Not required, but clarifies debugging when the going gets really tough. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4551

D4550: localrepo: use urllocalpath() for path to create repo too

2018-09-12 Thread martinvonz (Martin von Zweigbergk)
martinvonz updated this revision to Diff 10978. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4550?vs=10974=10978 REVISION DETAIL https://phab.mercurial-scm.org/D4550 AFFECTED FILES mercurial/localrepo.py CHANGE DETAILS diff --git

D4549: localrepo: move check for existing repo into createrepository()

2018-09-12 Thread martinvonz (Martin von Zweigbergk)
martinvonz updated this revision to Diff 10977. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4549?vs=10973=10977 REVISION DETAIL https://phab.mercurial-scm.org/D4549 AFFECTED FILES mercurial/localrepo.py CHANGE DETAILS diff --git

D4548: localrepo: fix a mixmatched arg name in createrepository() docstring

2018-09-12 Thread martinvonz (Martin von Zweigbergk)
martinvonz updated this revision to Diff 10976. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4548?vs=10975=10976 REVISION DETAIL https://phab.mercurial-scm.org/D4548 AFFECTED FILES mercurial/localrepo.py CHANGE DETAILS diff --git

D4436: httppeer: expose capabilities for each command

2018-09-12 Thread durin42 (Augie Fackler)
durin42 added a comment. Hmm. I'm still uneasy about this. Maybe we could make it a dev-mode thing and not be something we depend on long term? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4436 To: indygreg, #hg-reviewers Cc: durin42, mercurial-devel

Re: [PATCH] ancestor: remove extra generator from lazyancestors.__iter__()

2018-09-12 Thread Augie Fackler
> On Sep 10, 2018, at 09:15, Yuya Nishihara wrote: > > # HG changeset patch > # User Yuya Nishihara mailto:y...@tcha.org>> > # Date 1536580638 -32400 > # Mon Sep 10 20:57:18 2018 +0900 > # Node ID 4eee6e03686df30cacc8d78f9bd37d4628e478d6 > # Parent

Re: [PATCH] tests: stabilize test-no-symlink

2018-09-12 Thread Augie Fackler
already pushed as 0612e4c6fda0 > On Sep 10, 2018, at 21:16, Matt Harbison wrote: > > # HG changeset patch > # User Matt Harbison > # Date 1536628554 14400 > # Mon Sep 10 21:15:54 2018 -0400 > # Node ID 9f87aa9f809f353d699a2de0d8440386cd007303 > # Parent

D4549: localrepo: move check for existing repo into createrepository()

2018-09-12 Thread martinvonz (Martin von Zweigbergk)
martinvonz added a comment. In https://phab.mercurial-scm.org/D4549#69559, @pulkit wrote: > test-init.t and test-mq.t says hi! Sorry! :( Looks like I forgot to drop the `.hg` argument when I switched from wdirvfs to hgvfs. I'll fix right away. REPOSITORY rHG Mercurial

D4548: localrepo: fix a mixmatched arg name in createrepository() docstring

2018-09-12 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGa64a965b3610: localrepo: fix a mixmatched arg name in createrepository() docstring (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4549: localrepo: move check for existing repo into createrepository()

2018-09-12 Thread pulkit (Pulkit Goyal)
pulkit added a comment. test-init.t and test-mq.t says hi! --- /storage/pulkit/repo/hgpush/tests/test-init.t +++ /storage/pulkit/repo/hgpush/tests/test-init.t.err @@ -99,7 +99,7 @@ test failure $ hg init local - abort: repository local already exists!

D4550: localrepo: use urllocalpath() for path to create repo too

2018-09-12 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY It looks like this was lost in https://phab.mercurial-scm.org/rHG7ce9dea3a14a9142dadb2083f34a22834f5e9b70 (localrepo: move repo creation logic out of

D4549: localrepo: move check for existing repo into createrepository()

2018-09-12 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY For symmetry with the check for existence of a repo in localrepository.__init__, we should check for the non-existence in createrepository(). We could

D4548: localrepo: fix a mixmatches arg name in createrepository() docstring

2018-09-12 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4548 AFFECTED FILES mercurial/localrepo.py CHANGE DETAILS diff --git a/mercurial/localrepo.py

mercurial@39557: 10 new changesets

2018-09-12 Thread Mercurial Commits
10 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/7ce9dea3a14a changeset: 39548:7ce9dea3a14a parent: 39546:41aa5dced975 user:Gregory Szorc date:Tue Sep 11 13:46:59 2018 -0700 summary: localrepo: move repo creation logic out of

D4492: wireprotov2: let clients drive delta behavior

2018-09-12 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 10971. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4492?vs=10805=10971 REVISION DETAIL https://phab.mercurial-scm.org/D4492 AFFECTED FILES mercurial/exchangev2.py mercurial/help/internals/wireprotocolv2.txt

D4490: wireprotov2: define and implement "filedata" command

2018-09-12 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 10969. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4490?vs=10803=10969 REVISION DETAIL https://phab.mercurial-scm.org/D4490 AFFECTED FILES mercurial/help/internals/wireprotocolv2.txt

D4488: wireprotov2: define and implement "manifestdata" command

2018-09-12 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 10967. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4488?vs=10801=10967 REVISION DETAIL https://phab.mercurial-scm.org/D4488 AFFECTED FILES mercurial/help/internals/wireprotocolv2.txt

D4481: wireprotov2: define and implement "changesetdata" command

2018-09-12 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 10962. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4481?vs=10794=10962 REVISION DETAIL https://phab.mercurial-scm.org/D4481 AFFECTED FILES mercurial/exchange.py mercurial/help/internals/wireprotocolv2.txt

D4491: exchangev2: fetch file revisions

2018-09-12 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 10970. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4491?vs=10804=10970 REVISION DETAIL https://phab.mercurial-scm.org/D4491 AFFECTED FILES mercurial/exchangev2.py tests/test-wireproto-exchangev2.t CHANGE

D4489: exchangev2: fetch manifest revisions

2018-09-12 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 10968. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4489?vs=10802=10968 REVISION DETAIL https://phab.mercurial-scm.org/D4489 AFFECTED FILES mercurial/exchangev2.py tests/test-wireproto-exchangev2.t CHANGE

D4480: exchangev2: start to implement pull with wire protocol v2

2018-09-12 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 10961. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4480?vs=10793=10961 REVISION DETAIL https://phab.mercurial-scm.org/D4480 AFFECTED FILES mercurial/exchange.py mercurial/exchangev2.py

D4485: wireprotov2: add bookmarks to "changesetdata" command

2018-09-12 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 10965. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4485?vs=10798=10965 REVISION DETAIL https://phab.mercurial-scm.org/D4485 AFFECTED FILES mercurial/help/internals/wireprotocolv2.txt

D4486: exchangev2: fetch and apply bookmarks

2018-09-12 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 10966. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4486?vs=10799=10966 REVISION DETAIL https://phab.mercurial-scm.org/D4486 AFFECTED FILES mercurial/exchangev2.py tests/test-wireproto-exchangev2.t CHANGE

D4483: wireprotov2: add phases to "changesetdata" command

2018-09-12 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 10963. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4483?vs=10796=10963 REVISION DETAIL https://phab.mercurial-scm.org/D4483 AFFECTED FILES mercurial/help/internals/wireprotocolv2.txt

D4484: exchangev2: fetch and apply phases data

2018-09-12 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 10964. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4484?vs=10797=10964 REVISION DETAIL https://phab.mercurial-scm.org/D4484 AFFECTED FILES mercurial/exchangev2.py tests/test-wireproto-exchangev2.t CHANGE

D4436: httppeer: expose capabilities for each command

2018-09-12 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 10960. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4436?vs=10761=10960 REVISION DETAIL https://phab.mercurial-scm.org/D4436 AFFECTED FILES mercurial/httppeer.py CHANGE DETAILS diff --git

D4490: wireprotov2: define and implement "filedata" command

2018-09-12 Thread indygreg (Gregory Szorc)
indygreg added a comment. In https://phab.mercurial-scm.org/D4490#69457, @durin42 wrote: > Oh, one more thing: I think this, as-stated, will make it at best challenging to have ACLed branches: we'd have to, on the server, walk the linknodes and see if the client was authorized to see

D4488: wireprotov2: define and implement "manifestdata" command

2018-09-12 Thread indygreg (Gregory Szorc)
indygreg added a comment. In https://phab.mercurial-scm.org/D4488#69449, @durin42 wrote: > Could you add a TODO about the overhead of having to enumerate every node required? That'll be prohibitive fairly quickly I think. There are already TODOs in wireprotocolv2.txt. And,

D4480: exchangev2: start to implement pull with wire protocol v2

2018-09-12 Thread indygreg (Gregory Szorc)
indygreg planned changes to this revision. indygreg added inline comments. INLINE COMMENTS > durin42 wrote in exchange.py:1490 > What's the deal with this function-level import? It doesn't appear to be > avoiding a cycle... At one time the series introduced a cycle. But the current series

D4436: httppeer: expose capabilities for each command

2018-09-12 Thread indygreg (Gregory Szorc)
indygreg added a comment. In https://phab.mercurial-scm.org/D4436#69390, @durin42 wrote: > Hm, I worry this isn't explicit enough. Do you have a specific reason for why this is a thing we should do? Honestly, I did this to make the subsequent patches easier. The way I'm going

D4545: error: ensure ProgrammingError message is always a str

2018-09-12 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG921aeb9ac508: error: ensure ProgrammingError message is always a str (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4545: error: ensure ProgrammingError message is always a str

2018-09-12 Thread durin42 (Augie Fackler)
durin42 updated this revision to Diff 10958. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4545?vs=10953=10958 REVISION DETAIL https://phab.mercurial-scm.org/D4545 AFFECTED FILES mercurial/error.py CHANGE DETAILS diff --git a/mercurial/error.py

mercurial@39547: 15 new changesets (1 on stable)

2018-09-12 Thread Mercurial Commits
15 new changesets (1 on stable) in mercurial: https://www.mercurial-scm.org/repo/hg/rev/f6bcb4f9cd3c changeset: 39533:f6bcb4f9cd3c user:Yuya Nishihara date:Tue Sep 11 22:38:32 2018 +0900 summary: ancestor: remove alias of initrevs from _lazyancestorsiter()

D4546: tests: handle Python 3 not quoting non-empty-directory error

2018-09-12 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGcb1329738d64: tests: handle Python 3 not quoting non-empty-directory error (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4547: py3: whitelist a test caught by the ratchet

2018-09-12 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGb781709799f6: py3: whitelist a test caught by the ratchet (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4546: tests: handle Python 3 not quoting non-empty-directory error

2018-09-12 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I assume this happens on Windows too, so I did the same regex on both versions of the output. The whole message printed by these aborts comes from Python, so if

D4547: py3: whitelist a test caught by the ratchet

2018-09-12 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a reviewer: pulkit. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4547 AFFECTED FILES contrib/python3-whitelist CHANGE DETAILS diff

D4543: context: don't count deleted files as candidates for path conflicts in IMM

2018-09-12 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGfa4d16daf1be: context: dont count deleted files as candidates for path conflicts in IMM (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4545: error: ensure ProgrammingError message is always a str

2018-09-12 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Since this error is internal-only and a runtime error, let's give it a treatment that makes it behave identically when repr()d on both Python 2 and Python 3.

D4544: rebase: add tests showing patch conflict detection needs to be smarter in IMM

2018-09-12 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGaa022f8873ea: rebase: add tests showing patch conflict detection needs to be smarter in IMM (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

reaping old phabricator patches?

2018-09-12 Thread Augie Fackler
Howdy folks, We've got a fair stack of dead-ish patches in phabricator. Would anyone object to automatically marking everything that hasn't been touched since, say, the end of March as abandoned for now? Thanks, Augie ___ Mercurial-devel mailing list

D4490: wireprotov2: define and implement "filedata" command

2018-09-12 Thread durin42 (Augie Fackler)
durin42 added a comment. Oh, one more thing: I think this, as-stated, will make it at best challenging to have ACLed branches: we'd have to, on the server, walk the linknodes and see if the client was authorized to see any branch(es) that contain the node. That's probably okayer for us

D4490: wireprotov2: define and implement "filedata" command

2018-09-12 Thread durin42 (Augie Fackler)
durin42 accepted this revision. durin42 added a comment. This revision is now accepted and ready to land. In general I'm happy with where this is going, but I'm extremely uncomfortable with the manifest and filelog commands requiring so much client-server transfer to get everything,

D4488: wireprotov2: define and implement "manifestdata" command

2018-09-12 Thread durin42 (Augie Fackler)
durin42 added a comment. Could you add a TODO about the overhead of having to enumerate every node required? That'll be prohibitive fairly quickly I think. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4488 To: indygreg, #hg-reviewers Cc: durin42,

D4543: context: don't count deleted files as candidates for path conflicts in IMM

2018-09-12 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This patch makes sure we don't consider the deleted files in our IMM wctx as potential conflicts while calculating paths conflicts. This fixes the bug

D4544: rebase: add tests showing patch conflict detection needs to be smarter in IMM

2018-09-12 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This patch adds test which shows that you can't rebase a cset which removes a dir and adds a file of the same as that of dir as there are False positives path

D4519: zsh_completion: add new and remove deprecated flags

2018-09-12 Thread av6 (Anton Shestakov)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGa2d17b699628: zsh_completion: add new and remove deprecated flags (authored by av6, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4518: zsh_completion: update various arguments, descriptions, metavariables

2018-09-12 Thread av6 (Anton Shestakov)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG5f06c21d37de: zsh_completion: update various arguments, descriptions, metavariables (authored by av6, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4475: setup: don't support py 3.5.0, 3.5.1, 3.5.2 because of bug in codecs

2018-09-12 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGb6b9488aae4c: setup: dont support py 3.5.0, 3.5.1, 3.5.2 because of bug in codecs (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4506: util: update lrucachedict order during get()

2018-09-12 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG8f2c0d1b454c: util: update lrucachedict order during get() (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4503: util: teach lrucachedict to enforce a max total cost

2018-09-12 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG842cd0bdda75: util: teach lrucachedict to enforce a max total cost (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4502: util: allow lrucachedict to track cost of entries

2018-09-12 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGee087f0d7db5: util: allow lrucachedict to track cost of entries (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4505: util: lower water mark when removing nodes after cost limit reached

2018-09-12 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGf296c0b366c8: util: lower water mark when removing nodes after cost limit reached (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4504: util: optimize cost auditing on insert

2018-09-12 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGcc23c09bc562: util: optimize cost auditing on insert (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4504?vs=10823=10943

D4501: util: add a popoldest() method to lrucachedict

2018-09-12 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGbd9d3a89f07b: util: add a popoldest() method to lrucachedict (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4500: util: ability to change capacity when copying lrucachedict

2018-09-12 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG2dcc68c7d25b: util: ability to change capacity when copying lrucachedict (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4499: util: make capacity a public attribute on lrucachedict

2018-09-12 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG5d75a3c16193: util: make capacity a public attribute on lrucachedict (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4475: setup: don't support py 3.5.0, 3.5.1, 3.5.2 because of bug in codecs

2018-09-12 Thread durin42 (Augie Fackler)
durin42 added a comment. In https://phab.mercurial-scm.org/D4475#68453, @indygreg wrote: > I'm a bit wary of version sniffing for the same reason that `User-Agent` sniffing is bad in web design: it assumes that version number strings map to behavior. The best way to test for

D4498: util: properly copy lrucachedict instances

2018-09-12 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGb31b01f93b11: util: properly copy lrucachedict instances (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4497: tests: rewrite test-lrucachedict.py to use unittest

2018-09-12 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG067f7d2c7d60: tests: rewrite test-lrucachedict.py to use unittest (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4472: wireprotov2: implement commands as a generator of objects

2018-09-12 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG07b58266bce3: wireprotov2: implement commands as a generator of objects (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4474: wireprotov2peer: stream decoded responses

2018-09-12 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGd06834e0f48e: wireprotov2peer: stream decoded responses (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4474?vs=10792=10935

D4473: wireprotoframing: buffer emitted data to reduce frame count

2018-09-12 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG84bf6ded9317: wireprotoframing: buffer emitted data to reduce frame count (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4443: internals: extract frame-based protocol docs to own document

2018-09-12 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGb0e0db1565d1: internals: extract frame-based protocol docs to own document (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4480: exchangev2: start to implement pull with wire protocol v2

2018-09-12 Thread durin42 (Augie Fackler)
durin42 added inline comments. INLINE COMMENTS > exchange.py:1490 > +if remote.capable('exchangev2'): > +from . import exchangev2 > +exchangev2.pull(pullop) What's the deal with this function-level import? It doesn't appear to be avoiding a cycle... REPOSITORY

D4436: httppeer: expose capabilities for each command

2018-09-12 Thread durin42 (Augie Fackler)
durin42 added a comment. Hm, I worry this isn't explicit enough. Do you have a specific reason for why this is a thing we should do? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4436 To: indygreg, #hg-reviewers Cc: durin42, mercurial-devel

D2679: [PoC] obsolete: config option to enable local only obsolescence mode

2018-09-12 Thread durin42 (Augie Fackler)
durin42 added a comment. In https://phab.mercurial-scm.org/D2679#68489, @lothiraldan wrote: > To take a step back, I'm wondering what's the end goal? I remember there was a discussion about having rebase enabled by default, is it related? Getting rebase (and maybe histedit?)

[Bug 5985] New: abort: this diff is too large to be displayed

2018-09-12 Thread mercurial-bugs
https://bz.mercurial-scm.org/show_bug.cgi?id=5985 Bug ID: 5985 Summary: abort: this diff is too large to be displayed Product: Mercurial Version: stable branch Hardware: PC OS: Linux Status: UNCONFIRMED

Re: [PATCH 1 of 2] narrowspec: remove parseserverpatterns() which isn't used anymore

2018-09-12 Thread Pulkit Goyal
On Wed, Sep 12, 2018 at 4:32 PM Yuya Nishihara wrote: > # HG changeset patch > # User Yuya Nishihara > # Date 1536758143 -32400 > # Wed Sep 12 22:15:43 2018 +0900 > # Node ID c8ea5c7ec99d1ca4f349025c236c768081dd5084 > # Parent cb675e95a2c2d6b248a9deb459aa7e75edb649a7 > narrowspec: remove

[PATCH 2 of 2] narrow: remove hack to write narrowspec to shared .hg directory

2018-09-12 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1536758369 -32400 # Wed Sep 12 22:19:29 2018 +0900 # Node ID 7934af554124813b0a2bda1a9437a519ab3c04f1 # Parent c8ea5c7ec99d1ca4f349025c236c768081dd5084 narrow: remove hack to write narrowspec to shared .hg directory AFAIK, we no longer need

[PATCH 1 of 2] narrowspec: remove parseserverpatterns() which isn't used anymore

2018-09-12 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1536758143 -32400 # Wed Sep 12 22:15:43 2018 +0900 # Node ID c8ea5c7ec99d1ca4f349025c236c768081dd5084 # Parent cb675e95a2c2d6b248a9deb459aa7e75edb649a7 narrowspec: remove parseserverpatterns() which isn't used anymore Follows up

mercurial@39532: 5 new changesets

2018-09-12 Thread Mercurial Commits
5 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/2862e9b868c5 changeset: 39528:2862e9b868c5 user:Martin von Zweigbergk date:Tue Sep 11 11:03:15 2018 -0700 summary: narrow: check "narrow" wire protocol capability, not bundle2 capability

D4538: commands: pass include and exclude options to hg.clone()

2018-09-12 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG4c807ec07888: commands: pass include and exclude options to hg.clone() (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4541: hg: write narrow patterns after repo creation

2018-09-12 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGcb675e95a2c2: hg: write narrow patterns after repo creation (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4539: exchange: support defining narrow file patterns for pull

2018-09-12 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG130e5df346d5: exchange: support defining narrow file patterns for pull (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4540: narrow: don't wrap exchange.pull() during clone

2018-09-12 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG841c82d1a973: narrow: dont wrap exchange.pull() during clone (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4535: hg: allow extra arguments to be passed to repo creation

2018-09-12 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG089fc0db0954: hg: allow extra arguments to be passed to repo creation (API) (authored by indygreg, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D4535?vs=10912=10925#toc

D4537: localrepo: add requirement when narrow files creation option present

2018-09-12 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG261f1e8dc300: localrepo: add requirement when narrow files creation option present (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4534: localrepo: move repo creation logic out of localrepository.__init__

2018-09-12 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG7ce9dea3a14a: localrepo: move repo creation logic out of localrepository.__init__ (API) (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4536: hg: recognize include and exclude patterns when cloning

2018-09-12 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG65b5900f30be: hg: recognize include and exclude patterns when cloning (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4541: hg: write narrow patterns after repo creation

2018-09-12 Thread yuja (Yuya Nishihara)
yuja added a comment. Looks good. Queued the series, thanks. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4541 To: indygreg, durin42, #hg-reviewers Cc: yuja, mercurial-devel ___ Mercurial-devel mailing list

Re: D4541: hg: write narrow patterns after repo creation

2018-09-12 Thread Yuya Nishihara
Looks good. Queued the series, thanks. ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

D4535: hg: allow extra arguments to be passed to repo creation

2018-09-12 Thread yuja (Yuya Nishihara)
yuja added a comment. > +def filterknowncreateopts(ui, createopts): > +"""Filters a dict of repo creation options against options that are known. Nit: I thought this would select only known options. > +raise error.Abort(_('unable to create repository because of

Re: D4535: hg: allow extra arguments to be passed to repo creation

2018-09-12 Thread Yuya Nishihara
> +def filterknowncreateopts(ui, createopts): > +"""Filters a dict of repo creation options against options that are > known. Nit: I thought this would select only known options. > +raise error.Abort(_('unable to create repository because of unknown ' > +

D4533: localrepo: pass ui to newreporequirements()

2018-09-12 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGc20301a2bd87: localrepo: pass ui to newreporequirements() (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

  1   2   >