[PATCH 1 of 2 V2] py3: partially fix pager spawning on Windows

# HG changeset patch # User Matt Harbison # Date 1537032701 14400 # Sat Sep 15 13:31:41 2018 -0400 # Node ID 91531f9754a5f032fa635dc506091f23519bfdc3 # Parent 8bfbb25859f1455e908b8cff52d7ef30339a3db8 py3: partially fix pager spawning on Windows Previously, spinning up the pager crashed

[PATCH 2 of 2 V2] run-tests: convert the remaining os.system() call to Unicode

# HG changeset patch # User Matt Harbison # Date 1537153985 14400 # Sun Sep 16 23:13:05 2018 -0400 # Node ID b2b5116fbe990c793e765879c3f7fb9575394ec8 # Parent 91531f9754a5f032fa635dc506091f23519bfdc3 run-tests: convert the remaining os.system() call to Unicode I wasn't able to hit this

Re: [PATCH] py3: partially fix pager spawning on Windows

On Sun, 16 Sep 2018 11:26:35 -0400, Yuya Nishihara wrote: On Sun, 16 Sep 2018 09:21:46 -0400, Matt Harbison wrote: > On Sep 16, 2018, at 2:41 AM, Yuya Nishihara wrote: > >> On Sun, 16 Sep 2018 00:40:37 -0400, Matt Harbison wrote: >> # HG changeset patch >> # User Matt Harbison >> # Date

D4606: narrow: when writing treemanifests, skip inspecting directories outside narrow

yuja added a comment. Looks good to me. One nit. > - a/mercurial/manifest.py +++ b/mercurial/manifest.py @@ -1203,7 +1203,7 @@ s._dirty = False self._loadfunc = _load_for_read > - def writesubtrees(self, m1, m2, writesubtree): +def writesubtrees(self, m1, m2, writesubtree,

D4610: py3: add b'' prefixes in tests/test-hgweb-no-path-info.t

yuja added a comment. > > output = stringio() > > env['QUERY_STRING'] = 'style=raw' > > - > process(hgwebdir({'repo': '.'})) + > process(hgwebdir({'repo': b'.'})) Maybe need `b'repo'`. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4610 To:

Re: D4606: narrow: when writing treemanifests, skip inspecting directories outside narrow

Looks good to me. One nit. > --- a/mercurial/manifest.py > +++ b/mercurial/manifest.py > @@ -1203,7 +1203,7 @@ > s._dirty = False > self._loadfunc = _load_for_read > > -def writesubtrees(self, m1, m2, writesubtree): > +def writesubtrees(self, m1, m2, writesubtree,

Re: D4610: py3: add b'' prefixes in tests/test-hgweb-no-path-info.t

>> output = stringio() >> env['QUERY_STRING'] = 'style=raw' > - > process(hgwebdir({'repo': '.'})) > + > process(hgwebdir({'repo': b'.'})) Maybe need `b'repo'`. ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org

Re: [PATCH] censor: rename loop variable to silence pyflakes warning

On Fri, Sep 14, 2018 at 6:52 PM Yuya Nishihara wrote: > # HG changeset patch > # User Yuya Nishihara > # Date 1536975300 -32400 > # Sat Sep 15 10:35:00 2018 +0900 > # Node ID 3a3364720695f26ceee3cd0a056fda59251f4ca5 > # Parent 6ecfd12f09cd4fe185ebbc98d254534ebd995b68 > censor: rename loop

D4611: py3: add b'' prefixes in tests/test-hgweb-no-request-uri.t

This revision was automatically updated to reflect the committed changes. Closed by commit rHGa12916cfef9e: py3: add b prefixes in tests/test-hgweb-no-request-uri.t (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4610: py3: add b'' prefixes in tests/test-hgweb-no-path-info.t

This revision was automatically updated to reflect the committed changes. Closed by commit rHG19f701387ed5: py3: add b prefixes in tests/test-hgweb-no-path-info.t (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4609: py3: add b'' prefixes in tests/test-hgweb-non-interactive.t

This revision was automatically updated to reflect the committed changes. Closed by commit rHGc20861b65688: py3: add b prefixes in tests/test-hgweb-non-interactive.t (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4608: py3: use codecs.encode() to encode in rot-13 encoding

This revision was automatically updated to reflect the committed changes. Closed by commit rHG2b9f315a4217: py3: use codecs.encode() to encode in rot-13 encoding (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4607: py3: add two passing tests to whitelist found by buildbot

This revision was automatically updated to reflect the committed changes. Closed by commit rHGe3768bd48e26: py3: add two passing tests to whitelist found by buildbot (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4588: py3: fix kwargs handling in hgext/fastannotate.py

pulkit updated this revision to Diff 11101. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4588?vs=11042=11101 REVISION DETAIL https://phab.mercurial-scm.org/D4588 AFFECTED FILES hgext/fastannotate/commands.py CHANGE DETAILS diff --git

D4611: py3: add b'' prefixes in tests/test-hgweb-no-request-uri.t

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY 1. skip-blame because just b'' prefixes. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4611 AFFECTED FILES

D4610: py3: add b'' prefixes in tests/test-hgweb-no-path-info.t

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY 1. skip-blame because just b'' prefixes REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4610 AFFECTED FILES

D4609: py3: add b'' prefixes in tests/test-hgweb-non-interactive.t

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY 1. skip-blame because just b'' prefix REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4609 AFFECTED FILES

D4608: py3: use codecs.encode() to encode in rot-13 encoding

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The other occurence will need some more love as description is bytes by default and we need to decode it and then encode it. REPOSITORY rHG Mercurial REVISION

D4588: py3: fix kwargs handling in hgext/fastannotate.py

pulkit added inline comments. INLINE COMMENTS > indygreg wrote in commands.py:212-217 > Shouldn't we be doing the ``pycompat.byteskwargs()` at the beginning of the > function and using regular string literals on the keys we set? We can do that, but then in the end we have to do

Re: [PATCH] py3: partially fix pager spawning on Windows

On Sun, 16 Sep 2018 09:21:46 -0400, Matt Harbison wrote: > > > On Sep 16, 2018, at 2:41 AM, Yuya Nishihara wrote: > > > >> On Sun, 16 Sep 2018 00:40:37 -0400, Matt Harbison wrote: > >> # HG changeset patch > >> # User Matt Harbison > >> # Date 1537032701 14400 > >> # Sat Sep 15 13:31:41

D4607: py3: add two passing tests to whitelist found by buildbot

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The buildbot found these two new passing tests on Python 3. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4607 AFFECTED FILES

Re: [PATCH] py3: partially fix pager spawning on Windows

> On Sep 16, 2018, at 2:41 AM, Yuya Nishihara wrote: > >> On Sun, 16 Sep 2018 00:40:37 -0400, Matt Harbison wrote: >> # HG changeset patch >> # User Matt Harbison >> # Date 1537032701 14400 >> # Sat Sep 15 13:31:41 2018 -0400 >> # Node ID efffacd34255117920417dfb2d71627929499500 >> #

Re: [PATCH] py3: partially fix pager spawning on Windows

On Sun, 16 Sep 2018 00:40:37 -0400, Matt Harbison wrote: > # HG changeset patch > # User Matt Harbison > # Date 1537032701 14400 > # Sat Sep 15 13:31:41 2018 -0400 > # Node ID efffacd34255117920417dfb2d71627929499500 > # Parent 87539f615b878fe39973fb059b0531fa4fd7e6ff > py3: partially fix