# HG changeset patch
# User Sean Farley
# Date 1528775327 25200
# Mon Jun 11 20:48:47 2018 -0700
# Branch ctx-minor-fixes
# Node ID c21a9a45b1a718d67d294fb822b58c7d6a2aa207
# Parent 03041a020368729345f9b72e6914122c5e88a302
context: fix typo in workingcommitctx
This was probably a copy
# HG changeset patch
# User Sean Farley
# Date 1528497109 25200
# Fri Jun 08 15:31:49 2018 -0700
# Branch ctx-minor-fixes
# Node ID 58496e395dd324297748551297d1d572ab762496
# Parent 56222df6e5c8738b9b04881477c166540c50b17a
context: define contract for parents
From now on, context._parents
# HG changeset patch
# User Sean Farley
# Date 1526998571 -7200
# Tue May 22 16:16:11 2018 +0200
# Branch ctx-minor-fixes
# Node ID 0173c0dca9d389d55a3f0e8ff3bcf43dc7ef659d
# Parent 2a524ac6b6e5da11f0f8ab9c9137d44c16f724b5
memctx: simplify _manifest with new revlog nodeids
This was
# HG changeset patch
# User Sean Farley
# Date 1526985338 -7200
# Tue May 22 12:35:38 2018 +0200
# Branch ctx-minor-fixes
# Node ID 2a524ac6b6e5da11f0f8ab9c9137d44c16f724b5
# Parent c21a9a45b1a718d67d294fb822b58c7d6a2aa207
context: remove unused overlayctx
It seems that this was maybe used
# HG changeset patch
# User Sean Farley
# Date 1531872982 25200
# Tue Jul 17 17:16:22 2018 -0700
# Branch ctx-minor-fixes
# Node ID 03041a020368729345f9b72e6914122c5e88a302
# Parent 3d22aef3ecd5fe02c9411503b04dfbdcb6240cc1
filectx: fix return of renamed
How is this not blowing up
# HG changeset patch
# User Sean Farley
# Date 1528495331 25200
# Fri Jun 08 15:02:11 2018 -0700
# Branch ctx-minor-fixes
# Node ID 56222df6e5c8738b9b04881477c166540c50b17a
# Parent 0173c0dca9d389d55a3f0e8ff3bcf43dc7ef659d
context: use object-oriented programming
We have abstracted
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
The previous commit removed the last user of this method. It is
redundant with heads() and adds little to no value other than
convenience. Let's nuke it.
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
These appear to be the only callers of headrevs() on file storage
objects. Let's port to heads() so we can remove headrevs().
REPOSITORY
rHG Mercurial
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
The censor extension is doing very low-level things with revlogs.
It is fundamentally impossible for this logic to remain in the censor
extension while support
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
filelog and the file storage interface have some attributes that
ideally shouldn't be there. This commit annotates some of those
attributes with their users so
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
It appears the censor code was the last user of this proxy. With
there being a dedicated censor API, we can drop the proxy.
REPOSITORY
rHG Mercurial
REVISION
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
There are no callers of this API in core. And I'm not sure why this
proxy was added in the first place, as the commit that added it
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
The censoring code was previously relying on this. With a dedicated
censoring API on the interface, no consumers are left and we can
stop proxying this method.
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
These were needed by the censoring code, which formerly lived in the
censor extension. Now that there is a censoring API on the file storage
interface, nothing
On Tue, 18 Sep 2018 09:40:58 -0400, Yuya Nishihara wrote:
It looks like part of the problem with not finding these files is
TESTDIR
is not defined when running the *.t file. Inside Test.runTest(),
'TESTDIR' is not in env, osenvironb, or os.environ on py3 (but it is on
py2). I'm assuming
Sean Farley writes:
> Augie Fackler writes:
>
>> (+smf - this is for the website)
>>
>>> On Sep 6, 2018, at 22:07, Bradley M. Jones wrote:
>>>
>>> # HG changeset patch
>>> # User Bradley Jones
>>> # Date 1536285273 -43200
>>> # Fri Sep 07 13:54:33 2018 +1200
>>> # Node ID
59 new changesets in mercurial:
https://www.mercurial-scm.org/repo/hg/rev/a5de21c9e370
changeset: 39628:a5de21c9e370
user:Gregory Szorc
date:Tue Aug 21 15:33:11 2018 -0700
summary: httppeer: expose capabilities for each command
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
When catching errors in storage, we should be catching
StorageError instead of RevlogError. When throwing errors related
to storage, we shouldn't be using
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Errors in revlogs are often represented by RevlogError. It's fine
for revlogs to raise a revlog-specific exception. But in the context
of multiple storage
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
These should be lightly used and I doubt that will be any
strong objections to removing the aliases.
Note that some uses of ProgrammingError in this file
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This alias is especially bad because it shadows the built-in
LookupError type. This has caused me confusion in the past
when reading revlog code. Qualifying
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
error.RevlogError was moved from revlog.py in
https://phab.mercurial-scm.org/rHG08cabecfa8a89f14b17dd5b68ef297f9ab6f653a in
2009. revlog.RevlogError has
indygreg created this revision.
Herald added subscribers: mercurial-devel, mjpieters.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Our strategy for supporting alternate storage backends is to define
interfaces for everything then "code to the interface."
We already have
indygreg added a comment.
In https://phab.mercurial-scm.org/D4483#70789, @martinvonz wrote:
> > It's worth noting that when phase data is being requested, the
> > server will also emit changeset records for nodes in the bases
> > specified by the "noderange" argument. This is to
martinvonz added a comment.
> It's worth noting that when phase data is being requested, the
> server will also emit changeset records for nodes in the bases
> specified by the "noderange" argument. This is to ensure that
> phase-only updates for nodes the client has are available to
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
If the narrow requirement is present, revlogs created for that
repository will have the ellipsis flag enabled.
This is the same behavior that the narrow
indygreg created this revision.
Herald added a reviewer: durin42.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Core now automatically enables ellipsis support on revlogs when
repositories have narrow enabled. So, we no longer need to
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
The ellipsis flag processor can now be registered by specifying
an opener option when constructing a revlog instance. This allows
us to enable ellipsis flags
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Today, localrepository has a method that can be overloaded which
returns an instance of the root manifest storage object. When a
manifestlog is created, it
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Previously, revlog flag processing would consult a global dict
when processing flags. This was simple. But it had the undesired
side-effect that any extension
indygreg created this revision.
Herald added a reviewer: durin42.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
We will soon be teaching core to honor the ellipsis flag on revlogs.
Moving the definition of the processor functions to core
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Narrow repos may have file revisions whose copy/rename metadata
references files not in the store. This can pose problems when
consumers attempt to access a
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This commit implements the dynamic local repository type derivation
that was explained in the recent commit
indygreg created this revision.
Herald added a reviewer: durin42.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This functionality is now handled by core as of the previous commit.
I wanted this to be a standalone commit because the
5 new changesets in mercurial:
https://www.mercurial-scm.org/repo/hg/rev/34ecc0a09c76
changeset: 39623:34ecc0a09c76
user:Yuya Nishihara
date:Thu Jun 07 21:48:11 2018 +0900
summary: formatter: populate ctx from repo and node value
indygreg added a comment.
In https://phab.mercurial-scm.org/D4576#70668, @durin42 wrote:
> I kind of hope that eventually you're going to break all the
requirements-handling nonsense out into its own module somehow?
I suspect I'm trending in the direction of creating a `storage`
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGb10d145837bc: localrepo: extract resolving of opener
options to standalone functions (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG6f26417b71bb: localrepo: use boolean in opener options
(authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D4575?vs=11013=11173
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGf44187605315: localrepo: move store() from store module
(authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D4574?vs=11012=11171
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG9de1a1c83cd7: localrepo: document and test bug around
opening shared repos (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG98ca9078807a: localrepo: resolve store and cachevfs in
makelocalrepository() (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGcb2dcfa5cade: localrepo: move requirements reasonability
testing to own function (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG6192980553b4: statichttprepo: use new functions for
requirements validation (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG5b8e9b2060ef: localrepo: validate supported requirements in
makelocalrepository() (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG6a3162ed881d: localrepo: read requirements file in
makelocalrepository() (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG2f067e365532: localrepo: check for .hg/ directory in
makelocalrepository() (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGe0c5017124b3: localrepo: load extensions in
makelocalrepository() (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGf19bba3f4d3f: localrepo: copy ui in makelocalrepository()
(authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG2f9cdb5b3644: localrepo: move some vfs initialization out
of __init__ (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGbfeab472e3c0: localrepo: create new function for
instantiating a local repo object (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
durin42 added a comment.
I kind of hope that eventually you're going to break all the
requirements-handling nonsense out into its own module somehow?
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D4576
To: indygreg, #hg-reviewers
Cc: durin42, mercurial-devel
indygreg added inline comments.
INLINE COMMENTS
> durin42 wrote in wireprotov2server.py:543-546
> Shouldn't there be a default XOR required == true? That is, could we get away
> with `default=None` and then deriving requiredness from default-availability?
We could do that, sure. Would it be OK
durin42 added inline comments.
INLINE COMMENTS
> wireprotov2server.py:543-546
> + ``default``
> + A callable returning the default value for this argument.
> +
> + ``required``
Shouldn't there be a default XOR required == true? That is, could we get away
with
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG3d22aef3ecd5: transaction: make entries a private attribute
(API) (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG1a68c9b1920d: transaction: make map a private attribute
(authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D4632?vs=11131=11159
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG4024c363cd33: transaction: make names a private attribute
(authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG337d6e0fd9c9: transaction: make report a private attribute
(authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGb590f4763aba: transaction: make opener a private attribute
(authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG0d7b9db85675: transaction: make after a private attribute
(authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG264d56954dda: transaction: make checkambigfiles a private
attribute (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGd27fde3e023e: transaction: make file a private attribute
(authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGebbba3ba3f66: transaction: make validator a private
attribute (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG040007cd3d81: transaction: make releasefn a private
attribute (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG77c4e2ae9f07: transaction: make journal a private attribute
(authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGda9ce63bfa9b: transaction: make undoname a private
attribute (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG3e8952c0cb45: transaction: make count and usages private
attributes (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
It turns out they've never actually worked: prior to some recent
refactoring they just unintentionally followed the full-clone path,
which we unintentionally
pulkit added a comment.
In https://phab.mercurial-scm.org/D4638#70613, @indygreg wrote:
> I think the code as written makes sense: I'd rather have 1 loop over
`deltas` than 2.
>
> Regarding the other potential improvement, the reality of changegroups is
that both they and bundle2
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGf1844a10ee19: narrow: dont send the changelog
information when widening without ellipses (authored by pulkit, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGa1942015c10e: changegroup: add functionality to skip adding
changelog data to changegroup (authored by pulkit, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
indygreg accepted this revision.
indygreg added a comment.
This revision is now accepted and ready to land.
I think the code as written makes sense: I'd rather have 1 loop over `deltas`
than 2.
Regarding the other potential improvement, the reality of changegroups is
that both they and
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGdee887072f27: tests: add debug output in
test-narrow-widen-no-ellipsis.t (authored by pulkit, committed by ).
CHANGED PRIOR TO COMMIT
https://phab.mercurial-scm.org/D4637?vs=11136=11144#toc
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG9b07ee0a1054: changegroup: improve the devel-warn to
specify changelog was empty (authored by pulkit, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
indygreg added inline comments.
INLINE COMMENTS
> test-narrow-widen-no-ellipsis.t:93
>comparing with ssh://user@dummy/master
> + running python "/place/home/pulkit/repo/hg-committed/tests/dummyssh"
> 'user@dummy' 'hg -R master serve --stdio'
> + sending hello command
This needs some
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG3f11cb1aeb90: zsh_completion: add -b/--branch and
-B/--bookmark(s) flags properly (authored by av6, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG24870f1be088: narrow: when writing treemanifests, skip
inspecting directories outside narrow (authored by spectral, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG0b7594ada0db: tests: fix a couple of drawdag.py references
(authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGb77f2ea51da5: py3: fix kwargs handling in
hgext/fastannotate.py (authored by pulkit, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
yuja added a comment.
No idea which is more correct, but drawdag.py is generally paired with
`$TESTDIR`. Queued, thanks.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D4635
To: durin42, #hg-reviewers
Cc: yuja, mercurial-devel
No idea which is more correct, but drawdag.py is generally paired with
`$TESTDIR`. Queued, thanks.
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
> It looks like part of the problem with not finding these files is TESTDIR
> is not defined when running the *.t file. Inside Test.runTest(),
> 'TESTDIR' is not in env, osenvironb, or os.environ on py3 (but it is on
> py2). I'm assuming this is a bytes vs unicode thing since Linux works,
pulkit added a comment.
I agree this is dirty and I will be very happy to improve this. I can think
of folllowing improvements
First is this:
@@ -837,10 +838,14 @@ class cgpacker(object):
size = 0
clstate, deltas = self._generatechangelog(cl,
pulkit created this revision.
Herald added a reviewer: durin42.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
When we widen anon-ellipses narrow copy, the server sends the changelog
information of all the changesets. The code was copied
pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
In narrow extension, when we have a non-ellipses narrow working copy and we
extend it, we pull all the changelog data again and the client tries to
reapply
all
pulkit created this revision.
Herald added a reviewer: durin42.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This will help us in understanding the upcoming patches better.
REPOSITORY
rHG Mercurial
REVISION DETAIL
pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Right now, the develwarn says "applied empty changegroup" which is not correct
because we can send a changegroup without changelog with just manifest and
https://bz.mercurial-scm.org/show_bug.cgi?id=5987
Bug ID: 5987
Summary: exception thrown when cloning with trailing slash
Product: Mercurial
Version: 4.7.1
Hardware: PC
OS: All
Status: UNCONFIRMED
I liked this post very much, it gave me a lot of information about
Mercurial.
Thanks for writing it up :)
I wish if I could help in achieving this goal of a new wire protocol.
On Sat, Sep 1, 2018 at 4:17 AM Gregory Szorc
wrote:
> This is a long post and I apologize in advance for that. I've
88 matches
Mail list logo