Re: [PATCH 1 of 2 v2] py3: handle meta-path finders that only use pre-python3.4 API

2019-04-23 Thread Ludovic Chabant
> Does find_module() return a spec? We might instead have to skip py3.4 > finders. Ah you're right, it returns something else. It looks like Python does this: try: find_spec = finder.find_spec except AttributeError: loader = finder.find_module(name) if loader is

Re: [PATCH 1 of 2 v2] py3: handle meta-path finders that only use pre-python3.4 API

2019-04-23 Thread Yuya Nishihara
On Tue, 23 Apr 2019 01:57:32 +, Ludovic Chabant wrote: > # HG changeset patch > # User Ludovic Chabant > # Date 1555683918 0 > # Fri Apr 19 14:25:18 2019 + > # Branch stable > # Node ID 8214209f30a56052124b7f530d2a955a2b93b14f > # Parent 4a8d9ed864754837a185a642170cde24392f9abf >

Re: [PATCH 2 of 2] py3: convert unicode paths given for hgweb config

2019-04-23 Thread Yuya Nishihara
On Tue, 23 Apr 2019 11:20:05 -0400, Ludovic Chabant wrote: > > > > If we want to be consistent with other things like the hgclient API, > > > maybe we shouldn't be nice and encode the string for the caller, and > > > instead reject anything that's not bytes? > > > > Sounds good to reject

D6305: match: remove unused match.__iter__ implementation (API)

2019-04-23 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG7edff8dd46a7: match: remove unused match.__iter__ implementation (API) (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6167: fix: allow fixer tools to return metadata in addition to the file content

2019-04-23 Thread hooper (Danny Hooper)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG0da689a60163: fix: allow fixer tools to return metadata in addition to the file content (authored by hooper, committed by ). CHANGED PRIOR TO COMMIT

mercurial@42190: new changeset

2019-04-23 Thread Mercurial Commits
New changeset in mercurial: https://www.mercurial-scm.org/repo/hg/rev/7c0ece3cd3ee changeset: 42190:7c0ece3cd3ee bookmark:@ tag: tip parent: 42189:c0e30c9ee5ba parent: 42175:cd1bede340b0 user:Augie Fackler date:Tue Apr 23 15:49:17 2019 -0400 summary:

D6167: fix: allow fixer tools to return metadata in addition to the file content

2019-04-23 Thread martinvonz (Martin von Zweigbergk)
martinvonz added inline comments. INLINE COMMENTS > fix.py:90-104 > +"postfixfile" > + Run once for each file in each revision where any fixer tools made changes > to > + the file content. Provides "$HG_REV" and "$HG_PATH" to identify the file, > and > + "$HG_METADATA" with a map of fixer

D6167: fix: allow fixer tools to return metadata in addition to the file content

2019-04-23 Thread hooper (Danny Hooper)
hooper added inline comments. INLINE COMMENTS > martinvonz wrote in fix.py:559-570 > Would the thing that processes this metadata usually not care to aggregate > per fixer? If they did, it seems they would now have to look for a > `fixer-applied='my-fixer'` entry and then take the metadata

D6167: fix: allow fixer tools to return metadata in addition to the file content

2019-04-23 Thread hooper (Danny Hooper)
hooper updated this revision to Diff 14901. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6167?vs=14581=14901 REVISION DETAIL https://phab.mercurial-scm.org/D6167 AFFECTED FILES hgext/fix.py tests/test-fix-metadata.t tests/test-fix.t CHANGE

D6306: copies: write empty entries in changeset when also writing to filelog

2019-04-23 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY When writing to both changeset and filelog (during transition), we don't want the reader to waste time by falling back to reading from the filelog when there

mercurial@42189: 14 new changesets

2019-04-23 Thread Mercurial Commits
14 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/3bdb21bbf791 changeset: 42176:3bdb21bbf791 parent: 42171:84bd6ae2d1f6 user:Georges Racinet date:Tue Feb 19 23:41:57 2019 +0100 summary: rust-dagops: range of revisions

D6305: match: remove unused match.__iter__ implementation (API)

2019-04-23 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6305 AFFECTED FILES mercurial/match.py CHANGE DETAILS diff --git a/mercurial/match.py

Re: [PATCH 2 of 2] py3: convert unicode paths given for hgweb config

2019-04-23 Thread Ludovic Chabant
> > If we want to be consistent with other things like the hgclient API, > > maybe we shouldn't be nice and encode the string for the caller, and > > instead reject anything that's not bytes? > > Sounds good to reject unicodes explicitly. I had sent a v2 of my patch with a better way to encode

Re: [PATCH 1 of 2] py3: protect from exceptions thrown by other meta-path finders

2019-04-23 Thread Ludovic Chabant
> > Gracefully handling missing find_spec() should be fine. But we should > use hasattr() or getattr() for that (Mercurial’s linter may insist on > getattr() because I think we still ban hasattr()) because bare > “except:” is bad. Thanks, I sent a v2 of my patches yesterday evening with that

Evolve 8.5.1 released

2019-04-23 Thread Pierre-Yves David
I pushed a new release for the evolve extension: 8.5.1 As usual, the release is available on pypi and upgrade is recommended. This version brings a couple of bug fixes and compatibility polish. Talking about compatibility, the next version (non bugfix) version will drop support for Mercurial

[Bug 6124] New: 'hg log -pr .' at file-level doesn't show expected output

2019-04-23 Thread mercurial-bugs
https://bz.mercurial-scm.org/show_bug.cgi?id=6124 Bug ID: 6124 Summary: 'hg log -pr .' at file-level doesn't show expected output Product: Mercurial Version: 3.7 Hardware: PC OS: Linux Status:

Re: [PATCH 1 of 2] py3: protect from exceptions thrown by other meta-path finders

2019-04-23 Thread Gregory Szorc
> On Apr 23, 2019, at 05:41, Yuya Nishihara wrote: > > On Mon, 22 Apr 2019 21:22:31 -0400, Ludovic Chabant wrote: >>> >>> Is there any list of exceptions that are known to be safely >>> suppressed? Catching AttributeError, TypeError, etc. seems bad. >>> >> >> In my case, it's just a missing

[Bug 6123] New: hg shelve has no information about branches

2019-04-23 Thread mercurial-bugs
https://bz.mercurial-scm.org/show_bug.cgi?id=6123 Bug ID: 6123 Summary: hg shelve has no information about branches Product: Mercurial Version: 4.9 Hardware: PC OS: Linux Status: UNCONFIRMED Severity:

Re: [PATCH 1 of 2] py3: protect from exceptions thrown by other meta-path finders

2019-04-23 Thread Yuya Nishihara
On Mon, 22 Apr 2019 21:22:31 -0400, Ludovic Chabant wrote: > > > > Is there any list of exceptions that are known to be safely > > suppressed? Catching AttributeError, TypeError, etc. seems bad. > > > > In my case, it's just a missing method so AttributeError is what's being > raised I think (see

Re: [PATCH 2 of 2] py3: convert unicode paths given for hgweb config

2019-04-23 Thread Yuya Nishihara
On Mon, 22 Apr 2019 21:40:29 -0400, Ludovic Chabant wrote: > > > We'll probably need to fix the caller to not pass in a unicode. Can > > you copy-paste the traceback? > > The caller is my own code. It's basically a custom version of the > hgweb.wsgi file (see >

Re: [PATCH 1 of 2] rust: published the three extension crates to crates.io

2019-04-23 Thread Yuya Nishihara
(+CC Mike Hommey as he might know Debian packaging issues) On Tue, 23 Apr 2019 10:35:27 +0200, Georges Racinet wrote: > As far as I understand, it's necessary for all uploaded crates to > specify at least some version restriction, and path-only dependencies > aren't accepted. > >

Re: [PATCH 1 of 2] rust: published the three extension crates to crates.io

2019-04-23 Thread Georges Racinet
On 4/21/19 12:21 PM, Yuya Nishihara wrote: > On Tue, 16 Apr 2019 21:26:17 +0200, Georges Racinet wrote: >> # HG changeset patch >> # User Georges Racinet >> # Date 1555441784 -7200 >> # Tue Apr 16 21:09:44 2019 +0200 >> # Node ID 410396d5eca793a1b8cf9ee8ba7bce466e9be3c0 >> # Parent