D6709: config: add --all flag to show all known configs

2019-08-02 Thread navaneeth.suresh (Navaneeth Suresh)
navaneeth.suresh updated this revision to Diff 16117. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6709?vs=16114=16117 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6709/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6709

D6710: branchmap: properly refresh/warm all branchmap caches

2019-08-02 Thread spectral (Kyle Lippincott)
spectral added a comment. spectral planned changes to this revision. Needs some test updates. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6710/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6710 To: spectral, #hg-reviewers Cc:

D6710: branchmap: properly refresh/warm all branchmap caches

2019-08-02 Thread spectral (Kyle Lippincott)
spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The comment about 'served' refreshing all the others only applies when served is the head of the branchmap cache subsets. This was already no longer the case

D6711: branchheads: store wdir-dependent caches in wcache (issue6181)

2019-08-02 Thread spectral (Kyle Lippincott)
spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Previously, all branch2-* caches were stored in .hg/cache, which is shared across repos when using `hg share`. This can cause cache thrashing when the repos

Re: [PATCH 3 of 5] byteify-strings: add test for byteify-strings.py

2019-08-02 Thread Yuya Nishihara
On Fri, 02 Aug 2019 17:01:24 +0200, Raphaël Gomès wrote: > # HG changeset patch > # User Raphaël Gomès > # Date 1564757642 -7200 > # Fri Aug 02 16:54:02 2019 +0200 > # Node ID 91a17ea759c5f0fceaae18fb558435ab379faac7 > # Parent fea16ec00093e73bf0aa4db3f2a709c385fc6336 > # EXP-Topic

Re: [PATCH 5 of 5] byteify-strings: fix alignment issue

2019-08-02 Thread Yuya Nishihara
On Fri, 02 Aug 2019 17:01:26 +0200, Raphaël Gomès wrote: > # HG changeset patch > # User Raphaël Gomès > # Date 1564758059 -7200 > # Fri Aug 02 17:00:59 2019 +0200 > # Node ID 91da691d3bbc18d32760179e4012047505c244b8 > # Parent 1ae95b109c557785f566d307c13ded3eedc73dd9 > # EXP-Topic

Re: [PATCH 1 of 5] byteify-strings: simplify default value for `--treat-as-kwargs`

2019-08-02 Thread Yuya Nishihara
On Fri, 02 Aug 2019 17:01:22 +0200, Raphaël Gomès wrote: > # HG changeset patch > # User Raphaël Gomès > # Date 1564755240 -7200 > # Fri Aug 02 16:14:00 2019 +0200 > # Node ID 4a3e6c4ac759ed0d7678980328c0dec3824192ea > # Parent f95b59ffc307c4549d9640a81d750a99bd75f423 > # EXP-Topic

[Bug 6181] New: branchmap cache stores non-store-specific caches in shared cache

2019-08-02 Thread mercurial-bugs
https://bz.mercurial-scm.org/show_bug.cgi?id=6181 Bug ID: 6181 Summary: branchmap cache stores non-store-specific caches in shared cache Product: Mercurial Version: unspecified Hardware: PC OS: Linux

[Bug 6180] New: pruning while rebasing confuses rebase

2019-08-02 Thread mercurial-bugs
https://bz.mercurial-scm.org/show_bug.cgi?id=6180 Bug ID: 6180 Summary: pruning while rebasing confuses rebase Product: Mercurial Version: 4.8 Hardware: PC OS: Linux Status: UNCONFIRMED Severity: feature

[PATCH 1 of 5] byteify-strings: simplify default value for `--treat-as-kwargs`

2019-08-02 Thread Raphaël Gomès
# HG changeset patch # User Raphaël Gomès # Date 1564755240 -7200 # Fri Aug 02 16:14:00 2019 +0200 # Node ID 4a3e6c4ac759ed0d7678980328c0dec3824192ea # Parent f95b59ffc307c4549d9640a81d750a99bd75f423 # EXP-Topic byteify-strings byteify-strings: simplify default value for `--treat-as-kwargs`

[PATCH 5 of 5] byteify-strings: fix alignment issue

2019-08-02 Thread Raphaël Gomès
# HG changeset patch # User Raphaël Gomès # Date 1564758059 -7200 # Fri Aug 02 17:00:59 2019 +0200 # Node ID 91da691d3bbc18d32760179e4012047505c244b8 # Parent 1ae95b109c557785f566d307c13ded3eedc73dd9 # EXP-Topic byteify-strings byteify-strings: fix alignment issue While removing this `if`

[PATCH 4 of 5] byteify-strings: demonstrate an issue with multi-line parenthesis alignment

2019-08-02 Thread Raphaël Gomès
# HG changeset patch # User Raphaël Gomès # Date 1564757842 -7200 # Fri Aug 02 16:57:22 2019 +0200 # Node ID 1ae95b109c557785f566d307c13ded3eedc73dd9 # Parent 91a17ea759c5f0fceaae18fb558435ab379faac7 # EXP-Topic byteify-strings byteify-strings: demonstrate an issue with multi-line

[PATCH 3 of 5] byteify-strings: add test for byteify-strings.py

2019-08-02 Thread Raphaël Gomès
# HG changeset patch # User Raphaël Gomès # Date 1564757642 -7200 # Fri Aug 02 16:54:02 2019 +0200 # Node ID 91a17ea759c5f0fceaae18fb558435ab379faac7 # Parent fea16ec00093e73bf0aa4db3f2a709c385fc6336 # EXP-Topic byteify-strings byteify-strings: add test for byteify-strings.py This tests

[PATCH 2 of 5] byteify-strings: add cli argument to handle `attr*()` when they are methods

2019-08-02 Thread Raphaël Gomès
# HG changeset patch # User Raphaël Gomès # Date 1564755422 -7200 # Fri Aug 02 16:17:02 2019 +0200 # Node ID fea16ec00093e73bf0aa4db3f2a709c385fc6336 # Parent 4a3e6c4ac759ed0d7678980328c0dec3824192ea # EXP-Topic byteify-strings byteify-strings: add cli argument to handle `attr*()` when they

D6704: config: add defaultvalue template keyword

2019-08-02 Thread yuja (Yuya Nishihara)
yuja added a comment. > +def configdefault(self, section, name): > +"""returns the default value of the config item""" > +item = self._knownconfig.get(section, {}).get(name) > +itemdefault = None > +if item is not None: > +if

Re: D6704: config: add defaultvalue template keyword

2019-08-02 Thread Yuya Nishihara
> +def configdefault(self, section, name): > +"""returns the default value of the config item""" > +item = self._knownconfig.get(section, {}).get(name) > +itemdefault = None > +if item is not None: > +if callable(item.default): > +

Re: [PATCH 4 of 6] byteify-strings: broaden handling of attr* functions

2019-08-02 Thread Yuya Nishihara
On Fri, 02 Aug 2019 10:22:15 +0200, Raphaël Gomès wrote: > # HG changeset patch > # User Raphaël Gomès > # Date 1564733030 -7200 > # Fri Aug 02 10:03:50 2019 +0200 > # Node ID edff9054a1a327d3d444d4acfde0879a92742549 > # Parent 2ba0327a754304b371c06d84a80ab1871e02fa66 > # EXP-Topic

Re: [PATCH 6 of 6] byteify-strings: add --treat-as-kwargs argument to handle kwargs-like objects

2019-08-02 Thread Yuya Nishihara
On Fri, 02 Aug 2019 10:22:17 +0200, Raphaël Gomès wrote: > # HG changeset patch > # User Raphaël Gomès > # Date 1564733902 -7200 > # Fri Aug 02 10:18:22 2019 +0200 > # Node ID e6e13ca43b23038dd34e2c35b799f68868674f4b > # Parent d28c8bac8d4bc1eddc4a899eb081563e4823f6a6 > # EXP-Topic

D6709: config: add --all flag to show all known configs

2019-08-02 Thread av6 (Anton Shestakov)
This revision now requires changes to proceed. av6 added inline comments. av6 requested changes to this revision. INLINE COMMENTS > commands.py:1774 > @command('config|showconfig|debugconfig', > -[('u', 'untrusted', None, _('show untrusted configuration options')), > +[('a', 'all',

D6709: config: add --all flag to show all known configs

2019-08-02 Thread navaneeth.suresh (Navaneeth Suresh)
navaneeth.suresh updated this revision to Diff 16114. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6709?vs=16113=16114 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6709/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6709

D6709: config: add --all flag to show all known configs

2019-08-02 Thread navaneeth.suresh (Navaneeth Suresh)
navaneeth.suresh created this revision. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This patch fixes one of the issues in issue6014. This adds an `--all` flag to `hg showconfig` to show all known config options. REPOSITORY

[PATCH 6 of 6] byteify-strings: add --treat-as-kwargs argument to handle kwargs-like objects

2019-08-02 Thread Raphaël Gomès
# HG changeset patch # User Raphaël Gomès # Date 1564733902 -7200 # Fri Aug 02 10:18:22 2019 +0200 # Node ID e6e13ca43b23038dd34e2c35b799f68868674f4b # Parent d28c8bac8d4bc1eddc4a899eb081563e4823f6a6 # EXP-Topic byteify-strings byteify-strings: add --treat-as-kwargs argument to handle

[PATCH 2 of 6] byteify-strings: handle triple quoted strings if they are not docstrings

2019-08-02 Thread Raphaël Gomès
# HG changeset patch # User Raphaël Gomès # Date 1564732093 -7200 # Fri Aug 02 09:48:13 2019 +0200 # Node ID 649e2ec4232c359d5b09833d8d6e1b9e309ba28a # Parent 623f86cf8834b154cc2b7c88b6dd8378ff9481c6 # EXP-Topic byteify-strings byteify-strings: handle triple quoted strings if they are not

[PATCH 5 of 6] byteify-strings: add helpers to check for item access or method call

2019-08-02 Thread Raphaël Gomès
# HG changeset patch # User Raphaël Gomès # Date 1564733423 -7200 # Fri Aug 02 10:10:23 2019 +0200 # Node ID d28c8bac8d4bc1eddc4a899eb081563e4823f6a6 # Parent edff9054a1a327d3d444d4acfde0879a92742549 # EXP-Topic byteify-strings byteify-strings: add helpers to check for item access or method

[PATCH 4 of 6] byteify-strings: broaden handling of attr* functions

2019-08-02 Thread Raphaël Gomès
# HG changeset patch # User Raphaël Gomès # Date 1564733030 -7200 # Fri Aug 02 10:03:50 2019 +0200 # Node ID edff9054a1a327d3d444d4acfde0879a92742549 # Parent 2ba0327a754304b371c06d84a80ab1871e02fa66 # EXP-Topic byteify-strings byteify-strings: broaden handling of attr* functions The

[PATCH 3 of 6] byteify-strings: add support for ignore comments

2019-08-02 Thread Raphaël Gomès
# HG changeset patch # User Raphaël Gomès # Date 1564732532 -7200 # Fri Aug 02 09:55:32 2019 +0200 # Node ID 2ba0327a754304b371c06d84a80ab1871e02fa66 # Parent 649e2ec4232c359d5b09833d8d6e1b9e309ba28a # EXP-Topic byteify-strings byteify-strings: add support for ignore comments Our simple

[PATCH 1 of 6] byteify-strings: handle multi-line strings in _ensuresysstr

2019-08-02 Thread Raphaël Gomès
# HG changeset patch # User Raphaël Gomès # Date 1564731851 -7200 # Fri Aug 02 09:44:11 2019 +0200 # Node ID 623f86cf8834b154cc2b7c88b6dd8378ff9481c6 # Parent 4b04244f2d5fdc6221c29d6ae8074a81fe352c5e # EXP-Topic byteify-strings byteify-strings: handle multi-line strings in _ensuresysstr

D6708: unshelve: clear shelvedstate and _finishunshelve() on partial unshelve

2019-08-02 Thread navaneeth.suresh (Navaneeth Suresh)
navaneeth.suresh created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY On a partial unshelve, `shelvedstate` was not cleared and `_finishunshelve()` was not called. Ideally, these should be called on this case. This patch

D6699: tests: add test for unshelve --interactive --keep

2019-08-02 Thread navaneeth.suresh (Navaneeth Suresh)
navaneeth.suresh updated this revision to Diff 16111. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6699?vs=16086=16111 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6699/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6699

D6697: cmdutil: add allowunfinished to prevent checkunfinished() on docommit()

2019-08-02 Thread navaneeth.suresh (Navaneeth Suresh)
navaneeth.suresh updated this revision to Diff 16110. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6697?vs=16073=16110 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6697/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6697

D6694: unshelve: delete shelvedstate after a successful unshelve --continue

2019-08-02 Thread navaneeth.suresh (Navaneeth Suresh)
navaneeth.suresh updated this revision to Diff 16109. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6694?vs=16085=16109 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6694/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6694

D6686: unshelve: handle stripping changesets on interactive mode

2019-08-02 Thread navaneeth.suresh (Navaneeth Suresh)
navaneeth.suresh updated this revision to Diff 16108. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6686?vs=16065=16108 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6686/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6686

D6704: config: add defaultvalue template keyword

2019-08-02 Thread navaneeth.suresh (Navaneeth Suresh)
navaneeth.suresh added inline comments. navaneeth.suresh marked an inline comment as done. INLINE COMMENTS > durin42 wrote in commands.py:1875 > you almost certainly want `pycompat.bytestr()` here and not `str()` for py3 > compat reasons thanks for the fix and queuing @durin42. REPOSITORY

D6707: revset: drop argument when it's None

2019-08-02 Thread av6 (Anton Shestakov)
av6 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY getstack's definition is `getstack(repo, rev=None)`, so providing None explicitly is unnecessary. Moreover, when x is not None, it's definitely not a revision but a

D6706: stack: remove unnecessary reverse() predicate

2019-08-02 Thread av6 (Anton Shestakov)
av6 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Stack already sorts revisions, so no need to do it twice. This change was a part of D2400 , which didn't land for other

[Bug 6179] New: `hg fix -r .` should update to rewritten commit

2019-08-02 Thread mercurial-bugs
https://bz.mercurial-scm.org/show_bug.cgi?id=6179 Bug ID: 6179 Summary: `hg fix -r .` should update to rewritten commit Product: Mercurial Version: stable branch Hardware: PC OS: Linux Status: UNCONFIRMED

Re: [PATCH 3 of 3 STABLE] bookmarks: actual fix for race condition deleting bookmark

2019-08-02 Thread Pierre-Yves David
I don't see them in any repositories. Did you push them somewhere ? On 8/1/19 8:54 PM, Augie Fackler wrote: queued for stable, thanks On Aug 1, 2019, at 13:55, Pierre-Yves David wrote: # HG changeset patch # User Pierre-Yves David # Date 1561081840 -7200 # Fri Jun 21 03:50:40 2019