mercurial@43141: 11 new changesets

2019-10-09 Thread Mercurial Commits
11 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/c17a63eb5d4c changeset: 43131:c17a63eb5d4c user:Pierre-Yves David date:Sun Oct 06 23:36:51 2019 -0400 summary: sidedata: apply basic but tight security around exchange

D7038: py3: add a missing b'' prefix in test extension for chg

2019-10-09 Thread martinvonz (Martin von Zweigbergk)
Closed by commit rHGcd512f2e076d: py3: add a missing b prefix in test extension for chg (authored by martinvonz). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7038?vs=17030=17036

D7034: fuzz: new target to fuzz jsonescapeu8fast

2019-10-09 Thread durin42 (Augie Fackler)
Closed by commit rHG2b11fe679a5d: fuzz: new target to fuzz jsonescapeu8fast (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7034?vs=16991=17035 CHANGES SINCE

D7033: fuzz: new fuzzer for fncache-related functions

2019-10-09 Thread durin42 (Augie Fackler)
Closed by commit rHGca2ca7fbad44: fuzz: new fuzzer for fncache-related functions (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7033?vs=16990=17034 CHANGES

D7032: fuzz: exercise a little more revlog code

2019-10-09 Thread durin42 (Augie Fackler)
Closed by commit rHGdc827f5aba93: fuzz: exercise a little more revlog code (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7032?vs=16988=17033 CHANGES SINCE

D7031: fuzz: new fuzzer for dirs.c

2019-10-09 Thread durin42 (Augie Fackler)
Closed by commit rHGbd503fdb878c: fuzz: new fuzzer for dirs.c (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7031?vs=16987=17032 CHANGES SINCE LAST ACTION

D7030: dirs: fix trivial over-read of input data

2019-10-09 Thread durin42 (Augie Fackler)
Closed by commit rHG2a0774e9d2a8: dirs: fix trivial over-read of input data (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7030?vs=16986=17031 CHANGES SINCE

D7020: pycompat: implement a shlexquote that properly handles bytes

2019-10-09 Thread indygreg (Gregory Szorc)
indygreg added a comment. indygreg abandoned this revision. Yuya's patch fixed the test failure and is a better solution. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7020/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7020 To: indygreg,

D7038: py3: add a missing b'' prefix in test extension for chg

2019-10-09 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7038 AFFECTED FILES tests/test-chg.t CHANGE DETAILS diff --git a/tests/test-chg.t

D6999: help: categorizing evolve and topic commands

2019-10-09 Thread rdamazio (Rodrigo Damazio Bovendorp)
rdamazio added a comment. rdamazio abandoned this revision. This will be reviewed via heptapod instead REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6999/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6999 To: rdamazio, #hg-reviewers Cc:

D6885: relnotes: mention API change from https://phab.mercurial-scm.org/D6884

2019-10-09 Thread martinvonz (Martin von Zweigbergk)
martinvonz added a comment. In D6885#102923 , @marmoute wrote: > I am a bit confused about this diff, is this still required ? No, I thought it would be helpful to have all the release notes in one place, but I think the consensus was

D6953: sidedatacopies: read rename information from sidedata

2019-10-09 Thread marmoute (Pierre-Yves David)
Closed by commit rHG0171483b082f: sidedatacopies: read rename information from sidedata (authored by marmoute). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial

D6954: sidedatacopies: move various copies related function to the copies modules

2019-10-09 Thread marmoute (Pierre-Yves David)
Closed by commit rHG54e943b28101: sidedatacopies: move various copies related function to the copies modules (authored by marmoute). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review".

D6955: sidedatacopies: deal with upgrading and downgrading to that format

2019-10-09 Thread marmoute (Pierre-Yves David)
Closed by commit rHG843da18386d5: sidedatacopies: deal with upgrading and downgrading to that format (authored by marmoute). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY

D7037: context: make copies related function return None or a valid value

2019-10-09 Thread marmoute (Pierre-Yves David)
Closed by commit rHG4296cc3c4ae1: changelog: make copies related function return None or a valid value (authored by marmoute). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY

D7036: test: fix zstd related output in pure tests

2019-10-09 Thread marmoute (Pierre-Yves David)
Closed by commit rHGea230325dc8c: test: fix zstd related output in pure tests (authored by marmoute). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial CHANGES

D6954: sidedatacopies: move various copies related function to the copies modules

2019-10-09 Thread marmoute (Pierre-Yves David)
marmoute updated this revision to Diff 17024. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6954?vs=17009=17024 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6954/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6954 AFFECTED FILES

D6953: sidedatacopies: read rename information from sidedata

2019-10-09 Thread marmoute (Pierre-Yves David)
marmoute updated this revision to Diff 17023. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6953?vs=17008=17023 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6953/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6953 AFFECTED FILES

D7037: context: make copies related function return None or a valid value

2019-10-09 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY With the previous code, existing but empty value where not "decoded", leading to the method returning one of `None`, some valid value (`list` or `dict`) or

D7036: test: fix zstd related output in pure tests

2019-10-09 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7036 AFFECTED FILES tests/test-upgrade-repo.t CHANGE DETAILS diff --git a/tests/test-upgrade-repo.t

D6943: upgrade: allow for `sidedata` removal

2019-10-09 Thread marmoute (Pierre-Yves David)
marmoute added inline comments. INLINE COMMENTS > martinvonz wrote in test-sidedata.t:74-75 > Looks like this change should be in the parent Actually, the text should says "downgrade from", on my way to fix that REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION

D7035: test: fix a comment in test-side-data.t

2019-10-09 Thread martinvonz (Martin von Zweigbergk)
martinvonz added a comment. Thanks, I've folded this into D6943 REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7035/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7035 To: marmoute, #hg-reviewers Cc:

D6953: sidedatacopies: read rename information from sidedata

2019-10-09 Thread martinvonz (Martin von Zweigbergk)
martinvonz added inline comments. INLINE COMMENTS > marmoute wrote in changelog.py:369-371 > On this side of the discussion, confusion increases I want `None` value to be > preserved (if not relevant now, if will quickly become so). As far as I > understand, `decodefileindices` does not do

D6953: sidedatacopies: read rename information from sidedata

2019-10-09 Thread marmoute (Pierre-Yves David)
marmoute added inline comments. INLINE COMMENTS > martinvonz wrote in changelog.py:369-371 > Actually, both `decodefileindices()` and `decodecopies()` seem to properly > handle the "empty input" case. So I think you can revert this change. As I > suggested earlier, it may be best as a separate

D6953: sidedatacopies: read rename information from sidedata

2019-10-09 Thread martinvonz (Martin von Zweigbergk)
martinvonz added inline comments. INLINE COMMENTS > marmoute wrote in changelog.py:369-371 > Yes, this is to handle `b''` in different way from `None`. Actually, both `decodefileindices()` and `decodecopies()` seem to properly handle the "empty input" case. So I think you can revert this

D6989: push: support config option to require revs be specified when running push

2019-10-09 Thread spectral (Kyle Lippincott)
spectral updated this revision to Diff 17011. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6989?vs=16859=17011 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6989/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6989 AFFECTED FILES

D6954: sidedatacopies: move various copies related function to the copies modules

2019-10-09 Thread marmoute (Pierre-Yves David)
marmoute updated this revision to Diff 17009. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6954?vs=16955=17009 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6954/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6954 AFFECTED FILES

D6953: sidedatacopies: read rename information from sidedata

2019-10-09 Thread marmoute (Pierre-Yves David)
marmoute marked an inline comment as done. marmoute updated this revision to Diff 17008. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6953?vs=16954=17008 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6953/new/ REVISION DETAIL

D6955: sidedatacopies: deal with upgrading and downgrading to that format

2019-10-09 Thread marmoute (Pierre-Yves David)
marmoute updated this revision to Diff 17010. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6955?vs=16956=17010 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6955/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6955 AFFECTED FILES

D6734: git: RFC of a new extension to _directly_ operate on git repositories

2019-10-09 Thread durin42 (Augie Fackler)
durin42 edited the summary of this revision. durin42 updated this revision to Diff 17007. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6734?vs=16858=17007 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6734/new/ REVISION DETAIL

mercurial@43130: 13 new changesets

2019-10-09 Thread Mercurial Commits
13 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/57efd5bd2ca2 changeset: 43118:57efd5bd2ca2 user:Denis Laxalde date:Wed Oct 09 15:28:16 2019 +0200 summary: py3: decode prompt string before calling rawinput

D6953: sidedatacopies: read rename information from sidedata

2019-10-09 Thread marmoute (Pierre-Yves David)
marmoute added inline comments. marmoute marked 3 inline comments as done. INLINE COMMENTS > martinvonz wrote in changelog.py:369-371 > I think you're saying that you changed it in order to handle `rawindices == > b''` correctly. Makes sense. Yes, this is to handle `b''` in different way from

D6953: sidedatacopies: read rename information from sidedata

2019-10-09 Thread marmoute (Pierre-Yves David)
marmoute added inline comments. INLINE COMMENTS > martinvonz wrote in context.py:536-550 > Is there a way of writing `self._repo.filecopiesmode != > b'changeset-sidedata'` in positive way? Maybe `self._repo.filecopiesmode is > None`? The `source != b'changeset-only'` is because we want any >

D6953: sidedatacopies: read rename information from sidedata

2019-10-09 Thread martinvonz (Martin von Zweigbergk)
martinvonz added inline comments. INLINE COMMENTS > marmoute wrote in changelog.py:369-371 > I am confused, the function should return a list or None. Since rawindides > are bytes, they are not eligible for returns. > I updated the code as follow: > > --- a/mercurial/changelog.py > +++

D6953: sidedatacopies: read rename information from sidedata

2019-10-09 Thread marmoute (Pierre-Yves David)
marmoute added inline comments. INLINE COMMENTS > martinvonz wrote in changelog.py:369-371 > I thought the reason you explicitly did `if rawindices is not None` was in > order to not run the next statement if `rawindices` was an empty list. But > that should have no effect anyway, so I was

D6953: sidedatacopies: read rename information from sidedata

2019-10-09 Thread martinvonz (Martin von Zweigbergk)
martinvonz added inline comments. INLINE COMMENTS > marmoute wrote in context.py:536-550 > I think I prefer my version for being a bit more explicite (all `if`s are > positive) and hence easier to read for people new to this code. However, I > don't mind your version if you really want it that

D6953: sidedatacopies: read rename information from sidedata

2019-10-09 Thread marmoute (Pierre-Yves David)
marmoute added inline comments. INLINE COMMENTS > martinvonz wrote in context.py:536-550 > What do you think about writing this as follows? That reduces some of the `if > filesremoved is None: filesremoved = []` duplication. > > filesadded = self._changeset.filesadded > if

D6953: sidedatacopies: read rename information from sidedata

2019-10-09 Thread martinvonz (Martin von Zweigbergk)
martinvonz added inline comments. INLINE COMMENTS > marmoute wrote in changelog.py:369-371 > > I see that you've changed this code to return an empty list of files when > > the list of indices was itself an empty list. > > I dont' follow this sentence. What do you mean ? I thought the reason

D6953: sidedatacopies: read rename information from sidedata

2019-10-09 Thread marmoute (Pierre-Yves David)
marmoute added inline comments. INLINE COMMENTS > martinvonz wrote in changelog.py:369-371 > Calling the list of filenames `rawindices` is misleading. I see that you've > changed this code to return an empty list of files when the list of indices > was itself an empty list. That makes sense.

D6955: sidedatacopies: deal with upgrading and downgrading to that format

2019-10-09 Thread martinvonz (Martin von Zweigbergk)
martinvonz added inline comments. INLINE COMMENTS > copies.py:988 > +sidedata = {} > +if util.safehasattr(revlog, b'filteredrevs'): # this is a changelog > +sidedata = _getsidedata(srcrepo, rev) nit: drop the `b''` here and below REPOSITORY rHG Mercurial CHANGES

D6953: sidedatacopies: read rename information from sidedata

2019-10-09 Thread martinvonz (Martin von Zweigbergk)
martinvonz added inline comments. INLINE COMMENTS > test-copies.t:457-459 > + y -> z (sidedata !) >y -> z (compatibility !) >y -> z (changeset !) nit: combine these into a `no-filelog` case? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION

D6953: sidedatacopies: read rename information from sidedata

2019-10-09 Thread martinvonz (Martin von Zweigbergk)
martinvonz added inline comments. INLINE COMMENTS > context.py:536-550 > filesadded = self._changeset.filesadded > -if True: > +if self._repo.filecopiesmode == b'changeset-sidedata': > +if filesadded is None: > +filesadded = [] > +

D6950: sidedatacopies: write copies information in sidedata when applicable

2019-10-09 Thread marmoute (Pierre-Yves David)
Closed by commit rHGd37361888720: sidedatacopies: write copies information in sidedata when applicable (authored by marmoute). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY

D6951: sidedatacopies: get and store sidedata in the changelogrevision object

2019-10-09 Thread marmoute (Pierre-Yves David)
Closed by commit rHGc42df030a9eb: sidedatacopies: get and store sidedata in the changelogrevision object (authored by marmoute). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY

D6946: sidedatacopies: teach upgrade about the new requirement

2019-10-09 Thread marmoute (Pierre-Yves David)
Closed by commit rHGa329976b0bb5: sidedatacopies: teach upgrade about the new requirement (authored by marmoute). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG

D6945: sidedatacopies: add a new requirement for storing copies into sidedata

2019-10-09 Thread marmoute (Pierre-Yves David)
Closed by commit rHG5f95ad19482a: sidedatacopies: add a new requirement for storing copies into sidedata (authored by marmoute). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY

D6949: sidedatacopies: introduce a sidedata testcase for test-copies-in-changeset.t

2019-10-09 Thread marmoute (Pierre-Yves David)
Closed by commit rHG5a790eac6b1e: sidedatacopies: introduce a sidedata testcase for test-copies-in-changeset.t (authored by marmoute). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review".

D6948: sidedatacopies: introduce a sidedata testcase for test-copies-unrelated.t

2019-10-09 Thread marmoute (Pierre-Yves David)
Closed by commit rHGacdddf0a7a5b: sidedatacopies: introduce a sidedata testcase for test-copies-unrelated.t (authored by marmoute). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review".

D6947: sidedatacopies: introduce a sidedata testcase for test-copies.t

2019-10-09 Thread marmoute (Pierre-Yves David)
Closed by commit rHGffb802948be7: sidedatacopies: introduce a sidedata testcase for test-copies.t (authored by marmoute). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG

D6953: sidedatacopies: read rename information from sidedata

2019-10-09 Thread martinvonz (Martin von Zweigbergk)
martinvonz added inline comments. INLINE COMMENTS > changelog.py:369-371 > +if rawindices is not None: > +rawindices = decodefileindices(self.files, rawindices) > +return rawindices Calling the list of filenames `rawindices` is misleading. I see that you've changed

D6951: sidedatacopies: get and store sidedata in the changelogrevision object

2019-10-09 Thread martinvonz (Martin von Zweigbergk)
martinvonz added inline comments. INLINE COMMENTS > marmoute wrote in changelog.py:618-624 > Is a followup good enough for you ? Yes, even leaving it inconsistent is good enough for me :) I don't care that much REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION

D6952: sidedatacopies: preindent some copies related code

2019-10-09 Thread marmoute (Pierre-Yves David)
marmoute added a comment. In D6952#103223 , @martinvonz wrote: > I personally don't think this type of patch is needed -- Phabricator makes it very readable anyway (and there is `hg diff --ignore-space-change` for others). I'm sure some

D6951: sidedatacopies: get and store sidedata in the changelogrevision object

2019-10-09 Thread marmoute (Pierre-Yves David)
marmoute added inline comments. INLINE COMMENTS > martinvonz wrote in changelog.py:618-624 > nit: inconsistent way of calling the `changelogrevision` constructor between > these two call sites Is a followup good enough for you ? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION

D6952: sidedatacopies: preindent some copies related code

2019-10-09 Thread martinvonz (Martin von Zweigbergk)
martinvonz added a comment. I personally don't think this type of patch is needed -- Phabricator makes it very readable anyway (and there is `hg diff --ignore-space-change` for others). I'm sure some people disagree with me. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION

D6951: sidedatacopies: get and store sidedata in the changelogrevision object

2019-10-09 Thread martinvonz (Martin von Zweigbergk)
martinvonz added inline comments. INLINE COMMENTS > changelog.py:618-624 > +c = changelogrevision(*self._revisiondata(node)) > return (c.manifest, c.user, c.date, c.files, c.description, c.extra) > > def changelogrevision(self, nodeorrev): > """Obtain a

D7035: test: fix a comment in test-side-data.t

2019-10-09 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Small sentence adjustement. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7035 AFFECTED FILES tests/test-sidedata.t CHANGE

D6944: debugsidedata: small doc improvement

2019-10-09 Thread marmoute (Pierre-Yves David)
Closed by commit rHGadc6bebfd08e: debugsidedata: small doc improvement (authored by marmoute). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial CHANGES SINCE

D6939: sidedata: apply basic but tight security around exchange

2019-10-09 Thread marmoute (Pierre-Yves David)
Closed by commit rHGc17a63eb5d4c: sidedata: apply basic but tight security around exchange (authored by marmoute). marmoute marked an inline comment as done. This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state

D6943: upgrade: allow for `sidedata` removal

2019-10-09 Thread marmoute (Pierre-Yves David)
Closed by commit rHG1b4fd93cd79a: upgrade: allow for `sidedata` removal (authored by marmoute). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". CHANGED PRIOR TO COMMIT

D6942: upgrade: allow upgrade to repository using sidedata

2019-10-09 Thread marmoute (Pierre-Yves David)
Closed by commit rHG75ad8af9c95e: upgrade: allow upgrade to repository using sidedata (authored by marmoute). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial

D6941: revlog: add a way to control sidedata changes during revlog.clone

2019-10-09 Thread marmoute (Pierre-Yves David)
Closed by commit rHG3de4d13f22be: revlog: add a way to control sidedata changes during revlog.clone (authored by marmoute). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY

D6940: sidedata: use only changegroup3 if sidedata is in use

2019-10-09 Thread marmoute (Pierre-Yves David)
Closed by commit rHG8f807a83d53b: sidedata: use only changegroup3 if sidedata is in use (authored by marmoute). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial

D6943: upgrade: allow for `sidedata` removal

2019-10-09 Thread marmoute (Pierre-Yves David)
marmoute updated this revision to Diff 16992. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6943?vs=16989=16992 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6943/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6943 AFFECTED FILES

D7034: fuzz: new target to fuzz jsonescapeu8fast

2019-10-09 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This code just feels complicated enough we should go ahead and give it a dedicated fuzzer: we've found bugs in similar things before. REPOSITORY rHG

D7033: fuzz: new fuzzer for fncache-related functions

2019-10-09 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Not all of these are strictly fncache-related, but they all have th same signature and similar-enough behavior that we may as well fuzz them together.

mercurial@43117: 7 new changesets

2019-10-09 Thread Mercurial Commits
7 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/e5d535621ee1 changeset: 43111:e5d535621ee1 user:Augie Fackler date:Tue Oct 08 13:38:02 2019 -0400 summary: infinitepush: mark extension as likely to be deleted

D6943: upgrade: allow for `sidedata` removal

2019-10-09 Thread marmoute (Pierre-Yves David)
marmoute marked an inline comment as done. marmoute updated this revision to Diff 16989. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6943?vs=16947=16989 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6943/new/ REVISION DETAIL

D7025: rewriteutil: add configurable check to disallow obsoleting someone else cset

2019-10-09 Thread marmoute (Pierre-Yves David)
marmoute added a comment. This should probably be controled by a config option instead of a keyword argument to this function (we want the control of this to be unified) I would prefer a prompt than an abort. We talked about the pre-checking topic with Sushil on Sunday. The result

D7032: fuzz: exercise a little more revlog code

2019-10-09 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7032 AFFECTED FILES contrib/fuzz/revlog.cc CHANGE DETAILS diff --git a/contrib/fuzz/revlog.cc

D7031: fuzz: new fuzzer for dirs.c

2019-10-09 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This found a six-year-old bug immediately, and then I put it through a few CPU-days of time before sending it. REPOSITORY rHG Mercurial REVISION DETAIL

D7030: dirs: fix trivial over-read of input data

2019-10-09 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This code, introduced in 8c0a7eeda06d , was intentionally over-reading an input

Re: [PATCH 2 of 2] py3: flush ui after each message in interactive patch filtering

2019-10-09 Thread Pulkit Goyal
On Wed, Oct 9, 2019 at 4:42 PM Denis Laxalde wrote: > > # HG changeset patch > # User Denis Laxalde > # Date 1570627454 -7200 > # Wed Oct 09 15:24:14 2019 +0200 > # Node ID 0cdeb24af4076eae433de3f63fda36da4e6fc0d0 > # Parent 99f06850be3ecc521ba461684686865c1191c5a0 > py3: flush ui after

Re: [PATCH 2 of 2] py3: flush ui after each message in interactive patch filtering

2019-10-09 Thread Yuya Nishihara
On Wed, 09 Oct 2019 15:29:24 +0200, Denis Laxalde wrote: > # HG changeset patch > # User Denis Laxalde > # Date 1570627454 -7200 > # Wed Oct 09 15:24:14 2019 +0200 > # Node ID 0cdeb24af4076eae433de3f63fda36da4e6fc0d0 > # Parent 99f06850be3ecc521ba461684686865c1191c5a0 > py3: flush ui after

Re: [PATCH 1 of 2] py3: decode prompt string before calling rawinput

2019-10-09 Thread Pulkit Goyal
On Wed, Oct 9, 2019 at 4:38 PM Denis Laxalde wrote: > > # HG changeset patch > # User Denis Laxalde > # Date 1570627696 -7200 > # Wed Oct 09 15:28:16 2019 +0200 > # Node ID 99f06850be3ecc521ba461684686865c1191c5a0 > # Parent 1fcf79e9943a17a2e7ae19954b2b5ad5972f8fff > py3: decode prompt

Re: [PATCH 01 of 13] perf: document `perfstatus`

2019-10-09 Thread Pulkit Goyal
On Tue, Oct 8, 2019 at 8:16 PM Pierre-Yves David wrote: > > # HG changeset patch > # User Pierre-Yves David > # Date 1570511728 14400 > # Tue Oct 08 01:15:28 2019 -0400 > # Node ID 8d066f6d8a5716e88812487d7d1c7db2808bb9bb > # Parent 9002f4a3dde63518d1467f3934a1fe226f3b2297 > # EXP-Topic

Re: [PATCH 08 of 13] perf: document `perfdirfoldmap`

2019-10-09 Thread Pierre-Yves David
On 10/9/19 4:19 PM, Pulkit Goyal wrote: On Tue, Oct 8, 2019 at 8:45 PM Pierre-Yves David wrote: # HG changeset patch # User Pierre-Yves David # Date 1570513758 14400 # Tue Oct 08 01:49:18 2019 -0400 # Node ID 8a6ad5abbf29c925d1b2610714f9e68df1bbc8e1 # Parent

Re: [PATCH 08 of 13] perf: document `perfdirfoldmap`

2019-10-09 Thread Pulkit Goyal
On Tue, Oct 8, 2019 at 8:45 PM Pierre-Yves David wrote: > > # HG changeset patch > # User Pierre-Yves David > # Date 1570513758 14400 > # Tue Oct 08 01:49:18 2019 -0400 > # Node ID 8a6ad5abbf29c925d1b2610714f9e68df1bbc8e1 > # Parent 701f359a9899d1a8b2cafea2aadc1f667dacd385 > # EXP-Topic

D6987: strip: move strip extension to core as debugstrip

2019-10-09 Thread pulkit (Pulkit Goyal)
pulkit added inline comments. INLINE COMMENTS > strip.py:3 > > -This extension allows you to strip changesets and all their descendants from > the > -repository. See the command help for details. > +strip extension has been renamed to debugstrip and moved to core. However, > +this extension

[PATCH 2 of 2] py3: flush ui after each message in interactive patch filtering

2019-10-09 Thread Denis Laxalde
# HG changeset patch # User Denis Laxalde # Date 1570627454 -7200 # Wed Oct 09 15:24:14 2019 +0200 # Node ID 0cdeb24af4076eae433de3f63fda36da4e6fc0d0 # Parent 99f06850be3ecc521ba461684686865c1191c5a0 py3: flush ui after each message in interactive patch filtering Otherwise, actions from

[PATCH 1 of 2] py3: decode prompt string before calling rawinput

2019-10-09 Thread Denis Laxalde
# HG changeset patch # User Denis Laxalde # Date 1570627696 -7200 # Wed Oct 09 15:28:16 2019 +0200 # Node ID 99f06850be3ecc521ba461684686865c1191c5a0 # Parent 1fcf79e9943a17a2e7ae19954b2b5ad5972f8fff py3: decode prompt string before calling rawinput Calling input() (aka pycompat.rawinput()

D7029: py3: delete b'' prefix from safehasattr arguments

2019-10-09 Thread martinvonz (Martin von Zweigbergk)
Closed by commit rHG4aa72cdf616f: py3: delete b prefix from safehasattr arguments (authored by martinvonz). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7029?vs=16980=16983

D7027: debugcommands: add a few more writenoi18n()

2019-10-09 Thread martinvonz (Martin von Zweigbergk)
Closed by commit rHGdefabf63e969: debugcommands: add a few more writenoi18n() (authored by martinvonz). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7027?vs=16978=16984 CHANGES

[Bug 6199] New: i have problem when use hg update

2019-10-09 Thread mercurial-bugs
https://bz.mercurial-scm.org/show_bug.cgi?id=6199 Bug ID: 6199 Summary: i have problem when use hg update Product: Mercurial Version: unspecified Hardware: PC OS: Windows Status: UNCONFIRMED Severity: