D7506: phabricator: add a "phabstatus" show view

dlax added a comment. In D7506#111947 , @spectral wrote: > I don't think `from . import show` works generally. I did that because `test-check-module-imports.t` complained otherwise when using `from hgext import show`:

D7595: status: outputting structured unfinished-operation information

rdamazio edited the summary of this revision. rdamazio marked an inline comment as done. rdamazio updated this revision to Diff 18625. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7595?vs=18588=18625 BRANCH default CHANGES SINCE LAST ACTION

D7608: phabricator: color the status in the "phabstatus" view

mharbison72 created this revision. Herald added subscribers: mercurial-devel, Kwan. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I couldn't figure out strikethrough for "abandoned" like I've see with word diff. REPOSITORY rHG Mercurial REVISION DETAIL

D7607: phabricator: add the "Changes Planned" status name

mharbison72 created this revision. Herald added subscribers: mercurial-devel, Kwan. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I noticed this when coloring the status output. But it looks like status names are also used in the pseudo revset language as well, and abort when

D7506: phabricator: add a "phabstatus" show view

spectral added a comment. I don't think `from . import show` works generally. I received errors because I imported phabricator via a path (pointing directly at the .py file, something like `[extensions] phabricator = /home/spectral/src/hg/hgext/phabricator.py`), not by doing something like

D7606: fuzz: fix mpatch_corpus to not have an overridden __repr__ on py3

spectral created this revision. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D7606 AFFECTED FILES contrib/fuzz/mpatch_corpus.py CHANGE DETAILS diff

D7550: chg: fix chg to work with py3.7+ "coercing" the locale

spectral added a comment. In D7550#111235 , @yuja wrote: >> When the environment is empty (specifically: it doesn't contain LC_ALL, >> LC_CTYPE, or LANG), Python will "coerce" the locale environment variables to be >> a UTF-8 capable

D7517: filemerge: byteify the open() mode

mharbison72 added a comment. In D7517#111885 , @durin42 wrote: > I'm a little fuzzy on this: should I see some test failures? or...? It looks like not. I glossed over the fact that `pycompat.sysstr()` will simply return `str` if given

D7594: status: add template/json data about whether a file has unresolved conflicts

rdamazio added inline comments. INLINE COMMENTS > martinvonz wrote in cmdutil.py:792 > That's an O(n) lookup. Probably fine since you very rarely have thousands of > conflicts... Yes, I thought of storing it as a set, but then thought that it either didn't matter or would be slower because

mercurial@43847: new changeset

New changeset in mercurial: https://www.mercurial-scm.org/repo/hg/rev/49fa0b31ee1d changeset: 43847:49fa0b31ee1d bookmark:@ tag: tip user:Georges Racinet date:Thu Dec 05 20:41:23 2019 +0100 summary: cext-revlog: fixed __delitem__ for uninitialized nodetree --

[Bug 6239] New: qrefresh exclude option does not use regex

https://bz.mercurial-scm.org/show_bug.cgi?id=6239 Bug ID: 6239 Summary: qrefresh exclude option does not use regex Product: Mercurial Version: unspecified Hardware: All OS: Linux Status: UNCONFIRMED

mercurial@43846: 2 new changesets

2 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/1ffbd03c8d75 changeset: 43845:1ffbd03c8d75 user:Matt Harbison date:Wed Nov 20 13:01:56 2019 -0500 summary: filemerge: drop a default argument to appease pytype

D7603: cext-revlog: fixed __delitem__ for uninitialized nodetree

Closed by commit rHG49fa0b31ee1d: cext-revlog: fixed __delitem__ for uninitialized nodetree (authored by gracinet). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG

D7522: rust-dirs: handle forgotten `Result`s

martinvonz added inline comments. INLINE COMMENTS > dirstate_map.rs:355 > > assert_eq!(false, map.has_dir(HgPath::new(b"nope"))); > assert!(map.all_dirs.is_some()); Have to update at this test and probably others REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION

mercurial@43844: 21 new changesets

21 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/a6483107a07a changeset: 43824:a6483107a07a user:Augie Fackler date:Thu Dec 05 16:18:44 2019 -0500 summary: annotate: describe --skip as taking a revset

D7465: filemerge: fix a missing attribute usage

Closed by commit rHGd5ce99a6db52: filemerge: fix a missing attribute usage (authored by mharbison72). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial CHANGES

D7464: filemerge: drop a default argument to appease pytype

Closed by commit rHG1ffbd03c8d75: filemerge: drop a default argument to appease pytype (authored by mharbison72). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG

D7604: rust-hg-path: implement more readable custom Debug for HgPath{, Buf}

martinvonz added inline comments. INLINE COMMENTS > kevincox wrote in hg_path.rs:186 > I would recommend `"HgPath({:?})"` so that the result is unambiguous and > nicely escaped. Good point. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7604/new/

D7604: rust-hg-path: implement more readable custom Debug for HgPath{, Buf}

martinvonz marked an inline comment as done. martinvonz updated this revision to Diff 18618. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7604?vs=18616=18618 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7604/new/

D7605: formatting: fix some recent formatting regressions

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D7605 AFFECTED FILES contrib/fuzz/mpatch_corpus.py mercurial/cmdutil.py CHANGE

D7604: rust-hg-path: implement more readable custom Debug for HgPath{, Buf}

kevincox added inline comments. kevincox accepted this revision. INLINE COMMENTS > hg_path.rs:186 > +fn fmt(, f: fmt::Formatter<'_>) -> fmt::Result { > +write!(f, "HgPath({})", String::from_utf8_lossy()) > +} I would recommend `"HgPath({:?})"` so that the result is unambiguous

D7604: rust-hg-path: implement more readable custom Debug for HgPath{, Buf}

martinvonz created this revision. Herald added subscribers: mercurial-devel, kevincox, durin42. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The default prints the vector of bytes as a list of integers. I considered instead getting rid of the Debug trait, but we use the Debug

D7570: match: resolve filesets against the passed `cwd`, not the current one

martinvonz added a comment. In D7570#111892 , @durin42 wrote: > I'm happy with this, but didn't spend time figuring out if all concerns have been addressed (I'm mostly doing a fast triage path). I *think* they're addressed, but we there's

D7575: hg-core: vendor Facebook's configparser crate

durin42 added inline comments. INLINE COMMENTS > Alphare wrote in c_api.rs:1 > Do we need bindings to C ? I don't see what the use-case is at this stage of > the Rust development. +1, I'm not sure what the use case for this would be in core. REPOSITORY rHG Mercurial CHANGES SINCE LAST

D7522: rust-dirs: handle forgotten `Result`s

durin42 added a comment. durin42 resigned from this revision. This needs a rebase that I'm not sure I can accomplish correctly. Could you take a look? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7522/new/ REVISION DETAIL

D7570: match: resolve filesets against the passed `cwd`, not the current one

This revision is now accepted and ready to land. durin42 added a comment. durin42 accepted this revision. I'm happy with this, but didn't spend time figuring out if all concerns have been addressed (I'm mostly doing a fast triage path). REPOSITORY rHG Mercurial BRANCH default CHANGES

D7595: status: outputting structured unfinished-operation information

durin42 added inline comments. INLINE COMMENTS > rdamazio wrote in configitems.py:247 > I'm fine with removing the config option, but will let yuja reply first. > About being BC or not - it depends on how people are parsing the JSON output > :) If they're either turning off morestatus for

D7517: filemerge: byteify the open() mode

durin42 added a comment. I'm a little fuzzy on this: should I see some test failures? or...? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7517/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7517 To: mharbison72, #hg-reviewers Cc: durin42,

D7590: remotefilelog: remove the `ensurestart` usage

Closed by commit rHG612b4b63fb22: remotefilelog: remove the `ensurestart` usage (authored by marmoute). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial CHANGES

D7589: remotefilelog: remove most of the debugwait* command in the tests

Closed by commit rHG4f40dc190f63: remotefilelog: remove most of the debugwait* command in the tests (authored by marmoute). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D7587: remotefilelog: remove most sleep in tests

Closed by commit rHGfac25de8cbec: remotefilelog: remove most sleep in tests (authored by marmoute). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7587?vs=18552=18612 CHANGES SINCE

D7586: remotefilelog: have command wait for background task in the tests

Closed by commit rHG88ab1295db4c: remotefilelog: have command wait for background task in the tests (authored by marmoute). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D7585: remotefilelog: add a developer option to wait for background processes

Closed by commit rHG63bb6dc62f24: remotefilelog: add a developer option to wait for background processes (authored by marmoute). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY

D7588: remotefilelog: use the correct redirection in tests

Closed by commit rHGb6c7475595db: remotefilelog: use the correct redirection in tests (authored by marmoute). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7588?vs=18553=18613

D7584: procutil: add a option to not fully detach background process

Closed by commit rHG15a6c6783060: procutil: add a option to not fully detach background process (authored by marmoute). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG

D7529: rust-dirstate-status: add `walk_explicit` implementation, use `Matcher` trait

martinvonz added a comment. This no longer applies cleanly (and doesn't build when applied with fuzz) REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7529/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7529 To: Alphare, #hg-reviewers, kevincox

mercurial@43823: 5 new changesets

5 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/e8a3bbffdc7d changeset: 43819:e8a3bbffdc7d user:Gregory Szorc date:Sat Dec 07 13:07:25 2019 -0800 summary: tests: add test for Rust formatting https://www.mercurial-scm.org/repo/hg/rev/072b745936f1

D7594: status: add template/json data about whether a file has unresolved conflicts

martinvonz added inline comments. INLINE COMMENTS > cmdutil.py:792 > +def formatfile(self, path, fm): > +if self.inmergestate and path in self.unresolvedpaths: > +fm.data(unresolved=True) That's an O(n) lookup. Probably fine since you very rarely have thousands of

Re: [PATCH 1 of 2] crecord: repurpose "a" key to toggle all selections (BC)

On Wed, 2019-12-11 at 10:41 +0100, Denis Laxalde wrote: Jordi Gutiérrez Hermoso a écrit : > > # HG changeset patch > > # User Jordi Gutiérrez Hermoso > > # Date 1576015329 18000 > > # Tue Dec 10 17:02:09 2019 -0500 > > # Node ID bd10bc4bdb994b875040c0c58f1c341df66ddd46 > > # Parent

D7601: fuzz: fix test-fuzz-targets.t to run with python3

pulkit added inline comments. INLINE COMMENTS > mharbison72 wrote in mpatch_corpus.py:53 > Doesn't `__repr__` have to return `str` on py3? It looks like there are few > other instances of this. ha, yep. @spectral can you send a follow-up for this? REPOSITORY rHG Mercurial CHANGES SINCE

[PATCH 2 of 2 V2] crecord: remove toggleamend

# HG changeset patch # User Jordi Gutiérrez Hermoso # Date 1576015629 18000 # Tue Dec 10 17:07:09 2019 -0500 # Node ID 80c8a53c2fcc2aeb510f60fee74ab25b68d59a15 # Parent 5b6b8f718cbfc70202537aa38f0179cb6f8275a8 crecord: remove toggleamend Previous commit removed its only calling site. diff

[PATCH 1 of 2 V2] crecord: repurpose "a" key to toggle all selections (BC)

# HG changeset patch # User Jordi Gutiérrez Hermoso # Date 1576015329 18000 # Tue Dec 10 17:02:09 2019 -0500 # Node ID 5b6b8f718cbfc70202537aa38f0179cb6f8275a8 # Parent ce088b38f92b6d480df2072dc45fb068443758dd crecord: repurpose "a" key to toggle all selections (BC) I really don't like

D7601: fuzz: fix test-fuzz-targets.t to run with python3

mharbison72 added inline comments. INLINE COMMENTS > mpatch_corpus.py:53 > +# py2 calls __repr__ when you do `bytes(foo)` > +return self.__bytes__() > + Doesn't `__repr__` have to return `str` on py3? It looks like there are few other instances of this. REPOSITORY rHG

D7570: match: resolve filesets against the passed `cwd`, not the current one

mharbison72 added a comment. In D7570#111783 , @martinvonz wrote: > In D7570#111295 , @yuja wrote: > >>> if listsubrepos: >>> for subpath in ctx.substate: >>> >>> - sm =

D7593: status: split morestatus data loading from display

Closed by commit rHGfb4a6d584756: status: split morestatus data loading from display (authored by rdamazio). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7593?vs=18586=18605

D7594: status: add template/json data about whether a file has unresolved conflicts

Closed by commit rHG7315464f0613: status: add template/json data about whether a file has unresolved conflicts (authored by rdamazio). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D7600: fuzz: add a seed corpus for the dirs fuzzer

Closed by commit rHGb7af8a02a304: fuzz: add a seed corpus for the dirs fuzzer (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7600?vs=18594=18608 CHANGES

D7599: fuzz: clean up production of seed corpora

Closed by commit rHGd74d78aa74e9: fuzz: clean up production of seed corpora (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7599?vs=18593=18607 CHANGES SINCE

D7506: phabricator: add a "phabstatus" show view

Closed by commit rHG70060915c3f2: phabricator: add a phabstatus show view (authored by dlax). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7506?vs=18589=18603 CHANGES SINCE LAST

D7507: phabricator: add a "phabstatus" template keyword

Closed by commit rHG79c0121220e3: phabricator: add a phabstatus template keyword (authored by dlax). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7507?vs=18590=18604 CHANGES

D7597: dirs: fix out-of-bounds access in Py3

Closed by commit rHGa47ccdcce4f9: dirs: fix out-of-bounds access in Py3 (authored by martinvonz). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7597?vs=18591=18602 CHANGES SINCE

D7602: manifestcache: add some test involving shares

Closed by commit rHG8377570a36a9: manifestcache: add some test involving shares (authored by marmoute). This revision was automatically updated to reflect the committed changes. CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D7602?vs=18597=18601#toc REPOSITORY rHG Mercurial CHANGES

D7601: fuzz: fix test-fuzz-targets.t to run with python3

Closed by commit rHGba84a1ae4ae5: fuzz: fix test-fuzz-targets.t to run with python3 (authored by spectral). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7601?vs=18595=18600

D7598: py3: fix a bytes vs str issue in remotefilelog extension

Closed by commit rHG94670e124d29: py3: fix a bytes vs str issue in remotefilelog extension (authored by spectral). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7598?vs=18592=18599

D7603: cext-revlog: fixed __delitem__ for uninitialized nodetree

gracinet created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is a bug in a code path that's seldom used, because in practice (at least in the whole test suite), calls to `del index[i:j]` currently just don't happen

D7586: remotefilelog: have command wait for background task in the tests

marmoute added a comment. For those who wants to see the test misbehaving, your just need to run it in a loop on heavy load: `python run-tests.py --runs-per-test 1 --loop -j 90 test-remotefilelog-bgprefetch.t` REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION

D7602: manifestcache: add some test involving shares

marmoute created this revision. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Some issue around shares have been reported. I am adding tests to better cover the share case. The test show that the code behave as expected so far.

Re: [PATCH 1 of 2] crecord: repurpose "a" key to toggle all selections (BC)

Jordi Gutiérrez Hermoso a écrit : > # HG changeset patch > # User Jordi Gutiérrez Hermoso > # Date 1576015329 18000 > # Tue Dec 10 17:02:09 2019 -0500 > # Node ID bd10bc4bdb994b875040c0c58f1c341df66ddd46 > # Parent ce088b38f92b6d480df2072dc45fb068443758dd > crecord: repurpose "a" key to

D7528: rust-matchers: add `FileMatcher` implementation

Alphare added inline comments. INLINE COMMENTS > martinvonz wrote in matchers.rs:136 > It would be slightly simpler if the paths were owned. It doesn't seem too > expensive to take ownership of the paths. Do we have any call sites in this > series that we can look at? There is a single call

D7526: rust-hg-path: add method to get part of a path relative to a prefix

Alphare added inline comments. INLINE COMMENTS > martinvonz wrote in hg_path.rs:438 > The argument order here feels backwards. I know some frameworks (like Java's > JUnit) put the expected value first, but the definition of `assert_eq!` > doesn't seem to have any opinion and >

D7531: rust-matchers: add support for `explicitmatcher` in `dirstate.status`

Alphare added a comment. Yes, I meant `exactmatcher` indeed. `FileMatcher` is meant for the Rust side of things, I do not intend to rename it in Python because it is a minor change that would make a lot of noise for bikeshedding. Do you think that would be a good idea? REPOSITORY rHG

D7118: rust-dirstatemap: remove additional lookups in traverse

Alphare added a comment. In D7118#111735 , @martinvonz wrote: > What's the state of this patch? The description makes it sound like it's a Rust patch, but it only modifies Python code. It only impacts the rust module policy, I figured