D7914: rust-matchers: implement `visit_children_set` for `FileMatcher`

martinvonz added inline comments. INLINE COMMENTS > matchers.rs:166 > } > fn visit_children_set( > , This will often be called repeatedly, so isn't it better to calculate a map of each parent directory to its `VisitChildrenSet` value upfront (in `FilesMatcher::new()`)?

D7894: nodemap: introduce an option to use mmap to read the nodemap mapping

martinvonz added a comment. How much does this patch help performance? I would also like to see performance numbers (even just rough ones) for the Rust version. Sorry about a possibly stupid question, but why will this on-disk nodemap be faster than building it from the index? Is it

D7886: nodemap: introduce append-only incremental update of the persisten data

martinvonz added inline comments. INLINE COMMENTS > test-persistent-nodemap.t:53 > + > +(The pure code use the debug code that perform incremental update, the C > code reencode from scratch) > + Which patch introduced the C code? I have not looked at all patches yet, but I thought the idea

D7834: nodemap: have some python code serializing a nodemap

martinvonz added inline comments. INLINE COMMENTS > debugcommands.py:2084 > +) > +def debugnodemap(ui, repo, **args): > +"""write and inspect on disk nodemap could you also rename `args` to `opts`? or is there a reason to not follow the same convention we follow everywhere (?) else?

D7732: convert: refactor authormap into separate function for outside use

joerg.sonnenberger updated this revision to Diff 19398. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7732?vs=19035=19398 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7732/new/ REVISION DETAIL

D7920: tests: restore phabricator tests and regenerate the recordings

mharbison72 created this revision. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: hg-reviewers. REVISION SUMMARY These contain the new API chatter. Most of the changes are because some new commits were created, but they're pretty obviously equivalent. I have

D7913: cext: fix compiler warning about sign changing

mharbison72 added a comment. mharbison72 accepted this revision. LGTM REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7913/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7913 To: spectral, #hg-reviewers, mharbison72 Cc: mharbison72,

D7919: create comment for phabricator test

mharbison72 added a comment. mharbison72 abandoned this revision. Noise from regenerating the phabricator recordings. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7919/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7919 To: mharbison72,

D7918: create draft change for phabricator testing

mharbison72 added a comment. mharbison72 abandoned this revision. Noise from regenerating the phabricator recordings. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7918/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7918 To: mharbison72,

D7917: create public change for phabricator testing

mharbison72 added a comment. mharbison72 abandoned this revision. Noise from regenerating the phabricator recordings. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7917/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7917 To: mharbison72,

D7916: create beta for phabricator test

mharbison72 added a comment. mharbison72 abandoned this revision. Noise from regenerating the phabricator recordings. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7916/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7916 To: mharbison72,

D7915: create alpha for phabricator test €

mharbison72 added a comment. mharbison72 abandoned this revision. Noise from regenerating the phabricator recordings. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7915/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7915 To: mharbison72,

D7919: create comment for phabricator test

mharbison72 added a comment. mharbison72 updated this revision to Diff 19396. Address review comments REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7919?vs=19395=19396 BRANCH default CHANGES SINCE LAST ACTION

D7919: create comment for phabricator test

mharbison72 created this revision. mharbison72 added a comment. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. For default branch REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D7919 AFFECTED FILES comment

D7918: create draft change for phabricator testing

mharbison72 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D7918 AFFECTED FILES alpha CHANGE DETAILS diff --git a/alpha b/alpha ---

D7917: create public change for phabricator testing

mharbison72 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D7917 AFFECTED FILES beta CHANGE DETAILS diff --git a/beta b/beta --- a/beta

D7916: create beta for phabricator test

mharbison72 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D7916 AFFECTED FILES beta CHANGE DETAILS diff --git a/beta b/beta new file mode

D7915: create alpha for phabricator test €

mharbison72 updated this revision to Diff 19391. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7915?vs=19390=19391 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7915/new/ REVISION DETAIL

D7915: create alpha for phabricator test €

mharbison72 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D7915 AFFECTED FILES alpha CHANGE DETAILS diff --git a/alpha b/alpha new file

D7903: sha1dc: avoid including the nonexistent stdint.h with Visual Studio 2008

mharbison72 updated this revision to Diff 19389. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7903?vs=19339=19389 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7903/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7903 AFFECTED

D7914: rust-matchers: implement `visit_children_set` for `FileMatcher`

Alphare updated this revision to Diff 19388. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7914?vs=19387=19388 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7914/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7914

D7834: nodemap: have some python code serializing a nodemap

martinvonz added inline comments. INLINE COMMENTS > marmoute wrote in nodemap.py:112-118 > no, we need the value of block to be updated after each iteration otherwise > the next iteration would not descend to the level it just created. The test case still passes with that change, though

D7914: rust-matchers: implement `visit_children_set` for `FileMatcher`

Alphare created this revision. Herald added subscribers: mercurial-devel, kevincox, durin42. Herald added a reviewer: hg-reviewers. REVISION SUMMARY As per the removed inline comment, this will become useful in a future patch in this series as the `IncludeMatcher` is introduced. REPOSITORY

D7177: rebase: introduce optional parent mapping

martinvonz added a comment. I personally haven't queued this yet because I don't really like the UI. Some things I recently worked on made me realize that `hg graft` doesn't currently preserve merges, but we could probably easily add a `--preserve-merges` option to it, so `hg co D; hg graft

D7834: nodemap: have some python code serializing a nodemap

marmoute added inline comments. INLINE COMMENTS > martinvonz wrote in nodemap.py:112-118 > Would it work to replace these lines by the following? > > new = {} > block[_to_int(current_hex[level])] = new > _insert_into_block(index, level + 1, new, other_rev, other_hex) >

D7910: rust-re2: add wrapper for calling Re2 from Rust

Alphare marked an inline comment as done. Alphare updated this revision to Diff 19386. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7910?vs=19360=19386 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7910/new/ REVISION

D7909: rust-filepatterns: add support for `include` and `subinclude` patterns

Alphare retitled this revision from "rust-filepatterns: add support for `ignore` and `subignore` patterns" to "rust-filepatterns: add support for `include` and `subinclude` patterns". Alphare marked an inline comment as done. Alphare updated this revision to Diff 19385. REPOSITORY rHG

D7908: rust-filepatterns: improve API and robustness for pattern files parsing

Alphare updated this revision to Diff 19384. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7908?vs=19356=19384 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7908/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7908

D7869: rust-dirs-multiset: add `DirsChildrenMultiset`

Alphare updated this revision to Diff 19383. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7869?vs=19358=19383 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7869/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7869

D7867: rust-hg-path: add useful methods to `HgPath`

Alphare updated this revision to Diff 19382. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7867?vs=19352=19382 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7867/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7867

D7912: py3: fix curses chunkselector fallback (when diffs are too large) on py3

Closed by commit rHG19533e4c3450: py3: fix curses chunkselector fallback (when diffs are too large) on py3 (authored by spectral). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review".

D7834: nodemap: have some python code serializing a nodemap

This revision now requires changes to proceed. martinvonz added inline comments. martinvonz requested changes to this revision. INLINE COMMENTS > nodemap.py:47-49 > +def persistent_data(index): > +"""return the serialised data of a nodemap for a given index > +""" nit: call it

mercurial@44097: new changeset

New changeset in mercurial: https://www.mercurial-scm.org/repo/hg/rev/2f1d6180737f changeset: 44097:2f1d6180737f bookmark:@ tag: tip user:Pierre-Yves David date:Wed Jan 15 15:47:03 2020 +0100 summary: transaction: allow finalizer to add finalizer -- Repository

Re: Nlnet funding for transitioning out of SHA-1

> On Jan 15, 2020, at 11:53, Raphaël Gomès wrote: > > Hello all, > > As you all know, we have to transition out of using SHA-1 for Mercurial > (https://www.mercurial-scm.org/wiki/SHA1TransitionPlan). While a known > mitigation has been introduced by a few of Augie's patches, we still have

D7913: cext: fix compiler warning about sign changing

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY line.len is a Py_ssize_t, and we're casing to size_t (unsigned). On my compiler, this causes a warning to be emitted: mercurial/cext/manifest.c: In

D7908: rust-filepatterns: improve API and robustness for pattern files parsing

kevincox added inline comments. INLINE COMMENTS > Alphare wrote in filepatterns.rs:237 > I might be using godbolt wrong but it looks like you are using different > versions of rustc. When using 1.40 for both sides, I don't see any clear win > on either side... but I'm not fluent in assembly

D7912: py3: fix curses chunkselector fallback (when diffs are too large) on py3

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Previously we showed the message using Exception.message, which is removed in py3. Since crecordmod.fallbackerror inherits from error.Abort, we can just use

D7908: rust-filepatterns: improve API and robustness for pattern files parsing

Alphare added inline comments. Alphare marked 2 inline comments as done. INLINE COMMENTS > kevincox wrote in filepatterns.rs:237 > If you think it' is clearer that's fine. But I'm curious where "Rust might > optimize iterators better than for loops" comes from. I did a quick test and > it

D7909: rust-filepatterns: add support for `ignore` and `subignore` patterns

kevincox added inline comments. INLINE COMMENTS > Alphare wrote in filepatterns.rs:462 > The `match` arms would be incompatible. Or maybe I'm missing something. You would have to make sure you return a Vec on both arms. You will probably want `inner_pats.into_iter().collect()` on one branch

mercurial@44096: 9 new changesets

9 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/b3ec1ea95ee6 changeset: 44088:b3ec1ea95ee6 user:Aay Jay Chan date:Thu Jan 16 00:30:08 2020 +0800 summary: rust-core: fix typo in comment https://www.mercurial-scm.org/repo/hg/rev/bd22e90c54b3

D7833: transaction: allow finalizer to add finalizer

Closed by commit rHG2f1d6180737f: transaction: allow finalizer to add finalizer (authored by marmoute). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7833?vs=19153=19378 CHANGES

D7908: rust-filepatterns: improve API and robustness for pattern files parsing

kevincox added inline comments. kevincox accepted this revision. INLINE COMMENTS > filepatterns.rs:227 > +return acc; > +} > +if component != b".." Can you move this condition into a `.filter()`? > Alphare wrote in filepatterns.rs:237 > I'm

D7908: rust-filepatterns: improve API and robustness for pattern files parsing

Alphare added inline comments. Alphare marked an inline comment as done. INLINE COMMENTS > kevincox wrote in filepatterns.rs:220 > It might be clearer to do `bytes.iter().take_while(|b| b == sep).count()` Indeed. Also added a comment to explain the reasoning. > kevincox wrote in

D7907: rebase: always be graft-like, not merge-like, also for merges

martinvonz updated this revision to Diff 19377. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7907?vs=19343=19377 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7907/new/ REVISION DETAIL

D7867: rust-hg-path: add useful methods to `HgPath`

Alphare added inline comments. INLINE COMMENTS > kevincox wrote in hg_path.rs:169 > I don't think we should have this method. It provides us no way to ensure > that the invariants of this type are upheld. It is slightly more typing but I > think we should recommend converting to a slice, doing

D7909: rust-filepatterns: add support for `ignore` and `subignore` patterns

Alphare added inline comments. Alphare marked 2 inline comments as done. INLINE COMMENTS > kevincox wrote in filepatterns.rs:462 > I would write this as `Some(Ok(match syntax { .. }))` as the last expression > of this map. Then instead of `res.extend()` and `res.push()` you just return > the

mercurial@44087: 19 new changesets

19 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/5e0505d36aee changeset: 44069:5e0505d36aee user:Augie Fackler date:Wed Jan 08 14:37:01 2020 -0500 summary: examples: specify rustfmt nightly using a $() construct

D7833: transaction: allow finalizer to add finalizer

This revision is now accepted and ready to land. martinvonz added inline comments. martinvonz accepted this revision. INLINE COMMENTS > martinvonz wrote in transaction.py:511 > Any reason to not set this to `None` as we do on line 516? Also, can we > remove that line now? Ah, never mind, I

D7631: absorb: allowing committed changes to be absorbed into their ancestors

mharbison72 added inline comments. INLINE COMMENTS > martinvonz wrote in test-absorb-rev.t:63 > nit: I think I've heard that `^` needs to be quoted on Windows, so maybe `-s > '.^+.'` That's true in cmd.exe, but msys doesn't seem to care. (That said, I thought check-code enforced quoting

D7833: transaction: allow finalizer to add finalizer

martinvonz added inline comments. INLINE COMMENTS > transaction.py:511 > +callbacks = self._finalizecallback > +self._finalizecallback = {} > +categories = sorted(callbacks) Any reason to not set this to `None` as we do on line 516? Also, can we

mercurial@44068: 12 new changesets

12 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/7dddc2251365 changeset: 44057:7dddc2251365 user:Augie Fackler date:Wed Jan 08 15:09:01 2020 -0500 summary: sha1dc: import latest version from github

D7911: examples: refer to nightly rustfmt in Windows-compatible way

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Thanks to Jun Wu for the tip. I found that the new form also gave better error messages when the nightly rustfmt wasn't installed (it told me which command

D7812: examples: specify rustfmt nightly using a $() construct

martinvonz added a comment. I was just going to note that it seems like this would not work on Windows, but then I saw Jun's comment which seems to suggest the same. I'll send a patch to switch to Jun's proposal. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION

D7897: rebase: fix bug where `--collapse` would apply diff on missing file

Closed by commit rHGe733c59f3c09: rebase: fix bug where `--collapse` would apply diff on missing file (authored by martinvonz). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D7816: tests: stabilize test-subrepo-svn.t on Windows

Closed by commit rHGe598c874b4af: tests: stabilize test-subrepo-svn.t on Windows (authored by mharbison72). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7816?vs=19269=19375

D7860: graftcopies: remove `skip` and `repo` arguments

Closed by commit rHG833210fbd900: graftcopies: remove `skip` and `repo` arguments (authored by martinvonz). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7860?vs=19251=19371

D7896: rebase: extract a variable for a repeated `repo[p1]`

Closed by commit rHG521b4e3a42d7: rebase: extract a variable for a repeated `repo[p1]` (authored by martinvonz). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7896?vs=19332=19373

D7858: copies: replace duplicatecopies() by function that takes contexts

Closed by commit rHG2f0a44c69e07: copies: replace duplicatecopies() by function that takes contexts (authored by martinvonz). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D7859: graftcopies: use _filter() for filtering out invalid copies

Closed by commit rHG3df0bd706c40: graftcopies: use _filter() for filtering out invalid copies (authored by martinvonz). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D7861: graftcopies: document why the function is useful at all

Closed by commit rHG06e7e7652ac0: graftcopies: document why the function is useful at all (authored by martinvonz). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D7857: graft: extract repo[None] to a variable

Closed by commit rHGbd22e90c54b3: graft: extract repo[None] to a variable (authored by martinvonz). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7857?vs=19248=19368 CHANGES SINCE

D7895: rust-core: fix typo in comment

Closed by commit rHGb3ec1ea95ee6: rust-core: fix typo in comment (authored by aayjaychan). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7895?vs=19313=19367 CHANGES SINCE LAST

D7910: rust-re2: add wrapper for calling Re2 from Rust

kevincox added a comment. While I think the rust regex crate is heavily inspired by RE2 and uses a fairly compatible syntax I don't think there is a goal to be 100% compatible and I would be surprised if there weren't any differences. What I am trying to say is that if we are going to

D7865: rust-fmt: run cargo fmt

pulkit added a comment. This one fails to apply. Please rebase and resend. REPOSITORY rHG Mercurial BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7865/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7865 To: Alphare, #hg-reviewers, pulkit Cc:

D7867: rust-hg-path: add useful methods to `HgPath`

This revision now requires changes to proceed. kevincox added inline comments. kevincox requested changes to this revision. INLINE COMMENTS > hg_path.rs:169 > + self.inner > +} > pub fn contains(, other: u8) -> bool { I don't think we should have this method. It provides us no

D7910: rust-re2: add wrapper for calling Re2 from Rust

durin42 added a comment. In D7910#116208 , @kevincox wrote: > Does mercurial currently use RE2? If not then can you explain why we don't just use the rust `regex` crate? We have support for using re2 iff the correct Python bindings are

D7910: rust-re2: add wrapper for calling Re2 from Rust

This revision now requires changes to proceed. kevincox added inline comments. kevincox requested changes to this revision. INLINE COMMENTS > rust_re2.cpp:22 > + > + return new RE2(StringPiece(data, len), o); > + } This is never freed. Should we add a `Drop` implementation in

D7910: rust-re2: add wrapper for calling Re2 from Rust

kevincox added a comment. kevincox accepted this revision. Does mercurial currently use RE2? If not then can you explain why we don't just use the rust `regex` crate? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7910/new/ REVISION DETAIL

D7796: rust-nodemap: input/output primitives

kevincox added a comment. Maybe what we should do is keep the test I proposed, but change the definition of `BLOCK_SIZE` to be based upon the number of contained `i32` instead of `size_of`. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7796/new/

D7796: rust-nodemap: input/output primitives

kevincox added a comment. Ah yes. So my test would be ineffective. The problem that IIUC padding is not guaranteed to be initialized, and in rust all values need to be initialized. So if you cast a type with padding to a `u8` it is undefined behaviour. So we would need a test that

D7909: rust-filepatterns: add support for `ignore` and `subignore` patterns

This revision now requires changes to proceed. kevincox added inline comments. kevincox requested changes to this revision. INLINE COMMENTS > filepatterns.rs:456 > +.into_iter() > +.filter_map(|entry| -> Option> { > +let IgnorePattern { I don't see anywhere where

Re: D7494: localrepo: fastpath access to "."

Note: I sent the rebase of this series on behalf of marmoute as he is unable to access his computer at this time. On 1/16/20 3:26 PM, Alphare (Raphaël Gomès) wrote: Alphare updated this revision to Diff 19362. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D7908: rust-filepatterns: improve API and robustness for pattern files parsing

kevincox added inline comments. INLINE COMMENTS > filepatterns.rs:220 > +initial_slashes = 2; > +} > +let components = It might be clearer to do `bytes.iter().take_while(|b| b == sep).count()` > filepatterns.rs:237 > +acc > +}); > +let mut

D7903: sha1dc: avoid including the nonexistent stdint.h with Visual Studio 2008

yuja added a comment. > #ifndef SHA1DC_NO_STANDARD_INCLUDES > +#if !defined(_MSC_VER) || _MSC_VER >= 1600 > #include > +#else > +/* prior to Visual Studio 2010 */ > +typedef unsigned int uint32_t; `unsigned __int32` for consistency. REPOSITORY rHG Mercurial CHANGES SINCE

Re: D7903: sha1dc: avoid including the nonexistent stdint.h with Visual Studio 2008

> #ifndef SHA1DC_NO_STANDARD_INCLUDES > +#if !defined(_MSC_VER) || _MSC_VER >= 1600 > #include > +#else > +/* prior to Visual Studio 2010 */ > +typedef unsigned int uint32_t; `unsigned __int32` for consistency. ___ Mercurial-devel mailing list

D7903: sha1dc: avoid including the nonexistent stdint.h with Visual Studio 2008

mharbison72 added inline comments. INLINE COMMENTS > ubc_check.h:35 > +/* prior to Visual Studio 2010 */ > +typedef unsigned int uint32_t; > +#endif I see that ef36156eac9f uses `typedef unsigned __int32 uint32_t` if

D7492: localrepo: also fastpath access to working copy parents when possible

Alphare updated this revision to Diff 19361. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7492?vs=18382=19361 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7492/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7492

D7502: changectx: mark parent of changesets as non filtered

Alphare updated this revision to Diff 19366. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7502?vs=18387=19366 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7502/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7502

D7501: changectx: use unfiltered changelog to walk ancestors in annotate

Alphare updated this revision to Diff 19365. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7501?vs=18386=19365 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7501/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7501

D7495: localrepo: recognize trivial request for '.'

Alphare updated this revision to Diff 19363. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7495?vs=18384=19363 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7495/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7495

D7498: localrepo: also fast past the parents of working copies parents

Alphare updated this revision to Diff 19364. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7498?vs=18385=19364 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7498/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7498

D7494: localrepo: fastpath access to "."

Alphare updated this revision to Diff 19362. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7494?vs=18383=19362 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7494/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7494

Re: 5.4sprint location/date finalization

Folks, at this point it looks like either Antwerp or Paris makes the most sense. At this point it'd help to know: would either Paris or Antwerp be a deal-breaker for anyone? Or is it just a matter of whatever strikes our fancy? It also looks like we've only got one funding request at the

D7910: rust-re2: add wrapper for calling Re2 from Rust

Alphare created this revision. Herald added subscribers: mercurial-devel, mjpieters, kevincox, durin42. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This assumes that Re2 is installed following Google's guide. I am not sure how we want to integrate it in the project, but I think a

D7796: rust-nodemap: input/output primitives

gracinet added a comment. @kevincox (replying hastily because I'm also finishing something unrelated today). Doesn't `mem::size_of` guarantee to take any padding into account? At least that's what the doc seems to say: https://doc.rust-lang.org/std/mem/fn.size_of.html REPOSITORY rHG

D7871: rust-utils: add util for canonical path

Alphare updated this revision to Diff 19359. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7871?vs=19354=19359 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7871/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7871

D7869: rust-dirs-multiset: add `DirsChildrenMultiset`

Alphare updated this revision to Diff 19358. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7869?vs=19353=19358 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7869/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7869

D7869: rust-dirs-multiset: add `DirsChildrenMultiset`

kevincox added inline comments. kevincox accepted this revision. INLINE COMMENTS > hg_path.rs:197 > +/// ``` > +pub fn split_at_suffix() -> (, ) { > +match ().rposition(|c| *c == b'/') { "suffix" isn't clear to me. Maybe `split_dir_from_file`? That's a bit wordy but I feel that

D7870: rust-utils: add `Escaped` trait

kevincox added a comment. kevincox accepted this revision. I think it's better. Maybe still a little vauge but I'll let subject experts make that decision. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7870/new/ REVISION DETAIL

D7819: rust-nodemap: core implementation for shortest

kevincox added inline comments. kevincox accepted this revision. INLINE COMMENTS > nodemap.rs:337 > /// Main working method for `NodeTree` searches > fn lookup<'p>( > , Can you describe the return value in the doc comment. > nodemap.rs:575 > + > +fn shortest_bin<'a>( > +

D7909: rust-filepatterns: add support for `ignore` and `subignore` patterns

Alphare added a comment. Note to reviewers: this stack is part of the larger series of getting a full Rust dirstate.status which is most of the performance hit in bare hg status. More patches are coming, but I figured I would send the patches as I go to help with review timing. REPOSITORY

D7796: rust-nodemap: input/output primitives

kevincox added inline comments. INLINE COMMENTS > kevincox wrote in nodemap.rs:268 > This makes me uncomfortable. There is really no guarantee that there is no > padding around `Block` or `RawElement`. If there is any padding this is UB. I > would much prefer one of: > > 1. Store growable as

D7909: rust-filepatterns: add support for `ignore` and `subignore` patterns

Alphare created this revision. Herald added subscribers: mercurial-devel, kevincox, durin42. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This prepares a future patch for `IncludeMatcher` on the road to bare `hg status` support. REPOSITORY rHG Mercurial BRANCH default

D7908: rust-filepatterns: improve API and robustness for pattern files parsing

Alphare updated this revision to Diff 19356. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7908?vs=19355=19356 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7908/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7908

D7796: rust-nodemap: input/output primitives

This revision now requires changes to proceed. kevincox added inline comments. kevincox requested changes to this revision. INLINE COMMENTS > nodemap.rs:268 > +Vec::from_raw_parts( > +vec.as_ptr() as *mut u8, > +vec.len() * BLOCK_SIZE, This makes me

D7795: rust-nodemap: insert method

kevincox added inline comments. kevincox accepted this revision. INLINE COMMENTS > nodemap.rs:268 > +/// itself because of the mutable borrow taken with the returned `Block` > +fn mutable_block( self, idx: usize) -> (usize, Block, usize) { > +let ro_blocks = It looks like this

D7788: rust-node: binary Node and conversion utilities

kevincox added inline comments. kevincox accepted this revision. INLINE COMMENTS > node.rs:14 > +/// Binary revisions SHA > +pub type Node = [u8; 20]; > + I would recommend making this a proper type because almost no one should be poking at the bytes of the hash. struct Node([u8; 20]); You

[Bug 6256] New: Rebasing topic branch causes spurious new branch error message.

https://bz.mercurial-scm.org/show_bug.cgi?id=6256 Bug ID: 6256 Summary: Rebasing topic branch causes spurious new branch error message. Product: Mercurial Version: 5.2.1 Hardware: PC OS: Linux

D7492: localrepo: also fastpath access to working copy parents when possible

marmoute added a comment. Here is raw perf comparison for status, diff and export. We don't have a benchmark for annottate yet. (not too long to write, but I did not had the time to do that yet) All benchmarks: before after ratio [8e095512]

D7908: rust-filepatterns: improve API and robustness for pattern files parsing

Alphare created this revision. Herald added subscribers: mercurial-devel, kevincox, durin42. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Within the next few patches we will be using this new API. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL

  1   2   >