D8353: debugcommands: create new debugantivirusrunning command

mharbison72 added a comment. In D8353#124949 , @durin42 wrote: > In D8353#124948 , @mharbison72 wrote: > >> Should it delete the file after writing it, or don't bother because the AV may have

D8377: tests: move verification closer to setup in test-copies-chain-merge.t

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I found this test case really hard to read because it requires scrolling back and forth between the setup and the verification. This patch moves them closer

D8376: tests: collect all branch creation in one place in test-copies-chain-merge.t

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I found this test case really hard to read because it requires scrolling back and forth between the setup and the verification. The next patch will move the

D8258: copies-tests: remove spurious `]` in the template

Closed by commit rHG25d97090c6ca: copies-tests: remove spurious `]` in the template (authored by marmoute). This revision was automatically updated to reflect the committed changes. CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D8258?vs=20597=20979#toc REPOSITORY rHG Mercurial

D8375: manifest: leave a TODO where we may have more work for sha1 portability

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D8375 AFFECTED FILES mercurial/manifest.py CHANGE DETAILS diff --git

D8372: manifest: remove a final 40-byte assumption from pure-python parser

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D8372 AFFECTED FILES mercurial/manifest.py CHANGE DETAILS diff --git

D8374: fuzz: tell manifest fuzzer about longer node hashes

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D8374 AFFECTED FILES contrib/fuzz/manifest.cc contrib/fuzz/manifest_corpus.py

D8371: manifest: fix yet another 20-byte-hash assumption

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D8371 AFFECTED FILES mercurial/manifest.py CHANGE DETAILS diff --git

D8373: manifest: add test for long hashes

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D8373 AFFECTED FILES tests/test-manifest.py CHANGE DETAILS diff --git

D8370: manifest: fix another pure-parsing 20-byte assumption

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D8370 AFFECTED FILES mercurial/manifest.py CHANGE DETAILS diff --git

D8369: manifest: teach treemanifest about long hashes

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D8369 AFFECTED FILES mercurial/manifest.py CHANGE DETAILS diff --git

D8367: manifest: remove a 20-byte-hash assumption from pure manifest parsing

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is almost certainly slower, but it shouldn't be by much. We need to do this for the eventual hash transition, no matter what that looks like. REPOSITORY

D8368: manifest: start removing 40-byte hash restrictions from C code

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D8368 AFFECTED FILES mercurial/cext/manifest.c CHANGE DETAILS diff --git

D8258: copies-tests: remove spurious `]` in the template

This revision is now accepted and ready to land. martinvonz added a comment. martinvonz accepted this revision. This one is trivial to move ahead of the other two patches so I'll queue it and fix any conflicts in flight. REPOSITORY rHG Mercurial BRANCH default CHANGES SINCE LAST ACTION

D8353: debugcommands: create new debugantivirusrunning command

durin42 added a comment. In D8353#124948 , @mharbison72 wrote: > Should it delete the file after writing it, or don't bother because the AV may have it locked? I figured just leave it since it's tiny, but maybe we should sleep for a

D8353: debugcommands: create new debugantivirusrunning command

mharbison72 added a comment. Should it delete the file after writing it, or don't bother because the AV may have it locked? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8353/new/ REVISION DETAIL https://phab.mercurial-scm.org/D8353 To: durin42,

mercurial@44661: 50 new changesets (2 on stable)

50 new changesets (2 on stable) in mercurial: https://www.mercurial-scm.org/repo/hg/rev/bc592059d04f changeset: 44612:bc592059d04f parent: 44610:022bf71515c9 user:Pulkit Goyal <7895pul...@gmail.com> date:Mon Mar 23 21:06:54 2020 +0530 summary: chgserver: add

D8366: manifest: also declare treemanifest as implementing imanifestdict

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY It always has been intended to be, but it had a mismatched flags() method until the previous change. REPOSITORY rHG Mercurial BRANCH default REVISION

D8365: manifest: introduce new exception to signal unavailability of fastdelta()

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I've spent some time reflecting on this, and I think this is the best we can do in this API contract for now. This opens the door to adding treemanifest's

D8178: heptapod-ci: also run tests for chg on python 2

marmoute added a comment. Can we get the fix grafted on the stable branches. There are people using chg in production that would need them. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8178/new/ REVISION DETAIL

D8178: heptapod-ci: also run tests for chg on python 2

pulkit added a comment. In D8178#124930 , @marmoute wrote: > Is this targetted for stable or default ? having it on stable would be nice. Since all the fixes are on default branch, I am targeting it for default. Also default will be

D8178: heptapod-ci: also run tests for chg on python 2

marmoute added a comment. Is this targetted for stable or default ? having it on stable would be nice. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8178/new/ REVISION DETAIL https://phab.mercurial-scm.org/D8178 To: marmoute, #hg-reviewers Cc:

D8178: heptapod-ci: also run tests for chg on python 2

pulkit edited the summary of this revision. pulkit retitled this revision from "heptapod-ci: also run some test for chg" to "heptapod-ci: also run tests for chg on python 2". pulkit updated this revision to Diff 20967. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D8353: debugcommands: create new debugantivirusrunning command

durin42 added a comment. In D8353#124864 , @indygreg wrote: > I do not understand what the intended side-effect of running this command is supposed to be. Well, if an AV engine isn't configured to ignore the user's clone, then this will

[Bug 6297] New: .hgignore behavior changed with Python 3

https://bz.mercurial-scm.org/show_bug.cgi?id=6297 Bug ID: 6297 Summary: .hgignore behavior changed with Python 3 Product: Mercurial Version: 5.3 Hardware: PC OS: Windows Status: UNCONFIRMED Severity: bug

Re: D8358: rust-chg: depend on released version of tokio-process

This series is great. In case anyone wants to give their opinion, I have suggested to Yuya to start using async_std now that it's post-1.0 instead of Tokio. It's made by Tokio devs and is supposedly the better designed of the two as it gained hindsight from the different Tokio/futures

Re: D8360: rust-chg: spawn server process if not running

Aside from the outdated futures and Rust edition that Yuya already said are temporary, this looks good! On 4/2/20 1:12 PM, yuja (Yuya Nishihara) wrote: yuja created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is

Re: D8357: rust-chg: add brief comment about initial capacity of temp_sock_path()

Maybe I'm completely off-base here, but pid length varies with the OS, the architecture and user preferences. On Linux 64 bits it can be 4194304, 32768 for 32bits and 9 for FreeBSD. We could add constants, but I feel like it would be a lot of work for not a lot of gain. This patch looks

D8364: rust-chg: send client-side environment variables to server

yuja created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is also needed to run config validation. The "validate" request and its response handling will be implemented in the next batch. REPOSITORY rHG

D8363: rust-chg: add helper to pack environment variables

yuja created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY On my machine, "printenv | wc -c" says 3422. That's the only reason why the initial buffer capacity is set to 4kB. REPOSITORY rHG Mercurial BRANCH default

D8362: rust-chg: move set_current_dir() to Locator

yuja created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is necessary to run config validation in proper environment. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D8362

D8361: rust-chg: abort if server doesn't have required capabilities

yuja created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY It's checked at Locator::connect() since we'll have to do more stuff in this function. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL

D8360: rust-chg: spawn server process if not running

yuja created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is the minimal reimplementation of gethgcmd(), execcmdserver(), retryconnectcmdserver(), and connectcmdserver() in chg.c. No config validation is

D8359: rust-chg: update dependencies

yuja created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D8359 AFFECTED FILES rust/chg/Cargo.lock CHANGE DETAILS diff --git

D8358: rust-chg: depend on released version of tokio-process

yuja created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Still it is futures-0.1 based. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D8358 AFFECTED FILES

D8357: rust-chg: add brief comment about initial capacity of temp_sock_path()

yuja created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I don't know if it can be expressed as a compile-time constant, so it's a comment for now. About this series: This is quite old patches for rust-chg. I heard

mercurial@44611: new changeset (1 on stable)

New changeset (1 on stable) in mercurial: https://www.mercurial-scm.org/repo/hg/rev/8fca7e8449a8 changeset: 44611:8fca7e8449a8 branch: stable tag: tip parent: 44604:2141427533d2 user:Kyle Lippincott date:Wed Apr 01 14:14:55 2020 -0700 summary: histedit: