D8454: phabricator: ensure that `phabsend` is given a contiguous, linear commit range

mharbison72 created this revision. Herald added subscribers: mercurial-devel, Kwan. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Supplying a non-linear range was another orphan factory. While in theory there could be a use case for skipping over garbage commits (like adding

D8455: tests: clarify a comment describing a phabricator test scenario

mharbison72 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Per review feedback. REPOSITORY rHG Mercurial BRANCH stable REVISION DETAIL https://phab.mercurial-scm.org/D8455 AFFECTED FILES

D8432: dirstate: convert _checkexec to a bool when calling rustmod.status

marmoute added a comment. In D8432#126079 , @mplamann wrote: > What do you mean by fix the assignment? thre are some code somewhere putting a None in this attribute. given you issue you face. It seems reasonable to make that code set a

D8409: nodemap: create files in the repository used in the test

marmoute added a comment. marmoute requested review of this revision. I found the issue. I did not updated the counter in wait-on-file when I moved from `sleep 1` to `sleep 0.01`. So the timout was not 20s, but 0.2s a tad short. This is fixed in D8453

D8453: wait-on-file: adjust the timer counter

marmoute created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The wait performed in increment of 0.01 second, but the timer was expressed in second. So we did not wait 20s, we waited 0.2 second. Internally we adjust the

D8432: dirstate: convert _checkexec to a bool when calling rustmod.status

mplamann added a comment. What do you mean by fix the assignment? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8432/new/ REVISION DETAIL https://phab.mercurial-scm.org/D8432 To: mplamann, #hg-reviewers Cc: marmoute, mercurial-devel

mercurial@44731: 3 new changesets (3 on stable)

3 new changesets (3 on stable) in mercurial: https://www.mercurial-scm.org/repo/hg/rev/26ce8e751503 changeset: 44729:26ce8e751503 branch: stable tag: 5.4rc0 parent: 44692:539490756a72 parent: 44728:59ad165f6cdb user:Pulkit Goyal <7895pul...@gmail.com> date:

mercurial@44728: new changeset

New changeset in mercurial: https://www.mercurial-scm.org/repo/hg/rev/59ad165f6cdb changeset: 44728:59ad165f6cdb bookmark:@ tag: tip user:Yuya Nishihara date:Thu Apr 16 22:30:11 2020 +0900 summary: templatekw: fix shownames() to check if namespace exists in repo

mercurial@44727: 15 new changesets

15 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/97c10b157665 changeset: 44713:97c10b157665 user:Raphaël Gomès date:Thu Apr 16 17:31:11 2020 +0200 summary: rust: add option of static linking a local Re2 install

D8409: nodemap: create files in the repository used in the test

marmoute added a comment. I am on it. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8409/new/ REVISION DETAIL https://phab.mercurial-scm.org/D8409 To: marmoute, #hg-reviewers, pulkit, durin42 Cc: durin42, mercurial-devel

Re: [PATCH STABLE] templatekw: fix shownames() to check if namespace exists in repo (issue6301)

queued, tanks > On Apr 16, 2020, at 09:46, Yuya Nishihara wrote: > > # HG changeset patch > # User Yuya Nishihara > # Date 1587043811 -32400 > # Thu Apr 16 22:30:11 2020 +0900 > # Branch stable > # Node ID 7ac0467d2f83793f7f20fb12fa1ef1b4d6599052 > # Parent

D8409: nodemap: create files in the repository used in the test

This revision now requires changes to proceed. durin42 added a comment. durin42 requested changes to this revision. Did some bisecting. Prior to this change, I see about 2% failures on a 36-core 72-thread xeon machine that's otherwise idle. With this change, I see about 25% fails (out of 100

D8416: nodemap: move on disk file to version 1

marmoute added a comment. good catch, I updated the diff. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8416/new/ REVISION DETAIL https://phab.mercurial-scm.org/D8416 To: marmoute, #hg-reviewers Cc: durin42, mercurial-devel

D8418: nodemap: drop the 'exp-' prefix for internal opener option

marmoute updated this revision to Diff 21148. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8418?vs=21095=21148 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8418/new/ REVISION DETAIL

D8411: nodemap: also warm manifest nodemap with other caches

marmoute updated this revision to Diff 21146. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8411?vs=21091=21146 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8411/new/ REVISION DETAIL

D8416: nodemap: move on disk file to version 1

marmoute updated this revision to Diff 21147. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8416?vs=21094=21147 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8416/new/ REVISION DETAIL

D8410: nodemap: also use persistent nodemap for manifest

marmoute updated this revision to Diff 21145. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8410?vs=21090=21145 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8410/new/ REVISION DETAIL

D8423: graft: exit 1 on conflicts, like merge

Closed by commit rHG16c361152133: graft: exit 1 on conflicts, like merge (authored by valentin.gatienbaron). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8423?vs=21088=21142

D8426: wait-on-file: use proper variable in math

Closed by commit rHG694d40416d62: wait-on-file: use proper variable in math (authored by marmoute). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8426?vs=21103=21144 CHANGES SINCE

D8425: wait-on-file: don't quote arithmetic argument

Closed by commit rHG2789f25fc2b6: wait-on-file: dont quote arithmetic argument (authored by marmoute). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8425?vs=21102=21143 CHANGES

D8424: manifest: fix missing `el` on an `elif` spotted by yuya

durin42 added a comment. durin42 abandoned this revision. Yep it got folded. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8424/new/ REVISION DETAIL https://phab.mercurial-scm.org/D8424 To: durin42, #hg-reviewers, Alphare Cc: pulkit, Alphare,

D8397: tests: deal with "ls" vs "ls -A" difference on 2BSD derived systems

Closed by commit rHG5c2a4f37eace: tests: deal with ls vs ls -A difference on 2BSD derived systems (authored by joerg.sonnenberger). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review".

D8395: tests: skip CVS tests for root

Closed by commit rHGe5e5ee2b60e4: tests: skip CVS tests for root (authored by joerg.sonnenberger). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial CHANGES

D8396: tests: skip non-readable check for root

Closed by commit rHG28aacddf3af0: tests: skip non-readable check for root (authored by joerg.sonnenberger). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial

D8438: phabricator: restack any new orphans created by phabsend (issue6045)

Closed by commit rHG601ce5392cb0: phabricator: restack any new orphans created by phabsend (issue6045) (authored by mharbison72). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review".

D8436: phabricator: avoid creating unstable children within the review stack

Closed by commit rHG0680b8a1992a: phabricator: avoid creating unstable children within the review stack (authored by mharbison72). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review".

D8437: phabricator: prevent posting obsolete commits

Closed by commit rHGc482e2fe444c: phabricator: prevent posting obsolete commits (authored by mharbison72). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial

D8439: make: drop the `-c` arg to `install` in the documentation makefile

Closed by commit rHGeb9026a84e83: make: drop the `-c` arg to `install` in the documentation makefile (authored by mharbison72). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY

D8389: phabricator: add debug logging to show previous node values in `phabsend`

Closed by commit rHG38f7b2f02f6d: phabricator: add debug logging to show previous node values in `phabsend` (authored by mharbison72). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review".

D8390: tests: move the phabricator auth token to the global config file

Closed by commit rHGed81fa859426: tests: move the phabricator auth token to the global config file (authored by mharbison72). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY

D8314: phabricator: add an option to fold several commits into one review (issue6244)

Closed by commit rHG3dc6a70779f2: phabricator: add an option to fold several commits into one review (issue6244) (authored by mharbison72). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review".

D8452: rust: update README with new information about the Re2 path

Closed by commit rHG8dbcd5138102: rust: update README with new information about the Re2 path (authored by Alphare). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG

D8451: rust: add option of static linking a local Re2 install

Closed by commit rHG97c10b157665: rust: add option of static linking a local Re2 install (authored by Alphare). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial

D8424: manifest: fix missing `el` on an `elif` spotted by yuya

pulkit added a comment. Looks like this was amended and not needed anymore. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8424/new/ REVISION DETAIL https://phab.mercurial-scm.org/D8424 To: durin42, #hg-reviewers, Alphare Cc: pulkit, Alphare, yuja,

D8448: rust-chg: modernize entry function

durin42 added inline comments. INLINE COMMENTS > main.rs:70 > +#[tokio::main] > +async fn run(umask: u32) -> io::Result { > let mut loc = Locator::prepare_from_env()?; With this series I get lots of `+ error[E0670]: `async fn` is not permitted in the 2015 edition` from

D8416: nodemap: move on disk file to version 1

durin42 added inline comments. INLINE COMMENTS > nodemap.py:270 > > # version 0 is experimental, no BC garantee, do no use outside of tests. > +ONDISK_VERSION = 1 I feel like this comment is outdated? please send a follow-up (even if it's for stable after the freeze) on this. REPOSITORY

D8452: rust: update README with new information about the Re2 path

Alphare created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D8452 AFFECTED FILES rust/README.rst CHANGE DETAILS diff --git a/rust/README.rst

D8451: rust: add option of static linking a local Re2 install

Alphare created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Previously, only dynamically linking the system-wide install was possible. We force the user to provide one to prevent hard-to-track errors. REPOSITORY rHG

D8436: phabricator: avoid creating unstable children within the review stack

mharbison72 added inline comments. INLINE COMMENTS > Alphare wrote in test-phabricator.t:184 > Nit: I feel like using "rebasing" is confusing as it does not involve > user-level `rebase`. I can follow up and say "when restacking existing" after the freeze, unless someone fixes in flight.

D8438: phabricator: restack any new orphans created by phabsend (issue6045)

Alphare added a comment. Alphare accepted this revision. A feature I've always wanted but never bothered to speak up about it, thanks. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8438/new/ REVISION DETAIL https://phab.mercurial-scm.org/D8438 To:

D8437: phabricator: prevent posting obsolete commits

Alphare added a comment. Alphare accepted this revision. I think that these kinds of fail-safes are very useful. I might have been bit by this once. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8437/new/ REVISION DETAIL

D8436: phabricator: avoid creating unstable children within the review stack

Alphare added inline comments. Alphare accepted this revision. INLINE COMMENTS > test-phabricator.t:184 > > +Phabsend doesn't create an instability when rebasing existing revisions on > top > +of new revisions. Nit: I feel like using "rebasing" is confusing as it does not involve user-level

[PATCH STABLE] templatekw: fix shownames() to check if namespace exists in repo (issue6301)

# HG changeset patch # User Yuya Nishihara # Date 1587043811 -32400 # Thu Apr 16 22:30:11 2020 +0900 # Branch stable # Node ID 7ac0467d2f83793f7f20fb12fa1ef1b4d6599052 # Parent 539490756a72d8b9c8481af3129806072e9a7bb3 templatekw: fix shownames() to check if namespace exists in repo

D8431: upgrade: support upgrade and downgrade from persistent nodemap

mharbison72 added a comment. mharbison72 accepted this revision. s/requirements is not/requirement is now/ in the summary, but otherwise LGTM REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8431/new/ REVISION DETAIL

D8314: phabricator: add an option to fold several commits into one review (issue6244)

Alphare added a comment. Alphare accepted this revision. Thanks for addressing my comments, that looks good. (I did not read the VCR output hehe) REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8314/new/ REVISION DETAIL

D8450: rust-chg: clean up excessive indents

yuja created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D8450 AFFECTED FILES rust/chg/src/attachio.rs rust/chg/src/locator.rs

D8449: rust-chg: do not terminate tokio runtime until pager exits

yuja created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We no longer need to spawn a task just to keep the pager handle. The pager handle can be held by ChgUiHandler since the handler itself is not consumed and

D8448: rust-chg: modernize entry function

yuja created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Finally the entire build passes. There's a bug that run() no longer waits for the spawned pager, which will be fixed by the next patch. REPOSITORY rHG

D8447: rust-chg: reimplement locator by using async/await and tokio-0.2

yuja created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY connect_spawned() is rewritten from scratch by using std::process. Before, it would select completion of either connection or server process. New code could be

D8446: rust-chg: reimplement ChgClientExt as ChgClient wrapper

yuja created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY ChgClient is no longer an extension trait because: a. Client object is not consumed and recreated in future-0.3 world, which unblocks writing a simple

D8445: rust-chg: reimplement run_command operation as async function

yuja created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The crafted state machine is no longer needed thanks to async/await. The state machine is basically rewritten as follows: - Ready(..) -> return .. -

D8444: rust-chg: reimplement uihandler by using async-trait and tokio-0.2

yuja created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We no longer have to consume self and arguments. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D8444 AFFECTED FILES

D8441: rust-chg: upgrade to futures-0.3 based libraries

yuja created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY And do some trivial fixes: - BytesMut::put_u32_be() -> put_u32() - tokio_process -> tokio::process, CommandExt -> Command, spawn_async() -> spawn(), stdin() ->

D8443: rust-chg: have attach_io() simply take reference of AsRawFd object

yuja created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We no longer have to deal with the restriction of the Future type. Before, these file objects couldn't be references and that's the only reason why we had to make

D8442: rust-chg: reimplement attach_io operation as async function

yuja created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY In short, MessageLoop was redesigned as Protocol, and the protocol methods no longer consume self. API changes are briefly documented in the following page:

D8440: rust-chg: exclude futures-dependent modules from build and break things

yuja created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY It's impractical to upgrade the codebase incrementally since futures 0.1 and 0.3 APIs are fundamentally different. So this patch temporarily excludes