Re: [PATCH] commands: add short option `-H` for `--hidden`

2020-07-17 Thread Manuel Jacob
I’m sorry for the non-optimal form and timing. This was meant as an RFC patch. That’s why it contains no tests. It should have been flagged as such. Now is probably not a good time for RFC patches. I was aware that RFC patches should not be sent after the freeze. That’s why I kinda rushed

[PATCH] commands: add short option `-H` for `--hidden`

2020-07-17 Thread Manuel Jacob
# HG changeset patch # User Manuel Jacob # Date 1595011777 -7200 # Fri Jul 17 20:49:37 2020 +0200 # Node ID 91ac61b56b6ed95d9f62ba3615e8b160e6be8d9b # Parent a37f290a71240b851f5df900833f848efbab576a # EXP-Topic hidden-shortcut commands: add short option `-H` for `--hidden` When digging in

D8765: absorb: improve message for the case when changeset became empty

2020-07-17 Thread mjacob (Manuel Jacob)
mjacob created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY In changeset f55099982bc5 , I introduced the message "became empty and became ...",

D8353: debugcommands: create new debugantivirusrunning command

2020-07-17 Thread durin42 (Augie Fackler)
Closed by commit rHG87047efbc6a6: debugcommands: create new debugantivirusrunning command (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8353?vs=21426=21955

Re: [PATCH 2 of 2 rebased] exchange: check actually missing revs for obsolete / unstable revs (issue6372)

2020-07-17 Thread Pulkit Goyal
On Fri, Jul 17, 2020 at 6:15 PM Manuel Jacob wrote: > > # HG changeset patch > # User Manuel Jacob > # Date 1594966891 -7200 > # Fri Jul 17 08:21:31 2020 +0200 > # Node ID b5983bd8811e77fc82e7c7fbe3f602ab3e90852a > # Parent 6284dfa728899a6385361d59ba95d9c3d137a5e6 > # EXP-Topic issue6372 >

Heptapod news: doc sprint, versions 0.14 and 0.15

2020-07-17 Thread Georges Racinet
Hello everybody, Here are some news about Heptapod, the friendly fork of GitLab Community Edition supporting Mercurial. == Documentation virtual sprint ==     We're organizing an informal single day sprint about documentation and user messages. It will happen on the last week of July and

D8764: localrepo: deduplicate code around reading requires file

2020-07-17 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D8764 AFFECTED FILES mercurial/localrepo.py CHANGE DETAILS diff --git

[PATCH] windows: handle file-like objects without isatty() method

2020-07-17 Thread Manuel Jacob
# HG changeset patch # User Manuel Jacob # Date 1594990702 -7200 # Fri Jul 17 14:58:22 2020 +0200 # Node ID aa6621ba3a4871256c15bb7b87e8e5dfe940ad0f # Parent a37f290a71240b851f5df900833f848efbab576a # EXP-Topic winstdout windows: handle file-like objects without isatty() method Copying the

Re: [PATCH 4 of 4] windows: always work around EINVAL in case of broken pipe for stdout / stderr

2020-07-17 Thread Manuel Jacob
On 2020-07-17 13:24, Yuya Nishihara wrote: On Fri, 17 Jul 2020 04:38:50 +0200, Manuel Jacob wrote: # HG changeset patch # User Manuel Jacob # Date 1594949332 -7200 # Fri Jul 17 03:28:52 2020 +0200 # Node ID 741837f160677ec24154b3d5aa209133a3872d53 # Parent

Re: [PATCH]: [Bug 6373] py3 support for popen on windows vs cmdbuilder

2020-07-17 Thread Александр Литягин
The encoding of user arguments is unknown, but maybe using a.decode("mbcs") is better since the other hgclient APIs would expect an MBCS-encoded bytes on Windows. https://www.mercurial-scm.org/repo/hg/file/5.4/mercurial/pycompat.py#l174 And we might also want to leverage the encoding parameter

[PATCH 2 of 2 rebased] exchange: check actually missing revs for obsolete / unstable revs (issue6372)

2020-07-17 Thread Manuel Jacob
# HG changeset patch # User Manuel Jacob # Date 1594966891 -7200 # Fri Jul 17 08:21:31 2020 +0200 # Node ID b5983bd8811e77fc82e7c7fbe3f602ab3e90852a # Parent 6284dfa728899a6385361d59ba95d9c3d137a5e6 # EXP-Topic issue6372 exchange: check actually missing revs for obsolete / unstable revs

[PATCH 1 of 2 rebased] tests: test that push doesn’t complain about unstable changesets if no changes

2020-07-17 Thread Manuel Jacob
# HG changeset patch # User Manuel Jacob # Date 1594965560 -7200 # Fri Jul 17 07:59:20 2020 +0200 # Node ID 6284dfa728899a6385361d59ba95d9c3d137a5e6 # Parent a37f290a71240b851f5df900833f848efbab576a # EXP-Topic issue6372 tests: test that push doesn’t complain about unstable changesets if no

Re: [PATCH]: [Bug 6373] py3 support for popen on windows vs cmdbuilder

2020-07-17 Thread Yuya Nishihara
On Thu, 16 Jul 2020 23:05:19 +0300, Александр Литягин wrote: > # HG changeset patch > # User alexrayne > # Date 1557358579 -10800 > #  Thu May 09 02:36:19 2019 +0300 > # Node ID 856cea175acabd5b8f87319001067a7785c15279 > # Parent  33b512aa8dba0cbe523188fbb62d30ae2125a236 > !popen:py3 - #6065

Re: [PATCH 4 of 4] windows: always work around EINVAL in case of broken pipe for stdout / stderr

2020-07-17 Thread Yuya Nishihara
On Fri, 17 Jul 2020 04:38:50 +0200, Manuel Jacob wrote: > # HG changeset patch > # User Manuel Jacob > # Date 1594949332 -7200 > # Fri Jul 17 03:28:52 2020 +0200 > # Node ID 741837f160677ec24154b3d5aa209133a3872d53 > # Parent 91f6d0508acac2c8eb0fbf8864528f8f584e697c > # EXP-Topic

Re: [PATCH 1 of 2] discovery: weaken claim about returned common heads if ancestorsof are given

2020-07-17 Thread Yuya Nishihara
On Fri, 17 Jul 2020 09:54:41 +0200, Manuel Jacob wrote: > On 2020-07-17 08:49, Pierre-Yves David wrote: > > On 7/17/20 6:16 AM, Manuel Jacob wrote: > >> On 2020-07-17 05:15, Pierre-Yves David wrote: > >>> This looks correct to me. Thanks of lot to Manuel for making this > >>> clarification work. >

D8763: diff: move no-eol text constant to a common location

2020-07-17 Thread rdamazio (Rodrigo Damazio Bovendorp)
rdamazio created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D8763 AFFECTED FILES mercurial/crecord.py mercurial/diffhelper.py

D8762: revert: fix interactive reverting of end-of-file newline changes

2020-07-17 Thread rdamazio (Rodrigo Damazio Bovendorp)
rdamazio created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY The chunk reversal used by `revert -i` in Curses mode was not taking this case into account. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL

[PATCH 13 of 13] merge: remove no longer required ACTION_GET_OTHER_AND_STORE

2020-07-17 Thread Pulkit Goyal
# HG changeset patch # User Pulkit Goyal <7895pul...@gmail.com> # Date 1594725028 -19800 # Tue Jul 14 16:40:28 2020 +0530 # Node ID a5812036d3a33b466854204be2128d8aa1a11b0f # Parent 4021b2b860103442ac0d36b0cc5176ec74c92a6a # EXP-Topic mergestate-refactor merge: remove no longer required

[PATCH 12 of 13] merge: pass commitinfo to applyupdates() and get it stored in mergestate

2020-07-17 Thread Pulkit Goyal
# HG changeset patch # User Pulkit Goyal <7895pul...@gmail.com> # Date 1594724512 -19800 # Tue Jul 14 16:31:52 2020 +0530 # Node ID 4021b2b860103442ac0d36b0cc5176ec74c92a6a # Parent 9fd8b89eee7e32ce4f3703d423cc320dec64da86 # EXP-Topic mergestate-refactor merge: pass commitinfo to

[PATCH 11 of 13] merge: return 'commitinfo' from manifestmerge() and calculateupdates() (API)

2020-07-17 Thread Pulkit Goyal
# HG changeset patch # User Pulkit Goyal <7895pul...@gmail.com> # Date 1594723868 -19800 # Tue Jul 14 16:21:08 2020 +0530 # Node ID 9fd8b89eee7e32ce4f3703d423cc320dec64da86 # Parent 6a87141b0721d719fcc3b8bb94743eda1a120c17 # EXP-Topic mergestate-refactor merge: return 'commitinfo' from

[PATCH 09 of 13] merge: refactor code to advise fsmonitor in separate function

2020-07-17 Thread Pulkit Goyal
# HG changeset patch # User Pulkit Goyal <7895pul...@gmail.com> # Date 1594301530 -19800 # Thu Jul 09 19:02:10 2020 +0530 # Node ID 15d0b77c5833af7c1b04e29dd4628a66d9518cde # Parent 3e356397d1b4f0b07465fab86045a38d59029067 # EXP-Topic mergestate-refactor merge: refactor code to advise

[PATCH 10 of 13] merge: document return values of manifestmerge() and calculateupdates()

2020-07-17 Thread Pulkit Goyal
# HG changeset patch # User Pulkit Goyal <7895pul...@gmail.com> # Date 1594721548 -19800 # Tue Jul 14 15:42:28 2020 +0530 # Node ID 6a87141b0721d719fcc3b8bb94743eda1a120c17 # Parent 15d0b77c5833af7c1b04e29dd4628a66d9518cde # EXP-Topic mergestate-refactor merge: document return values of

[PATCH 07 of 13] mergestate: rename a helpless variable name to bit helpful one

2020-07-17 Thread Pulkit Goyal
# HG changeset patch # User Pulkit Goyal <7895pul...@gmail.com> # Date 1594300089 -19800 # Thu Jul 09 18:38:09 2020 +0530 # Node ID 7265d8b575ff4f3adfc392247f868344eadd43c2 # Parent 8dd9eeb56cd015f1e323fedad6c8d58de2d81bb1 # EXP-Topic mergestate-refactor mergestate: rename a helpless

[PATCH 08 of 13] mergestate: document what mergestate._results is for

2020-07-17 Thread Pulkit Goyal
# HG changeset patch # User Pulkit Goyal <7895pul...@gmail.com> # Date 1594300418 -19800 # Thu Jul 09 18:43:38 2020 +0530 # Node ID 3e356397d1b4f0b07465fab86045a38d59029067 # Parent 7265d8b575ff4f3adfc392247f868344eadd43c2 # EXP-Topic mergestate-refactor mergestate: document what

[PATCH 05 of 13] mergestate: document mergestate records in an organized way

2020-07-17 Thread Pulkit Goyal
# HG changeset patch # User Pulkit Goyal <7895pul...@gmail.com> # Date 1594294541 -19800 # Thu Jul 09 17:05:41 2020 +0530 # Node ID c571d56248d51c7ed396871495e9ddc989a8ce45 # Parent 6879b715405d2ff35deb35eac97104bb82c1aff2 # EXP-Topic mergestate-refactor mergestate: document mergestate

[PATCH 06 of 13] mergestate: remove unnecessary recordactions() from mergestate class

2020-07-17 Thread Pulkit Goyal
# HG changeset patch # User Pulkit Goyal <7895pul...@gmail.com> # Date 1594299054 -19800 # Thu Jul 09 18:20:54 2020 +0530 # Node ID 8dd9eeb56cd015f1e323fedad6c8d58de2d81bb1 # Parent c571d56248d51c7ed396871495e9ddc989a8ce45 # EXP-Topic mergestate-refactor mergestate: remove unnecessary

[PATCH 03 of 13] mergestate: add comments about couple of record types and minor reorder

2020-07-17 Thread Pulkit Goyal
# HG changeset patch # User Pulkit Goyal <7895pul...@gmail.com> # Date 1594292904 -19800 # Thu Jul 09 16:38:24 2020 +0530 # Node ID ed6b80e5ed265851feb59d7855641b5d5254953b # Parent 9e4a5e41f0ac3fa39a29d5376a1d3922e9221318 # EXP-Topic mergestate-refactor mergestate: add comments about couple

[PATCH 04 of 13] mergestate: remove unused unsupported related mergestate records

2020-07-17 Thread Pulkit Goyal
# HG changeset patch # User Pulkit Goyal <7895pul...@gmail.com> # Date 1594292982 -19800 # Thu Jul 09 16:39:42 2020 +0530 # Node ID 6879b715405d2ff35deb35eac97104bb82c1aff2 # Parent ed6b80e5ed265851feb59d7855641b5d5254953b # EXP-Topic mergestate-refactor mergestate: remove unused unsupported

[PATCH 02 of 13] mergestate: remove unrequired RECORD_RESOLVED_OTHER record

2020-07-17 Thread Pulkit Goyal
# HG changeset patch # User Pulkit Goyal <7895pul...@gmail.com> # Date 1594290002 -19800 # Thu Jul 09 15:50:02 2020 +0530 # Node ID 9e4a5e41f0ac3fa39a29d5376a1d3922e9221318 # Parent 66fb1ff9343a4d73b44c4314d88176e283a7839d # EXP-Topic mergestate-refactor mergestate: remove unrequired

[PATCH 01 of 13] mergestate: rename addpath() -> addpathonflict() to prevent confusion

2020-07-17 Thread Pulkit Goyal
# HG changeset patch # User Pulkit Goyal <7895pul...@gmail.com> # Date 1594286098 -19800 # Thu Jul 09 14:44:58 2020 +0530 # Node ID 66fb1ff9343a4d73b44c4314d88176e283a7839d # Parent 33524b6bef53fffcb34708e927c2b53f08fea736 # EXP-Topic mergestate-refactor mergestate: rename addpath() ->

Re: [PATCH 1 of 2] discovery: weaken claim about returned common heads if ancestorsof are given

2020-07-17 Thread Manuel Jacob
On 2020-07-17 08:49, Pierre-Yves David wrote: On 7/17/20 6:16 AM, Manuel Jacob wrote: On 2020-07-17 05:15, Pierre-Yves David wrote: This looks correct to me. Thanks of lot to Manuel for making this clarification work. You should consider using mercurial.util.nouideprecwarn to catch (and have

[PATCH] discovery: change users of `outgoing.missingheads` to `outgoing.ancestorsof`

2020-07-17 Thread Manuel Jacob
# HG changeset patch # User Manuel Jacob # Date 1594970448 -7200 # Fri Jul 17 09:20:48 2020 +0200 # Node ID 188143307f27defd20d67ef2ecc9adae1cf78767 # Parent 3e351fcbb83d88ec386ad8b0ffe6e0e0b0dfd46d # EXP-Topic discovery discovery: change users of `outgoing.missingheads` to

Re: [PATCH 1 of 2] discovery: weaken claim about returned common heads if ancestorsof are given

2020-07-17 Thread Pierre-Yves David
On 7/17/20 6:16 AM, Manuel Jacob wrote: On 2020-07-17 05:15, Pierre-Yves David wrote: This looks correct to me. Thanks of lot to Manuel for making this clarification work. You should consider using mercurial.util.nouideprecwarn to catch (and have extension catch) user of the old attribute.

[PATCH 1 of 2] tests: test that push doesn’t complain about unstable changesets if no changes

2020-07-17 Thread Manuel Jacob
# HG changeset patch # User Manuel Jacob # Date 1594965560 -7200 # Fri Jul 17 07:59:20 2020 +0200 # Node ID 55626b2da7d55766ae667d91652d094c0c4aa86f # Parent f55099982bc517c349bf46fab53b8696f0615c17 # EXP-Topic issue6372 tests: test that push doesn’t complain about unstable changesets if no

[PATCH 2 of 2] exchange: check actually missing revs for obsolete / unstable revs (issue6372)

2020-07-17 Thread Manuel Jacob
# HG changeset patch # User Manuel Jacob # Date 1594966891 -7200 # Fri Jul 17 08:21:31 2020 +0200 # Node ID 91c59e59daae6b4bc0fe86b09c01fcc2e1aace9d # Parent 55626b2da7d55766ae667d91652d094c0c4aa86f # EXP-Topic issue6372 exchange: check actually missing revs for obsolete / unstable revs