av6 created this revision.
Herald added subscribers: mercurial-devel, mjpieters.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
One of the most important aspects of a completion system is its speed, so 2
calls to hg is definitely better than 4.
Sorting by rev (descending) is to
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGb4e7e1f09c09: zsh_completion: complete merge tools for
-t/--tool (authored by av6, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
av6 added inline comments.
INLINE COMMENTS
> pulkit wrote in zsh_completion:636
> I changed "revision" to "REV" in flight.
What is REV? It's a metavariable used in hg help output. It makes sense if you
look at the help output while typing up hg files, but zsh's completion is
supposed to help
av6 added inline comments.
INLINE COMMENTS
> spectral wrote in zsh_completion:292
> I'm slightly concerned this might give a false impression of what's
> available, listing things that I don't have installed, but I think this might
> be the best we can do at the moment - there doesn't appear
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGad1c6bd3c676: zsh_completion: complete hg files (authored
by av6, committed by ).
CHANGED PRIOR TO COMMIT
https://phab.mercurial-scm.org/D4361?vs=10536=10650#toc
REPOSITORY
rHG Mercurial
CHANGES
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGd0dfdf263a20: zsh_completion: adjust usage of common
options (authored by av6, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D4360?vs=10535=10649
# HG changeset patch
# User Anton Shestakov
# Date 1535387530 -28800
# Tue Aug 28 00:32:10 2018 +0800
# Node ID 3e3b9ae9771f965611633ff21b168ac0f7b4bb06
# Parent bb2b462f81daae07d5400aee7db794857959979c
context: use new names for unstable changesets in docstrings
Plus slight corrections
av6 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D4362
AFFECTED FILES
contrib/zsh_completion
CHANGE DETAILS
diff --git a/contrib/zsh_completion
av6 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D4361
AFFECTED FILES
contrib/zsh_completion
CHANGE DETAILS
diff --git a/contrib/zsh_completion
av6 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
addremove, remove and serve accept -S/--subrepos, and purge actually doesn't.
qnew accepts -I/--include and -X/--exclude.
qrefresh accepts -D/--currentdate,
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG362c4603602d: zsh_completion: update all options (authored
by av6, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D4267?vs=10333=10468
REVISION
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG69876534caf2: zsh_completion: declare appropriate local
parameters for -string form (authored by av6, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGfd17590655cf: zsh_completion: drop -w, add -S to _arguments
(authored by av6, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D4262?vs=10328=10463
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGf625e457f43a: zsh_completion: run hg with
HGPLAINEXCEPT=alias to list commands (authored by av6, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG8ff14f8fe2d3: zsh_completion: complete files from `hg st
-mar` for commit and diff (authored by av6, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG93fdf00596e4: zsh_completion: remove completion for
obsolete graphlog extension (authored by av6, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG27bbd62e9957: zsh_completion: rename _hg_style_opts to
_hg_template_opts (authored by av6, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
av6 added a comment.
I've commented on things that can be improved, but they shouldn't stop this
from landing.
INLINE COMMENTS
> relnotes:51
> +r": implement ": -5,
> +r"2\.4": -20,
> +r": use .* implementation": -20,
I assume it's for Python 2.4. Maybe needs more versions we
av6 added inline comments.
INLINE COMMENTS
> spectral wrote in zsh_completion:644
> I assume the first section here makes continue and abort mutually exclusive?
> I believe that revision arguments are also forbidden if either --continue or
> --abort are specified; I don't know if there's a
On Sun, 12 Aug 2018 12:27:00 +0900
Yuya Nishihara wrote:
> # HG changeset patch
> # User Yuya Nishihara
> # Date 1533860444 -32400
> # Fri Aug 10 09:20:44 2018 +0900
> # Node ID 72f91934d88362792e8b6b79ceb51e90d655364e
> # Parent 365ea9b1e7f8ed5e803ea5403345afb6e219712b
> cmdutil: remove
av6 added a comment.
Thanks, `‘` and `’` for making it difficult to phabsend this. I had to
diff --git a/contrib/phabricator.py b/contrib/phabricator.py
--- a/contrib/phabricator.py
+++ b/contrib/phabricator.py
@@ -117,6 +117,8 @@ def urlencodenested(params):
def
av6 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
It's just too hard to further split this patch. What it does:
- adds missing flags
- removes flags that are no longer there
- updates flag descriptions and
av6 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
When ->string form is used for _arguments, the function that calls it must
declare appropriate local parameters.
Managing local return value is needed to tell
av6 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This is what contrib/bash_completion does, looks like a sensible thing to do.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D4266
av6 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Useful to have and is consistent with our bash completion file.
This is also an improvement coming from upstream, downstream or sidestream
(depends on how you
av6 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D4265
AFFECTED FILES
contrib/zsh_completion
CHANGE DETAILS
diff --git a/contrib/zsh_completion
av6 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
From the docs: http://zsh.sourceforge.net/Doc/Release/Completion-System.html
_arguments -w: "allow option stacking even if one or more of the options take
av6 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
--style is a deprecated alias for --template, and doesn't show up in help
without --verbose, so completing it doesn't make much sense.
Let's s/style/template/
On Fri, 10 Aug 2018 09:00:10 +0200
David Demelier wrote:
> Since translations are not updated often, my proposal is to completely
> remove them.
Here's the thing: given the multitude of ways to contribute to an open
source project, translating it is one of the most unappreciated such
ways. When
On Thu, 9 Aug 2018 20:50:50 +0900
Yuya Nishihara wrote:
> Good catch.
This actually was discovered by Kim Alvefur (zash on #mercurial). I
think it's worth putting a note in the message (I forgot, my bad).
___
Mercurial-devel mailing list
# HG changeset patch
# User Anton Shestakov
# Date 1533791092 -28800
# Thu Aug 09 13:04:52 2018 +0800
# Branch stable
# Node ID 8ae23d0e1367cc82e54d304bcef87ab42bada974
# Parent c9e6ca31cfe7bed4903fa129b7d2598487d97c67
hgweb: catch ParseError that's raised by revset.match()
Some queries
av6 added a comment.
Are you sure you're not just using hgwebdir_mod? hgweb_mod is for cases when
you don't use --web-conf flag, at least that seems to be the logic that
`hgweb.createapp()` uses to pick one of the two modules.
REPOSITORY
rHG Mercurial
REVISION DETAIL
# HG changeset patch
# User Anton Shestakov
# Date 1531909036 -28800
# Wed Jul 18 18:17:16 2018 +0800
# Node ID 3e63522314b688d32c393d783c501a5eab88c74e
# Parent 1fa3bf6e9e93cc244dea752196955a6d0c6b25b1
topic: use self instead of repo in topicrepo methods
Referring to repo here was somehow
On Wed, 11 Jul 2018 23:08:37 +0530
Pulkit Goyal <7895pul...@gmail.com> wrote:
> On Mon, Jul 9, 2018 at 6:29 PM Yuya Nishihara wrote:
>
> > On Sun, 8 Jul 2018 18:29:37 +0530, Pulkit Goyal wrote:
> > > > --- a/mercurial/help/config.txt
> > > > +++ b/mercurial/help/config.txt
> > > > @@ -702,6
av6 added inline comments.
INLINE COMMENTS
> configitems.py:1080
> )
> +coreconfigitem('ui', 'largefilelimit',
> +default=1000,
Suggestion: `large-file-limit`.
https://www.mercurial-scm.org/wiki/UIGuideline#naming_config_options
REPOSITORY
rHG Mercurial
REVISION DETAIL
av6 added inline comments.
INLINE COMMENTS
> configitems.py:569
> )
> +coreconfigitem('experimental', 'removeemptydirs',
> +default=True,
Not a huge deal for experimental options, but be aware of
https://www.mercurial-scm.org/wiki/UIGuideline#naming_config_options (which
recommends
# HG changeset patch
# User Anton Shestakov
# Date 1530154253 -28800
# Thu Jun 28 10:50:53 2018 +0800
# Node ID 184556878de102d6c328230ae31b0814be87c729
# Parent 9ddf150b8e266c7e81e018552630994529e54d50
hgweb: add archive entries to graph page
Changelog page has them, so it makes sense
# HG changeset patch
# User Anton Shestakov
# Date 1530142868 -28800
# Thu Jun 28 07:41:08 2018 +0800
# Node ID 9ddf150b8e266c7e81e018552630994529e54d50
# Parent b4cfd803b3f2697928be9b3a96787bcee3447c7e
hgweb: add z-index for search field tooltip
On graph page, search field tooltip
av6 added inline comments.
INLINE COMMENTS
> .editorconfig:17
> +indent_style = space
> +indent_size = 2
> +trim_trailing_whitespace = false
Nit: I'd sort these two lines for consistency with the two entries above,
otherwise looks good.
REPOSITORY
rHG Mercurial
REVISION DETAIL
# HG changeset patch
# User Anton Shestakov
# Date 1528291182 -28800
# Wed Jun 06 21:19:42 2018 +0800
# Branch stable
# Node ID 70ab2906aaf6320753375f380510e19718008a63
# Parent 19878108d5dbea75c97d3dcbf7d7af5434934e13
templatefuncs: only render text portion of minirst.format() result
When
# HG changeset patch
# User Anton Shestakov
# Date 1528290926 -28800
# Wed Jun 06 21:15:26 2018 +0800
# Branch stable
# Node ID 19878108d5dbea75c97d3dcbf7d7af5434934e13
# Parent 79c54e7c0c5279b315e43540b98fb22c4843d79b
tests: demonstrate that hgweb renders "pruned" that mini
av6 added a comment.
In https://phab.mercurial-scm.org/D3649#57901, @nspanti-logilab wrote:
> Could you describe tests that you would like?
For example, some that check that url is correct and is printed on stdout and
not stderr, maybe also that it is printed when --port is
av6 added a comment.
https://phab.mercurial-scm.org/D3649 mentions `xdg-open "$(hg serve
--print-url)"`, which shows that --print-url can nearly replace --graphical and
is more versatile.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D3650
To:
av6 added a comment.
Merits another patch with some simple tests.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D3649
To: nspanti-logilab, #hg-reviewers, durin42
Cc: av6, yuja, mercurial-devel
___
Mercurial-devel
# HG changeset patch
# User Anton Shestakov
# Date 1527756722 -28800
# Thu May 31 16:52:02 2018 +0800
# Node ID 5763aad1f7b9643c761d82a757ee0504a32b7c41
# Parent 5a87bf0bd34377f10b19d770acb943d7fda250f3
spartan: add missing closing tags
Browsers apparently don't care about this, but let's
# HG changeset patch
# User Anton Shestakov
# Date 1527763175 -28800
# Thu May 31 18:39:35 2018 +0800
# Node ID 376f6749677c4490644fef7590df666f66f0a47d
# Parent d588869f4819d644a448456535f5f860be3d0aca
monoblue: don't show '[up]' in file view when in root directory already
diff --git
# HG changeset patch
# User Anton Shestakov
# Date 1527762829 -28800
# Thu May 31 18:33:49 2018 +0800
# Node ID d588869f4819d644a448456535f5f860be3d0aca
# Parent 75ffc56c904c74db5f77643de8bfe8c84a31ccbf
gitweb: don't show '[up]' in file view when in root directory already
diff --git
# HG changeset patch
# User Anton Shestakov
# Date 1527764008 -28800
# Thu May 31 18:53:28 2018 +0800
# Node ID a9591fc50eb394454125df2807c1fcd8f3cd8193
# Parent 376f6749677c4490644fef7590df666f66f0a47d
spartan: don't show '[up]' in file view when in root directory already
diff --git
# HG changeset patch
# User Anton Shestakov
# Date 1527760914 -28800
# Thu May 31 18:01:54 2018 +0800
# Node ID 75ffc56c904c74db5f77643de8bfe8c84a31ccbf
# Parent 5763aad1f7b9643c761d82a757ee0504a32b7c41
paper: don't show '[up]' in file view when in root directory already
diff --git
# HG changeset patch
# User Anton Shestakov <a...@dwimlabs.net>
# Date 1527241096 -7200
# Fri May 25 11:38:16 2018 +0200
# Node ID 8133b5cebe9bcc24d91a0e5dfe2b191a11e4bb44
# Parent 6f67bfe4b82f1d0f1e11a7092262f961c49fdac9
extensions: PoC readme extension for hgweb
Here's a pro
On Tue, 08 May 2018 22:45:33 +0900
Yuya Nishihara wrote:
> # HG changeset patch
> # User Yuya Nishihara
> # Date 1522595199 -32400
> # Mon Apr 02 00:06:39 2018 +0900
> # Node ID b8887d7a2962c450cb9d1aa2be447f102ae776ab
> # Parent
# HG changeset patch
# User Anton Shestakov <a...@dwimlabs.net>
# Date 1525773297 -28800
# Tue May 08 17:54:57 2018 +0800
# Node ID 223f04ec87e4d17492a7ea7dc4bab1d9bd5c9fdf
# Parent 92213f6745ed6f2c50feca9a2261b6f33a9a32fa
templates: split getgraphnode() body into two fun
# HG changeset patch
# User Anton Shestakov <a...@dwimlabs.net>
# Date 1525777201 -28800
# Tue May 08 19:00:01 2018 +0800
# Node ID a1829e98f2a1ef920a49e48c89a8c4dfdb3e0c97
# Parent 223f04ec87e4d17492a7ea7dc4bab1d9bd5c9fdf
hgweb: reuse graph node-related functions from tem
# HG changeset patch
# User Anton Shestakov <a...@dwimlabs.net>
# Date 1524816850 -28800
# Fri Apr 27 16:14:10 2018 +0800
# Node ID 65ddff799cfd4d8c47b246350f8df8581c0c3c78
# Parent 3f26434bdf5cfcff3cf09aba84cc6121e5ffae32
obshistory: use a more appropriate type for obslog entries
# HG changeset patch
# User Anton Shestakov <a...@dwimlabs.net>
# Date 1524817714 -28800
# Fri Apr 27 16:28:34 2018 +0800
# Node ID f7eb6844f979e476e272672d50718dd589562b83
# Parent 73e62fe390ee02620c30878b333a20fa18d644b1
tests: test that `hg obslog wdir()` aborts with a useful m
# HG changeset patch
# User Anton Shestakov <a...@dwimlabs.net>
# Date 1524817185 -28800
# Fri Apr 27 16:19:45 2018 +0800
# Node ID 73e62fe390ee02620c30878b333a20fa18d644b1
# Parent 65ddff799cfd4d8c47b246350f8df8581c0c3c78
obshistory: make obslog work when a commit doesn't ha
On Sun, 15 Apr 2018 15:24:28 +0200
Antonio Muci wrote:
> Summarizing: I would try to find a more robust way of generating
> packages, but it will take some time.
Yep, people did discover that the way we do it now is not the most
"correct", but it's hard to formulate what is
# HG changeset patch
# User Anton Shestakov <a...@dwimlabs.net>
# Date 1523792494 -28800
# Sun Apr 15 19:41:34 2018 +0800
# Node ID 2efab3bfa60156194390b82a537514445c12ff86
# Parent b79993a8e173820205b21cb5c0821183bf68ed39
templates: adjust white space amount in the output of {whyun
# HG changeset patch
# User Anton Shestakov <a...@dwimlabs.net>
# Date 1523791681 -28800
# Sun Apr 15 19:28:01 2018 +0800
# Node ID b79993a8e173820205b21cb5c0821183bf68ed39
# Parent bf715ddd88d1e4b0d3bd72d0f7ab6398662096ed
tests: split long templates that use {whyunstable} and pu
# HG changeset patch
# User Anton Shestakov <a...@dwimlabs.net>
# Date 1523788069 -28800
# Sun Apr 15 18:27:49 2018 +0800
# Node ID 5b7426809d1df5b486205c87321c9db59e5d1e74
# Parent 24034bcd32fb97d457ef9b9fea3ecc6ac953a09d
tests: hg log shouldn't need --hidden to show whyunstable te
# HG changeset patch
# User Anton Shestakov <a...@dwimlabs.net>
# Date 1523788642 -28800
# Sun Apr 15 18:37:22 2018 +0800
# Node ID bf715ddd88d1e4b0d3bd72d0f7ab6398662096ed
# Parent 5b7426809d1df5b486205c87321c9db59e5d1e74
tests: make custom templates that use {whyunstable}
On Sat, 14 Apr 2018 18:31:24 +0200
Antonio Muci via Mercurial-devel
wrote:
> # HG changeset patch
> # User Antonio Muci
> # Date 1523714275 -7200
> # Sat Apr 14 15:57:55 2018 +0200
> # Node ID 3c8463e542db60db1ad234ec80f39e290ed17658
> #
On Sat, 14 Apr 2018 21:49:17 +0900
Yuya Nishihara wrote:
> -class _siblings(object):
> -def __init__(self, siblings=None, hiderev=None):
> -if siblings is None:
> -siblings = []
> -self.siblings = [s for s in siblings if s.node() != nullid]
> -
On Sat, 14 Apr 2018 21:49:17 +0900
Yuya Nishihara wrote:
> # HG changeset patch
> # User Yuya Nishihara
> # Date 1522594234 -32400
> # Sun Apr 01 23:50:34 2018 +0900
> # Node ID fe959b32685068231cad8ef26387c7c16fe0961a
> # Parent
On Sat, 14 Apr 2018 21:03:23 +0900
Yuya Nishihara <y...@tcha.org> wrote:
> On Sat, 14 Apr 2018 19:43:15 +0800, Anton Shestakov wrote:
> > # HG changeset patch
> > # User Anton Shestakov <a...@dwimlabs.net>
> > # Date 1522054812 -28800
> > # Mon M
On Sat, 14 Apr 2018 21:09:46 +0900
Yuya Nishihara <y...@tcha.org> wrote:
> On Sat, 14 Apr 2018 19:43:16 +0800, Anton Shestakov wrote:
> > # HG changeset patch
> > # User Anton Shestakov <a...@dwimlabs.net>
> > # Date 1523705764 -28800
> > # Sat A
# HG changeset patch
# User Anton Shestakov <a...@dwimlabs.net>
# Date 1523709254 -28800
# Sat Apr 14 20:34:14 2018 +0800
# Node ID c7fc8a7ca7f5ca13e7e54a2690872f4252a41796
# Parent 987c05eac1801d0b919c874280d03f9e8cccb411
templates: make divergentnodes in whyunstable keyword be a
On Mon, 26 Mar 2018 22:13:18 +0900
Yuya Nishihara <y...@tcha.org> wrote:
> On Mon, 26 Mar 2018 19:55:20 +0800, Anton Shestakov wrote:
> > # HG changeset patch
> > # User Anton Shestakov <a...@dwimlabs.net>
> > # Date 1522054812 -28800
> > # Mon M
# HG changeset patch
# User Anton Shestakov <a...@dwimlabs.net>
# Date 1523705764 -28800
# Sat Apr 14 19:36:04 2018 +0800
# Node ID 6287c68bde7bcdc1dc260da9983ecc7fffc9ee20
# Parent 987c05eac1801d0b919c874280d03f9e8cccb411
templates: make divergentnodes in whyunstable k
# HG changeset patch
# User Anton Shestakov <a...@dwimlabs.net>
# Date 1522054812 -28800
# Mon Mar 26 17:00:12 2018 +0800
# Node ID 987c05eac1801d0b919c874280d03f9e8cccb411
# Parent 8bacc09814ba5500d15fb40c472e84cb95ae2f99
templates: add whyunstable template keyword
diff --git a/mer
# HG changeset patch
# User Anton Shestakov <a...@dwimlabs.net>
# Date 1523510910 -28800
# Thu Apr 12 13:28:30 2018 +0800
# Node ID ef38b973097170304e7d4b62c6605d84d73fcc30
# Parent b36e38e3a1769fb4acf1b3dadcaeec998260113f
stablerange: include units in ui.progress() calls
diff
# HG changeset patch
# User Anton Shestakov <a...@dwimlabs.net>
# Date 1523511028 -28800
# Thu Apr 12 13:30:28 2018 +0800
# Node ID b9fba41c577de088b6582cae3f8a4603afda5589
# Parent ef38b973097170304e7d4b62c6605d84d73fcc30
stablerangecache: include units in ui.progress() calls
diff
On Wed, 11 Apr 2018 00:41:41 +0900
Yuya Nishihara wrote:
> # HG changeset patch
> # User Yuya Nishihara
> # Date 1522590109 -32400
> # Sun Apr 01 22:41:49 2018 +0900
> # Node ID a4d06c685ee182279e91c2856d8a69e809c6e317
> # Parent
# HG changeset patch
# User Anton Shestakov <a...@dwimlabs.net>
# Date 1523191987 -28800
# Sun Apr 08 20:53:07 2018 +0800
# Node ID 281674337d7709b4fa8e4d0425e7879c2300af28
# Parent 6d5ee23ffa66b61abf6466b87d8e813141fed364
hgweb: make followlines button absolutely positioned
It used t
# HG changeset patch
# User Anton Shestakov <a...@dwimlabs.net>
# Date 1523282411 -28800
# Mon Apr 09 22:00:11 2018 +0800
# Node ID 6d5ee23ffa66b61abf6466b87d8e813141fed364
# Parent 0a1fb171dc1ddd6a1cd1a5666e92299db12e9f5d
hgweb: insert followlines buttons before any children, includin
# HG changeset patch
# User Anton Shestakov <a...@dwimlabs.net>
# Date 152281 -28800
# Wed Apr 04 13:14:48 2018 +0800
# Node ID ac7a25c5acc5b69305d78b2d56475f9599553711
# Parent 281674337d7709b4fa8e4d0425e7879c2300af28
paper: make all source lines have the same minimum height
# HG changeset patch
# User Anton Shestakov <a...@dwimlabs.net>
# Date 152281 -28800
# Wed Apr 04 13:14:48 2018 +0800
# Node ID 7279e5d2e3b27b46b19218f91f19023bce5f6c30
# Parent 41826e0ae22d24a04cc1f4b911a56b787635fa6e
paper: make all source lines have the same minimum height
# HG changeset patch
# User Anton Shestakov <a...@dwimlabs.net>
# Date 1523191987 -28800
# Sun Apr 08 20:53:07 2018 +0800
# Node ID 41826e0ae22d24a04cc1f4b911a56b787635fa6e
# Parent 0a1fb171dc1ddd6a1cd1a5666e92299db12e9f5d
hgweb: make followlines button absolutely positioned
It used t
av6 added inline comments.
INLINE COMMENTS
> commands.py:3872
> +if opts['dry_run']:
> +raise error.Abort(_("can't use --dryrun when no targetphase"))
> # display
`"cannot use --dry-run without target phase"`
REPOSITORY
rHG Mercurial
REVISION DETAIL
# HG changeset patch
# User Anton Shestakov <a...@dwimlabs.net>
# Date 1522996596 -28800
# Fri Apr 06 14:36:36 2018 +0800
# Node ID ce9f0f1cfbc2bc7fd305625d9da79953fcd43fe1
# Parent 58ee2c2c7cdf8671c181035c5293bbbc91a3f05f
stablerangecache: use self instead o
# HG changeset patch
# User Anton Shestakov <a...@dwimlabs.net>
# Date 1522996642 -28800
# Fri Apr 06 14:37:22 2018 +0800
# Node ID 86695bae7a72ae1b64ec6d1fa9370abf473f6544
# Parent ce9f0f1cfbc2bc7fd305625d9da79953fcd43fe1
safeguard: use self instead of repo in noautopublishrepo.che
# HG changeset patch
# User Anton Shestakov <a...@dwimlabs.net>
# Date 1522995984 -28800
# Fri Apr 06 14:26:24 2018 +0800
# Node ID 58ee2c2c7cdf8671c181035c5293bbbc91a3f05f
# Parent 01108d67523ff366e18ba324e64edf527d8df1e5
obscache: use self instead of repo in obscacherepo.update
# HG changeset patch
# User Anton Shestakov <a...@dwimlabs.net>
# Date 152281 -28800
# Wed Apr 04 13:14:48 2018 +0800
# Node ID cec6b1932d091667b65daa5d2260b665a7f07e81
# Parent 0a1fb171dc1ddd6a1cd1a5666e92299db12e9f5d
paper: make all source lines have the same minimum
av6 requested changes to this revision.
av6 added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> templatefilters.py:293-294
> def person(author):
> -"""Any text. Returns the name before an email address,
> -interpreting it as per RFC 5322.
> -
Don't
av6 added inline comments.
INLINE COMMENTS
> stringutil.py:310
> +'''
> +return bool(_correctauthorformat.match(author))
Nit: `is not None` is more pythonic.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2959
To: sheehan, #hg-reviewers
Cc: av6,
On Mon, 26 Mar 2018 22:13:18 +0900
Yuya Nishihara wrote:
> Can you hold off this series for 2-3 weeks?
Sure, I'll do that.
> I have long series which will
> add a wrapper for a list of template mappings. Basically it will allow us
> to write the default string representation as
# HG changeset patch
# User Anton Shestakov <a...@dwimlabs.net>
# Date 1522062197 -28800
# Mon Mar 26 19:03:17 2018 +0800
# Node ID cc4c495dc38d5cf3a1b7e1162f1c745c1440de01
# Parent 123d9e4d706909c8912f11acee292735c0fb283c
debug: remove debugwhyunstable command
It was intr
# HG changeset patch
# User Anton Shestakov <a...@dwimlabs.net>
# Date 1522054812 -28800
# Mon Mar 26 17:00:12 2018 +0800
# Node ID 123d9e4d706909c8912f11acee292735c0fb283c
# Parent 6f570c501e3ebc3d9b59920f50ed7523d93cb847
templates: add whyunstable template keyword
diff --git a/mer
av6 added inline comments.
INLINE COMMENTS
> commands.py:2485
> +fm.data(node=fm.hexfunc(scmutil.binnode(ctx)))
> +if not bool(opts.get('all')) and not bool(opts.get('rev')):
> +cols = [
This line looks identical to the one later on, with Pulkit's comment
av6 added inline comments.
INLINE COMMENTS
> cmdutil.py:2007
> +if dryrun and confirm:
> +raise error.Abort(_("can't specify --dry-run and --confirm"))
> join = lambda f: os.path.join(prefix, f)
"cannot specify both --dry-run and --confirm" is the style used in other
commands.
On Wed, 21 Mar 2018 23:56:55 +0530
Sushil khanchi wrote:
> diff -r b6a4881cec19 -r 35c57ba0cf28 mercurial/commands.py
> --- a/mercurial/commands.py Sun Mar 18 15:32:49 2018 -0400
> +++ b/mercurial/commands.py Wed Mar 21 23:36:11 2018 +0530
> @@ -4207,7 +4207,7 @@
>
# HG changeset patch
# User Anton Shestakov <a...@dwimlabs.net>
# Date 1521526325 -28800
# Tue Mar 20 14:12:05 2018 +0800
# Node ID 6ee52d3b6bd4b86a68799cc969035cd0fd77ffe5
# Parent e349ad5cbb7195607a300439a12a5316795125f8
obsolete: add a note that explains creating aliases for marker
# HG changeset patch
# User Anton Shestakov <a...@dwimlabs.net>
# Date 1521526768 -28800
# Tue Mar 20 14:19:28 2018 +0800
# Node ID 81060ada33729a2b4f250f72416a3efab2c5f398
# Parent e349ad5cbb7195607a300439a12a5316795125f8
hgweb: explain instabilities of unstable changesets (th
# HG changeset patch
# User Anton Shestakov <a...@dwimlabs.net>
# Date 1519649041 -28800
# Mon Feb 26 20:44:01 2018 +0800
# Node ID cbe8de8d3714cefbe2d96553e720efd96ae466cb
# Parent b7b0c187d6aef20b63d48e1c98fcc923353fc707
# EXP-Topic whyunstable-obsutil
debug: add debugwhyun
# HG changeset patch
# User Anton Shestakov <a...@dwimlabs.net>
# Date 1520944478 -28800
# Tue Mar 13 20:34:38 2018 +0800
# Node ID b7b0c187d6aef20b63d48e1c98fcc923353fc707
# Parent 31581528f2421dc5d8a567125b8ecc0367b2b906
# EXP-Topic whyunstable-obsutil
obsolete: move marker
# HG changeset patch
# User Anton Shestakov <a...@dwimlabs.net>
# Date 1519649061 -28800
# Mon Feb 26 20:44:21 2018 +0800
# Node ID 3dd25c1472fb9ecd62b3fdd529ceee6c9810b4de
# Parent cbe8de8d3714cefbe2d96553e720efd96ae466cb
# EXP-Topic whyunstable-obsutil
hgweb: explain instabi
On Wed, 28 Feb 2018 00:44:49 +0900
Yuya Nishihara <y...@tcha.org> wrote:
> On Tue, 27 Feb 2018 21:11:17 +0800, Anton Shestakov wrote:
> > On Tue, 27 Feb 2018 20:45:21 +0900
> > Yuya Nishihara <y...@tcha.org> wrote:
> >
> > > On Mon, 26 Feb 2018 22:05:26
# HG changeset patch
# User Anton Shestakov <a...@dwimlabs.net>
# Date 1519649061 -28800
# Mon Feb 26 20:44:21 2018 +0800
# Node ID cded6bf4a90d43ff2b197f3b1e864a97ab99531f
# Parent 3372fb5de4a6f5a6e327d4d98d57f4e94ae64b60
# EXP-Topic whyunstable-obsolete
hgweb: explain instabi
# HG changeset patch
# User Anton Shestakov <a...@dwimlabs.net>
# Date 1520944478 -28800
# Tue Mar 13 20:34:38 2018 +0800
# Node ID 3372fb5de4a6f5a6e327d4d98d57f4e94ae64b60
# Parent 31581528f2421dc5d8a567125b8ecc0367b2b906
# EXP-Topic whyunstable-obsolete
debug: add debugwhyun
av6 added inline comments.
INLINE COMMENTS
> martinvonz wrote in request.py:45
> Would it make sense to make this an error if there isn't exactly one value?
I don't think it would. AIUI, that would make handling query strings like
?style=foo=bar just more difficult. I'm not aware of any web
201 - 300 of 460 matches
Mail list logo