Re: [PATCH] pager: exit cleanly on SIGPIPE (BC)

2017-02-08 Thread David Soria Parra
On Wed, Feb 08, 2017 at 07:47:39AM -0800, Simon Farnsworth wrote: > # HG changeset patch > # User Simon Farnsworth > # Date 1486568650 28800 > # Wed Feb 08 07:44:10 2017 -0800 > # Node ID d50cda2a403786836d1f0d5c99401599dc4f43ec > # Parent

Re: [PATCH 04 of 10 ipv6 V2] tinyproxy: use IPv6 if HGIPV6 is set to 1

2017-02-20 Thread David Soria Parra
On Fri, Feb 17, 2017 at 10:51:18AM -0800, Jun Wu wrote: > # HG changeset patch > # User Jun Wu > # Date 1487228025 28800 > # Wed Feb 15 22:53:45 2017 -0800 > # Node ID c34ad0f0fc375de9e2d96d17ddcb644d9054d154 > # Parent 5e76ef1698fde7a47fa78003beac71324793d051 > # Available At

Re: [PATCH 04 of 10 ipv6 V2] tinyproxy: use IPv6 if HGIPV6 is set to 1

2017-02-21 Thread David Soria Parra
On Mon, Feb 20, 2017 at 07:03:36PM -0800, Jun Wu wrote: > > Thanks for pointing out the RFC. > > The V1 series was ipv6 by default. But buildbot was not happy with all > changes. In order to make all changesets green, I have to temporarily > disable V6 handling, therefore V2 and IPv4 by default.

Re: [PATCH] formatter: add context manager interface for convenience

2016-08-30 Thread David Soria Parra
On Wed, Aug 31, 2016 at 12:05:58AM +0900, Yuya Nishihara wrote: > # HG changeset patch > # User Yuya Nishihara > # Date 1472396405 -32400 > # Mon Aug 29 00:00:05 2016 +0900 > # Node ID 41fea255bd1cda8d0f482b2582aec8a29f86c303 > # Parent

Re: [PATCH 1 of 6 v2] [convert] Use convert_revision for P4 imports

2016-12-07 Thread David Soria Parra
On Wed, Dec 07, 2016 at 09:48:28PM +, Kostia Balytskyi wrote: > On 12/7/16 9:30 PM, David Soria Parra wrote: > > # HG changeset patch > > # User David Soria Parra <davi...@fb.com> > > # Date 1480895549 28800 > > # Sun Dec 04

[PATCH 1 of 6 v2] [convert] Use convert_revision for P4 imports

2016-12-07 Thread David Soria Parra
# HG changeset patch # User David Soria Parra <davi...@fb.com> # Date 1480895549 28800 # Sun Dec 04 15:52:29 2016 -0800 # Node ID ade3103f5cf939007ca73af5e9e5853643dc8264 # Parent 48bf03a8f718f870256f79cbdf10550ca92c7f25 [convert] Use convert_revision for P4 imports We are

[PATCH 3 of 6 v3] convert: Allow passing in a revmap

2016-12-07 Thread David Soria Parra
# HG changeset patch # User David Soria Parra <davi...@fb.com> # Date 1480896014 28800 # Sun Dec 04 16:00:14 2016 -0800 # Node ID 897be730ab884aa8f7373a34eeb6a288cc1dabc7 # Parent c0168cd90fd67ccd20271416e0994abe6f95a201 convert: Allow passing in a revmap Implement `setrevmap` whi

[PATCH 5 of 6 v3] convert: Encapsulate commit data fetching and commit object creation

2016-12-07 Thread David Soria Parra
# HG changeset patch # User David Soria Parra <davi...@fb.com> # Date 1481140978 28800 # Wed Dec 07 12:02:58 2016 -0800 # Node ID be68e4436851b7e20f3b8cb34666418f5840dd66 # Parent e3c34b2fafd7ce1a78d23e35888a33ef10629fbf convert: Encapsulate commit data fetching and commit object cr

[PATCH 1 of 6 v3] convert: Use convert_revision for P4 imports

2016-12-07 Thread David Soria Parra
# HG changeset patch # User David Soria Parra <davi...@fb.com> # Date 1480895549 28800 # Sun Dec 04 15:52:29 2016 -0800 # Node ID 1f9a627a126694d67f3664dae387d8b98fa44ddb # Parent 48bf03a8f718f870256f79cbdf10550ca92c7f25 convert: Use convert_revision for P4 imports We are

[PATCH 4 of 6] [convert] Parse perforce changes when needed, not in the constructor

2016-12-07 Thread David Soria Parra
# HG changeset patch # User David Soria Parra <davi...@fb.com> # Date 1481139471 28800 # Wed Dec 07 11:37:51 2016 -0800 # Node ID 4e7c528ec68f36e26535614e9c8ef067305bdbbe # Parent e929ae5ce21443ecce43302abb006148c54ed0e3 [convert] Parse perforce changes when needed, not in the const

[PATCH 6 of 6 v3] convert: Create commits from revmap list if needed

2016-12-07 Thread David Soria Parra
# HG changeset patch # User David Soria Parra <davi...@fb.com> # Date 1481143876 28800 # Wed Dec 07 12:51:16 2016 -0800 # Node ID 109de539306c5bc49d38d6f1c802c4a8d092b485 # Parent be68e4436851b7e20f3b8cb34666418f5840dd66 convert: Create commits from revmap list if needed diff --git a

[PATCH 2 of 6 v3] convert: Don't use long list comprehensions

2016-12-07 Thread David Soria Parra
# HG changeset patch # User David Soria Parra <davi...@fb.com> # Date 1481139493 28800 # Wed Dec 07 11:38:13 2016 -0800 # Node ID c0168cd90fd67ccd20271416e0994abe6f95a201 # Parent 1f9a627a126694d67f3664dae387d8b98fa44ddb convert: Don't use long list comprehensions We are iteratin

[PATCH 3 of 6] [convert] Allow passing in a revmap

2016-12-07 Thread David Soria Parra
# HG changeset patch # User David Soria Parra <davi...@fb.com> # Date 1480896014 28800 # Sun Dec 04 16:00:14 2016 -0800 # Node ID e929ae5ce21443ecce43302abb006148c54ed0e3 # Parent eca976dd5da759a1fb1a71c648624a240156adb9 [convert] Allow passing in a revmap Implement `setrevmap` whi

[PATCH 1 of 6] [convert] Use convert_revision for P4 imports

2016-12-07 Thread David Soria Parra
# HG changeset patch # User David Soria Parra <davi...@fb.com> # Date 1480895549 28800 # Sun Dec 04 15:52:29 2016 -0800 # Node ID ade3103f5cf939007ca73af5e9e5853643dc8264 # Parent 48bf03a8f718f870256f79cbdf10550ca92c7f25 [convert] Use convert_revision for P4 imports We are

[PATCH 4 of 6 v3] convert: Parse perforce changes when needed, not in the constructor

2016-12-07 Thread David Soria Parra
# HG changeset patch # User David Soria Parra <davi...@fb.com> # Date 1481139471 28800 # Wed Dec 07 11:37:51 2016 -0800 # Node ID e3c34b2fafd7ce1a78d23e35888a33ef10629fbf # Parent 897be730ab884aa8f7373a34eeb6a288cc1dabc7 convert: Parse perforce changes when needed, not in the const

[PATCH 5 of 6 v2] [convert] Encapsulate commit data fetching and commit object creation

2016-12-07 Thread David Soria Parra
# HG changeset patch # User David Soria Parra <davi...@fb.com> # Date 1481140978 28800 # Wed Dec 07 12:02:58 2016 -0800 # Node ID e6aa56ec31278dcb4984f65776a3715a92aba180 # Parent 4e7c528ec68f36e26535614e9c8ef067305bdbbe [convert] Encapsulate commit data fetching and commit object cr

[PATCH 4 of 6 v2] [convert] Parse perforce changes when needed, not in the constructor

2016-12-07 Thread David Soria Parra
# HG changeset patch # User David Soria Parra <davi...@fb.com> # Date 1481139471 28800 # Wed Dec 07 11:37:51 2016 -0800 # Node ID 4e7c528ec68f36e26535614e9c8ef067305bdbbe # Parent e929ae5ce21443ecce43302abb006148c54ed0e3 [convert] Parse perforce changes when needed, not in the const

[PATCH 6 of 6] [convert] Create commits from revmap list if needed

2016-12-07 Thread David Soria Parra
# HG changeset patch # User David Soria Parra <davi...@fb.com> # Date 1481143876 28800 # Wed Dec 07 12:51:16 2016 -0800 # Node ID 8dfeb4ee8c626d50f0402a9bd1939ee916bf9b42 # Parent e6aa56ec31278dcb4984f65776a3715a92aba180 [convert] Create commits from revmap list if needed diff --git a

[PATCH 5 of 6] [convert] Encapsulate commit data fetching and commit object creation

2016-12-07 Thread David Soria Parra
# HG changeset patch # User David Soria Parra <davi...@fb.com> # Date 1481140978 28800 # Wed Dec 07 12:02:58 2016 -0800 # Node ID e6aa56ec31278dcb4984f65776a3715a92aba180 # Parent 4e7c528ec68f36e26535614e9c8ef067305bdbbe [convert] Encapsulate commit data fetching and commit object cr

[PATCH 4 of 6] [convert] Parse perforce changes when needed, not in the constructor

2016-12-07 Thread David Soria Parra
# HG changeset patch # User David Soria Parra <davi...@fb.com> # Date 1481139471 28800 # Wed Dec 07 11:37:51 2016 -0800 # Node ID 4e7c528ec68f36e26535614e9c8ef067305bdbbe # Parent e929ae5ce21443ecce43302abb006148c54ed0e3 [convert] Parse perforce changes when needed, not in the const

[PATCH 6 of 6] [convert] Create commits from revmap list if needed

2016-12-07 Thread David Soria Parra
# HG changeset patch # User David Soria Parra <davi...@fb.com> # Date 1481143876 28800 # Wed Dec 07 12:51:16 2016 -0800 # Node ID 8dfeb4ee8c626d50f0402a9bd1939ee916bf9b42 # Parent e6aa56ec31278dcb4984f65776a3715a92aba180 [convert] Create commits from revmap list if needed diff --git a

[PATCH 5 of 6] [convert] Encapsulate commit data fetching and commit object creation

2016-12-07 Thread David Soria Parra
# HG changeset patch # User David Soria Parra <davi...@fb.com> # Date 1481140978 28800 # Wed Dec 07 12:02:58 2016 -0800 # Node ID e6aa56ec31278dcb4984f65776a3715a92aba180 # Parent 4e7c528ec68f36e26535614e9c8ef067305bdbbe [convert] Encapsulate commit data fetching and commit object cr

[PATCH 2 of 6] [convert] Don't use long list comprehensions

2016-12-07 Thread David Soria Parra
# HG changeset patch # User David Soria Parra <davi...@fb.com> # Date 1481139493 28800 # Wed Dec 07 11:38:13 2016 -0800 # Node ID eca976dd5da759a1fb1a71c648624a240156adb9 # Parent ade3103f5cf939007ca73af5e9e5853643dc8264 [convert] Don't use long list comprehensions We are iteratin

[PATCH 1 of 6] [convert] Use convert_revision for P4 imports

2016-12-07 Thread David Soria Parra
# HG changeset patch # User David Soria Parra <davi...@fb.com> # Date 1480895549 28800 # Sun Dec 04 15:52:29 2016 -0800 # Node ID ade3103f5cf939007ca73af5e9e5853643dc8264 # Parent 48bf03a8f718f870256f79cbdf10550ca92c7f25 [convert] Use convert_revision for P4 imports We are

[PATCH 2 of 6] [convert] Don't use long list comprehensions

2016-12-07 Thread David Soria Parra
# HG changeset patch # User David Soria Parra <davi...@fb.com> # Date 1481139493 28800 # Wed Dec 07 11:38:13 2016 -0800 # Node ID eca976dd5da759a1fb1a71c648624a240156adb9 # Parent ade3103f5cf939007ca73af5e9e5853643dc8264 [convert] Don't use long list comprehensions We are iteratin

[PATCH 6 of 8 v4] convert: do not provide head revisions if we have no changests to import

2016-12-14 Thread David Soria Parra
# HG changeset patch # User David Soria Parra <davi...@fb.com> # Date 1481694598 28800 # Tue Dec 13 21:49:58 2016 -0800 # Node ID c6c26e238617600d0523b44a9043d17f963f9eda # Parent 4b9d267d2a05970d9320b83f8bf29ec99f8ab40f convert: do not provide head revisions if we have no cha

[PATCH 7 of 8 v4] convert: encapsulate commit data fetching and commit object creation

2016-12-14 Thread David Soria Parra
# HG changeset patch # User David Soria Parra <davi...@fb.com> # Date 1481694598 28800 # Tue Dec 13 21:49:58 2016 -0800 # Node ID 26ec2474ab06fdaf1aca034c54309245ded267b0 # Parent c6c26e238617600d0523b44a9043d17f963f9eda convert: encapsulate commit data fetching and commit object cr

[PATCH 8 of 8 v4] convert: return commit objects for revisions in the revmap

2016-12-14 Thread David Soria Parra
# HG changeset patch # User David Soria Parra <davi...@fb.com> # Date 1481704712 28800 # Wed Dec 14 00:38:32 2016 -0800 # Node ID eb4a6df3de20deb31e681aa7eba408dc352440c3 # Parent 26ec2474ab06fdaf1aca034c54309245ded267b0 convert: return commit objects for revisions in the revmap

[PATCH 1 of 8 v4] convert: don't use long list comprehensions

2016-12-14 Thread David Soria Parra
# HG changeset patch # User David Soria Parra <davi...@fb.com> # Date 1481694598 28800 # Tue Dec 13 21:49:58 2016 -0800 # Node ID 506cb0034ebdbe85d2a7174d9214f833b3fed3fb # Parent 76e77076e203fa0b42ff371c7a326580f27245cb convert: don't use long list comprehensions We are iteratin

[PATCH 4 of 8 v4] convert: use convert_revision for P4 imports

2016-12-14 Thread David Soria Parra
# HG changeset patch # User David Soria Parra <davi...@fb.com> # Date 1481694598 28800 # Tue Dec 13 21:49:58 2016 -0800 # Node ID 92b0ad25b4aca99c74d3813ddae163324c1110a7 # Parent 34621390d72ed1e23f30e6c8d0233d46e9d40ef2 convert: use convert_revision for P4 imports We are

[PATCH 3 of 8 v4] convert: remove unused dictionaries

2016-12-14 Thread David Soria Parra
# HG changeset patch # User David Soria Parra <davi...@fb.com> # Date 1481708717 28800 # Wed Dec 14 01:45:17 2016 -0800 # Node ID 34621390d72ed1e23f30e6c8d0233d46e9d40ef2 # Parent 09e574c75df2e3547a40f9d9b13464c63235136c convert: remove unused dictionaries self.parent, self.last

[PATCH 5 of 8 v4] convert: allow passing in a revmap

2016-12-14 Thread David Soria Parra
# HG changeset patch # User David Soria Parra <davi...@fb.com> # Date 1481708757 28800 # Wed Dec 14 01:45:57 2016 -0800 # Node ID 4b9d267d2a05970d9320b83f8bf29ec99f8ab40f # Parent 92b0ad25b4aca99c74d3813ddae163324c1110a7 convert: allow passing in a revmap Implement `common.setrevmap`

Re: [PATCH 8 of 8 v4] convert: return commit objects for revisions in the revmap

2016-12-14 Thread David Soria Parra
On Wed, Dec 14, 2016 at 04:53:24PM +, Kostia Balytskyi wrote: > > > On 12/14/16 9:46 AM, David Soria Parra wrote: > > # HG changeset patch > > # User David Soria Parra <davi...@fb.com> > > # Date 1481704712 28800 > > # Wed D

[PATCH 3 of 8 v5] convert: remove unused dictionaries

2016-12-14 Thread David Soria Parra
# HG changeset patch # User David Soria Parra <davi...@fb.com> # Date 1481708717 28800 # Wed Dec 14 01:45:17 2016 -0800 # Node ID 34621390d72ed1e23f30e6c8d0233d46e9d40ef2 # Parent 09e574c75df2e3547a40f9d9b13464c63235136c convert: remove unused dictionaries self.parent, self.last

[PATCH 2 of 8 v5] convert: self.heads is a list

2016-12-14 Thread David Soria Parra
# HG changeset patch # User David Soria Parra <davi...@fb.com> # Date 1481708627 28800 # Wed Dec 14 01:43:47 2016 -0800 # Node ID 09e574c75df2e3547a40f9d9b13464c63235136c # Parent 506cb0034ebdbe85d2a7174d9214f833b3fed3fb convert: self.heads is a list self.heads is used as a list thro

[PATCH 7 of 8 v5] convert: encapsulate commit data fetching and commit object creation

2016-12-14 Thread David Soria Parra
# HG changeset patch # User David Soria Parra <davi...@fb.com> # Date 1481694598 28800 # Tue Dec 13 21:49:58 2016 -0800 # Node ID 26ec2474ab06fdaf1aca034c54309245ded267b0 # Parent c6c26e238617600d0523b44a9043d17f963f9eda convert: encapsulate commit data fetching and commit object cr

[PATCH 1 of 8 v5] convert: don't use long list comprehensions

2016-12-14 Thread David Soria Parra
# HG changeset patch # User David Soria Parra <davi...@fb.com> # Date 1481694598 28800 # Tue Dec 13 21:49:58 2016 -0800 # Node ID 506cb0034ebdbe85d2a7174d9214f833b3fed3fb # Parent 76e77076e203fa0b42ff371c7a326580f27245cb convert: don't use long list comprehensions We are iteratin

[PATCH 6 of 8 v5] convert: do not provide head revisions if we have no changests to import

2016-12-14 Thread David Soria Parra
# HG changeset patch # User David Soria Parra <davi...@fb.com> # Date 1481694598 28800 # Tue Dec 13 21:49:58 2016 -0800 # Node ID c6c26e238617600d0523b44a9043d17f963f9eda # Parent 4b9d267d2a05970d9320b83f8bf29ec99f8ab40f convert: do not provide head revisions if we have no cha

[PATCH 4 of 8 v5] convert: use convert_revision for P4 imports

2016-12-14 Thread David Soria Parra
# HG changeset patch # User David Soria Parra <davi...@fb.com> # Date 1481694598 28800 # Tue Dec 13 21:49:58 2016 -0800 # Node ID 92b0ad25b4aca99c74d3813ddae163324c1110a7 # Parent 34621390d72ed1e23f30e6c8d0233d46e9d40ef2 convert: use convert_revision for P4 imports We are

[PATCH 5 of 8 v5] convert: allow passing in a revmap

2016-12-14 Thread David Soria Parra
# HG changeset patch # User David Soria Parra <davi...@fb.com> # Date 1481708757 28800 # Wed Dec 14 01:45:57 2016 -0800 # Node ID 4b9d267d2a05970d9320b83f8bf29ec99f8ab40f # Parent 92b0ad25b4aca99c74d3813ddae163324c1110a7 convert: allow passing in a revmap Implement `common.setrevmap`

Re: [PATCH 6 of 6 v3] convert: Create commits from revmap list if needed

2016-12-07 Thread David Soria Parra
On Wed, Dec 07, 2016 at 10:23:08PM +, Kostia Balytskyi wrote: > On 12/7/16 9:51 PM, David Soria Parra wrote: > > # HG changeset patch > > # User David Soria Parra <davi...@fb.com> > > # Date 1481143876 28800 > > # Wed Dec 07

[PATCH 2 of 4] convert: move localname state to function scope

2016-12-20 Thread David Soria Parra
# HG changeset patch # User David Soria Parra <davi...@fb.com> # Date 1482254630 28800 # Tue Dec 20 09:23:50 2016 -0800 # Node ID 6f7154489117ac5cc9f0f876e922fef5c44803d8 # Parent 4cb85a7af6deb30abfd4c40ec8e502560150999e convert: move localname state to function scope diff --git a

[PATCH 3 of 4] convert: return calculated values from parse() instead of manpulating state

2016-12-20 Thread David Soria Parra
# HG changeset patch # User David Soria Parra <davi...@fb.com> # Date 1482254630 28800 # Tue Dec 20 09:23:50 2016 -0800 # Node ID 77e1912e2e0817a96633568c400450a9566e7e33 # Parent 6f7154489117ac5cc9f0f876e922fef5c44803d8 convert: return calculated values from parse() instead of manpu

[PATCH 4 of 4] convert: parse perforce data on-demand

2016-12-20 Thread David Soria Parra
# HG changeset patch # User David Soria Parra <davi...@fb.com> # Date 1482254630 28800 # Tue Dec 20 09:23:50 2016 -0800 # Node ID a047a142f151709f882361916617e762816db619 # Parent 77e1912e2e0817a96633568c400450a9566e7e33 convert: parse perforce data on-demand We are using rea

[PATCH] tests: exclude bundled pywatchman from check-code test

2016-12-20 Thread David Soria Parra
# HG changeset patch # User David Soria Parra <davi...@fb.com> # Date 1482294521 28800 # Tue Dec 20 20:28:41 2016 -0800 # Node ID 26a5b7f91ec50d20782816b83841bd8087478eb0 # Parent b090cdf0e161af0ac6768cb404cc0e51bb0baf00 tests: exclude bundled pywatchman from check-code test pywa

[PATCH] tests: add magic string to bypass check-commit

2016-12-21 Thread David Soria Parra
# HG changeset patch # User David Soria Parra <davi...@fb.com> # Date 1482356655 28800 # Wed Dec 21 13:44:15 2016 -0800 # Node ID dba02153520bf599a723a6641a8040c7966d2226 # Parent 392751cbb6c47a43676e324d2f1a4e45f35e624b tests: add magic string to bypass check-commit Allow bypassin

[PATCH v2] tests: add magic string to bypass check-commit

2016-12-21 Thread David Soria Parra
# HG changeset patch # User David Soria Parra <davi...@fb.com> # Date 1482356655 28800 # Wed Dec 21 13:44:15 2016 -0800 # Node ID dba02153520bf599a723a6641a8040c7966d2226 # Parent 392751cbb6c47a43676e324d2f1a4e45f35e624b tests: add magic string to bypass check-commit Allow bypassin

Re: [PATCH 3 of 3 website] donate: new page to route donations to conservancy

2016-12-23 Thread David Soria Parra
On Fri, Dec 23, 2016 at 11:08:12AM -0500, Augie Fackler wrote: > # HG changeset patch > # User Augie Fackler > # Date 1482509162 18000 > # Fri Dec 23 11:06:02 2016 -0500 > # Node ID f48d84ce78aed4a3d063b08da0f7178028192501 > # Parent

[PATCH] help: correct title undescore length

2017-03-23 Thread David Soria Parra
# HG changeset patch # User David Soria Parra <d...@php.net> # Date 1490290521 -3600 # Thu Mar 23 18:35:21 2017 +0100 # Node ID a58314d8ab7f4cd910c238441779731ad16372d6 # Parent 55c6788c54e2faf80ec14f2b0844bfe429012bc3 help: correct title undescore length The underscores for a titl

[PATCH] worker: flush ui buffers before running the worker

2017-03-28 Thread David Soria Parra
# HG changeset patch # User David Soria Parra <davi...@fb.com> # Date 1490721698 25200 # Tue Mar 28 10:21:38 2017 -0700 # Node ID b89199982355728a3741edf5518c72ccc52ee33c # Parent 331cc4433efe0d897bb16ad4ff08a3fbe850869b worker: flush ui buffers before running the worker a91c6275 intr

[PATCH] convert: Fix the handling of empty changlist descriptions in P4

2017-03-22 Thread David Soria Parra
# HG changeset patch # User David Soria Parra <davi...@fb.com> # Date 1490209978 18000 # Wed Mar 22 14:12:58 2017 -0500 # Node ID ff24a4168c2f05fd367b0b126e52559ef89af77f # Parent 102f291807c92864a2231e5e925d6cd64783bb59 convert: Fix the handling of empty changlist descriptions in P4

Re: [1,of,2,RFC] RFC: implement immutable config objects

2017-03-29 Thread David Soria Parra
On Mon, Mar 27, 2017 at 11:38:06AM -0700, Jun Wu wrote: > # HG changeset patch > # User Jun Wu > # Date 1490635856 25200 > # Mon Mar 27 10:30:56 2017 -0700 > # Node ID 4eb7c76340791f379a34f9df4ec42e0c8b9b2a2f > # Parent 4a8d065bbad80d3b3401010375bc80165404aa87 > RFC: implement

Re: [2,of,2,RFC] RFC: switch to immutable configs

2017-03-29 Thread David Soria Parra
On Mon, Mar 27, 2017 at 11:38:07AM -0700, Jun Wu wrote: > # HG changeset patch > # User Jun Wu > # Date 1490639836 25200 > # Mon Mar 27 11:37:16 2017 -0700 > # Node ID 13bee3e959f04f970f2fc0a01120f0b30d725b84 > # Parent 4eb7c76340791f379a34f9df4ec42e0c8b9b2a2f > RFC: switch to

Re: [PATCH 5 of 5] ui: use bytes IO and convert EOL manually in ui.editor()

2017-03-31 Thread David Soria Parra
On Wed, Mar 29, 2017 at 11:46:41PM +0900, Yuya Nishihara wrote: > # HG changeset patch > # User Yuya Nishihara > # Date 1490791418 -32400 > # Wed Mar 29 21:43:38 2017 +0900 > # Node ID 81aa3738f703e4354b0f853e87548a139b129bdd > # Parent

Re: [PATCH] fancyopts: making config defaults actually override defaults

2017-03-14 Thread David Soria Parra
On Sat, Mar 11, 2017 at 06:03:30PM -0800, Rodrigo Damazio Bovendorp via Mercurial-devel wrote: > # HG changeset patch > # User Rodrigo Damazio > # Date 1489274373 28800 > # Sat Mar 11 15:19:33 2017 -0800 > # Node ID 8c833b81a994e2d3304c3b06793f536355528aab > # Parent

Re: [PATCH] patch: diff --stat can parse lines starting with -- or ++ (issue5479)

2017-03-14 Thread David Soria Parra
On Sun, Mar 12, 2017 at 01:32:05PM +0900, Matthieu Laneuville wrote: > # HG changeset patch > # User Matthieu Laneuville > # Date 1489292061 -32400 > # Sun Mar 12 13:14:21 2017 +0900 > # Node ID a79e4ec615dd14a65d1730e2795be41ffededc9e > # Parent

Re: [PATCH 2 of 2 v2] rebase: add flag to require destination

2017-03-14 Thread David Soria Parra
On Tue, Mar 14, 2017 at 05:56:16PM -0700, Ryan McElroy wrote: > # HG changeset patch > # User Ryan McElroy > # Date 1489538624 25200 > # Tue Mar 14 17:43:44 2017 -0700 > # Node ID 8d8b783803f43d5e2d86916c39e9554139752fe6 > # Parent 2dc26c57e60e7e7bf46a276e8a498a9746bd9271 >

Re: [PATCH 4 of 4] formatter: use templatefilters.json()

2017-04-03 Thread David Soria Parra
On Sun, Apr 02, 2017 at 12:28:24PM +0900, Yuya Nishihara wrote: > # HG changeset patch > # User Yuya Nishihara > # Date 1491102137 -32400 > # Sun Apr 02 12:02:17 2017 +0900 > # Node ID 6deb06584ae481c751b86782e2c8567e4996d04e > # Parent

Re: [PATCH] sortdict: fix .pop() to return a value

2017-04-09 Thread David Soria Parra
On Sun, Apr 09, 2017 at 10:10:01PM +0900, Yuya Nishihara wrote: > # HG changeset patch > # User Yuya Nishihara > # Date 1491706629 -32400 > # Sun Apr 09 11:57:09 2017 +0900 > # Node ID 48a7a1f77a9489e3c4b5f862243782ceae80eaf9 > # Parent

[PATCH 3 of 6 RFC] ui: don't return certain layers when they are supposed to be displayed

2017-03-12 Thread David Soria Parra
# HG changeset patch # User David Soria Parra <davi...@fb.com> # Date 1489349206 25200 # Sun Mar 12 13:06:46 2017 -0700 # Node ID ef5ce5325596fe5fef014a320abae0f0d5980f3d # Parent 084a30b54810d05c8b44d22fcab2ef6f783a9f7c ui: don't return certain layers when they are supposed to be dis

[PATCH 4 of 6 RFC] compat: module to handle different ui.compat settings

2017-03-12 Thread David Soria Parra
# HG changeset patch # User David Soria Parra <davi...@fb.com> # Date 1489349206 25200 # Sun Mar 12 13:06:46 2017 -0700 # Node ID 8efd04667ba8d2939a937f549e803bc3b56f70a7 # Parent ef5ce5325596fe5fef014a320abae0f0d5980f3d compat: module to handle different ui.compat settin

[PATCH 6 of 6 RFC] dispatch: modernize the ui after finalizing config loading

2017-03-12 Thread David Soria Parra
# HG changeset patch # User David Soria Parra <davi...@fb.com> # Date 1489349206 25200 # Sun Mar 12 13:06:46 2017 -0700 # Node ID 9eca95dec659b3ff37608fd257d888520599124d # Parent 2dfa752cf0751010867944aa707bd7a722d3ea87 dispatch: modernize the ui after finalizing config loading W

[PATCH 1 of 6 RFC] ui: refactoring handling of trusted, user and overlay

2017-03-12 Thread David Soria Parra
# HG changeset patch # User David Soria Parra <davi...@fb.com> # Date 1489349204 25200 # Sun Mar 12 13:06:44 2017 -0700 # Node ID 99514a82d5b23c75bd6da38e522acfd14a618c14 # Parent 1c3352d7eaf24533ad52d4b8a024211e9189fb0b ui: refactoring handling of trusted, user and overlay We are

[PATCH 2 of 6 RFC] ui: add a defaults layer to the config

2017-03-12 Thread David Soria Parra
# HG changeset patch # User David Soria Parra <davi...@fb.com> # Date 1489349206 25200 # Sun Mar 12 13:06:46 2017 -0700 # Node ID 084a30b54810d05c8b44d22fcab2ef6f783a9f7c # Parent 99514a82d5b23c75bd6da38e522acfd14a618c14 ui: add a defaults layer to the config Add a defaults

[PATCH 5 of 6 RFC] help: document compat mode

2017-03-12 Thread David Soria Parra
# HG changeset patch # User David Soria Parra <davi...@fb.com> # Date 1489349206 25200 # Sun Mar 12 13:06:46 2017 -0700 # Node ID 2dfa752cf0751010867944aa707bd7a722d3ea87 # Parent 8efd04667ba8d2939a937f549e803bc3b56f70a7 help: document compat mode diff --git a/mercurial/help/config

[PATCH 01 of 10 RFC v2] ui: refactoring handling of trusted, user and overlay

2017-03-12 Thread David Soria Parra
# HG changeset patch # User David Soria Parra <davi...@fb.com> # Date 1489349204 25200 # Sun Mar 12 13:06:44 2017 -0700 # Node ID 99514a82d5b23c75bd6da38e522acfd14a618c14 # Parent 1c3352d7eaf24533ad52d4b8a024211e9189fb0b ui: refactoring handling of trusted, user and overlay We are

[PATCH 06 of 10 RFC v2] dispatch: modernize the ui after finalizing config loading

2017-03-12 Thread David Soria Parra
# HG changeset patch # User David Soria Parra <davi...@fb.com> # Date 1489349206 25200 # Sun Mar 12 13:06:46 2017 -0700 # Node ID 63065d4cb13dc3acb9177473896fc3c9c9c7993b # Parent d402acdf7c439dc369b6ab3a6888078a2895978a dispatch: modernize the ui after finalizing config loading W

[PATCH 10 of 10 RFC v2] compat: add ui.interface=curses to latest

2017-03-12 Thread David Soria Parra
# HG changeset patch # User David Soria Parra <davi...@fb.com> # Date 1489358250 25200 # Sun Mar 12 15:37:30 2017 -0700 # Node ID 4ae47aa5224bbca0f9bc35b2b0aef0ab01059ccc # Parent b114907de6ce0f3d07c7be37e6570cc0a9456df6 compat: add ui.interface=curses to latest diff --git a/mer

[PATCH 05 of 10 RFC v2] help: document compat mode

2017-03-12 Thread David Soria Parra
# HG changeset patch # User David Soria Parra <davi...@fb.com> # Date 1489349206 25200 # Sun Mar 12 13:06:46 2017 -0700 # Node ID d402acdf7c439dc369b6ab3a6888078a2895978a # Parent 0986fb7be0f584f5169f93377f9d013f87381ea7 help: document compat mode diff --git a/mercurial/help/config

[PATCH 08 of 10 RFC v2] compat: add diff.showfunc=True to latest

2017-03-12 Thread David Soria Parra
# HG changeset patch # User David Soria Parra <davi...@fb.com> # Date 1489358226 25200 # Sun Mar 12 15:37:06 2017 -0700 # Node ID 8d4b79f7c6012aa1595fa3fbe184bc6849e3d81c # Parent 7256c598a7f493bcc999259a4cbd88d86077746d compat: add diff.showfunc=True to latest diff --git a/mer

[PATCH 09 of 10 RFC v2] compat: add ui.color=auto to latest

2017-03-12 Thread David Soria Parra
# HG changeset patch # User David Soria Parra <davi...@fb.com> # Date 1489358241 25200 # Sun Mar 12 15:37:21 2017 -0700 # Node ID b114907de6ce0f3d07c7be37e6570cc0a9456df6 # Parent 8d4b79f7c6012aa1595fa3fbe184bc6849e3d81c compat: add ui.color=auto to latest diff --git a/mercurial/compa

[PATCH 04 of 10 RFC v2] compat: module to handle different ui.compat settings

2017-03-12 Thread David Soria Parra
# HG changeset patch # User David Soria Parra <davi...@fb.com> # Date 1489349206 25200 # Sun Mar 12 13:06:46 2017 -0700 # Node ID 0986fb7be0f584f5169f93377f9d013f87381ea7 # Parent ef5ce5325596fe5fef014a320abae0f0d5980f3d compat: module to handle different ui.compat settin

[PATCH] ui: don't read the same config file twice

2017-03-13 Thread David Soria Parra
# HG changeset patch # User David Soria Parra <davi...@fb.com> # Date 1489459557 25200 # Mon Mar 13 19:45:57 2017 -0700 # Node ID 7e599b4f534e27a0462bb1263208cc1c8d71 # Parent 3d3109339b57341b333c1112beb41dd281fa944a ui: don't read the same config file twice During di

Re: [PATCH v2] exewrapper: prefer HackableMercurial python if availbale

2017-03-13 Thread David Soria Parra
On Mon, Mar 13, 2017 at 01:06:41PM -0700, Kostia Balytskyi wrote: > # HG changeset patch > # User Kostia Balytskyi > # Date 1489434253 25200 > # Mon Mar 13 12:44:13 2017 -0700 > # Node ID 83925d3a3306e7023b4b43757812285b40fcd90b > # Parent

Re: [PATCH] ui: don't read the same config file twice

2017-03-13 Thread David Soria Parra
On Mon, Mar 13, 2017 at 07:56:09PM -0700, Jun Wu wrote: > This is a BC because loading order matters: good catch. let's drop it until i find a better solution. ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org

Re: [PATCH 2 of 2] rebase: add flag to require destination

2017-03-13 Thread David Soria Parra
On Mon, Mar 13, 2017 at 08:15:58PM -0700, Augie Fackler wrote: > (+martinvonz,marmoute for my probably-bad idea) > > > On Mar 13, 2017, at 20:14, Ryan McElroy wrote: > > On 3/12/17 5:48 PM, Gregory Szorc wrote: > > > >> On Sun, Mar 12, 2017 at 12:06 PM, Augie Fackler

Re: [PATCH 04 of 10] scmutil: add a rcpath-like method to return multiple config sources

2017-03-13 Thread David Soria Parra
On Mon, Mar 13, 2017 at 08:44:49PM -0700, Jun Wu wrote: > scmutil: add a rcpath-like method to return multiple config sources nice series :) > +def rccomponents(): > +'''return an ordered [(type, obj)] about where to load configs. > + > +respect $HGRCPATH. if $HGRCPATH is empty, only

Re: [PATCH 7 of 7 V3] util: enable hardlink for copyfile

2017-03-14 Thread David Soria Parra
On Sun, Mar 12, 2017 at 01:23:56AM -0800, Jun Wu wrote: > # HG changeset patch > # User Jun Wu > # Date 1489309403 28800 > # Sun Mar 12 01:03:23 2017 -0800 > # Node ID 9da40a9e54c419490a2ff23b9dda7acc109f81cd > # Parent de28b62236a7d47a896bc4aba2bd95dcd8defc87 > # Available At

Re: [PATCH 5 of 5] ui: use bytes IO and convert EOL manually in ui.editor()

2017-04-01 Thread David Soria Parra
On Sat, Apr 01, 2017 at 07:00:07PM +0900, Yuya Nishihara wrote: > On Fri, 31 Mar 2017 09:52:37 -0700, David Soria Parra wrote: > > On Wed, Mar 29, 2017 at 11:46:41PM +0900, Yuya Nishihara wrote: > > > # HG changeset patch > > > # User Yuya Nishihara <y...@tcha.org&g

D422: mdiff: add a --ignore-space-at-eol option

2017-08-16 Thread dsp (David Soria Parra)
dsp updated this revision to Diff 1022. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D422?vs=1018=1022 REVISION DETAIL https://phab.mercurial-scm.org/D422 AFFECTED FILES mercurial/cmdutil.py mercurial/help/config.txt mercurial/mdiff.py

[Differential] [Accepted] D57: match: write forceincludematcher using unionmatcher

2017-07-13 Thread dsp (David Soria Parra)
dsp accepted this revision. dsp added a comment. This revision is now accepted and ready to land. accepting this for visibility to hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D57 EMAIL PREFERENCES

[Differential] [Accepted] D64: histedit: remove transaction from state object

2017-07-12 Thread dsp (David Soria Parra)
dsp accepted this revision. dsp added inline comments. INLINE COMMENTS > histedit.py:283 > self.backupfile = None > self.tr = None > if replacements is None: I think you can also remove this. I don't see it anywhere used. REPOSITORY rHG Mercurial REVISION DETAIL

[Differential] [Commented On] D57: match: write forceincludematcher using unionmatcher

2017-07-12 Thread dsp (David Soria Parra)
dsp added a comment. I am slightly -1 on this, as it removes `__repr__` for forceincludematcher. This would lead to remove information from `hg debugwalk`. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D57 EMAIL PREFERENCES

[Differential] [Commented On] D58: match: make unionmatcher a proper matcher

2017-07-12 Thread dsp (David Soria Parra)
dsp added a comment. LGTM REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D58 EMAIL PREFERENCES https://phab.mercurial-scm.org/settings/panel/emailpreferences/ To: martinvonz Cc: dsp, mercurial-devel ___

[Differential] [Changed Subscribers] D96: sparse: require [section] in sparse config files (BC)

2017-07-16 Thread dsp (David Soria Parra)
dsp added subscribers: durham, dsp. dsp added a comment. Change looks good to me. I am in favor of that BC change. /cc @durham for an opinion tho. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D96 EMAIL PREFERENCES

[Differential] [Commented On] D56: py3: make localrepo filtered repo cache work on py3

2017-07-11 Thread dsp (David Soria Parra)
dsp added a comment. LGTM REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D56 EMAIL PREFERENCES https://phab.mercurial-scm.org/settings/panel/emailpreferences/ To: martinvonz Cc: dsp, mercurial-devel ___

[Differential] [Commented On] D59: sparse: override dirstate.walk() instead of dirstate._ignore

2017-07-12 Thread dsp (David Soria Parra)
dsp added a comment. -1 on this. I feel this can lead to confusing behavior for users and require too much understanding of the underlying behaviors. See the following example 1. create a sparse profile [include] foo/ [exclude] 2. create directory bar/ and file

[Differential] [Commented On] D57: match: write forceincludematcher using unionmatcher

2017-07-12 Thread dsp (David Soria Parra)
dsp added a comment. In https://phab.mercurial-scm.org/D57#735, @martinvonz wrote: > What arguments do you pass to "hg debugwalk" to get a forceincludematcher? You are right, as we don't use forceincludematcher inside match() it never gets into debugwalk. Your patch seems fine.

D202: tests: fix test-flagprocessor.t flakiness

2017-08-01 Thread dsp (David Soria Parra)
dsp requested changes to this revision. dsp added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > test-flagprocessor.t:168 > + *** failed to set up extension duplicate: cannot register multiple > processors on flag '0x8'. > +File

D245: obsstore: rename precursors into predecessors

2017-08-08 Thread dsp (David Soria Parra)
dsp added inline comments. INLINE COMMENTS > obsutil.py:210 > nm = unfi.changelog.nodemap > -precursorsmarkers = unfi.obsstore.precursors > +precursorsmarkers = unfi.obsstore.predecessors > successormarkers = unfi.obsstore.successors should this be called `predecessormarkers`?

Re: https://www.mercurial-scm.org/downloads doesn't have download links?

2017-05-14 Thread David Soria Parra
On Sun, May 14, 2017 at 11:34:30AM -0700, Siddharth Agarwal wrote: > A coworker alerted me to this: https://www.mercurial-scm.org/downloads > doesn't appear to have any download links. For Windows there should be a > link to a TortoiseHg build or the MSI.

Re: [PATCH RFC] revset: lookup descendents for negative arguments to ancestor operator

2017-05-31 Thread David Soria Parra
On Wed, May 31, 2017 at 10:50:15PM +0900, Yuya Nishihara wrote: > On Mon, 29 May 2017 23:28:20 +0900, Yuya Nishihara wrote: > > On Mon, 29 May 2017 14:45:39 +0200, Denis Laxalde wrote: > > > > I agree it's a bit puzzling, but I also think it's an acceptable extension > > to > > the `~` operator

Re: [PATCH RFC] revset: lookup descendents for negative arguments to ancestor operator

2017-06-05 Thread David Soria Parra
On Wed, May 31, 2017 at 02:17:58PM -0400, Augie Fackler wrote: > > It's easy to allow child traversal only if it's unambigious, and come > back to it later and be more permissive later. It'll be hard to go the > other way though. > > (I'm lightly in favor of this series, +0-ish, but I need to

Re: [PATCH RFC] revset: lookup descendents for negative arguments to ancestor operator

2017-05-31 Thread David Soria Parra
On Wed, May 31, 2017 at 10:34:55AM -0700, Sean Farley wrote: > David Soria Parra <d...@experimentalworks.net> writes: > > > On Wed, May 31, 2017 at 10:50:15PM +0900, Yuya Nishihara wrote: > >> On Mon, 29 May 2017 23:28:20 +0900, Yuya Nishihara wrote: > >>

Re: [PATCH RFC] ui: add support for a tweakdefaults knob

2017-06-19 Thread David Soria Parra
On Sat, Jun 17, 2017 at 12:14:22AM +0900, Yuya Nishihara wrote: > On Wed, 14 Jun 2017 21:37:21 -0400, Augie Fackler wrote: > > # HG changeset patch > > # User Augie Fackler > > # Date 1497488194 14400 > > # Wed Jun 14 20:56:34 2017 -0400 > > # Node ID

D544: releasenotes: update docstrings with information on additional flags

2017-09-08 Thread dsp (David Soria Parra)
dsp added inline comments. INLINE COMMENTS > releasenotes.py:554 > + > +With the -c/--check option, you can check the commit message for an > invalid > +admonition. In case of an invalid admonition, the flag returns the name > of I think we usually don't address "you" directly. Maybe

D422: mdiff: add a --ignore-space-at-eol option

2017-08-24 Thread dsp (David Soria Parra)
dsp added inline comments. INLINE COMMENTS > yuja wrote in cmdutil.py:126-127 > `-Z` sounds good, which doesn't conflict with any existing short > options. > > FWIW, the long option is called as `--ignore-trailing-space` in > GNU diff. I am happy to change '-Z'. The used the long opt name from

D422: mdiff: add a --ignore-space-at-eol option

2017-08-24 Thread dsp (David Soria Parra)
dsp updated this revision to Diff 1266. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D422?vs=1241=1266 REVISION DETAIL https://phab.mercurial-scm.org/D422 AFFECTED FILES mercurial/cmdutil.py mercurial/help/config.txt mercurial/mdiff.py

D492: context: remove unnecessary default values for matchers (API)

2017-08-23 Thread dsp (David Soria Parra)
dsp requested changes to this revision. dsp added a comment. This revision now requires changes to proceed. if match can't be None, then we should remove it as the default value. Otherwise I look at this in a year and think "why do we not handle a None matcher, when it clearly can be None if

D494: test-casecollision-merge: fix the test

2017-08-23 Thread dsp (David Soria Parra)
dsp accepted this revision. dsp added a comment. Thanks REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D494 To: quark, #hg-reviewers, dsp Cc: dsp, mercurial-devel ___ Mercurial-devel mailing list

  1   2   >