Excerpts from Yuya Nishihara's message of 2017-01-31 23:36:46 +0900:
> > This introduces another race condition that unlinks an innocent socket file.
> > I will send a V2 later.
(This actually seems to be a regression after the socketserver refactoring.
It probably requires sub-classing "unixforki
Excerpts from Yuya Nishihara's message of 2017-02-01 00:48:26 +0900:
> On Tue, 31 Jan 2017 15:24:42 +0000, Jun Wu wrote:
> > Excerpts from Yuya Nishihara's message of 2017-01-31 23:36:46 +0900:
> > > > This introduces another race condition that unlinks an innocent
This is mainly to discuss more details about chg repo preloading idea [1].
Perf Numbers
I wrote a hacky prototype [2] that shows significant improvements on
various commands in our repo:
Before After (in seconds)
chg bookmark 0.40 0.08
Fixes a mysterious typo that affects reading.
Excerpts from Jun Wu's message of 2017-02-02 09:34:47 +:
> This is mainly to discuss more details about chg repo preloading idea [1].
>
> Perf Numbers
>
> I wrote a hacky prototype [2] that shows significant improvements on
> various commands
This patch looks good to me. See inline comment about how to make it faster.
That could probably be fixed in flight.
Excerpts from Stanislau Hlebik's message of 2017-02-02 02:57:24 -0800:
> # HG changeset patch
> # User Stanislau Hlebik
> # Date 1486032998 28800
> # Thu Feb 02 02:56:38 2017
Excerpts from Simon Farnsworth's message of 2017-02-02 15:25:45 +:
> On 02/02/2017 09:34, Jun Wu wrote:
>
>
> > What's the API?
> >
> > (This is an existing implementation detail. I'm open to any ideas)
> >
> > For example,
Excerpts from Yuya Nishihara's message of 2017-02-03 00:45:22 +0900:
> On Thu, 2 Feb 2017 09:34:47 +0000, Jun Wu wrote:
> > Perf Numbers
> >
> > I wrote a hacky prototype [2] that shows significant improvements on
> >
f preloadindex(repo):
yield preload.key(indexpath) # optional, default to repo.root
yield preload.checkhash(hash)
yield preload.update(content, hash)
This also looks more flexible - we may extend the preloading framework by
adding more contents.
Excerpts from Yuya
Excerpts from Yuya Nishihara's message of 2017-02-04 00:31:45 +0900:
> On Fri, 3 Feb 2017 09:33:32 +0000, Jun Wu wrote:
> > 1) What does the worker talk to the master via IPC?
> >
> > Current: worker sends "possible_dirty_repo: $REPO_PATH" after runcomman
Excerpts from Yuya Nishihara's message of 2017-02-04 00:11:22 +0900:
> On Thu, 2 Feb 2017 16:56:11 +0000, Jun Wu wrote:
> > Excerpts from Yuya Nishihara's message of 2017-02-03 00:45:22 +0900:
> > > On Thu, 2 Feb 2017 09:34:47 +, Jun Wu wrote:
>
Excerpts from Yuya Nishihara's message of 2017-02-05 13:31:29 +0900:
> > > Since we shouldn't pass repo to revlog (it's layering violation), I think
> > > we'll need a thin wrapper for chgcache anyway.
> >
> > I mentioned this in the second mail, "4) Where to get preloaded results (in
> > worker)"
Excerpts from Augie Fackler's message of 2017-02-05 22:24:39 -0500:
> > On Sun, Feb 5, 2017 at 1:44 AM, Yuya Nishihara wrote:
> > I like the direction of this patch, but this still involves a behavior
> > change. If PAGER variable is set but pager extension disabled, pager will
> > be started wron
Excerpts from Yuya Nishihara's message of 2017-02-05 13:59:32 +0900:
> Perhaps that is a matter of taste, I like the explicit one. But I heard
> Python 3 has a generator-based coroutine, so using "yield" for that purpose
> is more common in Python 3?
>
> @preload('index')
> def preloadindex
Excerpts from Augie Fackler's message of 2017-02-06 17:52:30 -0500:
> (sending again because this seems to have gotten stuck somewhere...)
> (+yuya explicitly for chg thoughts, +smf so someone else can forward to the
> list if it's stuck again)
chg would be fine so long as ui.pager() calls ui._ru
# HG changeset patch
# User Jun Wu
# Date 1486429266 28800
# Mon Feb 06 17:01:06 2017 -0800
# Node ID 8081cb8c346f1ccfa8c98e94d7e25cdfccafeb06
# Parent b6c051cd1231910b0981edb01b173cd53a3338d0
# Available At https://bitbucket.org/quark-zju/hg-draft
# hg pull https
Excerpts from Yuya Nishihara's message of 2017-02-03 22:59:07 +0900:
> On Thu, 2 Feb 2017 12:04:09 -0800, Bryan O'Sullivan wrote:
> > On Thu, Feb 2, 2017 at 11:18 AM, Simon Farnsworth wrote:
> >
> > > pager: don't terminate with extreme prejudice on SIGPIPE (BC)
> > >
> >
> > Looks good!
>
> Qu
# HG changeset patch
# User Jun Wu
# Date 1486495380 28800
# Tue Feb 07 11:23:00 2017 -0800
# Node ID 8cfbd33c54779d1bbd50412e99f8256eea954401
# Parent a68510b69f413545722c086eaeb840dd5e8305b4
# Available At https://bitbucket.org/quark-zju/hg-draft
# hg pull https
This approach looks good to me. The only problem is it will print "killed!"
on SIGPIPE so maybe a follow-up to make it silent.
Excerpts from Simon Farnsworth's message of 2017-02-07 12:08:29 -0800:
> # HG changeset patch
> # User Simon Farnsworth
> # Date 1486498104 28800
> # Tue Feb 07 12:0
Actually that's not a problem since the output is redirected to the pager
and it won't get printed out.
Excerpts from Jun Wu's message of 2017-02-07 12:17:00 -0800:
> This approach looks good to me. The only problem is it will print "killed!"
> on SIGPIPE so maybe a follow-up to make it silent.
>
I've marked this as Superseded, as Simon's patch is a better fix.
Excerpts from Jun Wu's message of 2017-02-07 11:23:42 -0800:
> # HG changeset patch
> # User Jun Wu
> # Date 1486495380 28800
> # Tue Feb 07 11:23:00 2017 -0800
> # Node ID 8cfbd33c54779d1bbd504
V1 was accepted and in hg-committed [1] already. I don't know the official
recommended workflows but I used to just push follow-up fixes.
In general, it's a good practice to use hg-committed instead of the hg repo
for development, to avoid potential conflicts with other changes.
[1]: https://www.
Excerpts from Augie Fackler's message of 2017-02-07 23:01:44 -0500:
>
> > On Feb 7, 2017, at 15:28, Simon Farnsworth wrote:
> >
> > On 07/02/2017 20:17, Jun Wu wrote:
> >> This approach looks good to me. The only problem is it will print "killed!"
&g
I think you are talking about the "entry point", which is different from
"chg".
At Facebook, "hg" is a wrapper that reads a tiny config file, and calls
either "chg" or "hg.real", where "hg.real" is the "hg" script elsewhere.
So it makes sense to have a very lightweight binary that basically execs
# HG changeset patch
# User Jun Wu
# Date 1486593458 28800
# Wed Feb 08 14:37:38 2017 -0800
# Node ID 5fc577761fb78168fcbd7ec93d911a1b7b4989c9
# Parent a68510b69f413545722c086eaeb840dd5e8305b4
# Available At https://bitbucket.org/quark-zju/hg-draft
# hg pull https
# HG changeset patch
# User Jun Wu
# Date 1486593930 28800
# Wed Feb 08 14:45:30 2017 -0800
# Node ID cb56fce57eceef2cf4cd9893d387b9fe2b3cecd6
# Parent 5fc577761fb78168fcbd7ec93d911a1b7b4989c9
# Available At https://bitbucket.org/quark-zju/hg-draft
# hg pull https
# HG changeset patch
# User Jun Wu
# Date 1486601798 28800
# Wed Feb 08 16:56:38 2017 -0800
# Node ID 8410c4a6703bed4b459cf8d62bd32fdcb1e7
# Parent 138f7ba58a70de9610713b8bd55d1ba0ac468fa6
# Available At https://bitbucket.org/quark-zju/hg-draft
# hg pull https
# HG changeset patch
# User Jun Wu
# Date 1486601732 28800
# Wed Feb 08 16:55:32 2017 -0800
# Node ID 138f7ba58a70de9610713b8bd55d1ba0ac468fa6
# Parent a68510b69f413545722c086eaeb840dd5e8305b4
# Available At https://bitbucket.org/quark-zju/hg-draft
# hg pull https
# HG changeset patch
# User Jun Wu
# Date 1486604289 28800
# Wed Feb 08 17:38:09 2017 -0800
# Node ID 79adf3722f1b0f602e9461f13fa940a25dbfce56
# Parent 88c498ad9318df115d8408412a38edbac7d92a6a
# Available At https://bitbucket.org/quark-zju/hg-draft
# hg pull https
# HG changeset patch
# User Jun Wu
# Date 1486603691 28800
# Wed Feb 08 17:28:11 2017 -0800
# Node ID 88c498ad9318df115d8408412a38edbac7d92a6a
# Parent 8410c4a6703bed4b459cf8d62bd32fdcb1e7
# Available At https://bitbucket.org/quark-zju/hg-draft
# hg pull https
This does not work if the hardcoded 127.0.0.1 is not known to the system:
sudo ip addr del 127.0.0.1/8 dev lo # on Linux
That could happen if the system is IPv6-only, or only has other addresses in
the 127./8 subnet like 127.0.0.2, or does not have a "lo" device. I think
the pathological envi
email` if there are
> test failures).
>
> If someone else does the work to replace the use of 127.0.0.1 in the
> existing error case with a different value, I'll happily redo this patch
> to follow their lead, but I've already spent more time on this than I'm
> w
# HG changeset patch
# User Jun Wu
# Date 1486648674 28800
# Thu Feb 09 05:57:54 2017 -0800
# Node ID 93e23f7b87a4ab456053b6ba573615be16c6c4b0
# Parent a68510b69f413545722c086eaeb840dd5e8305b4
# Available At https://bitbucket.org/quark-zju/hg-draft
# hg pull https
Excerpts from David Demelier's message of 2017-02-08 17:41:50 +0100:
> # HG changeset patch
> # User David Demelier
> # Date 1486485215 -3600
> # Tue Feb 07 17:33:35 2017 +0100
> # Node ID 5ecf752f0a79482fe2cecfa73c5a733dab29fb88
> # Parent 1f51b4658f21bbb797e922d155c1046eddccf91d
> hg: allo
# HG changeset patch
# User Jun Wu
# Date 1486675027 28800
# Thu Feb 09 13:17:07 2017 -0800
# Node ID 2c1834e1e6b5f734c27199d47de9b2252b8f4913
# Parent 245b1d962dcd5df48f929f10f786dc53936daabf
# Available At https://bitbucket.org/quark-zju/hg-draft
# hg pull https
# HG changeset patch
# User Jun Wu
# Date 1486673958 28800
# Thu Feb 09 12:59:18 2017 -0800
# Node ID bdaf60a60f81431a52291ece25ad3cd60c77ac05
# Parent a68510b69f413545722c086eaeb840dd5e8305b4
# Available At https://bitbucket.org/quark-zju/hg-draft
# hg pull https
# HG changeset patch
# User Jun Wu
# Date 1486675034 28800
# Thu Feb 09 13:17:14 2017 -0800
# Node ID 5e47a19fae82f4659f1e7df37f8f26dd56c4f246
# Parent 2c1834e1e6b5f734c27199d47de9b2252b8f4913
# Available At https://bitbucket.org/quark-zju/hg-draft
# hg pull https
# HG changeset patch
# User Jun Wu
# Date 1486687506 28800
# Thu Feb 09 16:45:06 2017 -0800
# Node ID d93bba366d42f9537a5556d7ff948848b608d02c
# Parent 76448b71f139b1fa06f2dbce04ac3f91ffd93f9d
# Available At https://bitbucket.org/quark-zju/hg-draft
# hg pull https
# HG changeset patch
# User Jun Wu
# Date 1486674516 28800
# Thu Feb 09 13:08:36 2017 -0800
# Node ID 245b1d962dcd5df48f929f10f786dc53936daabf
# Parent bdaf60a60f81431a52291ece25ad3cd60c77ac05
# Available At https://bitbucket.org/quark-zju/hg-draft
# hg pull https
# HG changeset patch
# User Jun Wu
# Date 1486689390 28800
# Thu Feb 09 17:16:30 2017 -0800
# Node ID 76448b71f139b1fa06f2dbce04ac3f91ffd93f9d
# Parent 5e47a19fae82f4659f1e7df37f8f26dd56c4f246
# Available At https://bitbucket.org/quark-zju/hg-draft
# hg pull https
# HG changeset patch
# User Jun Wu
# Date 1486689500 28800
# Thu Feb 09 17:18:20 2017 -0800
# Node ID 2c2051dfbf9079a294cded41ada42b67dd3c37f5
# Parent e042a694438fc4b35edcdcda99a4b6c4a0ce5bf2
# Available At https://bitbucket.org/quark-zju/hg-draft
# hg pull https
# HG changeset patch
# User Jun Wu
# Date 1486689613 28800
# Thu Feb 09 17:20:13 2017 -0800
# Node ID 90cfe2f9473ab23300591f5904ba51c98cddca16
# Parent 2c2051dfbf9079a294cded41ada42b67dd3c37f5
# Available At https://bitbucket.org/quark-zju/hg-draft
# hg pull https
# HG changeset patch
# User Jun Wu
# Date 1486689107 28800
# Thu Feb 09 17:11:47 2017 -0800
# Node ID 400747616e74d8af7ea053692e861d2495e56d78
# Parent d93bba366d42f9537a5556d7ff948848b608d02c
# Available At https://bitbucket.org/quark-zju/hg-draft
# hg pull https
# HG changeset patch
# User Jun Wu
# Date 1486689360 28800
# Thu Feb 09 17:16:00 2017 -0800
# Node ID e042a694438fc4b35edcdcda99a4b6c4a0ce5bf2
# Parent 400747616e74d8af7ea053692e861d2495e56d78
# Available At https://bitbucket.org/quark-zju/hg-draft
# hg pull https
# HG changeset patch
# User Jun Wu
# Date 1486728546 28800
# Fri Feb 10 04:09:06 2017 -0800
# Node ID a9b0b592aad5483f1229d2e71dbd70c32f560814
# Parent dd14ece7cb20d8f3c764b17d2edc9ee646a27f2f
# Available At https://bitbucket.org/quark-zju/hg-draft
# hg pull https
I forgot to mention this looks good to me too (as I saw dsp replied first).
It's an improved version of "dispatch: treat SIGPIPE as a termination signal
(BC)".
Excerpts from Simon Farnsworth's message of 2017-02-08 07:47:39 -0800:
> # HG changeset patch
> # User Simon Farnsworth
> # Date 1486568
Excerpts from Yuya Nishihara's message of 2017-02-10 22:11:26 +0900:
> Missed setting self._socketunlinked. Perhaps you want self._unlinksocket().
>
> Should I fix it in flight?
Sorry! It should be "self._unlinksocket()". Thanks for finding it out!
___
# HG changeset patch
# User Jun Wu
# Date 1486737071 28800
# Fri Feb 10 06:31:11 2017 -0800
# Node ID a4a844d706453079ea69de94f5e1c6fec64710e9
# Parent 44f2c707475a79758ecbc4b4117b9cda9d7a4380
# Available At https://bitbucket.org/quark-zju/hg-draft
# hg pull https
# HG changeset patch
# User Jun Wu
# Date 1486731527 28800
# Fri Feb 10 04:58:47 2017 -0800
# Node ID 1d7a184bb013a1a6f6b92d1f6d89406a7254ba2b
# Parent dd14ece7cb20d8f3c764b17d2edc9ee646a27f2f
# Available At https://bitbucket.org/quark-zju/hg-draft
# hg pull https
# HG changeset patch
# User Jun Wu
# Date 1486735766 28800
# Fri Feb 10 06:09:26 2017 -0800
# Node ID 44f2c707475a79758ecbc4b4117b9cda9d7a4380
# Parent 1d7a184bb013a1a6f6b92d1f6d89406a7254ba2b
# Available At https://bitbucket.org/quark-zju/hg-draft
# hg pull https
Excerpts from Jun Wu's message of 2017-02-10 06:34:18 -0800:
> # HG changeset patch
> # User Jun Wu
> # Date 1486735766 28800
> # Fri Feb 10 06:09:26 2017 -0800
> # Node ID 44f2c707475a79758ecbc4b4117b9cda9d7a4380
> # Parent 1d7a184bb013a1a6f6b92d1f6d89406a7254ba2b
In general, I think this is a good direction. Some random thoughts:
- general purposed
I think the bitmap is not always a cache, so it should only have
operations like set/unset/readfromdisk/writetodisk. Practically, I won't
couple cache invalidation with the bitmap implementation.
ct is considered reverted. But for things like x.__class__ = y;
extensions.wrapfoo(...), etc., they are basically impossible to revert
cleanly (confidently). So we avoid them at all costs.
Excerpts from Kevin Bullock's message of 2017-02-10 14:53:22 -0600:
> > On Feb 9, 2017, at 19:4
# HG changeset patch
# User Jun Wu
# Date 1486761243 28800
# Fri Feb 10 13:14:03 2017 -0800
# Node ID cefa2cc8e03941120286a1c8819dd7d5d62ae84b
# Parent 18f8e0f8ba54270bf158734c781327581cf43634
remotenames: be compatible with upstream change about smartset
The revset sets are moved to
# HG changeset patch
# User Jun Wu
# Date 1486763791 28800
# Fri Feb 10 13:56:31 2017 -0800
# Node ID 1884652829f6e68bde6ab3e9b0e9ca1da9bed40c
# Parent f8eb762559b242ec12b199db1ce27c2930881c75
# Available At https://bitbucket.org/quark-zju/hg-draft
# hg pull https
# HG changeset patch
# User Jun Wu
# Date 1486762521 28800
# Fri Feb 10 13:35:21 2017 -0800
# Node ID f8eb762559b242ec12b199db1ce27c2930881c75
# Parent b9116befa78417b1cb3763dafd44cc1fc6952109
# Available At https://bitbucket.org/quark-zju/hg-draft
# hg pull https
#x27;s message of 2017-02-10 14:09:35 -0800:
> # HG changeset patch
> # User Jun Wu
> # Date 1486763791 28800
> # Fri Feb 10 13:56:31 2017 -0800
> # Node ID 1884652829f6e68bde6ab3e9b0e9ca1da9bed40c
> # Parent f8eb762559b242ec12b199db1ce27c2930881c75
> # Availab
Excerpts from Sean Farley's message of 2017-02-06 11:41:55 -0800:
> Perhaps I'm the only one worried about adding all these markers. To me,
> it would make more sense to delete these markers since we're never going
> to push these shelved changesets.
You are not the only one.
While I agree that t
Excerpts from Sean Farley's message of 2017-02-06 15:22:56 -0800:
> I'll go through this series more in-depth now unless someone beats me to
> it.
Thanks!
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/ma
Excerpts from Yuya Nishihara's message of 2017-02-13 23:56:20 +0900:
> On Fri, 10 Feb 2017 06:34:18 -0800, Jun Wu wrote:
> > # HG changeset patch
> > # User Jun Wu
> > # Date 1486735766 28800
> > # Fri Feb 10 06:09:26 2017 -0800
> > # Node ID 44
Excerpts from David Demelier's message of 2017-02-13 15:43:45 +0100:
> Le 10/02/2017 à 10:08, Raffaele Salmaso a écrit :
> > Hi,
> >
> > On Fri, Feb 10, 2017 at 9:19 AM, David Demelier
> > mailto:demelier.da...@gmail.com>> wrote:
> >
> > I've updated the code so that hg config --edit still crea
Excerpts from Yuya Nishihara's message of 2017-02-13 23:00:25 +0900:
> Why not os.pipe()?
>
> We share the same (dup-ed) file descriptors. In this case, the write end can
> be used by many forked processes, but IIRC the read end can't. Only one
> reader can read out a message. So I think there's no
Excerpts from Yuya Nishihara's message of 2017-02-13 22:46:23 +0900:
> On Wed, 8 Feb 2017 17:41:01 -0800, Jun Wu wrote:
> > # HG changeset patch
> > # User Jun Wu
> > # Date 1486601732 28800
> > # Wed Feb 08 16:55:32 2017 -0800
> > # Node ID 13
Excerpts from Augie Fackler's message of 2017-02-13 14:55:57 -0500:
> On Fri, Feb 10, 2017 at 04:50:55PM -0800, Jun Wu wrote:
> > I'd like to note that although this patch prevents repo corruption when
> > running hg inside different containers (which has different pid nam
Excerpts from Siddharth Agarwal's message of 2017-02-13 13:07:08 -0800:
> On 2/13/17 13:03, Jun Wu wrote:
> > I think it could be an extension outside core.
>
> I'd say make it a clone-time option, turned off by default, with caveats
> documented. At FB we ban the sit
Excerpts from Sean Farley's message of 2017-02-13 12:08:39 -0800:
> I didn't see any mention of inhibit in Mercurial? Is this a FB
> extension? If so, should this logic be in hgext/shelve.py or in the FB
> extension? (honest question)
It's part of mutable-history and (imo) should be killed sooner
As said before, I still prefer a simpler design without the "required"
boolean flag, and move the responsibility of checking requirements to the
higher-level code. Because:
- As Yuya pointed out at the first place, "required" here will have
trouble dealing with future schema changes. So it's
Excerpts from Augie Fackler's message of 2017-02-13 18:58:59 -0500:
> On Fri, Feb 10, 2017 at 01:07:49PM -0800, Jun Wu wrote:
> > Side-effects are basically everything related to writes, like mutating
> > (wrapping) internal Python objects, etc. They are done by Python cod
Excerpts from Sean Farley's message of 2017-02-13 17:04:35 -0800:
> I was thinking about a more high-level approach (please feel free to
> pick apart):
>
> r = repo.filtered("bitmap1")
> r2 = r.filtered("bitmap2")
>
> So that r2 would be an intersection of bitmap1 and bitmap2 (haven't
> thought a
Excerpts from Gregory Szorc's message of 2017-02-13 17:22:59 -0700:
>
> > On Feb 13, 2017, at 12:55, Augie Fackler wrote:
> >
> >> On Fri, Feb 10, 2017 at 04:50:55PM -0800, Jun Wu wrote:
> >> I'd like to note that although this patch prevents
# HG changeset patch
# User Jun Wu
# Date 1487048450 28800
# Mon Feb 13 21:00:50 2017 -0800
# Node ID ba4d509ef528627871e26172fcf9cfd71c2195c4
# Parent f2ad0d8047009e6e58ab1fa34ae7107714f5dc30
# Available At https://bitbucket.org/quark-zju/hg-draft
# hg pull https
Excerpts from Yuya Nishihara's message of 2017-02-14 22:49:34 +0900:
> On Mon, 13 Feb 2017 09:46:21 -0800, Jun Wu wrote:
> > Excerpts from Yuya Nishihara's message of 2017-02-13 23:00:25 +0900:
> > > Why not os.pipe()?
> > >
> > > We share the sam
# HG changeset patch
# User Jun Wu
# Date 1487204542 28800
# Wed Feb 15 16:22:22 2017 -0800
# Node ID d223c3d57e14f22c18030166b83e2da9143fdf67
# Parent a70fa1e0fcdb11980338d72dde33dfe047bda7c2
# Available At https://bitbucket.org/quark-zju/hg-draft
# hg pull https
# HG changeset patch
# User Jun Wu
# Date 1487204998 28800
# Wed Feb 15 16:29:58 2017 -0800
# Node ID c5bdb942d324dcd732d277457d11eff7dc6aacc3
# Parent bacc5256a49b34d07616c1e60e119a74ac721b7a
# Available At https://bitbucket.org/quark-zju/hg-draft
# hg pull https
# HG changeset patch
# User Jun Wu
# Date 1487204311 28800
# Wed Feb 15 16:18:31 2017 -0800
# Node ID a70fa1e0fcdb11980338d72dde33dfe047bda7c2
# Parent e5363cb96233861fc99f7e9b85d7884d3121558c
# Available At https://bitbucket.org/quark-zju/hg-draft
# hg pull https
# HG changeset patch
# User Jun Wu
# Date 1487205807 28800
# Wed Feb 15 16:43:27 2017 -0800
# Node ID bacc5256a49b34d07616c1e60e119a74ac721b7a
# Parent d223c3d57e14f22c18030166b83e2da9143fdf67
# Available At https://bitbucket.org/quark-zju/hg-draft
# hg pull https
Excerpts from Augie Fackler's message of 2017-02-15 21:23:37 -0500:
> I'm not overjoyed at the static default. Is there a reason to use the
> static default instead of checking HGPORT, so that multiple users on a
> single box (such as the big compile farm machine several of us favor)
> can run the
# HG changeset patch
# User Jun Wu
# Date 1487212221 28800
# Wed Feb 15 18:30:21 2017 -0800
# Node ID 894c348d49abb67613b156a2f7c60a840818bc39
# Parent e5363cb96233861fc99f7e9b85d7884d3121558c
# Available At https://bitbucket.org/quark-zju/hg-draft
# hg pull https
Excerpts from Augie Fackler's message of 2017-02-15 21:32:38 -0500:
> On Wed, Feb 15, 2017 at 06:26:11PM -0800, Jun Wu wrote:
> > Excerpts from Augie Fackler's message of 2017-02-15 21:23:37 -0500:
> > > I'm not overjoyed at the static default. Is there a reaso
# HG changeset patch
# User Jun Wu
# Date 1487216474 28800
# Wed Feb 15 19:41:14 2017 -0800
# Node ID dda2ebe89f50fcf3bf5a9b8d2266aa2dd5b106ea
# Parent e5363cb96233861fc99f7e9b85d7884d3121558c
# Available At https://bitbucket.org/quark-zju/hg-draft
# hg pull https
Excerpts from Augie Fackler's message of 2017-02-15 23:27:23 -0500:
> >> Heh, I reported the flakiness on #mercurial earlier today. That's why
> >> Jun sent a series of patches maybe 2 hours ago that you then queued.
> >> Have you tested with those patches applied? I have not had time to
> >> look
Looks good to me. I was trying to make the test class "self-contained"
without accessing global variables, as some people have strong opinion on
global variables. So it was intentional. But removing the parameter leads to
shorter code. I'm fine with either way.
Excerpts from Martin von Zweigbergk'
# HG changeset patch
# User Jun Wu
# Date 1487265078 28800
# Thu Feb 16 09:11:18 2017 -0800
# Node ID ea77104f008e26351dde0b168432b8d903c4f240
# Parent 677049d4e7cadc6acfc557ef1ee8acf783c76e1d
# Available At https://bitbucket.org/quark-zju/hg-draft
# hg pull https
Excerpts from Augie Fackler's message of 2017-02-16 12:18:56 -0500:
> On Thu, Feb 16, 2017 at 09:14:52AM -0800, Jun Wu wrote:
> > # HG changeset patch
> > # User Jun Wu
> > # Date 1487265078 28800
> > # Thu Feb 16 09:11:18 2017 -0800
> > # Node ID ea
# HG changeset patch
# User Jun Wu
# Date 1487228025 28800
# Wed Feb 15 22:53:45 2017 -0800
# Node ID 72115e4deca500bd6da1929479a966b8b0eb0e1d
# Parent 28bb800077fd83098320b6f21334a71eedf03bbe
# Available At https://bitbucket.org/quark-zju/hg-draft
# hg pull https
# HG changeset patch
# User Jun Wu
# Date 1487263439 28800
# Thu Feb 16 08:43:59 2017 -0800
# Node ID b38591e034d5508ddfc73d50b95d6b29d6370671
# Parent 91137c500c4f8761c2d70bab7438d8d87959bd15
# Available At https://bitbucket.org/quark-zju/hg-draft
# hg pull https
# HG changeset patch
# User Jun Wu
# Date 1487232809 28800
# Thu Feb 16 00:13:29 2017 -0800
# Node ID 91137c500c4f8761c2d70bab7438d8d87959bd15
# Parent 72115e4deca500bd6da1929479a966b8b0eb0e1d
# Available At https://bitbucket.org/quark-zju/hg-draft
# hg pull https
# HG changeset patch
# User Jun Wu
# Date 1487221740 28800
# Wed Feb 15 21:09:00 2017 -0800
# Node ID 28bb800077fd83098320b6f21334a71eedf03bbe
# Parent f2743873dfbd6adedcd3aa1777b651ce5bd6f6ed
# Available At https://bitbucket.org/quark-zju/hg-draft
# hg pull https
# HG changeset patch
# User Jun Wu
# Date 1487266732 28800
# Thu Feb 16 09:38:52 2017 -0800
# Node ID a23452874b2a39c6e2b71c63f7edfc4f4d5df2d5
# Parent 2bd74124ed8f3824f956f301d15a6816bfa5d483
# Available At https://bitbucket.org/quark-zju/hg-draft
# hg pull https
# HG changeset patch
# User Jun Wu
# Date 1487260879 28800
# Thu Feb 16 08:01:19 2017 -0800
# Node ID ce9f5e640bdfcc6270f0be98d7fc6520740ba464
# Parent b38591e034d5508ddfc73d50b95d6b29d6370671
# Available At https://bitbucket.org/quark-zju/hg-draft
# hg pull https
# HG changeset patch
# User Jun Wu
# Date 1487229843 28800
# Wed Feb 15 23:24:03 2017 -0800
# Node ID 2bd74124ed8f3824f956f301d15a6816bfa5d483
# Parent ce9f5e640bdfcc6270f0be98d7fc6520740ba464
# Available At https://bitbucket.org/quark-zju/hg-draft
# hg pull https
# HG changeset patch
# User Jun Wu
# Date 1487221422 28800
# Wed Feb 15 21:03:42 2017 -0800
# Node ID f2743873dfbd6adedcd3aa1777b651ce5bd6f6ed
# Parent a70e11929c63cd9245812f3db8091a449cd1273e
# Available At https://bitbucket.org/quark-zju/hg-draft
# hg pull https
Excerpts from Danek Duvall's message of 2017-02-16 09:51:14 -0800:
> Jun Wu wrote:
>
> > # HG changeset patch
> > # User Jun Wu
> > # Date 1487221422 28800
> > # Wed Feb 15 21:03:42 2017 -0800
> > # Node ID f2743873dfbd
Excerpts from Martin von Zweigbergk's message of 2017-02-16 10:29:39 -0800:
> On Thu, Feb 16, 2017 at 10:02 AM, Augie Fackler wrote:
> >
> >> On Feb 16, 2017, at 12:36, Jun Wu wrote:
> >>
> >> Excerpts from Augie Fackler's message of 2017-02-16 12:18
# HG changeset patch
# User Jun Wu
# Date 1487270039 28800
# Thu Feb 16 10:33:59 2017 -0800
# Node ID 070d9b1d8c2528e8c247b5bcaeb69aea509619a1
# Parent 6e6a461b5b60dc48a9e49cab2f3994b1345531fc
# Available At https://bitbucket.org/quark-zju/hg-draft
# hg pull https
Excerpts from Danek Duvall's message of 2017-02-16 10:27:58 -0800:
> Or both? Would it be useful consider one to be primary and the other
> secondary, and to always test only a subset of networking-related tests on
> the secondary if it's available? Running the entire testsuite twice just
> to ma
Excerpts from Martin von Zweigbergk's message of 2017-02-16 10:40:09 -0800:
> On Thu, Feb 16, 2017 at 10:34 AM, Jun Wu wrote:
> > # HG changeset patch
> > # User Jun Wu
> > # Date 1487270039 28800
> > # Thu Feb 16 10:33:59 2017 -0800
> > # Node ID 07
# HG changeset patch
# User Jun Wu
# Date 1487270039 28800
# Thu Feb 16 10:33:59 2017 -0800
# Node ID 9088dc2948690d0668fbaa7bb1f2fe137c40ee5d
# Parent 6e6a461b5b60dc48a9e49cab2f3994b1345531fc
# Available At https://bitbucket.org/quark-zju/hg-draft
# hg pull https
Excerpts from Yuya Nishihara's message of 2017-02-13 23:56:20 +0900:
> On Fri, 10 Feb 2017 06:34:18 -0800, Jun Wu wrote:
> > # HG changeset patch
> > # User Jun Wu
> > # Date 1486735766 28800
> > # Fri Feb 10 06:09:26 2017 -0800
> > # Node ID 44
Excerpts from Stanislau Hlebik's message of 2017-02-16 19:39:07 +:
> Excerpts from Stanislau Hlebik's message of 2017-02-14 09:29:25 +:
> > Excerpts from Sean Farley's message of 2017-02-13 18:30:25 -0800:
> > > Jun Wu writes:
> > >
> > &g
Excerpts from Martin von Zweigbergk's message of 2017-02-16 22:54:58 -0800:
> On Thu, Feb 16, 2017 at 9:39 AM, Jun Wu wrote:
> > # HG changeset patch
> > # User Jun Wu
> > # Date 1487232809 28800
> > # Thu Feb 16 00:13:29 2017 -0800
> > # Node ID 91
1 - 100 of 2411 matches
Mail list logo
