Re: [PATCH 2 of 3 V3] chgcache: implement a smartcache layer

2017-03-08 Thread Jun Wu
Excerpts from Simon Farnsworth's message of 2017-03-08 18:52:06 +: > On 08/03/2017 06:35, Jun Wu wrote: > > # HG changeset patch > > # User Jun Wu > > # Date 1488949878 28800 > > # Tue Mar 07 21:11:18 2017 -0800 > > # Node ID f0bded8d53c5c9a

Re: [PATCH RFC] ui: introduce sysdefault section for pager and editor configuration

2017-03-08 Thread Jun Wu
A "sysdefault" section sounds a bit weird. Usually files under "/etc" are defining "system defaults". A new section also makes it harder to see what configs they are overriding. How about appending ":sysdefault" to normal configs? The idea was also mentioned by Yuya at [1] and we use them in "[pat

Re: [PATCH 2 of 2 V2] dirstate: track otherparent files same as nonnormal

2017-03-08 Thread Jun Wu
Excerpts from Pierre-Yves David's message of 2017-03-08 16:10:04 -0800: > > On 03/07/2017 09:29 AM, Augie Fackler wrote: > > On Sun, Mar 05, 2017 at 04:51:01PM -0800, Durham Goode wrote: > >> # HG changeset patch > >> # User Durham Goode > >> # Date 1488761157 28800 > >> # Sun Mar 05 16:45:5

Re: [PATCH 01 of 11] bdiff: use Python memory allocator in fixws

2017-03-09 Thread Jun Wu
Excerpts from Gregory Szorc's message of 2017-03-09 14:08:26 -0800: > On Thu, Mar 9, 2017 at 1:59 PM, Gregory Szorc > wrote: > > > # HG changeset patch > > # User Gregory Szorc > > # Date 1489089265 28800 > > # Thu Mar 09 11:54:25 2017 -0800 > > # Node ID 7a8ce919a13a9ff6e73f391fe14d228e183

[PATCH] localrepo: rename proxycls to filteredrepo

2017-03-09 Thread Jun Wu
# HG changeset patch # User Jun Wu # Date 1489101027 28800 # Thu Mar 09 15:10:27 2017 -0800 # Node ID 4e98743085e0706c827e786930c817d79256c8b6 # Parent 1871a1ee64ed49172b1568b89cdbab126284b309 # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull https

Re: [PATCH 01 of 11] bdiff: use Python memory allocator in fixws

2017-03-09 Thread Jun Wu
Excerpts from Augie Fackler's message of 2017-03-09 18:24:22 -0800: > > > On Mar 9, 2017, at 18:12, Gregory Szorc wrote: > > > > On Thu, Mar 9, 2017 at 5:46 PM, Augie Fackler wrote: > > On Thu, Mar 09, 2017 at 01:59:09PM -0800, Gregory Szorc wrote: > > > # HG changeset patch > > > # User Gregor

Re: [PATCH RFC] ui: introduce sysdefault section for pager and editor configuration

2017-03-09 Thread Jun Wu
Excerpts from Sean Farley's message of 2017-03-09 18:49:18 -0800: > Kevin Bullock writes: > > >> On Mar 8, 2017, at 18:06, Jun Wu wrote: > >> > >> A "sysdefault" section sounds a bit weird. Usually files under "/etc" are > >>

Re: [PATCH RFC] ui: introduce sysdefault section for pager and editor configuration

2017-03-09 Thread Jun Wu
Excerpts from Jun Wu's message of 2017-03-09 18:52:34 -0800: > Excerpts from Sean Farley's message of 2017-03-09 18:49:18 -0800: > > Kevin Bullock writes: > > > > >> On Mar 8, 2017, at 18:06, Jun Wu wrote: > > >> > > >> A "sysd

Re: [PATCH 2 of 2] rebase: use unfiltered repo and remove complex unhiding code (issue5219)

2017-03-10 Thread Jun Wu
I like this change. It removes a dynamic blocker. I also did some manual tests and the logic seems good to me. Excerpts from Martin von Zweigbergk's message of 2017-03-10 17:15:52 -0800: > # HG changeset patch > # User Martin von Zweigbergk > # Date 1485968584 28800 > # Wed Feb 01 09:03:04

Re: [PATCH 2 of 2] rebase: use unfiltered repo and remove complex unhiding code (issue5219)

2017-03-11 Thread Jun Wu
Excerpts from Martin von Zweigbergk's message of 2017-03-10 22:17:10 -0800: > On Fri, Mar 10, 2017 at 6:06 PM, Jun Wu wrote: > > I like this change. It removes a dynamic blocker. > > > > I also did some manual tests and the logic seems good to me. > > > >

Re: [PATCH 3 of 3 V3] chgcache: implement repocache

2017-03-11 Thread Jun Wu
Excerpts from Yuya Nishihara's message of 2017-03-11 12:54:17 -0800: > On Tue, 7 Mar 2017 22:35:59 -0800, Jun Wu wrote: > > # HG changeset patch > > # User Jun Wu > > # Date 1488953311 28800 > > # Tue Mar 07 22:08:31 2017 -0800 > > # Node ID d1

Re: [PATCH 4 of 5 V2] util: add a getfstype method

2017-03-11 Thread Jun Wu
:54 -0800: > On Thu, 2 Mar 2017 22:13:30 -0800, Jun Wu wrote: > > # HG changeset patch > > # User Jun Wu > > # Date 1488521308 28800 > > # Thu Mar 02 22:08:28 2017 -0800 > > # Node ID d79c818940ff7e29c76ff5e985b920885aa4e7c1 > > # Parent 1cf153ec3fa

Re: [PATCH 3 of 3 V3] chgcache: implement repocache

2017-03-11 Thread Jun Wu
Excerpts from Yuya Nishihara's message of 2017-03-11 15:50:43 -0800: > On Sat, 11 Mar 2017 14:54:54 -0800, Jun Wu wrote: > > Excerpts from Yuya Nishihara's message of 2017-03-11 12:54:17 -0800: > > > On Tue, 7 Mar 2017 22:35:59 -0800, Jun Wu wrote: > > > >

Re: [PATCH 4 of 5 V2] util: add a getfstype method

2017-03-11 Thread Jun Wu
27;m investigating the details. Seems I (or strace once) was wrong. /proc is still the only way to get the filesystem infomation. Maybe we should hard-code /proc/mounts for Linux to avoid /etc/mtab being wrong. > > Excerpts from Yuya Nishihara's message of 2017-03-11 16:48:54 -0800: >

Re: [PATCH 4 of 5 V2] util: add a getfstype method

2017-03-11 Thread Jun Wu
Excerpts from Yuya Nishihara's message of 2017-03-11 16:48:54 -0800: > On Thu, 2 Mar 2017 22:13:30 -0800, Jun Wu wrote: > > # HG changeset patch > > # User Jun Wu > > # Date 1488521308 28800 > > # Thu Mar 02 22:08:28 2017 -0800 > > # Node ID d7

Re: [PATCH] util: add a getfstype method

2017-03-11 Thread Jun Wu
Excerpts from Yuya Nishihara's message of 2017-03-03 22:07:53 +0900: > We could move finddirs() to posix.finddirs() and use it, but not sure if > it's good idea. finddirs() does not return "/", and requires an ending "/", which is a bit annoying. ___ Mer

[PATCH 7 of 7 V3] util: enable hardlink for copyfile

2017-03-12 Thread Jun Wu
# HG changeset patch # User Jun Wu # Date 1489309403 28800 # Sun Mar 12 01:03:23 2017 -0800 # Node ID 9da40a9e54c419490a2ff23b9dda7acc109f81cd # Parent de28b62236a7d47a896bc4aba2bd95dcd8defc87 # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull https

[PATCH 6 of 7 V3] hghave: add a check about whitelisted filesystem that supports hardlink

2017-03-12 Thread Jun Wu
# HG changeset patch # User Jun Wu # Date 1489307180 28800 # Sun Mar 12 00:26:20 2017 -0800 # Node ID de28b62236a7d47a896bc4aba2bd95dcd8defc87 # Parent 10ec43758c6b4034a0eeecf24a54752784c82a2c # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull https

[PATCH 3 of 7 V3] windows: add a getfstype method

2017-03-12 Thread Jun Wu
# HG changeset patch # User Jun Wu # Date 1489305423 28800 # Sat Mar 11 23:57:03 2017 -0800 # Node ID ecd7fb0f1919e28472e6d41ea282c82d10c33675 # Parent 9c4d023de5832618e06d9434968ef9af35d70986 # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull https

[PATCH 5 of 7 V3] util: disable hardlink for copyfile if fstype is outside a whitelist

2017-03-12 Thread Jun Wu
# HG changeset patch # User Jun Wu # Date 1489306987 28800 # Sun Mar 12 00:23:07 2017 -0800 # Node ID 10ec43758c6b4034a0eeecf24a54752784c82a2c # Parent cd3743a4b74ef409de34ec002a469201cd39b30e # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull https

[PATCH 4 of 7 V3] util: add a getfstype method

2017-03-12 Thread Jun Wu
# HG changeset patch # User Jun Wu # Date 1489305432 28800 # Sat Mar 11 23:57:12 2017 -0800 # Node ID cd3743a4b74ef409de34ec002a469201cd39b30e # Parent ecd7fb0f1919e28472e6d41ea282c82d10c33675 # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull https

[PATCH 1 of 7 V3] posix: implement a method to get filesystem type for Linux

2017-03-12 Thread Jun Wu
# HG changeset patch # User Jun Wu # Date 1489302836 28800 # Sat Mar 11 23:13:56 2017 -0800 # Node ID 3fbaae1fa75a54a527d4f56963227561b65a8c28 # Parent 78ac7061f84000a0b1e6dae1c3f363324d8e1aba # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull https

[PATCH 2 of 7 V3] posix: add a getfstype method

2017-03-12 Thread Jun Wu
# HG changeset patch # User Jun Wu # Date 1489305410 28800 # Sat Mar 11 23:56:50 2017 -0800 # Node ID 9c4d023de5832618e06d9434968ef9af35d70986 # Parent 3fbaae1fa75a54a527d4f56963227561b65a8c28 # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull https

[PATCH] debugfsinfo: print fstype information

2017-03-12 Thread Jun Wu
# HG changeset patch # User Jun Wu # Date 1489311257 28800 # Sun Mar 12 01:34:17 2017 -0800 # Node ID ff9af50d033388f74cbaf1eeac1509b3e75da07b # Parent 9da40a9e54c419490a2ff23b9dda7acc109f81cd # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull https

Re: [PATCH 7 of 7 V3] util: enable hardlink for copyfile

2017-03-12 Thread Jun Wu
Excerpts from Augie Fackler's message of 2017-03-12 14:03:44 -0400: > It's actually believed the problem is in the Windows CIFS *server*, if > you read the bug attached to the previous change. > > I'm hesitant to turn on hardlinks at all because of the way problems > manifest (unrecoverable data c

Re: [PATCH 4 of 5 V2] util: add a getfstype method

2017-03-12 Thread Jun Wu
Excerpts from Yuya Nishihara's message of 2017-03-12 08:08:55 -0700: > On Sat, 11 Mar 2017 23:28:25 -0800, Jun Wu wrote: > > Excerpts from Yuya Nishihara's message of 2017-03-11 16:48:54 -0800: > > > On Thu, 2 Mar 2017 22:13:30 -0800, Jun Wu wrote: > > > >

Re: [PATCH 4 of 5 V2] util: add a getfstype method

2017-03-12 Thread Jun Wu
Excerpts from Yuya Nishihara's message of 2017-03-12 11:58:40 -0700: > > That's good to know. I actually had 3 patches to move it to vfs, but was > > concerned about the future "repostorage" layer holding vfs objects that > > won't get invalidated across chg workers. > > If the filesystem at the c

Re: [PATCH 7 of 7 V3] util: enable hardlink for copyfile

2017-03-12 Thread Jun Wu
Excerpts from Mads Kiilerich's message of 2017-03-12 11:48:35 -0700: > I only see mentioning of problems with Windows on the client side. > Matt's theory of the source of the cache coherency issue suggested that > it was interaction between client and server side caches. Non-windows > client sid

Re: [PATCH] debugfsinfo: print fstype information

2017-03-12 Thread Jun Wu
Sun, 12 Mar 2017 14:12:03 -0400, Augie Fackler wrote: > >> On Sun, Mar 12, 2017 at 01:34:53AM -0800, Jun Wu wrote: > >>> # HG changeset patch > >>> # User Jun Wu > >>> # Date 1489311257 28800 > >>> # Sun Mar 12 01:34:17 2017 -0800 > >&

Re: [PATCH RFC] ui: introduce sysdefault section for pager and editor configuration

2017-03-12 Thread Jun Wu
What if instead of reading environments directly, introduce a new config layer which is converted from environment variables? Like: - (Top)layer: command line config flags - layer: user configs - layer: config converted from environment variables lik

Re: [PATCH 4 of 5 V2] util: add a getfstype method

2017-03-12 Thread Jun Wu
Excerpts from Yuya Nishihara's message of 2017-03-12 12:26:57 -0700: > On Sun, 12 Mar 2017 12:06:32 -0700, Jun Wu wrote: > > Excerpts from Yuya Nishihara's message of 2017-03-12 11:58:40 -0700: > > > > That's good to know. I actually had 3 patches to move it to

Re: [PATCH] extensions: formalize concept of experimental extensions

2017-03-12 Thread Jun Wu
If I read it correctly, this means an "experimental" extension will end up with: | ext=| ext=!beta old client | load| do not load new client | do not load | load I think that's confusing. I think we can have an "[extensi

Re: [PATCH] extensions: formalize concept of experimental extensions

2017-03-12 Thread Jun Wu
Excerpts from Gregory Szorc's message of 2017-03-12 19:48:35 -0700: > > > On Mar 12, 2017, at 19:28, Jun Wu wrote: > > > > If I read it correctly, this means an "experimental" extension will end up > > with: >

[PATCH 1 of 4] obsolete: track node versions

2017-03-13 Thread Jun Wu
# HG changeset patch # User Jun Wu # Date 1489385975 25200 # Sun Mar 12 23:19:35 2017 -0700 # Node ID dec2b2328ef19c166f0ed1cb711b6c99dc9c590a # Parent 8a17c541177f32348e248608b6a9dfd7fefdf517 # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull https

[PATCH 2 of 4] obsolete: add a filteredmarkerdict class

2017-03-13 Thread Jun Wu
# HG changeset patch # User Jun Wu # Date 1489386664 25200 # Sun Mar 12 23:31:04 2017 -0700 # Node ID 09a30f1a2da8d17d4781b1a66a282265138f4f29 # Parent dec2b2328ef19c166f0ed1cb711b6c99dc9c590a # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull https

[PATCH 3 of 4] obsolete: use filteredmarkerdict for obsstore dicts

2017-03-13 Thread Jun Wu
# HG changeset patch # User Jun Wu # Date 1489391940 25200 # Mon Mar 13 00:59:00 2017 -0700 # Node ID 83288095bc38cef4b9e8bb9c69914b981115aaab # Parent 09a30f1a2da8d17d4781b1a66a282265138f4f29 # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull https

[PATCH 4 of 4] obsolete: allow cycles

2017-03-13 Thread Jun Wu
# HG changeset patch # User Jun Wu # Date 1489395002 25200 # Mon Mar 13 01:50:02 2017 -0700 # Node ID 5cf846db23cddc36b01acf0211d52f8d50f36dcd # Parent 83288095bc38cef4b9e8bb9c69914b981115aaab # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull https

Re: [PATCH 4 of 4] obsolete: allow cycles

2017-03-13 Thread Jun Wu
Excerpts from Jun Wu's message of 2017-03-13 02:34:19 -0700: > # HG changeset patch > # User Jun Wu > # Date 1489395002 25200 > # Mon Mar 13 01:50:02 2017 -0700 > # Node ID 5cf846db23cddc36b01acf0211d52f8d50f36dcd > # Parent 83288095bc38cef4b9e8bb9c69914b981115aaab

[PATCH 4 of 4 V2] obsolete: allow cycles

2017-03-13 Thread Jun Wu
# HG changeset patch # User Jun Wu # Date 1489395002 25200 # Mon Mar 13 01:50:02 2017 -0700 # Node ID 6ae6d1069ba1d4089afaeb0bb8ef2411983a1292 # Parent 0280ee091bd0ae33aa0a67b0c8a55ccffd2e0718 # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull https

[PATCH 1 of 4 V2] obsolete: track node versions

2017-03-13 Thread Jun Wu
# HG changeset patch # User Jun Wu # Date 1489385975 25200 # Sun Mar 12 23:19:35 2017 -0700 # Node ID dec2b2328ef19c166f0ed1cb711b6c99dc9c590a # Parent 8a17c541177f32348e248608b6a9dfd7fefdf517 # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull https

[PATCH 3 of 4 V2] obsolete: use filteredmarkerdict for obsstore dicts

2017-03-13 Thread Jun Wu
# HG changeset patch # User Jun Wu # Date 1489391940 25200 # Mon Mar 13 00:59:00 2017 -0700 # Node ID 0280ee091bd0ae33aa0a67b0c8a55ccffd2e0718 # Parent 09a30f1a2da8d17d4781b1a66a282265138f4f29 # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull https

[PATCH 2 of 4 V2] obsolete: add a filteredmarkerdict class

2017-03-13 Thread Jun Wu
# HG changeset patch # User Jun Wu # Date 1489386664 25200 # Sun Mar 12 23:31:04 2017 -0700 # Node ID 09a30f1a2da8d17d4781b1a66a282265138f4f29 # Parent dec2b2328ef19c166f0ed1cb711b6c99dc9c590a # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull https

Re: [PATCH 4 of 4 V2] obsolete: allow cycles

2017-03-13 Thread Jun Wu
Excerpts from Durham Goode's message of 2017-03-13 09:23:49 -0700: > On 3/13/17 2:48 AM, Jun Wu wrote: > > # HG changeset patch > > # User Jun Wu > > # Date 1489395002 25200 > > # Mon Mar 13 01:50:02 2017 -0700 > > # Node ID 6ae6d1069ba1d40

Re: [PATCH 4 of 4 V2] obsolete: allow cycles

2017-03-13 Thread Jun Wu
Excerpts from Pierre-Yves David's message of 2017-03-13 11:57:08 -0700: > > On 03/13/2017 09:23 AM, Durham Goode wrote: > > On 3/13/17 2:48 AM, Jun Wu wrote: > >> # HG changeset patch > >> # User Jun Wu > >> # Date 1489395002 25200 > >>

Re: [PATCH] ui: don't read the same config file twice

2017-03-13 Thread Jun Wu
This is a BC because loading order matters: # a.rc %include b.rc [ui] editor = foo %include b.rc # b.rc [ui] editor = bar Since people should be able to arrange config files in a way that no files are included twice. I prefer not being too smart in hg. Excerpts from David Soria

[PATCH 10 of 10] pager: do not read from environment variable

2017-03-13 Thread Jun Wu
# HG changeset patch # User Jun Wu # Date 1489456112 25200 # Mon Mar 13 18:48:32 2017 -0700 # Node ID ceef734e0887a34bad5290daf735512bc0108a9f # Parent fca9187f1dbaaf17305878e9310e332373589c14 # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull https

[PATCH 03 of 10] scmutil: split osrcpath to return system and user paths separately

2017-03-13 Thread Jun Wu
# HG changeset patch # User Jun Wu # Date 1489452019 25200 # Mon Mar 13 17:40:19 2017 -0700 # Node ID 4211d15ea4df24e3825a481a2fd7eaf5e96416c3 # Parent 742ced65214c96869a4305e6d621a9a0d2b1282d # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull https

[PATCH 09 of 10] ui: simplify geteditor

2017-03-13 Thread Jun Wu
# HG changeset patch # User Jun Wu # Date 1489456194 25200 # Mon Mar 13 18:49:54 2017 -0700 # Node ID fca9187f1dbaaf17305878e9310e332373589c14 # Parent a0cff9968a6041c3c47a8417637c79959f9ba408 # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull https

[PATCH 02 of 10] scmutil: define a list of configs overriding system rc, but not users

2017-03-13 Thread Jun Wu
# HG changeset patch # User Jun Wu # Date 1489450537 25200 # Mon Mar 13 17:15:37 2017 -0700 # Node ID 742ced65214c96869a4305e6d621a9a0d2b1282d # Parent 0d9bf7436a14061e02ef91dc4f81bee97d638f0a # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull https

[PATCH 01 of 10] scmutil: add a method to convert environment variables to config items

2017-03-13 Thread Jun Wu
# HG changeset patch # User Jun Wu # Date 1489449998 25200 # Mon Mar 13 17:06:38 2017 -0700 # Node ID 0d9bf7436a14061e02ef91dc4f81bee97d638f0a # Parent 3d3109339b57341b333c1112beb41dd281fa944a # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull https

[PATCH 07 of 10] config: list environment variables in debug output

2017-03-13 Thread Jun Wu
# HG changeset patch # User Jun Wu # Date 1489455351 25200 # Mon Mar 13 18:35:51 2017 -0700 # Node ID d640c97a1c2b7098581753814ec8e3c72ce53dfd # Parent 685e4b92293443041840afc47a2445290c63f13b # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull https

[PATCH 08 of 10] scmutil: remove rcpath

2017-03-13 Thread Jun Wu
# HG changeset patch # User Jun Wu # Date 1489455385 25200 # Mon Mar 13 18:36:25 2017 -0700 # Node ID a0cff9968a6041c3c47a8417637c79959f9ba408 # Parent d640c97a1c2b7098581753814ec8e3c72ce53dfd # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull https

[PATCH 06 of 10] ui: use scmutil.rccomponents to load configs (BC)

2017-03-13 Thread Jun Wu
# HG changeset patch # User Jun Wu # Date 1489462886 25200 # Mon Mar 13 20:41:26 2017 -0700 # Node ID 685e4b92293443041840afc47a2445290c63f13b # Parent c00819f7c5c38b6e8b3fa6c29578dd7d2592a59e # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull https

[PATCH 04 of 10] scmutil: add a rcpath-like method to return multiple config sources

2017-03-13 Thread Jun Wu
# HG changeset patch # User Jun Wu # Date 1489452890 25200 # Mon Mar 13 17:54:50 2017 -0700 # Node ID 3661037ef3868497350990f02d23a04069020b9a # Parent 4211d15ea4df24e3825a481a2fd7eaf5e96416c3 # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull https

[PATCH 05 of 10] run-tests: drop environment variables affecting configs

2017-03-13 Thread Jun Wu
# HG changeset patch # User Jun Wu # Date 1489455061 25200 # Mon Mar 13 18:31:01 2017 -0700 # Node ID c00819f7c5c38b6e8b3fa6c29578dd7d2592a59e # Parent 3661037ef3868497350990f02d23a04069020b9a # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull https

Re: [PATCH 04 of 10] scmutil: add a rcpath-like method to return multiple config sources

2017-03-13 Thread Jun Wu
Excerpts from David Soria Parra's message of 2017-03-13 21:37:57 -0700: > On Mon, Mar 13, 2017 at 08:44:49PM -0700, Jun Wu wrote: > > scmutil: add a rcpath-like method to return multiple config sources > > nice series :) > > > +def rccomponents(): > > +

[PATCH 2 of 4] histedit: use safecleanupnode in _finishhistedit

2017-03-13 Thread Jun Wu
# HG changeset patch # User Jun Wu # Date 1489468746 25200 # Mon Mar 13 22:19:06 2017 -0700 # Node ID 990c1dcccd1aad7e8a7c3ecdedcc79c6d98ff169 # Parent b4cf155f7a41ebf314407000f6948716ae0a64e2 # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull https

[PATCH 1 of 4] histedit: add a method to cleanup nodes safely

2017-03-13 Thread Jun Wu
# HG changeset patch # User Jun Wu # Date 1489464645 25200 # Mon Mar 13 21:10:45 2017 -0700 # Node ID b4cf155f7a41ebf314407000f6948716ae0a64e2 # Parent 3d3109339b57341b333c1112beb41dd281fa944a # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull https

[PATCH 4 of 4] histedit: inline cleanupnode

2017-03-13 Thread Jun Wu
# HG changeset patch # User Jun Wu # Date 1489469407 25200 # Mon Mar 13 22:30:07 2017 -0700 # Node ID c8fd15f1632259900b87f6df61211e94b2eb3637 # Parent 0993e7596542d0e29532f949bc4a59a3075c123b # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull https

[PATCH 3 of 4] histedit: use safecleanupnode in _aborthistedit (issue5500)

2017-03-13 Thread Jun Wu
# HG changeset patch # User Jun Wu # Date 1489468938 25200 # Mon Mar 13 22:22:18 2017 -0700 # Node ID 0993e7596542d0e29532f949bc4a59a3075c123b # Parent 990c1dcccd1aad7e8a7c3ecdedcc79c6d98ff169 # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull https

Re: [PATCH] extensions: formalize concept of experimental extensions

2017-03-14 Thread Jun Wu
Excerpts from Yuya Nishihara's message of 2017-03-13 19:02:06 -0700: > How about :allowbeta = True ? Old clients will try to load "True" as an extension. ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mai

Re: [PATCH 01 of 10 RFC v2] ui: refactoring handling of trusted, user and overlay

2017-03-14 Thread Jun Wu
The direction looks fine. I'm especially interested in the performance and correctness of the "config merging" part (not in this patch), I'll comment in that patch. It seems it does not conflict with the immutable config objects I had before. Maybe we want the immutable thing eventually. But that

Re: [PATCH 04 of 10 RFC v2] compat: module to handle different ui.compat settings

2017-03-14 Thread Jun Wu
Excerpts from David Soria Parra's message of 2017-03-12 15:40:27 -0700: [...] > +# compat.py - handlign compatibility settings spell: "handling" > +# > +# Copyright 2005-2017 Mercurial Steering Committee > +# > +# This software may be used and distributed according to the terms of the > +# GNU

Re: [PATCH 05 of 10 RFC v2] help: document compat mode

2017-03-14 Thread Jun Wu
Excerpts from David Soria Parra's message of 2017-03-12 15:40:28 -0700: [...] > +``compat`` > +String: Compatibility mode for the ui. Possible values are compat Maybe also quote "compat" and "latest" in these 2 lines. > +or latest (default: compat). ``compat`` provides backwards compati

Re: [PATCH 03 of 10 RFC v2] ui: don't return certain layers when they are supposed to be displayed

2017-03-14 Thread Jun Wu
Excerpts from David Soria Parra's message of 2017-03-12 15:40:26 -0700: [...] > -def _data(self, untrusted): > +def _data(self, untrusted, includeinternal=True): > +res = {} This does not seem to work. I guess you mean "res = config.config()". > +if includeinternal: >

[PATCH] osutil: fix potential wrong fd close

2017-03-15 Thread Jun Wu
# HG changeset patch # User Jun Wu # Date 1489635792 25200 # Wed Mar 15 20:43:12 2017 -0700 # Node ID ebcce969e076146ae9aa3690c35373123f5f508d # Parent fb1b5cd17664218f73ed6ba604973b817932593e # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull https

Re: [PATCH 2 of 2] pager: skip running the pager if it's set to 'cat'

2017-03-15 Thread Jun Wu
I think these changes are good. I'd like to have more "modernize" stuffs. Another thing that git does (reasonably, I think) is to set default environment variable. Say if we decide to go with shell=False, set LESS=FRX so people using pager.pager=less will have a better experience. Excerpts from A

Re: [PATCH 01 of 11] bdiff: use Python memory allocator in fixws

2017-03-15 Thread Jun Wu
I think it makes sense to migrate Python modules to PyMem_*. However, I'm also a bit conservative about the "calloc" perf issue mentioned by Yuya. I think it's safe to take Patch 1, 2, 4, 5 where there is no calloc change for now. We can figure out what to do with calloc / pure C code later. Exce

Re: [PATCH 01 of 11] bdiff: use Python memory allocator in fixws

2017-03-15 Thread Jun Wu
Excerpts from Jun Wu's message of 2017-03-15 23:15:13 -0700: > I think it makes sense to migrate Python modules to PyMem_*. > > However, I'm also a bit conservative about the "calloc" perf issue mentioned > by Yuya. I think it's safe to take Patch 1, 2, 4, 5 where there is no calloc Sorry, it sho

[PATCH 1 of 8] commit: get rid of ui.backupconfig

2017-03-16 Thread Jun Wu
# HG changeset patch # User Jun Wu # Date 1489698920 25200 # Thu Mar 16 14:15:20 2017 -0700 # Node ID def9b72933ce717a48e3cc8fa4934bd3459b9479 # Parent 5c9cda37d7f6b181ab604c8d5a7592b5553f886b # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull https

[PATCH 4 of 8] record: get rid of ui.backupconfig

2017-03-16 Thread Jun Wu
# HG changeset patch # User Jun Wu # Date 1489700075 25200 # Thu Mar 16 14:34:35 2017 -0700 # Node ID 4ff0515eaa03cf3fdd2b19a3444eb9c2cebdbcea # Parent 01931210cd8d62aa56447843c096ea57bdf03889 # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull https

[PATCH 6 of 8] mq: get rid of ui.backupconfig

2017-03-16 Thread Jun Wu
# HG changeset patch # User Jun Wu # Date 1489700358 25200 # Thu Mar 16 14:39:18 2017 -0700 # Node ID 8b086a28d1b605d6c0726d77c21f8d13188691fa # Parent 93772a7ad2c443b7c92d0d23e85405f5b0d1a800 # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull https

[PATCH 2 of 8] clone: get rid of ui.backupconfig

2017-03-16 Thread Jun Wu
# HG changeset patch # User Jun Wu # Date 1489699130 25200 # Thu Mar 16 14:18:50 2017 -0700 # Node ID 7b575fd8a7a1e9a96cd79352351d87ac69479270 # Parent def9b72933ce717a48e3cc8fa4934bd3459b9479 # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull https

[PATCH 5 of 8] histedit: get rid of ui.backupconfig

2017-03-16 Thread Jun Wu
# HG changeset patch # User Jun Wu # Date 1489700195 25200 # Thu Mar 16 14:36:35 2017 -0700 # Node ID 93772a7ad2c443b7c92d0d23e85405f5b0d1a800 # Parent 4ff0515eaa03cf3fdd2b19a3444eb9c2cebdbcea # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull https

[PATCH 8 of 8] shelve: get rid of ui.backupconfig

2017-03-16 Thread Jun Wu
# HG changeset patch # User Jun Wu # Date 1489699661 25200 # Thu Mar 16 14:27:41 2017 -0700 # Node ID 4f98fa7baebed161fe94c98661a8c404dd82a87d # Parent 8f87b407da24ee802e271f517dbc96ad32f21779 # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull https

[PATCH 3 of 8] import: get rid of ui.backupconfig

2017-03-16 Thread Jun Wu
# HG changeset patch # User Jun Wu # Date 1489699429 25200 # Thu Mar 16 14:23:49 2017 -0700 # Node ID 01931210cd8d62aa56447843c096ea57bdf03889 # Parent 7b575fd8a7a1e9a96cd79352351d87ac69479270 # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull https

[PATCH 7 of 8] rebase: get rid of ui.backupconfig

2017-03-16 Thread Jun Wu
# HG changeset patch # User Jun Wu # Date 1489700434 25200 # Thu Mar 16 14:40:34 2017 -0700 # Node ID 8f87b407da24ee802e271f517dbc96ad32f21779 # Parent 8b086a28d1b605d6c0726d77c21f8d13188691fa # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull https

Re: [PATCH 7 of 8] rebase: get rid of ui.backupconfig

2017-03-16 Thread Jun Wu
Excerpts from Martin von Zweigbergk's message of 2017-03-16 17:14:33 -0700: > On Thu, Mar 16, 2017 at 2:57 PM, Jun Wu wrote: > > # HG changeset patch > > # User Jun Wu > > # Date 1489700434 25200 > > # Thu Mar 16 14:40:34 2017 -0700 > > # Node ID 8f

Re: [PATCH 1 of 8] commit: get rid of ui.backupconfig

2017-03-16 Thread Jun Wu
Thanks! Excerpts from Martin von Zweigbergk's message of 2017-03-16 17:19:15 -0700: > On Thu, Mar 16, 2017 at 2:56 PM, Jun Wu wrote: > > # HG changeset patch > > # User Jun Wu > > # Date 1489698920 25200 > > # Thu Mar 16 1

Re: [PATCH V2] merge: add `internal:dumpjson` tool to `resolve`, which outputs conflict state

2017-03-16 Thread Jun Wu
Just to add some notes on variable names. There are some very common short names. Like "p1" representing "parent1". And "p1" should be preferred. An incomplete list is at [1]. It's okay to use "fname" hetlridvnvrtrtf "filename". FWIW, Ruby community standard prefers longer names while Golang expli

Re: [PATCH V2] merge: add `internal:dumpjson` tool to `resolve`, which outputs conflict state

2017-03-16 Thread Jun Wu
Fix a cat typing. Excerpts from Jun Wu's message of 2017-03-16 20:12:28 -0700: > Just to add some notes on variable names. There are some very common short > names. Like "p1" representing "parent1". And "p1" should be preferred. An > incomplete list is at [1]. It's okay to use "fname" hetlridvnvrt

Re: [PATCH 1 of 4] histedit: add a method to cleanup nodes safely

2017-03-17 Thread Jun Wu
Excerpts from Yuya Nishihara's message of 2017-03-17 22:32:45 +0900: > On Mon, 13 Mar 2017 22:36:16 -0700, Jun Wu wrote: > > # HG changeset patch > > # User Jun Wu > > # Date 1489464645 25200 > > # Mon Mar 13 21:10:45 2017 -0700 > > # Node ID b4

Re: [PATCH 01 of 10 RFC v2] ui: refactoring handling of trusted, user and overlay

2017-03-17 Thread Jun Wu
Another issue with the "compat" layer outside "ucfg" or "tcfg" is that it cannot handle the case where ucfg or tcfg have different ui.compat setting. I just discovered this when writing the immutable stuff. Hopefully I can send a V1 today. Excerpts from David Soria Parra's message of 2017-03-12 1

[PATCH config easy] ui: move configlist parser to config.py

2017-03-17 Thread Jun Wu
# HG changeset patch # User Jun Wu # Date 1489767596 25200 # Fri Mar 17 09:19:56 2017 -0700 # Node ID 012156d455f06480e3825edb450fcb37b63e9a1c # Parent 96929bd6e58d29bc3d44e1db7c1283f224bd1dc1 # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull https

Re: [PATCH 1 of 4] histedit: add a method to cleanup nodes safely

2017-03-17 Thread Jun Wu
Excerpts from Yuya Nishihara's message of 2017-03-18 11:13:36 +0900: > On Fri, 17 Mar 2017 08:37:14 -0700, Jun Wu wrote: > > Excerpts from Yuya Nishihara's message of 2017-03-17 22:32:45 +0900: > > > On Mon, 13 Mar 2017 22:36:16 -0700, Jun Wu wrote: > > > >

Re: [PATCH 1 of 4] histedit: add a method to cleanup nodes safely

2017-03-17 Thread Jun Wu
Excerpts from Yuya Nishihara's message of 2017-03-18 11:48:30 +0900: > (+CC Pierre-Yves) I guess he may be busy with other stuffs. > I meant they both could be iterators/generators now, but 'sucs' wouldn't > be by design. I'm saying that because it seems not common to take a nested > iterator as

Re: [PATCH 6 of 8] mq: get rid of ui.backupconfig

2017-03-17 Thread Jun Wu
Excerpts from Yuya Nishihara's message of 2017-03-18 11:34:21 +0900: > On Thu, 16 Mar 2017 14:57:01 -0700, Jun Wu wrote: > > # HG changeset patch > > # User Jun Wu > > # Date 1489700358 25200 > > # Thu Mar 16 14:39:18 2017 -0700 > > # Node ID 8b

[PATCH 4 of 4 V2] histedit: inline cleanupnode

2017-03-17 Thread Jun Wu
# HG changeset patch # User Jun Wu # Date 1489469407 25200 # Mon Mar 13 22:30:07 2017 -0700 # Node ID 059f7bf163769c1483f8f1dacf2de70d4808a0ae # Parent 4b3b1a9932d9af65893d293a92684649f0d25772 # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull https

[PATCH 1 of 4 V2] histedit: add a method to cleanup nodes safely

2017-03-17 Thread Jun Wu
# HG changeset patch # User Jun Wu # Date 1489464645 25200 # Mon Mar 13 21:10:45 2017 -0700 # Node ID 19a0f5164fcd28240327beffc3c90cdddfb17123 # Parent 96929bd6e58d29bc3d44e1db7c1283f224bd1dc1 # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull https

[PATCH 3 of 4 V2] histedit: use safecleanupnode in _aborthistedit (issue5500)

2017-03-17 Thread Jun Wu
# HG changeset patch # User Jun Wu # Date 1489468938 25200 # Mon Mar 13 22:22:18 2017 -0700 # Node ID 4b3b1a9932d9af65893d293a92684649f0d25772 # Parent e9c84e5081e18d67e061bae2a77e7465d8a6f685 # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull https

[PATCH 2 of 4 V2] histedit: use safecleanupnode in _finishhistedit

2017-03-17 Thread Jun Wu
# HG changeset patch # User Jun Wu # Date 1489468746 25200 # Mon Mar 13 22:19:06 2017 -0700 # Node ID e9c84e5081e18d67e061bae2a77e7465d8a6f685 # Parent 19a0f5164fcd28240327beffc3c90cdddfb17123 # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull https

Re: [PATCH config easy] ui: move configlist parser to config.py

2017-03-18 Thread Jun Wu
Excerpts from Yuya Nishihara's message of 2017-03-18 14:11:33 +0900: > On Fri, 17 Mar 2017 09:34:09 -0700, Jun Wu wrote: > > # HG changeset patch > > # User Jun Wu > > # Date 1489767596 25200 > > # Fri Mar 17 09:19:56 2017 -0700 > > # Node ID 01

Re: [PATCH 1 of 4 V2] histedit: add a method to cleanup nodes safely

2017-03-18 Thread Jun Wu
Excerpts from Yuya Nishihara's message of 2017-03-18 14:12:24 +0900: > On Fri, 17 Mar 2017 20:17:48 -0700, Jun Wu wrote: > > # HG changeset patch > > # User Jun Wu > > # Date 1489464645 25200 > > # Mon Mar 13 21:10:45 2017 -0700 > > # Node ID 19

Re: [PATCH 1 of 3] dispatch: store args and command run on ui

2017-03-20 Thread Jun Wu
Excerpts from Ryan McElroy's message of 2017-03-20 11:43:22 +: > I think Jun needs to weigh in on this since the ui object is something > he's wanted to make immutable for a while and this doesn't seem to help > move us in that direction. Immutable is for the config object. I'm +1 to add ui.

Re: [PATCH 1 of 3] dispatch: store args and command run on ui

2017-03-20 Thread Jun Wu
have dispatch.request and it uses "args". So "ui.args" is better than "ui.argv". > > On Mon, Mar 20, 2017 at 9:16 AM, Jun Wu wrote: > > > Excerpts from Ryan McElroy's message of 2017-03-20 11:43:22 +: > > > I think Jun needs to weigh i

[PATCH 3 of 6] setup: detect statfs

2017-03-20 Thread Jun Wu
# HG changeset patch # User Jun Wu # Date 1490047878 25200 # Mon Mar 20 15:11:18 2017 -0700 # Node ID 8a5bf6002f2c9f98fbbe68c216579a7803693d65 # Parent 3706485e7df8662529498360cc09584b185dfcc7 # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull https

[PATCH 1 of 6] setup: split "hasfunction" to test arbitrary code

2017-03-20 Thread Jun Wu
# HG changeset patch # User Jun Wu # Date 149004 25200 # Mon Mar 20 15:28:08 2017 -0700 # Node ID 272f2d2a56cad143c899d4beb4b36610f68e6310 # Parent 44c591f634584c721778c5a77edeb04cd919ac43 # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull https

[PATCH 6 of 6] osutil: export a "getfstype" method

2017-03-20 Thread Jun Wu
# HG changeset patch # User Jun Wu # Date 1490052852 25200 # Mon Mar 20 16:34:12 2017 -0700 # Node ID c8693bc1191b3ac1af0a67e97068777b13cfa672 # Parent f710d54d1985975d7d37aa58e9d5740ebdcf5b7b # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull https

[PATCH 2 of 6] setup: add a function to test header files

2017-03-20 Thread Jun Wu
# HG changeset patch # User Jun Wu # Date 1490049081 25200 # Mon Mar 20 15:31:21 2017 -0700 # Node ID 3706485e7df8662529498360cc09584b185dfcc7 # Parent 272f2d2a56cad143c899d4beb4b36610f68e6310 # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull https

[PATCH 5 of 6] osutil: add a C function getting filesystem type

2017-03-20 Thread Jun Wu
# HG changeset patch # User Jun Wu # Date 1490052299 25200 # Mon Mar 20 16:24:59 2017 -0700 # Node ID f710d54d1985975d7d37aa58e9d5740ebdcf5b7b # Parent 8a3c7ac9923732e980a3660f0555c2e109ee93e0 # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull https

<    1   2   3   4   5   6   7   8   9   10   >