D970: hgweb: extract function for loading style from request context

av6 accepted this revision. av6 added a comment. LGTM. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D970 To: durin42, #hg-reviewers, av6 Cc: av6, mercurial-devel ___ Mercurial-devel mailing list Mercurial-devel@mercur

D4053: [RFC]hgweb: garbage collect on every request in hgweb_mod too

av6 added a comment. Are you sure you're not just using hgwebdir_mod? hgweb_mod is for cases when you don't use --web-conf flag, at least that seems to be the logic that `hgweb.createapp()` uses to pick one of the two modules. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercur

D4261: zsh_completion: rename _hg_style_opts to _hg_template_opts

av6 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY --style is a deprecated alias for --template, and doesn't show up in help without --verbose, so completing it doesn't make much sense. Let's s/style/template/ thi

D4266: zsh_completion: run hg with HGPLAINEXCEPT=alias to list commands

av6 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is what contrib/bash_completion does, looks like a sensible thing to do. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4266 AFFECT

D4263: zsh_completion: complete files from `hg st -mar` for commit and diff

av6 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Useful to have and is consistent with our bash completion file. This is also an improvement coming from upstream, downstream or sidestream (depends on how you loo

D4265: zsh_completion: remove completion for obsolete graphlog extension

av6 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4265 AFFECTED FILES contrib/zsh_completion CHANGE DETAILS diff --git a/contrib/zsh_completion b/contrib/z

D4262: zsh_completion: drop -w, add -S to _arguments

av6 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY From the docs: http://zsh.sourceforge.net/Doc/Release/Completion-System.html _arguments -w: "allow option stacking even if one or more of the options take argumen

D4267: zsh_completion: update all options

av6 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY It's just too hard to further split this patch. What it does: - adds missing flags - removes flags that are no longer there - updates flag descriptions and argu

D4264: zsh_completion: declare appropriate local parameters for ->string form

av6 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY When ->string form is used for _arguments, the function that calls it must declare appropriate local parameters. Managing local return value is needed to tell the

D4262: zsh_completion: drop -w, add -S to _arguments

av6 added a comment. Thanks, `‘` and `’` for making it difficult to phabsend this. I had to diff --git a/contrib/phabricator.py b/contrib/phabricator.py --- a/contrib/phabricator.py +++ b/contrib/phabricator.py @@ -117,6 +117,8 @@ def urlencodenested(params): def pro

D4267: zsh_completion: update all options

av6 added inline comments. INLINE COMMENTS > spectral wrote in zsh_completion:644 > I assume the first section here makes continue and abort mutually exclusive? > I believe that revision arguments are also forbidden if either --continue or > --abort are specified; I don't know if there's a way

D4291: contrib: import the relnotes script from the release-tools repo

av6 added a comment. I've commented on things that can be improved, but they shouldn't stop this from landing. INLINE COMMENTS > relnotes:51 > +r": implement ": -5, > +r"2\.4": -20, > +r": use .* implementation": -20, I assume it's for Python 2.4. Maybe needs more versions we do

D4261: zsh_completion: rename _hg_style_opts to _hg_template_opts

This revision was automatically updated to reflect the committed changes. Closed by commit rHG27bbd62e9957: zsh_completion: rename _hg_style_opts to _hg_template_opts (authored by av6, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4261?vs=

D4263: zsh_completion: complete files from `hg st -mar` for commit and diff

This revision was automatically updated to reflect the committed changes. Closed by commit rHG8ff14f8fe2d3: zsh_completion: complete files from `hg st -mar` for commit and diff (authored by av6, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org

D4265: zsh_completion: remove completion for obsolete graphlog extension

This revision was automatically updated to reflect the committed changes. Closed by commit rHG93fdf00596e4: zsh_completion: remove completion for obsolete graphlog extension (authored by av6, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4

D4264: zsh_completion: declare appropriate local parameters for ->string form

This revision was automatically updated to reflect the committed changes. Closed by commit rHG69876534caf2: zsh_completion: declare appropriate local parameters for ->string form (authored by av6, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.o

D4262: zsh_completion: drop -w, add -S to _arguments

This revision was automatically updated to reflect the committed changes. Closed by commit rHGfd17590655cf: zsh_completion: drop -w, add -S to _arguments (authored by av6, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4262?vs=10328&id=1046

D4266: zsh_completion: run hg with HGPLAINEXCEPT=alias to list commands

This revision was automatically updated to reflect the committed changes. Closed by commit rHGf625e457f43a: zsh_completion: run hg with HGPLAINEXCEPT=alias to list commands (authored by av6, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D42

D4267: zsh_completion: update all options

This revision was automatically updated to reflect the committed changes. Closed by commit rHG362c4603602d: zsh_completion: update all options (authored by av6, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4267?vs=10333&id=10468 REVISION

D4360: zsh_completion: adjust usage of common options

av6 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY addremove, remove and serve accept -S/--subrepos, and purge actually doesn't. qnew accepts -I/--include and -X/--exclude. qrefresh accepts -D/--currentdate, -U

D4361: zsh_completion: complete hg files

av6 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4361 AFFECTED FILES contrib/zsh_completion CHANGE DETAILS diff --git a/contrib/zsh_completion b/contrib/z

D4362: zsh_completion: complete merge tools for -t/--tool

av6 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4362 AFFECTED FILES contrib/zsh_completion CHANGE DETAILS diff --git a/contrib/zsh_completion b/contrib/z

D4361: zsh_completion: complete hg files

This revision was automatically updated to reflect the committed changes. Closed by commit rHGad1c6bd3c676: zsh_completion: complete hg files (authored by av6, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D4361?vs=10536&id=10650#toc REPOSITORY rHG Mercurial CHANGES

D4360: zsh_completion: adjust usage of common options

This revision was automatically updated to reflect the committed changes. Closed by commit rHGd0dfdf263a20: zsh_completion: adjust usage of common options (authored by av6, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4360?vs=10535&id=106

D4362: zsh_completion: complete merge tools for -t/--tool

av6 added inline comments. INLINE COMMENTS > spectral wrote in zsh_completion:292 > I'm slightly concerned this might give a false impression of what's > available, listing things that I don't have installed, but I think this might > be the best we can do at the moment - there doesn't appear to

D4361: zsh_completion: complete hg files

av6 added inline comments. INLINE COMMENTS > pulkit wrote in zsh_completion:636 > I changed "revision" to "REV" in flight. What is REV? It's a metavariable used in hg help output. It makes sense if you look at the help output while typing up hg files, but zsh's completion is supposed to help u

D4362: zsh_completion: complete merge tools for -t/--tool

This revision was automatically updated to reflect the committed changes. Closed by commit rHGb4e7e1f09c09: zsh_completion: complete merge tools for -t/--tool (authored by av6, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4362?vs=10537&id

D4426: zsh_completion: use revsets to exclude this rev from suggestions to hg merge

av6 created this revision. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: hg-reviewers. REVISION SUMMARY One of the most important aspects of a completion system is its speed, so 2 calls to hg is definitely better than 4. Sorting by rev (descending) is to p

D4428: zsh_completion: complete shelve and unshelve

av6 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4428 AFFECTED FILES contrib/zsh_completion CHANGE DETAILS diff --git a/contrib/zsh_completion b/contrib/z

D4427: zsh_completion: handle --rev as well as -r for diff and revert

av6 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Completion for hg diff and revert should suggest all files in context of a non-current revision. The script used to look only for `-r foo`, and now it also understan

D4428: zsh_completion: complete shelve and unshelve

av6 added inline comments. INLINE COMMENTS > spectral wrote in zsh_completion:1272 > Mine has a --cleanup flag. Not sure where that came from, and I think it's > dangerous as heck and I don't like it, but ... should we list it? (I'm 100% > fine with the answer being "no, it's too scary" :))

D4426: zsh_completion: use revsets to exclude this rev from suggestions to hg merge

av6 added a comment. It probably would make sense, but you don't need to exclude current branch, because `hg merge mybranch` works when you have more than one branch head (except when you stand on the newest head, unfortunately: "abort: merging with a working directory ancestor has no effect

D4427: zsh_completion: handle --rev as well as -r for diff and revert

This revision was automatically updated to reflect the committed changes. Closed by commit rHG09f23b4f1be3: zsh_completion: handle --rev as well as -r for diff and revert (authored by av6, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4427

D4426: zsh_completion: use revsets to exclude this rev from suggestions to hg merge

av6 updated this revision to Diff 10716. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4426?vs=10682&id=10716 REVISION DETAIL https://phab.mercurial-scm.org/D4426 AFFECTED FILES contrib/zsh_completion CHANGE DETAILS diff --git a/contrib/zsh_complet

D4428: zsh_completion: complete shelve and unshelve

av6 updated this revision to Diff 10717. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4428?vs=10684&id=10717 REVISION DETAIL https://phab.mercurial-scm.org/D4428 AFFECTED FILES contrib/zsh_completion CHANGE DETAILS diff --git a/contrib/zsh_complet

D4428: zsh_completion: complete shelve and unshelve

av6 added a comment. Ah, and now the comments are grayed out. I shouldn't have re-phabsend-ed this, since there are no changes from the previous version. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4428 To: av6, #hg-reviewers Cc: spectral, mercurial-devel __

D4426: zsh_completion: use revsets to exclude this rev from suggestions to hg merge

av6 added a comment. Now it's only one call to hg. All possible branches included, even if hg merge that-branch would complain (see my comment above), because in completions it's better to give extra suggestions than to miss some. But this "revision numbers + branch names" got me thinkin

D4426: zsh_completion: use revsets to exclude this rev from suggestions to hg merge

This revision was automatically updated to reflect the committed changes. Closed by commit rHG2815e0db4c54: zsh_completion: use revsets to exclude this rev from suggestions to hg merge (authored by av6, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial

D4428: zsh_completion: complete shelve and unshelve

This revision was automatically updated to reflect the committed changes. Closed by commit rHG45d12c49c3f3: zsh_completion: complete shelve and unshelve (authored by av6, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4428?vs=10717&id=10781

D4518: zsh_completion: update various arguments, descriptions, metavariables

av6 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Addition of "=" means the flag must have an argument after it. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4518 AFFECTED FILES cont

D4519: zsh_completion: add new and remove deprecated flags

av6 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4519 AFFECTED FILES contrib/zsh_completion CHANGE DETAILS diff --git a/contrib/zsh_completion b/contrib/z

D4518: zsh_completion: update various arguments, descriptions, metavariables

This revision was automatically updated to reflect the committed changes. Closed by commit rHG5f06c21d37de: zsh_completion: update various arguments, descriptions, metavariables (authored by av6, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.or

D4519: zsh_completion: add new and remove deprecated flags

This revision was automatically updated to reflect the committed changes. Closed by commit rHGa2d17b699628: zsh_completion: add new and remove deprecated flags (authored by av6, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4519?vs=10854&i

D4612: zsh_completion: add -b/--branch and -B/--bookmark(s) flags properly

av6 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY _hg_branch_bmark_opts used to add these two flags, but had the same descriptions for the flags regardless of what command took them and didn't allow specifying flags

D4612: zsh_completion: add -b/--branch and -B/--bookmark(s) flags properly

This revision was automatically updated to reflect the committed changes. Closed by commit rHG3f11cb1aeb90: zsh_completion: add -b/--branch and -B/--bookmark(s) flags properly (authored by av6, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/

D4665: meld: enable auto-merge

av6 added a comment. Although I must say that EPEL 6 (it's for RHEL/CentOS 6) still has meld 1.3.1, which may be too old for this option: https://repology.org/metapackage/meld/versions REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4665 To: martinvonz, #hg-rev

D4678: tests: split capabilities into separate lines while searching for "narrow"

av6 created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This test is interested only in capabilities that are related to narrow, so let's omit everything else. Makes it easier to update oth

D4679: bundle2: graduate bundle2.stream option from experimental to server section

av6 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4679 AFFECTED FILES mercurial/bundle2.py mercurial/configitems.py mercurial/help/config.txt tests/tes

D4680: bundle2: make server.bundle2.stream default to True

av6 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Support for bundle2 streaming clones has been shipped in Mercurial 4.5 (https://phab.mercurial-scm.org/rHG7eedbd5d4880f6c0518e5ff706450a7389acb70d), but was never act

D4678: tests: split capabilities into separate lines while searching for "narrow"

This revision was automatically updated to reflect the committed changes. Closed by commit rHG7d9b1b50cad5: tests: split capabilities into separate lines while searching for "narrow" (authored by av6, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-s

D4680: bundle2: make server.bundle2.stream default to True

This revision was automatically updated to reflect the committed changes. Closed by commit rHG4bd6e444c76f: bundle2: make server.bundle2.stream default to True (authored by av6, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4680?vs=11217&i

D4679: bundle2: graduate bundle2.stream option from experimental to server section

This revision was automatically updated to reflect the committed changes. Closed by commit rHG1b5880352314: bundle2: graduate bundle2.stream option from experimental to server section (authored by av6, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-

D2010: check-commit: allow foo_bar naming in functions

av6 added a comment. As opposed to 11 words smashed together, function names in Mercurial usually are 2 or 3 words (if not just one), which is not at all bad. I think breaking inconsistency with the existing code base would be worse than making people get used to no-spaces style (the one tha

D2253: releasenotes: mention changeset with warning and abort

av6 added inline comments. INLINE COMMENTS > pulkit wrote in releasenotes.py:315 > No need for `node.hex(ctx.node())`, just use ctx. or `ctx.hex()` REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2253 To: rishabhmadan96, #hg-reviewers Cc: av6, pulkit, mercurial-de

D2776: hgweb: use a multidict for holding query string parameters

av6 added inline comments. INLINE COMMENTS > martinvonz wrote in request.py:45 > Would it make sense to make this an error if there isn't exactly one value? I don't think it would. AIUI, that would make handling query strings like ?style=foo&style=bar just more difficult. I'm not aware of any w

D2934: forget: add --confirm option

av6 added inline comments. INLINE COMMENTS > cmdutil.py:2007 > +if dryrun and confirm: > +raise error.Abort(_("can't specify --dry-run and --confirm")) > join = lambda f: os.path.join(prefix, f) "cannot specify both --dry-run and --confirm" is the style used in other commands.

D2938: grep: make grep search on working directory by default

av6 added inline comments. INLINE COMMENTS > commands.py:2485 > +fm.data(node=fm.hexfunc(scmutil.binnode(ctx))) > +if not bool(opts.get('all')) and not bool(opts.get('rev')): > +cols = [ This line looks identical to the one later on, with Pulkit's comment

D2959: stringutil: add isauthorwellformed function

av6 added inline comments. INLINE COMMENTS > stringutil.py:310 > +''' > +return bool(_correctauthorformat.match(author)) Nit: `is not None` is more pythonic. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2959 To: sheehan, #hg-reviewers Cc: av6, mercurial

D2960: stringutil: move person function from templatefilters

av6 requested changes to this revision. av6 added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > templatefilters.py:293-294 > def person(author): > -"""Any text. Returns the name before an email address, > -interpreting it as per RFC 5322. > - Don't re

D5710: py3: add 7 new passing tests to whitelist found by buildbot

av6 added a comment. Is this patch a result of some flawed automated script? Because wow, unless my eyes fail me, these additions are all duplicates. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5710 To: pulkit, #hg-reviewers Cc: av6, mercurial-devel

D5537: obsutil: add a simplified obshistorywalker() (PoC)

av6 abandoned this revision. av6 added a comment. Okay then, I'll work on a non-PoC version of this. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5537 To: av6, #hg-reviewers Cc: mjpieters, mercurial-devel ___ Mercuri

D5538: hgweb: add /obsgraph page that shows obsolescence history of a changeset (PoC)

av6 abandoned this revision. av6 added a comment. Okay then, I'll work on a non-PoC version of this. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5538 To: av6, #hg-reviewers Cc: durin42, mjpieters, mercurial-devel __

D5779: copyright: update to 2019

av6 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5779 AFFECTED FILES contrib/packaging/debian/copyright contrib/win32/ReadMe.html contrib/win32/mercuria

D5779: copyright: update to 2019

av6 added a comment. Intended for stable. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5779 To: av6, #hg-reviewers Cc: mercurial-devel ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.me

D5779: copyright: update to 2019

This revision was automatically updated to reflect the committed changes. Closed by commit rHG8427fea04017: copyright: update to 2019 (authored by av6, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5779?vs=13640&id=13643 REVISION DETAIL

D6122: tests: add a file listing all the flaky tests

av6 added a comment. Another way to do this could be to introduce another special keyword, similar to "slow", so that tests that are known flaky can `#require flaky` or even mark a specific block with `#if flaky`. Obviously fixing ​test-remotefilelog-bgprefetch.t is a better idea altogether,

D6123: Experimental features: Add condition to for float number (issue6099)

av6 added a comment. I find it troubling that we now have contributors that don't follow #1 in https://www.mercurial-scm.org/wiki/ContributingChanges#Submission_checklist. Potentially #4 too (as Pulkit commented). Seriously, the title is terrible at describing what this patch fixes and

D6123: Experimental features: Add condition to for float number (issue6099)

av6 added inline comments. INLINE COMMENTS > similar.py:67 > +if lengths > 0: > return equal * 2.0 / lengths > This returns None in some cases, and code that uses `_score()` and `score()` tries to compare it to an integer. In Python3 `None > 1` raises TypeError. REPOSITORY rHG Mer

D6123: ZeroDivisionError: Add condition to avoid Zerodivisonerror due to float number (issue6099)

av6 added a comment. Okay, let's go over #1 in https://www.mercurial-scm.org/wiki/ContributingChanges#Submission_checklist once more. If you want to know what a good "topic" is, look at what other people do. How patches that get accepted generally look. How bug-fixing commits are worded.

D6122: tests: add a file listing all the flaky tests

av6 added a comment. In https://phab.mercurial-scm.org/D6122#89818, @lothiraldan wrote: > @av6 is a `--no-flaky-tests` flag what you had in mind? Something like that, yes. I suggested that flag seeing how this change introduces a quite specific file with just one line. And I thoug

D6442: help: include subtopic in error message if passed

av6 added inline comments. INLINE COMMENTS > help.py:826 > +if subtopic: > +hint += _(" or 'hg help --keyword %s'") % subtopic > raise error.Abort(msg, hint=hint) Concatenating things is not the best option when it comes to i18n, but even if

D6441: help: check if a subtopic exists and raise an error if it doesn't (issue6145)

av6 added inline comments. INLINE COMMENTS > help.py:689-695 > +exists = False > for names, header, doc in subtopics[name]: > if subtopic in names: > +exists = True > break > +if not exists: > +

D6459: githelp: translate --directory of git apply to --prefix

av6 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY According to the help pages, these flags do the same. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6459 AFFECTED FILES hgext/githelp

D6460: githelp: add --dry-run for mv

av6 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6460 AFFECTED FILES hgext/githelp.py CHANGE DETAILS diff --git a/hgext/githelp.py b/hgext/githelp.py ---

D6461: githelp: translate git stash show and clear actions and --patch flag

av6 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6461 AFFECTED FILES hgext/githelp.py tests/test-githelp.t CHANGE DETAILS diff --git a/tests/test-githel

D6460: githelp: add --dry-run for mv

This revision was automatically updated to reflect the committed changes. Closed by commit rHG37ff80505dfd: githelp: add --dry-run for mv (authored by av6, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6460?vs=15297&id=15300 REVISION DETA

D6459: githelp: translate --directory of git apply to --prefix

This revision was automatically updated to reflect the committed changes. Closed by commit rHGeddff539f5be: githelp: translate --directory of git apply to --prefix (authored by av6, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6459?vs=152

D6461: githelp: translate git stash show and clear actions and --patch flag

This revision was automatically updated to reflect the committed changes. Closed by commit rHG7752cd3a2f83: githelp: translate git stash show and clear actions and --patch flag (authored by av6, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org

D6467: doc: fix description of "predecessors" to match reality

av6 added a comment. This change looks good, but I have doubts about "visible" in the docstring. https://phab.mercurial-scm.org/rHG1858fc2327ef7b631941e37550738f1fc4217bfb does say that this template keyword respects repo filtering, but I've encountered instances where it shows hidden predec

D6476: merge: correct argument name in docstring

av6 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6476 AFFECTED FILES mercurial/merge.py CHANGE DETAILS diff --git a/mercurial/merge.py b/mercurial/merge.p

D6476: merge: correct argument name in docstring

This revision was automatically updated to reflect the committed changes. Closed by commit rHG127937874395: merge: correct argument name in docstring (authored by av6, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6476?vs=15332&id=15333 R

D1167: makefile: add target to apply clang-format in-place

av6 added a comment. I'm a bit late to the party, but wanted to remind people that targets that are not actual files (in this case, a file named "format-c") should also go into .PHONY list. Nothing bad will happen right now (unless such file appears at some point), but adding it to "phony" t

D1167: makefile: add target to apply clang-format in-place

av6 added a comment. Yep, mailed. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1167 To: durin42, #hg-reviewers, indygreg Cc: av6, mercurial-devel ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org htt

D1270: help: adding a topic on flags

av6 added inline comments. INLINE COMMENTS > flags.txt:7 > +Mercurial command-line flags can be strings, numbers, booleans, or lists of > +strings. > + This "lists of strings" caught my attention, but it took me some time to figure out what's the matter. I don't feel strongly, but here are some

D5140: zsh_completion: use $_hg_remote_opts after it is defined

av6 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Before this patch, zsh wouldn't complete --ssh, --remotecmd or --insecure for hg clone. While at it, replace --uncompressed by --stream. REPOSITORY rHG Mercuri

D5141: zsh_completion: fix a couple of flags still not being perfect

av6 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5141 AFFECTED FILES contrib/zsh_completion CHANGE DETAILS diff --git a/contrib/zsh_completion b/contrib/z

D5142: zsh_completion: add -l/--list flag for hg bookmarks completion

av6 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Flags in parentheses are mutually exclusive. Logic is taken from commands.py: selactions = [k for k in ['delete', 'rename', 'list'] if opts.get(k)] if len(sel

D5140: zsh_completion: use $_hg_remote_opts after it is defined

This revision was automatically updated to reflect the committed changes. Closed by commit rHG4c9418e3a7d3: zsh_completion: use $_hg_remote_opts after it is defined (authored by av6, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5140?vs=12

D5141: zsh_completion: fix a couple of flags still not being perfect

This revision was automatically updated to reflect the committed changes. Closed by commit rHG01bdf7294274: zsh_completion: fix a couple of flags still not being perfect (authored by av6, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5141?

D5142: zsh_completion: add -l/--list flag for hg bookmarks completion

This revision was automatically updated to reflect the committed changes. Closed by commit rHGd365e2b7aa2a: zsh_completion: add -l/--list flag for hg bookmarks completion (authored by av6, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5142

D4362: zsh_completion: complete merge tools for -t/--tool

av6 added projects: hg, hg-reviewers. av6 added a comment. Changing project tags, please ignore. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4362 To: av6, #hg-reviewers, spectral Cc: spectral, mercurial-devel, namenlos, dsp, pulkit, durham, akushner _

D5064: style: run black on a subset of mercurial

av6 added a comment. I look at the changes and see nitpicks at best. On the one hand, black proved better than any linter that we can already write consistent code. On the other, if black were a linter... I'd switch to flake8, which at least is configurable

D5444: help: use "yes" and "no" for boolean defaults instead of "on" and "off"

av6 created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5444 AFFECTED FILES mercurial/help.py tests/test-extension.t tests/te

D5444: help: use "yes" and "no" for boolean defaults instead of "on" and "off"

av6 added a comment. The point of https://phab.mercurial-scm.org/D5430 was to make hg help output more human friendly by replacing `True` and `False` with something less Python-related. In other words, more human-friendly. "Yes" and "no" are way more human-friendly: - they are one of th

D5455: help: hide default value for default-off flags

av6 accepted this revision. av6 added a comment. This revision is now accepted and ready to land. These look good. One more thing I want to mention: hg help evolve looks like this: --phase-divergent solves only phase-divergent changesets --content-divergent solves only conte

D5474: obsutil: fix the issue5686

av6 added inline comments. INLINE COMMENTS > test-obsmarker-template.t:2511 >| @ 471597cad322 > - |/ Obsfate: pruned; > + |/ Obsfate: rewritten as 2:617adc3a144c by test (at 1970-01-01 00:00 > +); >o ea207398892e The new output looks somewhat more correct, but not quite.

D5537: obsutil: add a simplified obshistorywalker() (PoC)

av6 created this revision. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This code is taken from evolve extension, namely from obslog command implementation, and somewhat simplified to be easier to review. No tests and no use

D5538: hgweb: add /obsgraph page that shows obsolescence history of a changeset (PoC)

av6 created this revision. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Feel free to ask questions, I suspect some chunks would need a comment (either in review or in code) to explain what's going on there. I'll start workin

D3187: phase: add dry-run functionality

av6 added inline comments. INLINE COMMENTS > commands.py:3872 > +if opts['dry_run']: > +raise error.Abort(_("can't use --dryrun when no targetphase")) > # display `"cannot use --dry-run without target phase"` REPOSITORY rHG Mercurial REVISION DETAIL https://pha

D3649: serve: add option print-url

av6 added a comment. Merits another patch with some simple tests. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3649 To: nspanti-logilab, #hg-reviewers, durin42 Cc: av6, yuja, mercurial-devel ___ Mercurial-devel maili

  1   2   >