D7370: fuzz: clean out most of fuzzutil

2019-11-11 Thread durin42 (Augie Fackler)
Closed by commit rHG6f5c352f41b6: fuzz: clean out most of fuzzutil (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7370?vs=18030&id=18037 CHANGES SINCE LAST AC

D7166: packaging: ship all help .txt files on WiX

2019-11-12 Thread durin42 (Augie Fackler)
durin42 added a comment. In D7166#108320 , @indygreg wrote: > This got dropped on committed but Phabricator is confused about its closedstate. Please re-review and land @martinvonz or @durin42. Per Martin's comment, it looks like you had

D7166: packaging: ship all help .txt files on WiX

2019-11-12 Thread durin42 (Augie Fackler)
durin42 added a comment. I re-landed this and tests passed on my workstation when I did so. Let's not drop this again without some additional coordination? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7166/new/ REVISION DETAIL https://phab.mercuri

D7166: packaging: ship all help .txt files on WiX

2019-11-12 Thread durin42 (Augie Fackler)
durin42 added a comment. No worries, I'm not sure what went sideways there. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7166/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7166 To: indygreg, #hg-reviewers Cc: durin42, martinvonz, mercurial-

D7375: py3: replace "%r" by"'%s'% for py3-compatible (and clearer) quoting in chg

2019-11-13 Thread durin42 (Augie Fackler)
durin42 added a comment. I feel obligated to point out that this will result in different (wrong!) quoting if `path` contains a `'`, but that's also probably fine since it's just a log. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7375/new/ REVISIO

D7257: [RFC] repoview: add a "filter" that just disallows walking to heads

2019-11-13 Thread durin42 (Augie Fackler)
durin42 added a comment. durin42 accepted this revision as: durin42. I'm a big fan of this idea. I'd probably land it if there were some obvious usecases as child patches. :) REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7257/new/ REVISION DETAIL h

D7289: branchmap: always copy closednodes to a set

2019-11-13 Thread durin42 (Augie Fackler)
durin42 updated this revision to Diff 18063. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7289?vs=17659&id=18063 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7289/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7289 AFFECTED FILES

D7379: encoding: fix bad type annotation

2019-11-13 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This function returns utf-8 in a bytes, not a unicode. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7379 AFFECTED FILES mercuria

D7380: encoding: define per-use identity functions only in typechecking mode

2019-11-13 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This avoids some unfortunate overhead from my previous iteration. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7380 AFFECTED FILES

D7296: pycompat: kludge around pytype being confused by __new__

2019-11-13 Thread durin42 (Augie Fackler)
Herald added a subscriber: mjpieters. durin42 updated this revision to Diff 18066. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7296?vs=17672&id=18066 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7296/new/ REVISION DETAIL https://phab.m

D7378: debugcommands: don't shadow the error module

2019-11-13 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Caught by pytype. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7378 AFFECTED FILES mercurial/debugcommands.py CHANGE DETAILS d

D7382: logcmdutil: add a type annotation

2019-11-13 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This wasn't actually required in the end, as there was a real bug found by pytype, but the annotation helped me figure that out. We can drop this patch if that's

D7383: state: add a pytype annotation

2019-11-13 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7383 AFFECTED FILES mercurial/state.py CHANGE DETAILS diff --git a/mercurial/state.py b/mercurial/sta

D7297: cleanup: remove now-obsolete wrong-arg-type annotations

2019-11-13 Thread durin42 (Augie Fackler)
durin42 updated this revision to Diff 18067. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7297?vs=17673&id=18067 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7297/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7297 AFFECTED FILES

D7377: commands: log --line-range is incompatible with --copies

2019-11-13 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This was (to my surprise) detected by pytype. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7377 AFFECTED FILES mercurial/command

D7381: cmdutil: add a pytype annotation to help out some callsites

2019-11-13 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I think we could constrain the values here more than Any, but this lets us move forward with typechecking commands.py. REPOSITORY rHG Mercurial REVISION DETAIL

D7295: pytype: add a (very slow) test that executes pytype

2019-11-13 Thread durin42 (Augie Fackler)
durin42 updated this revision to Diff 18072. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7295?vs=17665&id=18072 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7295/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7295 AFFECTED FILES

D7385: debugcommands: suppress import errors for pytype

2019-11-13 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7385 AFFECTED FILES mercurial/debugcommands.py CHANGE DETAILS diff --git a/mercurial/debugcommands.py

D7384: commands: necessary annotations and suppresssions to pass pytype

2019-11-13 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY As with other places, there are some places where our types are just too complicated for pytype, so we put some suppressions in place. REPOSITORY rHG Mercurial

D7380: encoding: define per-use identity functions only in typechecking mode

2019-11-13 Thread durin42 (Augie Fackler)
durin42 added a comment. Let's not land this for now: it's breaking a fair amount of typechecking. :( REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7380/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7380 To: durin42, #hg-reviewers Cc: mercur

D7289: branchmap: correctly set()-ify list argument

2019-11-14 Thread durin42 (Augie Fackler)
durin42 edited the summary of this revision. durin42 retitled this revision from "branchmap: always copy closednodes to a set" to "branchmap: correctly set()-ify list argument". durin42 updated this revision to Diff 18077. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercu

D7389: branchmap: annotate constructor type for branchcache

2019-11-14 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This type signature is...big. But it's correct as far as I can tell, and it detected a bug. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-s

D7390: extdiff: use field names instead of field numbers on scmutil.status

2019-11-14 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY As part of my pytype adventures I want to make scmutil.status no longer a subclass of tuple. This is part of that process. REPOSITORY rHG Mercurial REVISION DE

D7391: hgk: use field names instead of field numbers on scmutil.status

2019-11-14 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY As part of my pytype adventures I want to make scmutil.status no longer a subclass of tuple. This is part of that process. REPOSITORY rHG Mercurial REVISION DE

D7393: split: use field names instead of field numbers on scmutil.status

2019-11-14 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY As part of my pytype adventures I want to make scmutil.status no longer a subclass of tuple. This is part of that process. REPOSITORY rHG Mercurial REVISION DE

D7395: uncommit: use field names instead of field numbers on scmutil.status

2019-11-14 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY As part of my pytype adventures I want to make scmutil.status no longer a subclass of tuple. This is part of that process. REPOSITORY rHG Mercurial REVISION DE

D7394: transplant: use field names instead of field numbers on scmutil.status

2019-11-14 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY As part of my pytype adventures I want to make scmutil.status no longer a subclass of tuple. This is part of that process. REPOSITORY rHG Mercurial REVISION DE

D7297: cleanup: remove now-obsolete wrong-arg-type annotations

2019-11-14 Thread durin42 (Augie Fackler)
durin42 updated this revision to Diff 18079. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7297?vs=18067&id=18079 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7297/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7297 AFFECTED FILES

D7392: mq: use field names instead of field numbers on scmutil.status

2019-11-14 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY As part of my pytype adventures I want to make scmutil.status no longer a subclass of tuple. This is part of that process. REPOSITORY rHG Mercurial REVISION DE

D7396: cmdutil: use field names instead of field numbers on scmutil.status

2019-11-14 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY As part of my pytype adventures I want to make scmutil.status no longer a subclass of tuple. This is part of that process. REPOSITORY rHG Mercurial REVISION DE

D7397: cmdutil: convert terse status result back to an scmutil.status

2019-11-14 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is also part of detupling scmutil.status. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7397 AFFECTED FILES mercurial/cmduti

D7400: logcmdutil: use field names instead of field numbers on scmutil.status

2019-11-14 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY As part of my pytype adventures I want to make scmutil.status no longer a subclass of tuple. This is part of that process. REPOSITORY rHG Mercurial REVISION DE

D7399: context: use field names instead of field numbers on scmutil.status

2019-11-14 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY As part of my pytype adventures I want to make scmutil.status no longer a subclass of tuple. This is part of that process. REPOSITORY rHG Mercurial REVISION DE

D7401: patch: use field names instead of field numbers on scmutil.status

2019-11-14 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY As part of my pytype adventures I want to make scmutil.status no longer a subclass of tuple. This is part of that process. REPOSITORY rHG Mercurial REVISION DE

D7403: subrepo: use field names instead of field numbers on scmutil.status

2019-11-14 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY As part of my pytype adventures I want to make scmutil.status no longer a subclass of tuple. This is part of that process. REPOSITORY rHG Mercurial REVISION DE

D7402: revset: use field names instead of field numbers on scmutil.status

2019-11-14 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY As part of my pytype adventures I want to make scmutil.status no longer a subclass of tuple. This is part of that process. REPOSITORY rHG Mercurial REVISION DE

D7398: commands: use field names instead of field numbers on scmutil.status

2019-11-14 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY As part of my pytype adventures I want to make scmutil.status no longer a subclass of tuple. This is part of that process. REPOSITORY rHG Mercurial REVISION DE

D7404: tags: use field names instead of field numbers on scmutil.status

2019-11-14 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY As part of my pytype adventures I want to make scmutil.status no longer a subclass of tuple. This is part of that process. REPOSITORY rHG Mercurial REVISION DE

D7382: logcmdutil: add a type annotation

2019-11-14 Thread durin42 (Augie Fackler)
durin42 updated this revision to Diff 18098. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7382?vs=18069&id=18098 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7382/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7382 AFFECTED FILES

D7406: scmutil: convert status data object from a tuple to an attrs (API)

2019-11-14 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We've been pushing towards the property names for a while, and the subclassing of the tuple confuses pytype. Rather than bend over backwards to try and annotate

D7405: perf: bool() elements of dirstate.status return instead of len()

2019-11-14 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I'm about to make scmutil.status no longer have a len(), so we need to do something else to "use" the results in this perf method. REPOSITORY rHG Mercurial REV

D7408: extensions: hide two confusing import statements from pytype

2019-11-14 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7408 AFFECTED FILES mercurial/extensions.py CHANGE DETAILS diff --git a/mercurial/extensions.py b/mer

D7381: cmdutil: add a pytype annotation to help out some callsites

2019-11-14 Thread durin42 (Augie Fackler)
durin42 updated this revision to Diff 18097. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7381?vs=18068&id=18097 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7381/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7381 AFFECTED FILES

D7409: dispatch: add some assertions to give pytype a helping hand

2019-11-14 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7409 AFFECTED FILES mercurial/dispatch.py CHANGE DETAILS diff --git a/mercurial/dispatch.py b/mercuri

D7410: extensions: suppress a strange pytype failure

2019-11-14 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I suspect a bug in pytype here, but I'll follow up with that later. We have good enough coverage on this that I'm happy to move on for now. REPOSITORY rHG Mercu

D7295: pytype: add a (very slow) test that executes pytype

2019-11-14 Thread durin42 (Augie Fackler)
durin42 updated this revision to Diff 18104. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7295?vs=18072&id=18104 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7295/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7295 AFFECTED FILES

D7407: debugcommands: add assertions to convince pytype peer is not None

2019-11-14 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This function is moderately annoyingly defined, and peer is set up iff we're not in raw-proto mode. That's fine, but it confuses pytype. Adding these assertions

D7384: commands: necessary annotations and suppresssions to pass pytype

2019-11-14 Thread durin42 (Augie Fackler)
durin42 updated this revision to Diff 18099. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7384?vs=18071&id=18099 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7384/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7384 AFFECTED FILES

D7406: scmutil: convert status data object from a tuple to an attrs (API)

2019-11-14 Thread durin42 (Augie Fackler)
durin42 updated this revision to Diff 18105. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7406?vs=18096&id=18105 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7406/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7406 AFFECTED FILES

D7381: cmdutil: add a pytype annotation to help out some callsites

2019-11-14 Thread durin42 (Augie Fackler)
durin42 added inline comments. durin42 marked an inline comment as done. INLINE COMMENTS > dlax wrote in cmdutil.py:3970 > Wouldn't `-> Dict[bytes, List[bytes]]` be okay? (Not sure why "Any" you're > referering to in commit message, though I understand `Dict[bytes, Any]` comes > from `state.cmd

D7384: commands: necessary annotations and suppresssions to pass pytype

2019-11-14 Thread durin42 (Augie Fackler)
durin42 added inline comments. INLINE COMMENTS > dlax wrote in commands.py:1127 > This one is sad. I think this can be sorted out by replacing the > `try:/finally:` with a context manager. (Can send a patch, if it sounds good > to you.) By all means! REPOSITORY rHG Mercurial CHANGES SINCE

D7385: debugcommands: suppress import errors for pytype

2019-11-14 Thread durin42 (Augie Fackler)
durin42 added a comment. In D7385#108592 , @dlax wrote: > I wonder if using `importlib.import_module()` wouldn't help. Or is it something we avoid in Mercurial? We use it in other places. I have no idea the extent to which it'd help. REPO

D7377: commands: log --line-range is incompatible with --copies

2019-11-14 Thread durin42 (Augie Fackler)
durin42 added a comment. durin42 abandoned this revision. @dlax seems to have fixed the underlying issue here. :) REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7377/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7377 To: durin42, #hg-reviewe

D7411: dirs: resolve fuzzer OOM situation by disallowing deep directory hierarchies

2019-11-14 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY It seems like 2048 directories ought to be enough for any reasonable use of Mercurial? .. bc: Mercurial will now defend against OOMs by refusing to ope

D7411: dirs: resolve fuzzer OOM situation by disallowing deep directory hierarchies

2019-11-14 Thread durin42 (Augie Fackler)
durin42 edited the summary of this revision. durin42 updated this revision to Diff 18112. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7411?vs=18106&id=18112 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7411/new/ REVISIO

D7411: dirs: resolve fuzzer OOM situation by disallowing deep directory hierarchies

2019-11-14 Thread durin42 (Augie Fackler)
durin42 added inline comments. durin42 marked an inline comment as done. INLINE COMMENTS > indygreg wrote in dirs.c:66 > What code calls this function? Do we have any good perf numbers for > introducing this loop? > > I ask because the diffing code is surprisingly impacted by the the "find > n

D7289: branchmap: correctly set()-ify list argument

2019-11-14 Thread durin42 (Augie Fackler)
Closed by commit rHG43f57b9620d2: branchmap: correctly set()-ify list argument (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7289?vs=18077&id=18114 CHANGES S

D7389: branchmap: annotate constructor type for branchcache

2019-11-14 Thread durin42 (Augie Fackler)
Closed by commit rHG9c1eccdd7ed8: branchmap: annotate constructor type for branchcache (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7389?vs=18078&id=18116 C

D7379: encoding: fix bad type annotation

2019-11-14 Thread durin42 (Augie Fackler)
Closed by commit rHG7edc07fb890c: encoding: fix bad type annotation (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7379?vs=18064&id=18117 CHANGES SINCE LAST A

D7390: extdiff: use field names instead of field numbers on scmutil.status

2019-11-14 Thread durin42 (Augie Fackler)
Closed by commit rHG7415cd486696: extdiff: use field names instead of field numbers on scmutil.status (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7390?vs=18

D7391: hgk: use field names instead of field numbers on scmutil.status

2019-11-14 Thread durin42 (Augie Fackler)
Closed by commit rHG52a73fb498a4: hgk: use field names instead of field numbers on scmutil.status (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7391?vs=18081&

D7393: split: use field names instead of field numbers on scmutil.status

2019-11-14 Thread durin42 (Augie Fackler)
Closed by commit rHG705738def50c: split: use field names instead of field numbers on scmutil.status (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7393?vs=1808

D7378: debugcommands: don't shadow the error module

2019-11-14 Thread durin42 (Augie Fackler)
Closed by commit rHG72b454fae92e: debugcommands: don't shadow the error module (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7378?vs=18062&id=18115 CHANGES S

D7394: transplant: use field names instead of field numbers on scmutil.status

2019-11-14 Thread durin42 (Augie Fackler)
Closed by commit rHG96edd0c38740: transplant: use field names instead of field numbers on scmutil.status (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7394?vs

D7395: uncommit: use field names instead of field numbers on scmutil.status

2019-11-14 Thread durin42 (Augie Fackler)
Closed by commit rHGd0310f21ee9e: uncommit: use field names instead of field numbers on scmutil.status (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7395?vs=1

D7392: mq: use field names instead of field numbers on scmutil.status

2019-11-14 Thread durin42 (Augie Fackler)
Closed by commit rHG2d5b991c2192: mq: use field names instead of field numbers on scmutil.status (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7392?vs=18082&i

D7396: cmdutil: use field names instead of field numbers on scmutil.status

2019-11-14 Thread durin42 (Augie Fackler)
Closed by commit rHGe01e0641f18a: cmdutil: use field names instead of field numbers on scmutil.status (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7396?vs=18

D7397: cmdutil: convert terse status result back to an scmutil.status

2019-11-14 Thread durin42 (Augie Fackler)
Closed by commit rHG9cb7f855e2fc: cmdutil: convert terse status result back to an scmutil.status (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7397?vs=18087&i

D7400: logcmdutil: use field names instead of field numbers on scmutil.status

2019-11-14 Thread durin42 (Augie Fackler)
Closed by commit rHG4093fc1777c2: logcmdutil: use field names instead of field numbers on scmutil.status (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7400?vs

D7399: context: use field names instead of field numbers on scmutil.status

2019-11-14 Thread durin42 (Augie Fackler)
Closed by commit rHGe035a8f71d52: context: use field names instead of field numbers on scmutil.status (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7399?vs=18

D7398: commands: use field names instead of field numbers on scmutil.status

2019-11-14 Thread durin42 (Augie Fackler)
Closed by commit rHG1e1bad31b427: commands: use field names instead of field numbers on scmutil.status (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7398?vs=1

D7401: patch: use field names instead of field numbers on scmutil.status

2019-11-14 Thread durin42 (Augie Fackler)
Closed by commit rHGd649de29f1ff: patch: use field names instead of field numbers on scmutil.status (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7401?vs=1809

D7402: revset: use field names instead of field numbers on scmutil.status

2019-11-14 Thread durin42 (Augie Fackler)
Closed by commit rHGd212d657ba0e: revset: use field names instead of field numbers on scmutil.status (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7402?vs=180

D7404: tags: use field names instead of field numbers on scmutil.status

2019-11-14 Thread durin42 (Augie Fackler)
Closed by commit rHGba5c39b9324c: tags: use field names instead of field numbers on scmutil.status (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7404?vs=18094

D7403: subrepo: use field names instead of field numbers on scmutil.status

2019-11-14 Thread durin42 (Augie Fackler)
Closed by commit rHGaeed2f106213: subrepo: use field names instead of field numbers on scmutil.status (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7403?vs=18

D7406: scmutil: convert status data object from a tuple to an attrs (API)

2019-11-14 Thread durin42 (Augie Fackler)
Closed by commit rHGc5548b0b6847: scmutil: convert status data object from a tuple to an attrs (API) (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7406?vs=181

D7405: perf: bool() elements of dirstate.status return instead of len()

2019-11-14 Thread durin42 (Augie Fackler)
Closed by commit rHG6186c2a53ea5: perf: bool() elements of dirstate.status return instead of len() (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7405?vs=18095

D7411: dirs: resolve fuzzer OOM situation by disallowing deep directory hierarchies

2019-11-14 Thread durin42 (Augie Fackler)
Closed by commit rHG0796e266d26b: dirs: resolve fuzzer OOM situation by disallowing deep directory hierarchies (authored by durin42). durin42 marked an inline comment as done. This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST

D7424: [RFC] pyoxidizer

2019-11-15 Thread durin42 (Augie Fackler)
durin42 added a comment. durin42 added a subscriber: martinvonz. FYI @martinvonz REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7424/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7424 To: indygreg, #hg-reviewers Cc: martinvonz, durin42, kevin

D7424: [RFC] pyoxidizer

2019-11-15 Thread durin42 (Augie Fackler)
durin42 added a comment. durin42 added a subscriber: mharbison72. also fyi @mharbison72 since it looks like the @ in the commit message didn't work? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7424/new/ REVISION DETAIL https://phab.mercurial-scm.

D7408: extensions: hide two confusing import statements from pytype

2019-11-15 Thread durin42 (Augie Fackler)
durin42 added a comment. In D7408#109174 , @dlax wrote: > Out of curiosity, where does this `__index__` value come from? Beats me. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7408/new/ REVISION

D7410: extensions: suppress a pytype failure due to a typeshed bug

2019-11-15 Thread durin42 (Augie Fackler)
durin42 edited the summary of this revision. durin42 retitled this revision from "extensions: suppress a strange pytype failure" to "extensions: suppress a pytype failure due to a typeshed bug". durin42 updated this revision to Diff 18159. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE h

D7385: debugcommands: suppress import errors for pytype

2019-11-15 Thread durin42 (Augie Fackler)
durin42 updated this revision to Diff 18157. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7385?vs=18073&id=18157 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7385/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7385 AFFECTED FILES

D7407: debugcommands: add assertions to convince pytype peer is not None

2019-11-15 Thread durin42 (Augie Fackler)
durin42 updated this revision to Diff 18158. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7407?vs=18100&id=18158 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7407/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7407 AFFECTED FILES

D7384: commands: necessary annotations and suppresssions to pass pytype

2019-11-15 Thread durin42 (Augie Fackler)
durin42 added a comment. I still want to keep the annotations I added. :) REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7384/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7384 To: durin42, #hg-reviewers, dlax Cc: dlax, mercurial-devel __

D7406: scmutil: convert status data object from a tuple to an attrs (API)

2019-11-15 Thread durin42 (Augie Fackler)
durin42 added inline comments. INLINE COMMENTS > martinvonz wrote in scmutil.py:81-88 > What depends on this? It looked like many of the patches earlier in the > series tried to get rid of iteration. I started out trying to get rid of the iterator interface on this, and gave up because it's ju

D7296: pycompat: kludge around pytype being confused by __new__

2019-11-15 Thread durin42 (Augie Fackler)
durin42 edited the summary of this revision. durin42 updated this revision to Diff 18161. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7296?vs=18066&id=18161 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7296/new/ REVISION DETAIL https:/

D7384: commands: necessary annotations and suppresssions to pass pytype

2019-11-15 Thread durin42 (Augie Fackler)
durin42 updated this revision to Diff 18162. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7384?vs=18099&id=18162 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7384/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7384 AFFECTED FILES

D7296: pycompat: kludge around pytype being confused by __new__

2019-11-15 Thread durin42 (Augie Fackler)
durin42 updated this revision to Diff 18163. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7296?vs=18161&id=18163 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7296/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7296 AFFECTED FILES

D7296: pycompat: kludge around pytype being confused by __new__

2019-11-15 Thread durin42 (Augie Fackler)
durin42 updated this revision to Diff 18170. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7296?vs=18163&id=18170 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7296/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7296 AFFECTED FILES

D7384: commands: necessary annotations and suppresssions to pass pytype

2019-11-15 Thread durin42 (Augie Fackler)
durin42 updated this revision to Diff 18171. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7384?vs=18162&id=18171 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7384/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7384 AFFECTED FILES

D7382: logcmdutil: add a type annotation

2019-11-18 Thread durin42 (Augie Fackler)
Closed by commit rHGc9301ac73b95: logcmdutil: add a type annotation (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7382?vs=18098&id=18224 CHANGES SINCE LAST A

D7383: state: add a pytype annotation

2019-11-18 Thread durin42 (Augie Fackler)
Closed by commit rHG127d46468a45: state: add a pytype annotation (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7383?vs=18070&id=18225 CHANGES SINCE LAST ACTI

D7408: extensions: hide two confusing import statements from pytype

2019-11-18 Thread durin42 (Augie Fackler)
Closed by commit rHG1ea33dff7841: extensions: hide two confusing import statements from pytype (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7408?vs=18101&id=

D7381: cmdutil: add a pytype annotation to help out some callsites

2019-11-18 Thread durin42 (Augie Fackler)
Closed by commit rHGa58d2361b231: cmdutil: add a pytype annotation to help out some callsites (authored by durin42). durin42 marked an inline comment as done. This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://

D7409: dispatch: add some assertions to give pytype a helping hand

2019-11-18 Thread durin42 (Augie Fackler)
Closed by commit rHGac8fd215a776: dispatch: add some assertions to give pytype a helping hand (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7409?vs=18102&id=1

D7410: extensions: suppress a pytype failure due to a typeshed bug

2019-11-18 Thread durin42 (Augie Fackler)
Closed by commit rHGda5ccc591cff: extensions: suppress a pytype failure due to a typeshed bug (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7410?vs=18159&id=1

D7385: debugcommands: suppress import errors for pytype

2019-11-18 Thread durin42 (Augie Fackler)
Closed by commit rHGa9b14ef701d1: debugcommands: suppress import errors for pytype (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7385?vs=18157&id=18226 CHANG

D7407: debugcommands: add assertions to convince pytype peer is not None

2019-11-18 Thread durin42 (Augie Fackler)
Closed by commit rHG23ad4f0c1578: debugcommands: add assertions to convince pytype peer is not None (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7407?vs=1815

D7252: dirs: reject consecutive slashes in paths

2019-11-19 Thread durin42 (Augie Fackler)
durin42 added a comment. In D7252#109627 , @Alphare wrote: > Sorry to necropost, but since this broke the Rust implementation, I was wondering what the best approach would be to replicate this behavior, and I am starting to think that this sho

<    1   2   3   4   5   6   7   8   9   10   >