This revision was automatically updated to reflect the committed changes.
Closed by commit rHG0646608368a9: extensions: don't give AttributeError bytes
message on Python 3 (authored by durin42).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D353?vs=946&id=
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG38a3767975a7: extensions: if on py3 and propname is a
bytestr, convert to sysstr (authored by durin42).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D296?vs=945&
durin42 added a comment.
In https://phab.mercurial-scm.org/D482#7640, @lothiraldan wrote:
> Would it be possible to define `pycompat.bytestr(string.ascii_letters)` at
the module level once and for all?
I think I'd bias against this, just because it's only used in six or so
places
durin42 accepted this revision as: durin42.
durin42 added a comment.
I don't object to this, but maybe others do. Reviewers not on vacation,
please feel encouraged to push this.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D468
To: mbolin, #hg-reviewers, quark
durin42 requested changes to this revision.
durin42 added a comment.
Also, please include at least one `log` invocation or similar in a test with
the config knob set? And maybe some rough benchmark results in the commit
message to justify the feature. :)
REPOSITORY
rHG Mercurial
REVISION
durin42 added a comment.
In https://phab.mercurial-scm.org/D468#7908, @smf wrote:
> In https://phab.mercurial-scm.org/D468#7836, @quark wrote:
>
> > In https://phab.mercurial-scm.org/D468#7833, @smf wrote:
> >
> > > Basically, I'd like a more unified approach for all types of temp
durin42 added a comment.
In https://phab.mercurial-scm.org/D468#7914, @smf wrote:
> Basically, I was pondering aloud if '~' would be enough to future-proof us
and if we shouldn't just rename all temp files to something unique (HG_EDITOR
for commits, HG_HISTEDIT for histedit, etc). What I
durin42 accepted this revision.
durin42 added a comment.
This revision is now accepted and ready to land.
I like yuya's suggestion, but this seems like it stands to prevent bugs now,
so I'll land it and we can continue with a followup in the revlog layer.
REPOSITORY
rHG Mercurial
REVISION
durin42 requested changes to this revision.
durin42 added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> phillco wrote in util.py:1862
> https://phab.mercurial-scm.org/rHG87c6ad2251d8703d7f16d51e99e3d1c040f0be49 --
> it linkifies if you don't use backtics, app
durin42 requested changes to this revision.
durin42 added inline comments.
INLINE COMMENTS
> cmdutil.py:3214
> +extra = ctx.extra()
> +extra['suffix'] = '.hgcommit.txt'
> +
I agree with smf: this patch is accomplishing a reasonable thing, but we should
clean up this interface if we're g
durin42 requested changes to this revision.
durin42 added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> pulkit wrote in rebase.py:487-488
> That looks like a nice idea, but since other outputs are repo.ui.* things and
> as far as I know, they can be templated,
durin42 added inline comments.
INLINE COMMENTS
> releasenotes.py:554
> +
> +With -c/--check option, you can check the commit message for any invalid
> +admonition. In case of an invalid admonition, the flag returns the name
nit: "With the" instead of "With", "an" instead of "any"
> rele
durin42 added inline comments.
INLINE COMMENTS
> smf wrote in cmdutil.py:3214
> Yeah, this is pretty much what I had in mind (sorry again for the
> confusion!). I also don't have any preference for '.hg.$ACTION.txt' just for
> it to be something sane / stable.
A thought: should we do .$ACTION.
durin42 added a comment.
In https://phab.mercurial-scm.org/D464#9054, @mbolin wrote:
> Also, it looks like I would have to refactor `ui.edit()` quite a bit to
create a unit test since the file name never escapes the method and that's what
you would like me to verify, right?
You c
durin42 added inline comments.
INLINE COMMENTS
> test-editor-filename.t:15
> + $ hg add editor.sh
> + $ HGEDITOR=`realpath ./editor.sh`
> + $ export HGEDITOR
realpath is not portable. I think you can use $TESTTMP/editor.sh though.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.me
durin42 added inline comments.
INLINE COMMENTS
> yuja wrote in cmdutil.py:344
> Sorry for late review, but doesn't it change the suffix from
> `.diff` to `.diff.hg.txt`?
Argh, yes it does. @mbolin can you send a follow-up to fix that?
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.m
durin42 added a comment.
Relevant continuous build failure:
https://buildbot.mercurial-scm.org/builders/FreeBSD%20hg%20tests/builds/909/steps/run-tests.py%20%28python%202.7.13%29/logs/stdio
- @mbolin could I get you to take a look?
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.m
durin42 added a comment.
From the list:
On Sep 1, 2017, at 02:16, Adrian Buehlmann wrote:
> Ugh. Can I reply to a phabricator notification by email?
>
> Adding gregory.sz...@gmail.com manually, as I'm not sure replaying to
> those nasty phabricator emails is going to work...
durin42 added a comment.
https://www.mercurial-scm.org/pipermail/mercurial-devel/2017-September/104093.html
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D588
To: indygreg, #hg-reviewers, quark
Cc: durin42, quark, mercurial-devel
___
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
As far as I know this has always been true and is intentional (it's in
line with many other behaviors), but it wasn't tested. Since I'm about
to tweak To and Cc
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
As far as I know this has always been true and is intentional (it's in
line with many other behaviors), but it wasn't tested. Since I'm about
to tweak To and Cc
durin42 added a comment.
This is an email reply. Will it work?
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D660
To: durin42, #hg-reviewers
Cc: mercurial-devel
___
Mercurial-devel mailing list
Mercurial-devel@mercuria
durin42 accepted this revision.
durin42 added a comment.
This revision is now accepted and ready to land.
pushed with delight, may the solaris builders smile on us
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D687
To: durham, #hg-reviewers, quark, durin42
Cc: d
durin42 added a comment.
This is already pushed, but please consider breaking up context.py into a
package in the near future - it's far too large to comprehend, and I think it'd
help organization if we had each of the various file{ctx} types (mem, working,
overlay) in their own file and the
durin42 added inline comments.
INLINE COMMENTS
> dispatch.py:491
> def __getattr__(self, name):
> -adefaults = {r'norepo': True,
> +adefaults = {r'norepo': True, r'cmdtype': 'unrecoverable',
> r'optionalrepo': False, r'inferrepo': False}
Shouldn't this
durin42 requested changes to this revision.
durin42 added a comment.
This revision now requires changes to proceed.
Please include benchmark numbers in your commit message.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D477
To: mbthomas, #fbhgext, indygreg, #hg-
durin42 requested changes to this revision.
durin42 added a comment.
This revision now requires changes to proceed.
Either this or https://phab.mercurial-scm.org/D477 needs updating per the
comment I made there. I'm just too nervous about the potential for silent
mysterious changelog read fai
durin42 requested changes to this revision.
durin42 added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> revlog.py:348
> +self.opener.fstat(f).st_size >= mmapindexthreshold):
> +indexdata = util.buffer(util.mmapread(f))
> +
durin42 added a comment.
One extra comment: maybe include some "why" as well as "what" in your commit
message. :)
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D674
To: phillco, #hg-reviewers
Cc: durin42, sid0, martinvonz, mercurial-devel
_
durin42 added a comment.
In https://phab.mercurial-scm.org/D612#12426, @pulkit wrote:
> Resend the series as https://phab.mercurial-scm.org/D736,
https://phab.mercurial-scm.org/D737 and https://phab.mercurial-scm.org/D738.
Can we discard this one then? It looks like those supersed
durin42 requested changes to this revision.
durin42 added a comment.
This revision now requires changes to proceed.
Fails test-subrepo-deep-nested-change.t, but otherwise looks good. Fix up
test failures? (I think you just need to update the expected behavior.)
REPOSITORY
rHG Mercurial
REV
durin42 accepted this revision.
durin42 added a comment.
I'm landing this, but we should plan to figure out the right tradeoff values
and get it on by default or discard the extra complexity at some point. That
doesn't have to be before 4.4, but it'd be nice to have that sorted out by 4.5.
R
durin42 added a comment.
I concur with @quark: if we're going to bother renaming this again, we should
just use the `[experimental]` namespace.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D761
To: lothiraldan, #hg-reviewers, pulkit, quark
Cc: durin42, quark,
durin42 added a comment.
I would bias towards just having one change that advances to using
`[experimental]` if we want to rename this again. I don't think we need to take
the rollback-then-forward approach, seems like unnecessary ceremony. Let's just
talk this over at the sprint?
REPOSITOR
durin42 accepted this revision as: durin42.
durin42 added a comment.
A couple of nitpicks. I'm not super in love with this, but it seems to be
enough of a huge win we should do it anyway. Sigh.
INLINE COMMENTS
> util.py:656
> +"""
> +pass
> +
you can (and should) omit pass when you
durin42 requested changes to this revision.
durin42 added a comment.
This revision now requires changes to proceed.
One nit.
INLINE COMMENTS
> copies.py:144
> c = ds.copies().copy()
> -for k in c.keys():
> +for k in list(c.keys()):
> if ds[k] not in 'anm':
please use li
durin42 added inline comments.
INLINE COMMENTS
> merge.py:993
> _("note: merging %s and %s using bids from ancestors %s\n") %
> -(wctx, mctx, _(' and ').join(str(anc) for anc in ancestors)))
> +(wctx, mctx, _(' and ').join(bytes(anc) for anc in ancestors)))
>
durin42 added a comment.
Do we need this with https://phab.mercurial-scm.org/D858? It looks like we
get enough extra coverage from that we don't need this extra check here.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D857
To: pulkit, #hg-reviewers
Cc: durin42
durin42 accepted this revision.
durin42 added a comment.
This revision is now accepted and ready to land.
(Accepted, but need some of the ancestors to be ready first)
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D858
To: pulkit, #hg-reviewers, durin42
Cc: durin
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Specifically, zstd isn't available in --pure mode, and we need to glob
off the leading comma as well as the absent compression engine.
REPOSITORY
rHG Mercurial
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
I'm not sure why this needs an update, but the test passes for me both
pure and non-pure.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGc4594d38b2da: treediscovery: update test expectation
(authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D860?vs=2203&id=2226
REV
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG44841a4d0efb: tests: update some clonebundles expectations
to pass on both pure and non-pure (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mer
durin42 added inline comments.
INLINE COMMENTS
> histedit.py:864
> +def _verifynodeconstraints(self, prev, expected, seen, basenodes):
> +pass
> +
Shouldnt't we only allow copying things from outside the histedit stack?
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.merc
durin42 added inline comments.
INLINE COMMENTS
> simpkins wrote in webutil.py:180-183
> Would it be better to use `util.parsebool()` here?
Yeah, let's do parsebool() here, but that's fine as a follow-up
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D849
To: indyg
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This password manager proxy is roughly the right-looking layer to
convert between strings and bytes. Many of these arguments can be
None, so we have a helper met
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D889
AFFECTED FILES
mercurial/url.py
CHANGE DETAILS
diff --git a/mercurial/url.py b/mercurial/url.py
-
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Doing a new file instead of pycompat because I'm starting to feel like
pycompat is getting a little enormous in terms of scope.
REPOSITORY
rHG Mercurial
REVISI
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D888
AFFECTED FILES
mercurial/keepalive.py
CHANGE DETAILS
diff --git a/mercurial/keepalive.py b/mercur
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
We only ever call these functions in a single way, so let's just
actually specify them. We need to do some string/bytes encoding
dancing here for Python 3, so it
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
On Python 3, we need to use unicodes, rather than bytes. This lets
test-pull.t get a lot further along.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D891
AFFECTED FILES
mercurial/byterange.py
mercurial/httpconnection.py
mercurial/keepalive.py
merc
durin42 added inline comments.
INLINE COMMENTS
> yuja wrote in ui.py:141
> Nit: no need to check if ispy3.
Experimentally not true: if I don't do the ispy3 check, tests fail.
> yuja wrote in ui.py:169
> No idea how user and passwd are encoded, but encoding.strfromlocal() might
> be better becau
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGa454123f5d94: keepalive: python 3 portability tweaks
(authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D888?vs=2300&id=2335
REV
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG0ee9cf8d054a: url: use native strings for header values
(authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D889?vs=2301&id=2336
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGae2fcf7af409: httppasswordmgrdbproxy: specify exact
arguments (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D885?vs=2297&id=
durin42 added inline comments.
INLINE COMMENTS
> mbthomas wrote in histedit.py:864
> I allowed copy to refer to things in the stack because it's conceivable you
> might want something from the stack twice. Thinking about it now, this is
> only actually useful if the `base` action is enabled
>
durin42 updated this revision to Diff 2421.
durin42 marked 3 inline comments as done.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D886?vs=2298&id=2421
REVISION DETAIL
https://phab.mercurial-scm.org/D886
AFFECTED FILES
mercurial/ui.py
CHANGE DETAILS
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
These are all the httpserver and urllib.* aliases. They seem to make
more sense in the slightly-more-specific urllibcompat package than the
general-purpose pycom
durin42 updated this revision to Diff 2424.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D891?vs=2303&id=2424
REVISION DETAIL
https://phab.mercurial-scm.org/D891
AFFECTED FILES
mercurial/byterange.py
mercurial/httpconnection.py
mercurial/keepaliv
durin42 added a comment.
Oddly, this is now working correctly for me. I'm baffled why it was broken
previously.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D886
To: durin42, #hg-reviewers, yuja
Cc: yuja, mercurial-devel
___
durin42 updated this revision to Diff 2422.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D890?vs=2302&id=2422
REVISION DETAIL
https://phab.mercurial-scm.org/D890
AFFECTED FILES
mercurial/urllibcompat.py
CHANGE DETAILS
diff --git a/mercurial/urllibc
durin42 added a comment.
boilerplate added
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D890
To: durin42, #hg-reviewers, yuja
Cc: yuja, mercurial-devel
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.or
durin42 abandoned this revision.
durin42 added a comment.
(Marking as abandoned because this is landed.)
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D541
To: durin42, #hg-reviewers, lothiraldan
Cc: quark, martinvonz, mercurial-devel
___
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG80d4681150b9: urllibcompat: new library to help abstract
out some python3 urllib2 stuff (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercuria
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG1232f7fa00c3: cleanup: use urllibcompat for renamed methods
on urllib request objects (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG192f7b126ed2: urllibcompat: move some adapters from
pycompat to urllibcompat (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG75de5d456b60: ui: convert to/from Optional[bytes] to
Optional[str] in password manager (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial
durin42 requested changes to this revision.
durin42 added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> quark wrote in histedit.py:796
> You can use the decorator here:
>
> @action()
>
> just like line 819.
Please do this, then I think you're good to g
durin42 abandoned this revision.
durin42 added a comment.
was folded into https://phab.mercurial-scm.org/D877 and landed
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D872
To: durin42, #hg-reviewers, pulkit, yuja, rishabhmadan96
Cc: yuja, mercurial-devel
___
durin42 added a comment.
I see what it does, but why? What's the motivation for the feature?
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D934
To: pulkit, #hg-reviewers
Cc: durin42, mercurial-devel
___
Mercurial-devel
durin42 added a comment.
In https://phab.mercurial-scm.org/D934#15995, @pulkit wrote:
> In https://phab.mercurial-scm.org/D934#15939, @durin42 wrote:
>
> > I see what it does, but why? What's the motivation for the feature?
>
>
> It's for automation and helping editors such as Nu
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This is just a side effect of surfacing the "revisions were skipped"
state in the blame output.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercuri
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG323bed58cf57: test-annotate: fix up expected output for
pure (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D956?vs=2469&id=2
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This greatly confounded some Python 3 porting work, once it was
managing to get this far.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D964
AFFECTED FILES
mercurial/peer.py
mercurial/pycompat.py
mercurial/templater.py
CHANGE DETAILS
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D968
AFFECTED FILES
mercurial/hgweb/request.py
CHANGE DETAILS
diff --git a/mercurial/hgweb/request.py
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D965
AFFECTED FILES
mercurial/templatefilters.py
CHANGE DETAILS
diff --git a/mercurial/templatefilters
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Also make it work on Python 3.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D970
AFFECTED FILES
mercurial/hgweb/hgweb_mod.py
me
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Again, required by WSGI.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D969
AFFECTED FILES
mercurial/hgweb/request.py
CHANGE DETA
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Also use %d since we know mtime is numeric.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D966
AFFECTED FILES
mercurial/hgweb/comm
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
That's what's required of us to work with the WSGI API on Python 3.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D967
AFFECTED FILE
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D963
AFFECTED FILES
mercurial/hgweb/protocol.py
CHANGE DETAILS
diff --git a/mercurial/hgweb/protocol.p
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGcb52aefbd652: hgweb: extract function for loading style
from request context (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG147665d36088: hgweb: when constructing or adding to a wsgi
environ dict, use native strs (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercuri
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG9fdcc560a2ae: hgweb: produce native string for etag value
(authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D966?vs=2482&id=2526
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGc23fa3103925: hgweb: in protocol adapter, look for bytes
instances, not str (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D9
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG5526da708fab: request: use trivial iterator over dictionary
keys (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D968?vs=2484&
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGe21f274cccea: hgweb: in protocol adapter, avoid control
reaching end of non-void function (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercur
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGfc21a3513062: request: coerce content-type to native str
(authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D969?vs=2485&id=2530
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG4296bbb19410: templatefilters: be sure we always feed
cgi.escape a str (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D965?vs
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG68faf082bdcd: python3: add and use adapter for func_name
attr, now known as __name__ (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-s
durin42 added a comment.
I also popped https://phab.mercurial-scm.org/D964 out of the stack until I
can address review feedback. :)
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D965
To: durin42, #hg-reviewers, pulkit, indygreg, yuja
Cc: yuja, indygreg, pulkit,
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
The latter doesn't always exist, such as on Solaris-derived platforms.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D996
AFFECTED F
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
The latter doesn't always exist, such as on Solaris-derived platforms.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D997
AFFECTED F
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
The latter doesn't always exist, such as on Solaris-derived platforms.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D998
AFFECTED F
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
The latter doesn't always exist, such as on Solaris-derived platforms.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D999
AFFECTED F
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
readlink doesn't always exist, such as on Solaris-derived platforms.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1000
AFFECTED FI
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Were I only slightly bolder, I'd make it on by default in the
suggested user hgrc.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1
durin42 added inline comments.
INLINE COMMENTS
> test-convert-p4-filetypes.t:750
> + $ readlink.py crazy_symlink+k
> + crazy_symlink+k -> target_$Header:
> //depot/test-mercurial-import/crazy_symlink+k#1 $
> + $ readlink.py dst/crazy_symlink+k
Please check these carefully. I don't have the a
501 - 600 of 3646 matches
Mail list logo
