D3492: tests: port test-simplemerge.py to Python 3

2018-05-08 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGc1bc196e021d: tests: port test-simplemerge.py to Python 3 (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3492?vs=8544=8565

D3493: tests: prefer string concatenation with () instead of \ in parseindex2 tests

2018-05-08 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGb4e42a9bd12e: tests: prefer string concatenation with () instead of \ in parseindex2 tests (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3491: tests: replace use of assertEquals with assertEqual in test-simplemerge.py

2018-05-08 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGa3ed6e7217c1: tests: replace use of assertEquals with assertEqual in test-simplemerge.py (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3494: tests: port test-parseindex2.py to Python 3

2018-05-08 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG2f00c6e8f6a1: tests: port test-parseindex2.py to Python 3 (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3494?vs=8546=8567

D3495: tests: migrate test-wsgirequest.py to Python 3

2018-05-08 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGe0598133ac68: tests: migrate test-wsgirequest.py to Python 3 (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3496: tests: port test-revlog-raw.py to Python 3

2018-05-08 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG03a09579c854: tests: port test-revlog-raw.py to Python 3 (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3496?vs=8548=8569

D3476: tests: use stringutil.pprint instead of pprint.pprint in test-minirst.py

2018-05-08 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG672f51ec0d47: tests: use stringutil.pprint instead of pprint.pprint in test-minirst.py (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3466: tests: port test-hybridencode.py to unittest

2018-05-08 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG6574c81b6831: tests: port test-hybridencode.py to unittest (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3466?vs=8493=8521

D3474: tests: port test-hgwebdir-paths.py to Python 3

2018-05-08 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG81455f482478: tests: port test-hgwebdir-paths.py to Python 3 (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3475: tests: port test-pathencode.py to Python 3

2018-05-08 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG1b230e19d044: tests: port test-pathencode.py to Python 3 (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3475?vs=8502=8530

D3471: minifileset: fix on Python 3

2018-05-08 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG9c98cb30f4de: minifileset: fix on Python 3 (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3471?vs=8498=8525 REVISION

D3470: tests: port test-url.py to Python 3

2018-05-08 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG078c3eec2d5c: tests: port test-url.py to Python 3 (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3470?vs=8497=8526

D3469: tests: fix error case in test-url.py's doctest

2018-05-08 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG0dcd03637d36: tests: fix error case in test-url.pys doctest (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3472: tests: port test-minifileset.py to Python 3

2018-05-08 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG2cdae2582d8a: tests: port test-minifileset.py to Python 3 (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3472?vs=8499=8527

D3468: util: make util.url __repr__ consistent on Python 2 and 3

2018-05-08 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGbb1b15acfd06: util: make util.url __repr__ consistent on Python 2 and 3 (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3473: tests: port test-walkrepo.py to Python 3

2018-05-08 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGfa2423acb02f: tests: port test-walkrepo.py to Python 3 (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3473?vs=8500=8528

D3478: minirst: fix bytes slicing defect on Python 3

2018-05-08 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGa61583cba509: minirst: fix bytes slicing defect on Python 3 (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3620: tests: fix test-patch.t on picker /bin/sh implementations

2018-05-19 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG0b39edeff033: tests: fix test-patch.t on pickier /bin/sh implementations (authored by durin42, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D3620?vs=8792=8822#toc REPOSITORY

D3619: patch: add debug message to show external patch tool invocation

2018-05-19 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGf3776f70985e: patch: add debug message to show external patch tool invocation (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3621: tests: use [(] instead of \( to avoid warning on py3

2018-05-19 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGe504fa630860: tests: use [(] instead of \( to avoid warning on py3 (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3624: py3: re-sort test whitelist

2018-05-19 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a reviewer: pulkit. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3624 AFFECTED FILES contrib/python3-whitelist CHANGE DETAILS diff

D3626: tests: port inline extensions in test-obsolete.t to Python 3

2018-05-19 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Still some lingering failure in here, but it's much better. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3626 AFFECTED FILES

D3626: tests: port inline extensions in test-obsolete.t to Python 3

2018-05-19 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG5a87bf0bd343: tests: port inline extensions in test-obsolete.t to Python 3 (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3620: tests: fix test-patch.t on picker /bin/sh implementations

2018-05-19 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY FreeBSD sh(1) doesn't accept -d, so we weren't testing what we expected there. Let's just use a simple Python script instead. REPOSITORY rHG Mercurial

D3619: patch: add debug message to show external patch tool invocation

2018-05-19 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3619 AFFECTED FILES mercurial/patch.py CHANGE DETAILS diff --git a/mercurial/patch.py

D3622: tests: fix test-parseindex2 on Python 3

2018-05-19 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY parsers.versionerrortext is a sysstr, but it's only ever used in this test on the Python side, so I'm okay to just handle it like this. REPOSITORY rHG

D3621: tests: use [(] instead of \( to avoid warning on py3

2018-05-19 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY From a recent test run of mine: run-tests.py:1633: DeprecationWarning: invalid escape sequence '\(' This lets us encode the expectation without the

D3623: tests: fix test-subrepo-paths.t on Python 3

2018-05-19 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The Python 3 group reference error message is a little more helpful, so we'll allow the extra output. I tried matching this with an (re) line, but decided it

D3624: py3: re-sort test whitelist

2018-05-19 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGa400fe810346: py3: re-sort test whitelist (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3624?vs=8826=8831 REVISION DETAIL

D3625: py3: consolidate down some (case ...) entries

2018-05-19 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGc3eda7207f25: py3: consolidate down some (case ...) entries (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3625: py3: consolidate down some (case ...) entries

2018-05-19 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a reviewer: pulkit. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3625 AFFECTED FILES contrib/python3-whitelist CHANGE DETAILS diff

D3618: pathencode: remove unused variable

2018-05-19 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Caught by Yuya during review of https://phab.mercurial-scm.org/rHG92ac9cf78dba7765b39e32e1380bfa5e51a44ff5. REPOSITORY rHG Mercurial REVISION DETAIL

D3622: tests: fix test-parseindex2 on Python 3

2018-05-19 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG3de58f50afa2: tests: fix test-parseindex2 on Python 3 (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3622?vs=8824=8829

D3623: tests: fix test-subrepo-paths.t on Python 3

2018-05-19 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGf97c83d94911: tests: fix test-subrepo-paths.t on Python 3 (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3623?vs=8825=8830

D3627: status: add a config knob for setting default of --terse

2018-05-19 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I want --terse=u basically 100% of the time, but there's not a good way to do that before this patch. I'm very unhappy with how the default value for --terse

D3628: status: add default of --terse=u to tweakdefaults (BC)

2018-05-19 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is in line with both Git and Subversion, and strikes me as a more humane behavior. Test output changes are expected once you read test-status.t, and I

D3628: status: add default of --terse=u to tweakdefaults (BC)

2018-05-20 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG6acf41bb8d40: status: add default of --terse=u to tweakdefaults (BC) (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3627: status: add a config knob for setting default of --terse

2018-05-20 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG18424aeece7f: status: add a config knob for setting default of --terse (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3618: pathencode: remove unused variable

2018-05-21 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGf9eaa5cd9ee9: pathencode: remove unused variable (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3618?vs=8790=8861 REVISION

D3620: tests: fix test-patch.t on picker /bin/sh implementations

2018-05-24 Thread durin42 (Augie Fackler)
durin42 added a comment. In https://phab.mercurial-scm.org/D3620#57367, @martinvonz wrote: > > FreeBSD sh(1) doesn't accept -d, so we weren't testing what we > > expected there. Let's just use a simple Python script instead. > > This confused me for longer than it should. I assume

D3620: tests: fix test-patch.t on picker /bin/sh implementations

2018-05-24 Thread durin42 (Augie Fackler)
durin42 added a comment. In https://phab.mercurial-scm.org/D3620#57370, @martinvonz wrote: > In https://phab.mercurial-scm.org/D3620#57369, @durin42 wrote: > > > In https://phab.mercurial-scm.org/D3620#57367, @martinvonz wrote: > > > > > > FreeBSD sh(1) doesn't accept -d, so we

D3584: patch: fix import-time syntax error in test-check-module-imports.t

2018-05-18 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is more correct, though we were getting lucky in practice with our rewriter saving us. 1. skip-blame just a b prefix REPOSITORY rHG Mercurial

D3585: context: fix %-formatting on Python 3

2018-05-18 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY changeid could be an int or a bytestr, so use our pycompat wrapper. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3585 AFFECTED

D3586: patch: use slicing to check patch line prefixes

2018-05-18 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This fixes some regressed Python 3 tests, though I'm not sure when they regressed. REPOSITORY rHG Mercurial REVISION DETAIL

D3589: pathencode: improve error messages slightly

2018-05-18 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Both of these are conditions we should never hit, so we can afford to be more verbose to make debugging less baffling. REPOSITORY rHG Mercurial REVISION

D3587: pathencode: fix importing hashlib on Python 3

2018-05-18 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I'm curious why PyImport_Import is returning NULL, but PyImport_ImportModule bypasses some of the regular import path, probably including demandimport, which I

D3588: pathencode: hashlib.sha1() takes bytes not str on Python 3

2018-05-18 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3588 AFFECTED FILES mercurial/cext/pathencode.c CHANGE DETAILS diff --git

D3583: py3: whitelist two more passing tests observed by buildbot

2018-05-18 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGcab398cb9b49: py3: whitelist two more passing tests observed by buildbot (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3585: context: fix %-formatting on Python 3

2018-05-18 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGc0f8fa74d8c2: context: fix %-formatting on Python 3 (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3585?vs=8747=8757

D3587: pathencode: fix importing hashlib on Python 3

2018-05-18 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG92ac9cf78dba: pathencode: fix importing hashlib on Python 3 (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3589: pathencode: improve error messages slightly

2018-05-18 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG9aaa74f9eb87: pathencode: improve error messages slightly (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3589?vs=8751=8760

D3584: patch: fix import-time syntax error in test-check-module-imports.t

2018-05-18 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG468797392cc6: patch: fix import-time syntax error in test-check-module-imports.t (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3588: pathencode: hashlib.sha1() takes bytes not str on Python 3

2018-05-18 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG4fccc73ce2f6: pathencode: hashlib.sha1() takes bytes not str on Python 3 (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3583: py3: whitelist two more passing tests observed by buildbot

2018-05-18 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a reviewer: pulkit. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3583 AFFECTED FILES contrib/python3-whitelist CHANGE DETAILS diff

D3694: shelve: use more accurate description in conflict marker

2018-06-11 Thread durin42 (Augie Fackler)
durin42 added a comment. In https://phab.mercurial-scm.org/D3694#58241, @lothiraldan wrote: > > Interesting. I think I like this, it's a bummer that it requires a format bump in requires. > > > > - There are no format changes per-se, older client would preserve the phases for

D3717: repair: mark the critical section of strip() as unsafe

2018-06-12 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY When our experimental nointerrupt feature is enabled, this will help prevent users from corrupting their repo during a strip. REPOSITORY rHG Mercurial

D3718: narrow: mark the critical chunks of narrowing/widening as unsafe

2018-06-12 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I'm _mostly_ sure these are the only unsafe chunks here. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3718 AFFECTED FILES

D3716: ui: add an unsafeoperation context manager that can block SIGINT

2018-06-12 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The blocking of SIGINT is not done by default, but my hope is that we will one day. This was inspired by Facebook's "nointerrupt" extension, which is a bit more

D3719: narrowbundle2: when we handle a widen, mark the operation as unsafe

2018-06-12 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We have to manually drive the context manager here since the logic is awkwardly split between a couple of places. REPOSITORY rHG Mercurial REVISION DETAIL

D3695: fuzz: new fuzzer for the mpatch code

2018-06-08 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG46dcb9f14900: fuzz: new fuzzer for the mpatch code (authored by durin42, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D3695?vs=8986=8996#toc REPOSITORY rHG Mercurial

D3697: fuzz: try and generate an interesting mpatch seed from a repo

2018-06-08 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG99ab72b867b7: fuzz: try and generate an interesting mpatch seed from a repo (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3696: fuzz: structured helpers for creating mpatch seed corpus entries

2018-06-08 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG06e2fc08f6f0: fuzz: structured helpers for creating mpatch seed corpus entries (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3649: serve: add option print-url

2018-06-07 Thread durin42 (Augie Fackler)
durin42 added a comment. In https://phab.mercurial-scm.org/D3649#57906, @yuja wrote: > (resend because I forgot to remove the Phab shit, sorry for the noise.) > > > > It's surprising that `hg serve --print-url` spawns a daemon process! > > > > If it does not launch a daemon

D3762: py3: whitelist another 5 passing tests thanks to the ratchet

2018-06-16 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a reviewer: pulkit. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3762 AFFECTED FILES contrib/python3-whitelist CHANGE DETAILS diff

D3762: py3: whitelist another 5 passing tests thanks to the ratchet

2018-06-16 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG03aa222ca28e: py3: whitelist another 5 passing tests thanks to the ratchet (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3723: cvsps: avoid comparison between None and a tuple in date sorting

2018-06-12 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Avoids badness on Python 3. I had to figure out which entries in this object *could* be None experimentally, but I think I've got them all now. REPOSITORY

D3726: hgweb: pass a sysstr to low-level _start_response method

2018-06-12 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This fixes a regression in Python 3 support introduced in https://phab.mercurial-scm.org/rHG7de7bd407251af2bc98e5b809c8598ee95830daf on the stable branch. We're

D3725: tests: fix printenv script on Python 3

2018-06-12 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3725 AFFECTED FILES tests/printenv.py CHANGE DETAILS diff --git a/tests/printenv.py

D3724: cvsps: port changeset __repr__ to py3

2018-06-12 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This appears to be unused except as a debugging aid, as it didn't break until I added a debug print() in service of the previous fix. Sigh. REPOSITORY rHG

D3694: shelve: use more accurate description in conflict marker

2018-06-12 Thread durin42 (Augie Fackler)
durin42 added a comment. In https://phab.mercurial-scm.org/D3694#58369, @lothiraldan wrote: > > How much work is this, do you have any idea? > > The first option (adding "reserved" phase) should be very quick to implement. It might need minor adjustment for performance but I don't

D3716: ui: add an unsafeoperation context manager that can block SIGINT

2018-06-12 Thread durin42 (Augie Fackler)
durin42 added a comment. Good suggestions, integrated them. :) REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3716 To: durin42, #hg-reviewers Cc: martinvonz, mercurial-devel ___ Mercurial-devel mailing list

D3716: ui: add an unsafeoperation context manager that can block SIGINT

2018-06-12 Thread durin42 (Augie Fackler)
durin42 updated this revision to Diff 9033. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3716?vs=9023=9033 REVISION DETAIL https://phab.mercurial-scm.org/D3716 AFFECTED FILES mercurial/configitems.py mercurial/ui.py CHANGE DETAILS diff --git

D3700: run-tests: add support for external test result

2018-06-12 Thread durin42 (Augie Fackler)
durin42 added a comment. In https://phab.mercurial-scm.org/D3700#58403, @lothiraldan wrote: > In https://phab.mercurial-scm.org/D3700#58376, @durin42 wrote: > > > I see some what, but not any why. Why is this useful? > > > I need this changeset to integrate the mercurial test

D3722: py3: buildbot informs me we have two new passing tests

2018-06-12 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a reviewer: pulkit. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3722 AFFECTED FILES contrib/python3-whitelist CHANGE DETAILS diff

D3727: hgweb: insist http_status value is a sysstr

2018-06-13 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGaf0e88e64ede: hgweb: insist http_status value is a sysstr (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3727?vs=9039=9048

D3726: hgweb: pass a sysstr to low-level _start_response method

2018-06-13 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG9f499d28efb4: hgweb: pass a sysstr to low-level _start_response method (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3723: cvsps: avoid comparison between None and a tuple in date sorting

2018-06-13 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG80f6e95fac2d: cvsps: avoid comparison between None and a tuple in date sorting (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3725: tests: fix printenv script on Python 3

2018-06-13 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG42f3a277c8dc: tests: fix printenv script on Python 3 (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3725?vs=9037=9046

D3722: py3: buildbot informs me we have two new passing tests

2018-06-13 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG9f56ad50924d: py3: buildbot informs me we have two new passing tests (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3724: cvsps: port changeset __repr__ to py3

2018-06-13 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGbec815f991b0: cvsps: port changeset __repr__ to py3 (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3724?vs=9036=9045

D3729: bitmanipulation: fix undefined behavior in bit shift in getbe32

2018-06-13 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY OSS-Fuzz caught this in its ubsan mode[0]. I'm not worried about a security issue here because in practice this should work out the way we naively expected,

D3729: bitmanipulation: fix undefined behavior in bit shift in getbe32

2018-06-13 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG1fb2510cf8c8: bitmanipulation: fix undefined behavior in bit shift in getbe32 (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3715: namespaces: allow namespaces whose symbols resolve to many nodes (API)

2018-06-12 Thread durin42 (Augie Fackler)
durin42 added subscribers: lothiraldan, smf, durin42. durin42 accepted this revision as: durin42. durin42 added a comment. I'm in favor, but feel like I've got enough conflict of interest I shouldn't land the patches. @smf @lothiraldan this might be of interest to both of you?

D3732: debugcommands: work around logiofd being a pipe and unseekable

2018-06-14 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This was breaking in our Python 3 build, but not Python 2. I don't know how it ever worked in Python 2, but this passes on both. REPOSITORY rHG Mercurial

D3733: tests: suppress read(-1) -> '' calls in fileobjectobserver

2018-06-14 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a reviewer: pulkit. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This stabilizes the test output of the low-level wireproto tests between Python 2 and 3. I don't feel great about this change,

D3732: debugcommands: work around logiofd being a pipe and unseekable

2018-06-15 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG275cc461b854: debugcommands: work around logiofd being a pipe and unseekable (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3733: tests: suppress read(-1) -> '' calls in fileobjectobserver

2018-06-15 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG565074cc9ac6: tests: suppress read(-1) - calls in fileobjectobserver (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3749: tests: replace `echo -n` with `printf` per check-code

2018-06-15 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3749 AFFECTED FILES tests/test-commit-interactive-curses.t CHANGE DETAILS diff --git

D3749: tests: replace `echo -n` with `printf` per check-code

2018-06-15 Thread durin42 (Augie Fackler)
durin42 added a comment. FYI, this is intended for the stable branch. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3749 To: durin42, #hg-reviewers Cc: mercurial-devel ___ Mercurial-devel mailing list

D3749: tests: replace `echo -n` with `printf` per check-code

2018-06-15 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG2baf79933b45: tests: replace `echo -n` with `printf` per check-code (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3736: py3: two more passing tests from the ratchet in buildbot

2018-06-14 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a reviewer: pulkit. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3736 AFFECTED FILES contrib/python3-whitelist CHANGE DETAILS diff

D3736: py3: two more passing tests from the ratchet in buildbot

2018-06-14 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG2049a21c8396: py3: two more passing tests from the ratchet in buildbot (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3772: highlight: adjust to attribute being private

2018-06-17 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3772 AFFECTED FILES hgext/highlight/highlight.py CHANGE DETAILS diff --git

D3773: streamclone: update progress later to avoid passing None to util.bytecount

2018-06-17 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3773 AFFECTED FILES mercurial/streamclone.py CHANGE DETAILS diff --git a/mercurial/streamclone.py

D3756: rebase: no need to backup rebased csets while aborting

2018-06-17 Thread durin42 (Augie Fackler)
durin42 added a comment. In https://phab.mercurial-scm.org/D3756#58937, @indygreg wrote: > I'm unsure about this change. On one hand, the comment (which appears to have been added to mpm several years ago) implies that we never should have generated backups in this case. On the other,

D3773: streamclone: update progress later to avoid passing None to util.bytecount

2018-06-17 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGc1fca51c26f3: streamclone: update progress later to avoid passing None to util.bytecount (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3772: highlight: adjust to attribute being private

2018-06-17 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG876352ea831e: highlight: adjust to attribute being private (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3772?vs=9141=9143

D3702: mercurial: add .t files to .editorconfig

2018-06-12 Thread durin42 (Augie Fackler)
durin42 added inline comments. INLINE COMMENTS > av6 wrote in .editorconfig:17 > Nit: I'd sort these two lines for consistency with the two entries above, > otherwise looks good. queued with that fixed REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3702 To:

D3700: run-tests: add support for external test result

2018-06-12 Thread durin42 (Augie Fackler)
durin42 added a comment. I see some what, but not any why. Why is this useful? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3700 To: lothiraldan, #hg-reviewers Cc: durin42, mercurial-devel ___ Mercurial-devel

D3675: fuzz: extract some common utilities and use modern C++ idioms

2018-05-30 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Alex Gaynor suggested we should probably copy the left and right sides of diffs to new blocks so we can detect over-reads in the diffing code, and I agree. Once

<    2   3   4   5   6   7   8   9   10   11   >