D1998: wireproto: define and use types for wire protocol commands

2018-02-07 Thread indygreg (Gregory Szorc)
indygreg added a comment. In https://phab.mercurial-scm.org/D1998#34740, @durin42 wrote: > I'm curious what registrations you need that don't fit in 2-tuples. Can I see a sample of where that's going? I'll be adding additional attributes to `@wireprotocommand` in future series.

D2065: wireprotoserver: rename abstractserverproto and improve docstring

2018-02-07 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 5299. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2065?vs=5262=5299 REVISION DETAIL https://phab.mercurial-scm.org/D2065 AFFECTED FILES mercurial/wireprotoserver.py CHANGE DETAILS diff --git

D2068: revlog: do not use delta for lfs revisions

2018-02-07 Thread indygreg (Gregory Szorc)
indygreg requested changes to this revision. indygreg added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > revlog.py:408 > +# do not use flags != 0 (ex. LFS) revision as delta base > +if revlog.flags(candidaterev) !=

D2069: revlog: resolve lfs rawtext to vanilla rawtext before applying delta

2018-02-07 Thread indygreg (Gregory Szorc)
indygreg requested changes to this revision. indygreg added a comment. This revision now requires changes to proceed. I'd like to see the next versions of hte previous 2 patches before looking at this because this patch will likely get some minor rework as well. REPOSITORY rHG Mercurial

D2067: changegroup: do not delta lfs revisions

2018-02-07 Thread indygreg (Gregory Szorc)
indygreg requested changes to this revision. indygreg added a comment. This revision now requires changes to proceed. This looks mostly good. I would like a change to address a future footgun though. I would also appreciate someone familiar with censor and narrow to weigh in on the

D2083: wireprotoserver: remove redirect() and restore() (API)

2018-02-07 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 5335. indygreg edited the summary of this revision. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2083?vs=5317=5335 REVISION DETAIL https://phab.mercurial-scm.org/D2083 AFFECTED FILES

D2081: wireprotoserver: add context manager mechanism for redirecting stdio

2018-02-07 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 5333. indygreg edited the summary of this revision. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2081?vs=5315=5333 REVISION DETAIL https://phab.mercurial-scm.org/D2081 AFFECTED FILES mercurial/wireproto.py

D2092: wireprotoserver: add version to SSH protocol names (API)

2018-02-07 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We recently introduced version 2 of the SSH protocol. Like we did for the peer, we will need to differentiate version 1 and 2 of the server. So, we add version

D2094: wireprotoserver: define and use parse_qs from urllib

2018-02-07 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The cgi module is deprecated since Python 2.6. Let's replace uses of it in wireprotoserver with a similar function from urllib. REPOSITORY rHG Mercurial

D2057: translate base85.c into rust code

2018-02-07 Thread indygreg (Gregory Szorc)
indygreg added a comment. To be honest, we're not yet sure what we'll decide for the Python -> Rust bridge. The problem is summarized in the `Rust <=> Python Interop` section on https://www.mercurial-scm.org/wiki/OxidationPlan. I suspect at some level we'll need a CPython extension for

D2089: wireproto: introduce type for raw byte responses (API)

2018-02-07 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 5341. indygreg edited the summary of this revision. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2089?vs=5325=5341 REVISION DETAIL https://phab.mercurial-scm.org/D2089 AFFECTED FILES hgext/largefiles/proto.py

D2086: wireproto: remove unused proto argument from supportedcompengines (API)

2018-02-07 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 5338. indygreg retitled this revision from "wireproto: remove unused proto argument from supportedcompengines" to "wireproto: remove unused proto argument from supportedcompengines (API)". REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2082: wireproto: use maybecapturestdio() for push responses (API)

2018-02-07 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 5334. indygreg edited the summary of this revision. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2082?vs=5316=5334 REVISION DETAIL https://phab.mercurial-scm.org/D2082 AFFECTED FILES hgext/largefiles/proto.py

D2087: wireprotoserver: move responsetype() out of http handler

2018-02-07 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 5339. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2087?vs=5321=5339 REVISION DETAIL https://phab.mercurial-scm.org/D2087 AFFECTED FILES mercurial/wireprotoserver.py CHANGE DETAILS diff --git

D2091: wireprotoserver: extract SSH response handling functions

2018-02-07 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The lookup/dispatch table was cute. But it isn't needed. Future refactors will benefit from the handlers for individual response types living outside the

D2080: wireprotoserver: split ssh protocol handler and server

2018-02-07 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 5332. indygreg edited the summary of this revision. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2080?vs=5314=5332 REVISION DETAIL https://phab.mercurial-scm.org/D2080 AFFECTED FILES

D2084: wireprotoserver: rename _client to client (API)

2018-02-07 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 5336. indygreg edited the summary of this revision. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2084?vs=5318=5336 REVISION DETAIL https://phab.mercurial-scm.org/D2084 AFFECTED FILES mercurial/wireproto.py

D2085: wireprotoserver: rename getfile() to forwardpayload() (API)

2018-02-07 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 5337. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2085?vs=5319=5337 REVISION DETAIL https://phab.mercurial-scm.org/D2085 AFFECTED FILES hgext/largefiles/proto.py mercurial/wireproto.py

D2088: wireprototypes: move wire protocol response types to new module

2018-02-07 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 5340. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2088?vs=5324=5340 REVISION DETAIL https://phab.mercurial-scm.org/D2088 AFFECTED FILES mercurial/wireproto.py mercurial/wireprotoserver.py

D2082: wireproto: use maybecapturestdio() for push responses (API)

2018-02-07 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 5345. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2082?vs=5334=5345 REVISION DETAIL https://phab.mercurial-scm.org/D2082 AFFECTED FILES hgext/largefiles/proto.py mercurial/wireproto.py

D2086: wireproto: remove unused proto argument from supportedcompengines (API)

2018-02-07 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 5349. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2086?vs=5338=5349 REVISION DETAIL https://phab.mercurial-scm.org/D2086 AFFECTED FILES mercurial/wireproto.py mercurial/wireprotoserver.py CHANGE DETAILS

D2089: wireproto: introduce type for raw byte responses (API)

2018-02-07 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 5352. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2089?vs=5341=5352 REVISION DETAIL https://phab.mercurial-scm.org/D2089 AFFECTED FILES hgext/largefiles/proto.py mercurial/wireproto.py

D2084: wireprotoserver: rename _client to client (API)

2018-02-07 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 5347. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2084?vs=5336=5347 REVISION DETAIL https://phab.mercurial-scm.org/D2084 AFFECTED FILES mercurial/wireproto.py mercurial/wireprotoserver.py CHANGE DETAILS

D2093: tests: add tests for sending recognized command before handshake

2018-02-07 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Rounding out our test coverage for the SSH server. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2093 AFFECTED FILES

D2087: wireprotoserver: move responsetype() out of http handler

2018-02-07 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 5350. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2087?vs=5339=5350 REVISION DETAIL https://phab.mercurial-scm.org/D2087 AFFECTED FILES mercurial/wireprotoserver.py CHANGE DETAILS diff --git

D2088: wireprototypes: move wire protocol response types to new module

2018-02-07 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 5351. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2088?vs=5340=5351 REVISION DETAIL https://phab.mercurial-scm.org/D2088 AFFECTED FILES mercurial/wireproto.py mercurial/wireprotoserver.py

D2083: wireprotoserver: remove redirect() and restore() (API)

2018-02-07 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 5346. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2083?vs=5335=5346 REVISION DETAIL https://phab.mercurial-scm.org/D2083 AFFECTED FILES mercurial/wireprotoserver.py CHANGE DETAILS diff --git

D2085: wireprotoserver: rename getfile() to forwardpayload() (API)

2018-02-07 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 5348. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2085?vs=5337=5348 REVISION DETAIL https://phab.mercurial-scm.org/D2085 AFFECTED FILES hgext/largefiles/proto.py mercurial/wireproto.py

D2081: wireprotoserver: add context manager mechanism for redirecting stdio

2018-02-07 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 5344. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2081?vs=5333=5344 REVISION DETAIL https://phab.mercurial-scm.org/D2081 AFFECTED FILES mercurial/wireproto.py mercurial/wireprotoserver.py CHANGE DETAILS

D2091: wireprotoserver: extract SSH response handling functions

2018-02-07 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 5342. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2091?vs=5331=5342 REVISION DETAIL https://phab.mercurial-scm.org/D2091 AFFECTED FILES mercurial/wireprotoserver.py tests/sshprotoext.py CHANGE DETAILS

D2057: translate base85.c into rust code

2018-02-06 Thread indygreg (Gregory Szorc)
indygreg added a comment. Yes, we should definitely split things into multiple crates. Small, narrowly-focused crates does seem to be the Rust way, after all. `hgcli` should be for things specific to the Rust implementation of `hg`. I think this can also include the feature set of `chg`

D2019: wireprotoserver: move protocol parsing and dispatch out of hgweb

2018-02-06 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 5259. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2019?vs=5173=5259 REVISION DETAIL https://phab.mercurial-scm.org/D2019 AFFECTED FILES mercurial/hgweb/hgweb_mod.py mercurial/wireprotoserver.py CHANGE

D1999: wireproto: function for testing if wire protocol command is available

2018-02-06 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 5258. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1999?vs=5138=5258 REVISION DETAIL https://phab.mercurial-scm.org/D1999 AFFECTED FILES mercurial/hgweb/hgweb_mod.py mercurial/wireproto.py

D2021: wireprotoserver: move error response handling out of hgweb

2018-02-06 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 5260. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2021?vs=5175=5260 REVISION DETAIL https://phab.mercurial-scm.org/D2021 AFFECTED FILES mercurial/hgweb/hgweb_mod.py mercurial/wireprotoserver.py CHANGE

D2061: sshpeer: initial definition and implementation of new SSH protocol

2018-02-06 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The existing SSH protocol has several design flaws. Future commits will elaborate on these flaws as new features are introduced to combat these flaws. For now,

D2062: sshpeer: rename sshpeer class to sshv1peer (API)

2018-02-06 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY With the introduction of version 2 of the SSH wire protocol, we will need a new peer class to speak that protocol because it will be too difficult to shoehorn

D2060: internals: refactor wire protocol documentation

2018-02-06 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Upcoming work will introduce a new version of the HTTP and SSH transports. The differences will be significant enough to consider them new transports. So, we

D2063: sshpeer: implement peer for version 2 of wire protocol

2018-02-06 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Since the protocol is now negotiated before we construct a peer instance, we can return the negotiated protocol from the handshake function and instantiate an

D2065: wireprotoserver: rename abstractserverproto and improve docstring

2018-02-06 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The docstring isn't completely accurate for the current state of the world. But it does describe the direction future patches will be taking things.

D2064: wireprotoserver: document and improve the httplib workaround

2018-02-06 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This workaround dates all the way back to https://phab.mercurial-scm.org/rHGa42d27bc809dda4939c5b3807b397bcc811ebbe0 in 2008. The code is esoteric enough to

D2057: translate base85.c into rust code

2018-02-06 Thread indygreg (Gregory Szorc)
indygreg added a comment. We generally prefer that patches to Mercurial be small and do a single thing. This makes it easier to review and understand changes, since each change can be evaluated in isolation. If you submit changesets together using `hg phabsend`, they automatically show up

D2061: sshpeer: initial definition and implementation of new SSH protocol

2018-02-06 Thread indygreg (Gregory Szorc)
indygreg added a comment. I want to emphasize that I'm not committed to any implementation detail at this point in time. I've very opened minded about alternatives and making backwards incompatible changes throughout the 4.6 release cycle. That being said, I am trying to make forward

D2031: sshpeer: establish SSH connection before class instantiation

2018-02-05 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 5232. indygreg edited the summary of this revision. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2031?vs=5189=5232 REVISION DETAIL https://phab.mercurial-scm.org/D2031 AFFECTED FILES mercurial/sshpeer.py

D2032: sshpeer: clean up API for sshpeer.__init__ (API)

2018-02-05 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 5233. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2032?vs=5190=5233 REVISION DETAIL https://phab.mercurial-scm.org/D2032 AFFECTED FILES mercurial/sshpeer.py tests/test-check-interfaces.py CHANGE DETAILS

D2035: sshpeer: document the handshake mechanism

2018-02-05 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 5236. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2035?vs=5230=5236 REVISION DETAIL https://phab.mercurial-scm.org/D2035 AFFECTED FILES mercurial/sshpeer.py CHANGE DETAILS diff --git a/mercurial/sshpeer.py

D2034: sshpeer: move handshake outside of sshpeer

2018-02-05 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 5235. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2034?vs=5229=5235 REVISION DETAIL https://phab.mercurial-scm.org/D2034 AFFECTED FILES mercurial/sshpeer.py tests/sshprotoext.py

D2036: sshpeer: remove support for connecting to <0.9.1 servers (BC)

2018-02-05 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 5237. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2036?vs=5231=5237 REVISION DETAIL https://phab.mercurial-scm.org/D2036 AFFECTED FILES mercurial/sshpeer.py tests/test-ssh-proto.t CHANGE DETAILS diff

D1973: bdiff: write a native version of splitnewlines

2018-02-12 Thread indygreg (Gregory Szorc)
indygreg accepted this revision. indygreg added a comment. I'm happy with this as a first revision. While I'm accepting as hg-reviewers, I think C code should have an extra set of eyes. So I'll defer to @yuja to queue it. For the record, I'm no fan of not having braces for all

D2178: pathencode: allow clang-format oversight

2018-02-12 Thread indygreg (Gregory Szorc)
indygreg accepted this revision. indygreg added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > pathencode.c:129-130 > charcopy(dest, , destsize, src[i++]); > - } > - else state = DDEFAULT;

D2181: charencode: allow clang-format oversight

2018-02-12 Thread indygreg (Gregory Szorc)
indygreg requested changes to this revision. indygreg added a comment. This revision now requires changes to proceed. I want a second opinion about the `#include` order. INLINE COMMENTS > charencode.h:11-12 > > +#include "compat.h" > #include > Huh? Why is it putting a system include

D1974: narrow: import experimental extension from narrowhg revision cb51d673e9c5

2018-02-12 Thread indygreg (Gregory Szorc)
indygreg accepted this revision. indygreg added a comment. This revision is now accepted and ready to land. I think I've seen enough follow-ups to feel comfortable taking this in core. There's still a ton of work that needs to get done. But it will be easier to iterate and for others to get

D2093: tests: add tests for sending recognized command before handshake

2018-02-12 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG465858451347: tests: add tests for sending recognized command before handshake (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2094: wireprotoserver: define and use parse_qs from urllib

2018-02-12 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGa3d42d1865f1: wireprotoserver: define and use parse_qs from urllib (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2108: infinitepush: drop the `--to` flag to push and use `-B` instead

2018-02-12 Thread indygreg (Gregory Szorc)
indygreg added a comment. In https://phab.mercurial-scm.org/D2108#36335, @durham wrote: > > There are things which I am not sure whether to keep or not: > > > > - the --bundle-store flag to push command > > This is useful for scripts or tools that want to upload a commit to the

D2088: wireprototypes: move wire protocol response types to new module

2018-02-12 Thread indygreg (Gregory Szorc)
indygreg added a comment. In https://phab.mercurial-scm.org/D2088#36287, @durin42 wrote: > I wonder if these should move to being attrs-generated at some point. Probably. I'm half considering blowing up all these types because they are... not well-defined and behavior is

D2082: wireproto: use maybecapturestdio() for push responses (API)

2018-02-12 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGcaca3ac2ac04: wireproto: use maybecapturestdio() for push responses (API) (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2089: wireproto: introduce type for raw byte responses (API)

2018-02-12 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG2f7290555c96: wireproto: introduce type for raw byte responses (API) (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2088: wireprototypes: move wire protocol response types to new module

2018-02-12 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGcd6ab329c5c7: wireprototypes: move wire protocol response types to new module (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2092: wireprotoserver: add version to SSH protocol names (API)

2018-02-12 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGac33dc94e1d5: wireprotoserver: add version to SSH protocol names (API) (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2081: wireprotoserver: add context manager mechanism for redirecting stdio

2018-02-12 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG2ad145fbde54: wireprotoserver: add context manager mechanism for redirecting stdio (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2084: wireprotoserver: rename _client to client (API)

2018-02-12 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG957e773614d0: wireprotoserver: rename _client to client (API) (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2085: wireprotoserver: rename getfile() to forwardpayload() (API)

2018-02-12 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG90ca4986616c: wireprotoserver: rename getfile() to forwardpayload() (API) (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2086: wireproto: remove unused proto argument from supportedcompengines (API)

2018-02-12 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG038bcb759b75: wireproto: remove unused proto argument from supportedcompengines (API) (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2083: wireprotoserver: remove redirect() and restore() (API)

2018-02-12 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG56fe8a3b2d52: wireprotoserver: remove redirect() and restore() (API) (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2091: wireprotoserver: extract SSH response handling functions

2018-02-12 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG5767664d39a5: wireprotoserver: extract SSH response handling functions (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2080: wireprotoserver: split ssh protocol handler and server

2018-02-12 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGbf676267f64f: wireprotoserver: split ssh protocol handler and server (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2087: wireprotoserver: move responsetype() out of http handler

2018-02-12 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG341c886e411e: wireprotoserver: move responsetype() out of http handler (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2219: wireprotoserver: add version to HTTP protocol name (API)

2018-02-12 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This matches what we did for the SSH protocol handler in https://phab.mercurial-scm.org/rHGac33dc94e1d53cf3fae22fd7e7c07805300ab42a. .. api:: HTTP

D2217: wireproto: improve docstring for "hello"

2018-02-12 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2217 AFFECTED FILES mercurial/wireproto.py CHANGE DETAILS diff --git a/mercurial/wireproto.py

D2215: httppeer: remove redundant code to fetch capabilities

2018-02-12 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY _fetchcaps() is called by httppeer.instance(), which is the only instantiator of httppeer. Since _fetchcaps() always sets self._caps and since

D2218: wireprotoserver: rename webproto to httpv1protocolhandler

2018-02-12 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This matches our naming convention for the SSH server's protocol handler. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2218

D2216: httppeer: remove httpspeer

2018-02-12 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY All it did was verify at construction time that Mercurial supports TLS. instance() is what's used to construct peer instances. So we can just inline this check

D2175: py3: use b'' in mockblackbox.py

2018-02-12 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGf49c3ee5b02f: py3: use b in mockblackbox.py (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2175?vs=5476=5576 REVISION

D2154: py3: use system strings when calling __import__

2018-02-12 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGc4146cf4dd20: py3: use system strings when calling __import__ (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2152: py3: compare against bytes instead of str

2018-02-12 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGc33a99506e13: py3: compare against bytes instead of str (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2152?vs=5453=5577

D2159: py3: use hex(hasher.digest())

2018-02-12 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG6426878f7f0f: py3: use hex(hasher.digest()) (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2159?vs=5460=5582 REVISION

D2161: py3: use b'' for changegroup version literals

2018-02-12 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG83246d6920f2: py3: use b for changegroup version literals (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2161?vs=5462=5585

D2160: py3: use b'' in inline extension

2018-02-12 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGa42817fede27: py3: use b in inline extension (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2160?vs=5461=5584 REVISION

D2156: py3: catch TypeError during template operations

2018-02-12 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG230489fc0b41: py3: catch TypeError during template operations (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2167: py3: cast character set to bytes

2018-02-12 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG6ea7f1c10c81: py3: cast character set to bytes (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2167?vs=5468=5590 REVISION

D2163: py3: use raw string for key in **kwargs

2018-02-12 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGb587a889b97e: py3: use raw string for key in **kwargs (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2163?vs=5464=5587

D2155: py3: use bytes literals for test extension

2018-02-12 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG361276a36d49: py3: use bytes literals for test extension (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2155?vs=5456=5581

D2153: py3: open patches.queue in binary mode

2018-02-12 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGbff95b002e33: py3: open patches.queue in binary mode (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2153?vs=5454=5578

D2162: py3: preserve chunks as an iterable of bytes

2018-02-12 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGc1104fe76e69: py3: preserve chunks as an iterable of bytes (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2164: py3: avoid changing dictionary during iteration

2018-02-12 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGc02771617a70: py3: avoid changing dictionary during iteration (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2169: py3: explicitly cast bool to bytes

2018-02-12 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGd78a51982262: py3: explicitly cast bool to bytes (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2169?vs=5470=5592

D2168: mail: import email.utils not email.Utils

2018-02-12 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG54dfb65e2f82: mail: import email.utils not email.Utils (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2168?vs=5469=5591

D2166: py3: cast decode() argument to system string

2018-02-12 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG9e47bfbeb723: py3: cast decode() argument to system string (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2170: py3: make dummyssh compatible with Python 3

2018-02-12 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG9996ec844c1e: py3: make dummyssh compatible with Python 3 (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2170?vs=5471=5593

D2176: py3: convert traceback representation to bytes when logging

2018-02-12 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG9446246e4d1a: py3: convert traceback representation to bytes when logging (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2171: ui: use named attributes on FrameInfo instance

2018-02-12 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGffcc3b977e43: ui: use named attributes on FrameInfo instance (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2172: py3: convert FrameInfo members to bytes

2018-02-12 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG20dbe0eee139: py3: convert FrameInfo members to bytes (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2172?vs=5473=5595

D2173: py3: add missing b'' literal to sshprotoext.py

2018-02-12 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG2e1d3924fa5b: py3: add missing b literal to sshprotoext.py (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2157: py3: use string for "close" value in commit extras

2018-02-12 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGb44a47214122: py3: use string for close value in commit extras (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2174: py3: convert context to bytes instead of str

2018-02-12 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGdd905ea1ea60: py3: convert context to bytes instead of str (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2198: tests: remove references to bundle2-exp config option

2018-02-12 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This option was deleted a while ago. We don't even alias it in core. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2198

D2199: tests: glob over line number

2018-02-12 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2199 AFFECTED FILES tests/test-narrow-pull.t CHANGE DETAILS diff --git a/tests/test-narrow-pull.t

D2200: hg: move share._getsrcrepo into core

2018-02-12 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The fact we were calling this from extensions was a sign that it should live in core. We were also able to remove some extra attribute aliases from the

D2202: tests: remove code to support Mercurial 4.3

2018-02-12 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Now that narrow lives in core, we don't need the legacy support. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2202 AFFECTED

D2201: narrowspec: move module into core

2018-02-12 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Having support for parsing the narrow specification in core is necessary for moving many other parts of narrow to core. We do still want to harmonize the

<    2   3   4   5   6   7   8   9   10   11   >