D4688: py3: use '%d' instead of '%s' for integers

2018-09-20 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG7303ab86431a: py3: use '%d' instead of '%s' for integers (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4688?vs=11250&id=1125

D4694: py3: fix kwargs handling in hgext/absorb.py

2018-09-23 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This fixes couple of tests on Python 3. There is only one absorb test left failing on Python 3. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercuria

D4695: py3: add b'' prefixes in tests/test-bdiff.py

2018-09-23 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This makes the test close to passing 1. skip-blame because just b'' prefixes REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4695

D4696: py3: use '%d' for integers instead of '%s'

2018-09-23 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Python 3 does not allow using "%s" for integers. This makes the test works on Python 3. The test still does not pass because there is a deprecation warning. R

D4697: tests: use assertTrue() instead of assert_() in test-bdiff.py

2018-09-23 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The later is deprecated in Python 3. This patch also makes the test pass on Python 3. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.o

D4698: py3: add b'' prefixes in contrib/simplemerge

2018-09-23 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY They were added using byteify-strings.py. 1. skip-blame because just b'' prefixes REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D

D4699: py3: use pycompat.strkwargs() in contrib/simplemerge

2018-09-23 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4699 AFFECTED FILES contrib/simplemerge CHANGE DETAILS diff --git a/contrib/simplemerge b/contrib/simp

D4694: py3: fix kwargs handling in hgext/absorb.py

2018-09-23 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGd50125dec2c1: py3: fix kwargs handling in hgext/absorb.py (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4694?vs=11290&id=112

D4695: py3: add b'' prefixes in tests/test-bdiff.py

2018-09-23 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGe05d7c71f209: py3: add b'' prefixes in tests/test-bdiff.py (authored by pulkit, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D4695?vs=11291&id=11297#toc REPOSITORY rHG Merc

D4696: py3: use '%d' for integers instead of '%s'

2018-09-23 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG69defbb83be7: py3: use '%d' for integers instead of '%s' (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4696?vs=11292&id=1129

D4697: tests: use assertTrue() instead of assert_() in test-bdiff.py

2018-09-23 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGe961f18a0094: tests: use assertTrue() instead of assert_() in test-bdiff.py (authored by pulkit, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D4697?vs=11293&id=11299#toc REPO

D4698: py3: add b'' prefixes in contrib/simplemerge

2018-09-23 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGd3e940a32be0: py3: add b'' prefixes in contrib/simplemerge (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4698?vs=11294&id=11

D4699: py3: use pycompat.strkwargs() in contrib/simplemerge

2018-09-23 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG1dd82ecb869b: py3: use pycompat.strkwargs() in contrib/simplemerge (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4699?vs=112

D4784: streamclone: pass includes and excludes to stream_out wireprotocol cmd

2018-09-27 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This adds client side logic to pass includes and excludes to the stream_out() wireprotocol command. Tests are not added because there is not server side logic ye

D4783: narrow: add 'narrowstream' server capability to use streamclones with narrow

2018-09-27 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This patch adds a new server capability "narrowstream" which will dictate whether the server is capable of serving narrow-stream clones or not. This also add s

D4785: streamclone: pass includes and excludes to fn generating clones

2018-09-27 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This patch adds includes and excludes as argument to couple of functions which generates the streamclone. The goal is to filter ou

D4783: narrow: add 'narrowstream' server capability to use streamclones with narrow

2018-09-27 Thread pulkit (Pulkit Goyal)
pulkit added a comment. This series works on streamclone v1 right now because I ran into that codepath first and also that's what we use right now. I looked into the code for v2 streamclone and once I get narrow clones working for v1, I will make sure we support v2. REPOSITORY rHG Mercuri

D4786: narrow: factor out logic to create cg while widening into separate fn

2018-09-28 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This patch takes out the logic which generates a changegroup for widening a narrow clone when ellipses are disabled. This is done

D4787: narrow: pass 'narrow_widen' as source while generating changegroup

2018-09-28 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Although this is called as a part of exchange.pull(), we don't want other extensions to wrap this pull call because it's not a nor

D4788: narrow: don't do the dirstate dance if ellipses is not enabled

2018-09-28 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I believe we set dirstate parents to nullid before widening pull because in ellipses cases, the parent might be stripped off with

D4789: narrow: check for servers' narrow support before doing anything (BC)

2018-09-28 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Recently we introduced narrow capabilities for the server. So we can check whether a server has narrow clone support or not before

D4788: narrow: don't do the dirstate dance if ellipses is not enabled

2018-09-28 Thread pulkit (Pulkit Goyal)
pulkit added a subscriber: martinvonz. pulkit added a comment. I am not sure about this one. I was unable to think of a reason why we need to do this dirstate dance in non-ellipses cases. @martinvonz @durin42 do you know why we do this? REPOSITORY rHG Mercurial REVISION DETAIL https://p

D4808: narrow: move the wireprotocol narrow capability name to core

2018-09-29 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We are trying to integrate the whole of narrow logic into core and it will be helpful for upcoming patches to have these capabilit

D4810: repository: introduce an ellipses repo requirement

2018-09-29 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Right now there is no good way to check whether a repo is ellipses enabled or not. This patch introduces a ellipses repo requirement which will be used in upcomin

D4809: narrow: move the ellipses server capability to core

2018-09-29 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This will be used in core logic to determining whether a server is ellipses enabled or not. And also this will ease moving narrow

D4811: py3: use util.forcebytestr() to convert error messages to bytes

2018-09-29 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a reviewer: indygreg. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This makes the python 3 buildbot green again. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4811

D4811: py3: use util.forcebytestr() to convert error messages to bytes

2018-09-29 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG7eb937f598d1: py3: use util.forcebytestr() to convert error messages to bytes (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D

D4808: narrow: move the wireprotocol narrow capability name to core

2018-09-30 Thread pulkit (Pulkit Goyal)
pulkit updated this revision to Diff 11499. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4808?vs=11491&id=11499 REVISION DETAIL https://phab.mercurial-scm.org/D4808 AFFECTED FILES hgext/narrow/narrowcommands.py hgext/narrow/narrowrepo.py hgext/n

D4810: repository: introduce an ellipses repo requirement

2018-09-30 Thread pulkit (Pulkit Goyal)
pulkit updated this revision to Diff 11501. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4810?vs=11493&id=11501 REVISION DETAIL https://phab.mercurial-scm.org/D4810 AFFECTED FILES mercurial/repository.py CHANGE DETAILS diff --git a/mercurial/repos

D4809: narrow: move the ellipses server capability to core

2018-09-30 Thread pulkit (Pulkit Goyal)
pulkit updated this revision to Diff 11500. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4809?vs=11492&id=11500 REVISION DETAIL https://phab.mercurial-scm.org/D4809 AFFECTED FILES hgext/narrow/__init__.py hgext/narrow/narrowcommands.py hgext/nar

D4788: narrow: don't do the dirstate dance if ellipses is not enabled

2018-09-30 Thread pulkit (Pulkit Goyal)
pulkit updated this revision to Diff 11502. pulkit edited the summary of this revision. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4788?vs=11471&id=11502 REVISION DETAIL https://phab.mercurial-scm.org/D4788 AFFECTED FILES hgext/narrow/narrowcomman

D4789: narrow: check for servers' narrow support before doing anything (BC)

2018-09-30 Thread pulkit (Pulkit Goyal)
pulkit updated this revision to Diff 11503. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4789?vs=11472&id=11503 REVISION DETAIL https://phab.mercurial-scm.org/D4789 AFFECTED FILES hgext/narrow/narrowcommands.py tests/test-narrow-clone-non-narrow-s

D4812: narrow: pass old includes and excludes to _widen()

2018-09-30 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY In future patches we will need to pass them in the widen wireprotocol command which we are building. REPOSITORY rHG Mercurial

D4813: [RFC] narrow: the first version of narrow_widen wireprotocol command

2018-09-30 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This patch introduces a wireprotocol command narrow_widen() which will be used to widen a narrow copy using `hg tracked` command p

D4814: py3: add one more passing test to whitelist caught by buildbot

2018-09-30 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Thanks to Matt Harbison who fixed the remaining failures of this test. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4814 AFFECTED F

D4664: mergecommit: add a new extension to merge in-memory and create a commit

2018-09-30 Thread pulkit (Pulkit Goyal)
pulkit added a comment. Thinking about this more, I think I have not done a good job writing commit message. The extension is very useful when you have automation around merges or you do merges because of the following reasons: - The merge is done in-memory and is very fast if you disabl

D4809: narrow: move the ellipses server capability to core

2018-09-30 Thread pulkit (Pulkit Goyal)
pulkit added inline comments. INLINE COMMENTS > martinvonz wrote in test-narrow-clone.t:48 > This doesn't look right. I suspect it was done by a mistaken `run-tests.py -i` I just ran `run-tests.py -i` and it popped up and I accepted it. I will check if the test pass without this change or not.

D4810: repository: introduce an ellipses repo requirement

2018-09-30 Thread pulkit (Pulkit Goyal)
pulkit added inline comments. INLINE COMMENTS > martinvonz wrote in repository.py:22-24 > I'm not sure I understand what this says. > > The first sentence sounds too obvious to mention (kind of like "when it's > done, it should be working well"), but I suspect you mean something else. Do > you

D4814: py3: add one more passing test to whitelist caught by buildbot

2018-10-01 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGeca452fa99b5: py3: add one more passing test to whitelist caught by buildbot (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4

D4817: py3: whitelist two additional tests

2018-10-01 Thread pulkit (Pulkit Goyal)
pulkit added a comment. I removed the duplicate entry of `test-debugcommands.t` and amended the commit message to say one test and queued, many thanks! INLINE COMMENTS > python3-whitelist:107 > test-debugcommands.t > +test-debugcommands.t > test-debugextensions.t This already exists on th

D4786: narrow: factor out logic to create cg while widening into separate fn

2018-10-01 Thread pulkit (Pulkit Goyal)
pulkit added inline comments. INLINE COMMENTS > martinvonz wrote in narrowbundle2.py:54 > Do you plan to add support for ellipses to this too? I don't know if you need > that feature, but I think the coming wire protocol command should eventually > gain support for ellipsis nodes. Do you think

D4787: narrow: pass 'narrow_widen' as source while generating changegroup

2018-10-01 Thread pulkit (Pulkit Goyal)
pulkit added a comment. In https://phab.mercurial-scm.org/D4787#72712, @martinvonz wrote: > > Although this is called as a part of exchange.pull(), we don't want other > > extensions to wrap this pull call because it's not a normal pull and it's > > widening. > > I don't follow t

D4788: narrow: don't do the dirstate dance if ellipses is not enabled

2018-10-01 Thread pulkit (Pulkit Goyal)
pulkit added a comment. In https://phab.mercurial-scm.org/D4788#72714, @martinvonz wrote: > In https://phab.mercurial-scm.org/D4788#72444, @pulkit wrote: > > > I am not sure about this one. I was unable to think of a reason why we need to do this dirstate dance in non-ellipses cases.

D4809: narrow: move the ellipses server capability to core

2018-10-01 Thread pulkit (Pulkit Goyal)
pulkit updated this revision to Diff 11516. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4809?vs=11500&id=11516 REVISION DETAIL https://phab.mercurial-scm.org/D4809 AFFECTED FILES hgext/narrow/narrowcommands.py hgext/narrow/narrowrepo.py hgext/n

D4788: narrow: don't do the dirstate dance if ellipses is not enabled

2018-10-01 Thread pulkit (Pulkit Goyal)
pulkit updated this revision to Diff 11517. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4788?vs=11502&id=11517 REVISION DETAIL https://phab.mercurial-scm.org/D4788 AFFECTED FILES hgext/narrow/narrowcommands.py tests/test-narrow-widen-no-ellipsis.

D4812: narrow: pass old includes and excludes to _widen()

2018-10-01 Thread pulkit (Pulkit Goyal)
pulkit updated this revision to Diff 11519. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4812?vs=11504&id=11519 REVISION DETAIL https://phab.mercurial-scm.org/D4812 AFFECTED FILES hgext/narrow/narrowcommands.py CHANGE DETAILS diff --git a/hgext/na

D4789: narrow: check for servers' narrow support before doing anything (BC)

2018-10-01 Thread pulkit (Pulkit Goyal)
pulkit updated this revision to Diff 11518. pulkit edited the summary of this revision. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4789?vs=11503&id=11518 REVISION DETAIL https://phab.mercurial-scm.org/D4789 AFFECTED FILES hgext/narrow/narrowcomman

D4813: [RFC] narrow: the first version of narrow_widen wireprotocol command

2018-10-01 Thread pulkit (Pulkit Goyal)
pulkit updated this revision to Diff 11520. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4813?vs=11505&id=11520 REVISION DETAIL https://phab.mercurial-scm.org/D4813 AFFECTED FILES hgext/narrow/narrowcommands.py hgext/narrow/narrowwirepeer.py tes

D4810: repository: introduce an ellipses repo requirement

2018-10-01 Thread pulkit (Pulkit Goyal)
pulkit planned changes to this revision. pulkit added a comment. Let's do this step by step and get the wireprotocol command reviewed first. Once that is done, I will resend this one. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4810 To: pulkit, #hg-reviewers

D4789: narrow: check for servers' narrow support before doing anything (BC)

2018-10-01 Thread pulkit (Pulkit Goyal)
pulkit added a comment. In https://phab.mercurial-scm.org/D4789#72717, @martinvonz wrote: > > This is BC because new clients won't be able to extend from old narrow-enabled servers. > > I think your previous patch was also BC in that sense since it started requiring the server to hav

D4809: narrow: move the ellipses server capability to core

2018-10-01 Thread pulkit (Pulkit Goyal)
pulkit added a comment. @martinvonz I have removed the logic of adding a new ellipses requirement from current series as coupling that and this series for review turned out to be a bad idea. This series now only tries to do some cleanup and introduce a new wireprotocol command. REPOSITORY

D4808: narrow: move the wireprotocol narrow capability name to core

2018-10-01 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGd5498db5f86a: narrow: move the wireprotocol narrow capability name to core (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D480

D4809: narrow: move the ellipses server capability to core

2018-10-01 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGa24f4638d6c1: narrow: move the ellipses server capability to core (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4809?vs=1151

D4823: narrow: drop unnecessary overrides of patch

2018-10-02 Thread pulkit (Pulkit Goyal)
pulkit added inline comments. INLINE COMMENTS > __init__.py:71 > narrowrepo.wraprepo(repo) > -narrowcopies.setup(repo) > narrowpatch.setup(repo) I think you want to delete narrowpatch here, not narrowcopies. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.me

D4837: narrow: remove narrowpatch instead of narrowcopies

2018-10-02 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a reviewer: durin42. Herald added a reviewer: martinvonz. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY https://phab.mercurial-scm.org/rHG84092edd5c88bbb3c2a5de377cfd9ca79019fa39 removed narrowpatch

D4837: narrow: remove narrowpatch instead of narrowcopies

2018-10-02 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG813eb942ca0a: narrow: remove narrowpatch instead of narrowcopies (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4837?vs=11549

D4786: narrow: factor out logic to create cg while widening into separate fn

2018-10-02 Thread pulkit (Pulkit Goyal)
pulkit updated this revision to Diff 11559. pulkit edited the summary of this revision. Herald added a reviewer: martinvonz. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4786?vs=11469&id=11559 REVISION DETAIL https://phab.mercurial-scm.org/D4786 AFFEC

D4787: narrow: pass 'narrow_widen' as source while generating changegroup

2018-10-02 Thread pulkit (Pulkit Goyal)
pulkit updated this revision to Diff 11560. Herald added a reviewer: martinvonz. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4787?vs=11470&id=11560 REVISION DETAIL https://phab.mercurial-scm.org/D4787 AFFECTED FILES hgext/narrow/narrowbundle2.py C

D4838: narrow: start returning bundle2 from widen_bundle()

2018-10-02 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a reviewer: durin42. Herald added a reviewer: martinvonz. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4838 AFFECTED FILES hgext/narrow/

D4813: [RFC] narrow: the first version of narrow_widen wireprotocol command

2018-10-02 Thread pulkit (Pulkit Goyal)
pulkit updated this revision to Diff 11561. pulkit edited the summary of this revision. Herald added a reviewer: martinvonz. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4813?vs=11520&id=11561 REVISION DETAIL https://phab.mercurial-scm.org/D4813 AFFEC

D4813: [RFC] narrow: the first version of narrow_widen wireprotocol command

2018-10-02 Thread pulkit (Pulkit Goyal)
pulkit added inline comments. INLINE COMMENTS > indygreg wrote in narrowwirepeer.py:71-78 > Do we need to call `narrowspec.restrictpatterns()` anywhere in here? I am not sure, @martinvonz what do you think? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4813 To:

D4786: narrow: factor out logic to create cg while widening into separate fn

2018-10-02 Thread pulkit (Pulkit Goyal)
pulkit added a comment. I have not changed this patch much, just added a XXX, saying we should return a bundle from here. I changed https://phab.mercurial-scm.org/D4813 to return a bundle2 instead of just sending the changegroup and added a patch on top of it for returning a bundle2 from the

D4786: narrow: factor out logic to create cg while widening into separate fn

2018-10-02 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGad9ca365738b: narrow: factor out logic to create cg while widening into separate fn (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm

D4787: narrow: pass 'narrow_widen' as source while generating changegroup

2018-10-02 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGfa2395659828: narrow: pass 'narrow_widen' as source while generating changegroup (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.or

D4788: narrow: don't do the dirstate dance if ellipses is not enabled

2018-10-02 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG693dda764efe: narrow: don't do the dirstate dance if ellipses is not enabled (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4

D4812: narrow: pass old includes and excludes to _widen()

2018-10-02 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG1a4c1a3cc3f5: narrow: pass old includes and excludes to _widen() (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4812?vs=11519

D4789: narrow: check for servers' narrow support before doing anything (BC)

2018-10-02 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG06e75fbf9d6b: narrow: check for servers' narrow support before doing anything (BC) (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.

D4838: narrow: start returning bundle2 from widen_bundle()

2018-10-02 Thread pulkit (Pulkit Goyal)
pulkit updated this revision to Diff 11573. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4838?vs=11562&id=11573 REVISION DETAIL https://phab.mercurial-scm.org/D4838 AFFECTED FILES hgext/narrow/narrowbundle2.py hgext/narrow/narrowwirepeer.py CHANG

D4813: narrow: the first version of narrow_widen wireprotocol command

2018-10-02 Thread pulkit (Pulkit Goyal)
pulkit updated this revision to Diff 11572. pulkit edited the summary of this revision. pulkit retitled this revision from "[RFC] narrow: the first version of narrow_widen wireprotocol command" to "narrow: the first version of narrow_widen wireprotocol command". REPOSITORY rHG Mercurial CHANG

D4832: debugcommands: add a debugindexstats command

2018-10-02 Thread pulkit (Pulkit Goyal)
pulkit added a comment. Can we please add a simple test for the new command? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4832 To: martinvonz, #hg-reviewers Cc: pulkit, mercurial-devel ___ Mercurial-devel mailing lis

D4847: manifest: remove an unused variable caught by pyflakes

2018-10-03 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Uses of todel were removed in https://phab.mercurial-scm.org/D4843. This patch will make buildbots green again. REPOSITORY rHG Mercurial REVISION DETAIL https:

D4848: py3: whitelist another passing tests caught by buildbot

2018-10-03 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I this indygreg recent patches made this test pass on Python 3. So thanks to him! REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D484

D4838: narrow: start returning bundle2 from widen_bundle()

2018-10-03 Thread pulkit (Pulkit Goyal)
pulkit updated this revision to Diff 11592. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4838?vs=11573&id=11592 REVISION DETAIL https://phab.mercurial-scm.org/D4838 AFFECTED FILES hgext/narrow/narrowbundle2.py hgext/narrow/narrowwirepeer.py CHANG

D4813: narrow: the first version of narrow_widen wireprotocol command

2018-10-03 Thread pulkit (Pulkit Goyal)
pulkit added inline comments. INLINE COMMENTS > martinvonz wrote in narrowcommands.py:293-295 > As I said on IRC, I think we (Google) would appreciate it if this could > remain here for a while to give us more time to migrate our custom server to > the new wire protocol command. I was thinking

D4813: narrow: the first version of narrow_widen wireprotocol command

2018-10-03 Thread pulkit (Pulkit Goyal)
pulkit updated this revision to Diff 11591. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4813?vs=11572&id=11591 REVISION DETAIL https://phab.mercurial-scm.org/D4813 AFFECTED FILES hgext/narrow/narrowbundle2.py hgext/narrow/narrowcommands.py hgex

D4848: py3: whitelist another passing tests caught by buildbot

2018-10-03 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGa8ec8bce14c6: py3: whitelist another passing tests caught by buildbot (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4848?vs=

D4847: manifest: remove an unused variable caught by pyflakes

2018-10-03 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGe22016e83c1e: manifest: remove an unused variable caught by pyflakes (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4847?vs=1

D4786: narrow: factor out logic to create cg while widening into separate fn

2018-10-03 Thread pulkit (Pulkit Goyal)
pulkit added inline comments. INLINE COMMENTS > martinvonz wrote in narrowbundle2.py:54 > > I said that because there is a 'narrow:changespec' part being send from the > > server. > > I assumed that was the reason :) But I don't think we'll need that part > because we don't need to strip nodes

D4849: store: introduce a function to get tracked path from a fncache entry

2018-10-03 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This patch introduces a function to get the trakced path from a fncache entry. This will be used to filter out files to streamclone using a narrowmatcher. The

D4850: store: pass matcher to store.datafiles() and filter files according to it

2018-10-03 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY To get narrow stream clones working, we need a way to filter the storage files using a matcher. This patch adds matcher as an argument to store.walk() and store.d

D4851: streamclone: pass narrowing related info in generatev2() and _walkstreamfiles()

2018-10-03 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This patch adds includes and excludes as argument to generatev2() and build a matcher using that and pass that into _walkstreamfiles(). This will help us in filte

D2039: py3: slice on bytes to prevent getting the ascii values

2018-02-05 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2039 AFFECTED FILES mercurial/scmutil.py CHANGE DETAILS diff --git a/mercurial/scmutil.py b/mercurial/

D2038: py3: add r'' to convert keys to keyword arguments to str

2018-02-05 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY 1. skip-blame as we are just adding r'' REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2038 AFFECTED FILES hgext/shelve.py CHANGE

D2037: py3: add b'' to tweakdefualts config string

2018-02-05 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The tweakdefaults config string is enclosed inside triple quotes and the transformer does not adds b'' there. 1. skip-blame because we are just adding b'' REP

D2040: py3: use .startswith() instead of bytes[0]

2018-02-05 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2040 AFFECTED FILES mercurial/revset.py CHANGE DETAILS diff --git a/mercurial/revset.py b/mercurial/re

D2043: py3: use pycompat.strkwargs() to convert kwargs' key to str

2018-02-05 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2043 AFFECTED FILES hgext/rebase.py CHANGE DETAILS diff --git a/hgext/rebase.py b/hgext/rebase.py ---

D2046: py3: add b'' to literals in check-config.py

2018-02-05 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY 1. skip-blame because we are just adding b'' REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2046 AFFECTED FILES contrib/check-confi

D2045: check-config: specify the mode 'rb' to open the file

2018-02-05 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2045 AFFECTED FILES contrib/check-config.py CHANGE DETAILS diff --git a/contrib/check-config.py b/cont

D2041: py3: use "%d" to convert integer to bytes

2018-02-05 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2041 AFFECTED FILES hgext/rebase.py CHANGE DETAILS diff --git a/hgext/rebase.py b/hgext/rebase.py ---

D2042: py3: add __bytes__() for mq.patchheader and make sure __str__ returns str

2018-02-05 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Before this patch, __str__() function for mq.patchheader class return bytes which is not str on Python 3. So let's move that logic to __bytes__() and for __str__(

D2044: py3: use open() instead of file()

2018-02-05 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY file() is not present in Python 3 REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2044 AFFECTED FILES hgext/mq.py CHANGE DETAILS d

D2038: py3: add r'' to convert keys to keyword arguments to str

2018-02-05 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG78b985c75731: py3: add r'' to convert keys to keyword arguments to str (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2038?vs

D2037: py3: add b'' to tweakdefualts config string

2018-02-05 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG704095e27c5c: py3: add b'' to tweakdefaults config string (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2037?vs=5195&id=5208

D2045: check-config: specify the mode 'rb' to open the file

2018-02-05 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG143d7b27b09c: check-config: specify the mode 'rb' to open the file (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2045?vs=520

D2041: py3: use "%d" to convert integer to bytes

2018-02-05 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG83b9f96ce20f: py3: use "%d" to convert integer to bytes (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2041?vs=5199&id=5212

D2043: py3: use pycompat.strkwargs() to convert kwargs' key to str

2018-02-05 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG3d8b0020f470: py3: use pycompat.strkwargs() to convert kwargs' key to str (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2043

D2040: py3: use .startswith() instead of bytes[0]

2018-02-05 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG7a991241f586: py3: use .startswith() instead of bytes[0] (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2040?vs=5198&id=5211

D2039: py3: slice on bytes to prevent getting the ascii values

2018-02-05 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG558e01a23f40: py3: slice on bytes to prevent getting the ascii values (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2039?vs=

D2046: py3: add b'' to literals in check-config.py

2018-02-05 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG2912bed9b0c7: py3: add b'' to literals in check-config.py (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2046?vs=5204&id=5217

D2042: py3: add __bytes__() for mq.patchheader and make sure __str__ returns str

2018-02-05 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGd41e41d11574: py3: add __bytes__() for mq.patchheader and make sure __str__ returns str (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial

<    2   3   4   5   6   7   8   9   10   11   >