valentin.gatienbaron created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Claiming "repository foo not found" when the repository does exist
causes confusion regularly ("where is the typo?").
REPOSITORY
rHG Mercurial
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGac0a87160012: localrepo: better error when a repo exists
but we lack permissions (authored by valentin.gatienbaron, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
valentin.gatienbaron created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Before this, running hg in emacs' M-x shell started `less`, which
would complain about the terminal not being fully functional.
REPOSITORY
rHG
valentin.gatienbaron created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D4377
AFFECTED FILES
mercurial/commands.py
CHANGE DETAILS
diff --git
valentin.gatienbaron created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Before this, calling 'hg resolve' with neither -m, -u or -l will
re-merge. This is highly error prone (it's easy to forget to forget a
-m), and
valentin.gatienbaron created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
On its own, it's not useful, but the next commit will add an hgrc
config option to make it mandatory.
There is no short option, as -r almost
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG3a60416c4fd8: commitextras: no need to special case
extras=[] (authored by valentin.gatienbaron, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG1cb7c9777852: commitextras: work nicely with other
extensions (authored by valentin.gatienbaron, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG6f38284b23f4: pager: do not enable when TERM=dumb (authored
by valentin.gatienbaron, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
valentin.gatienbaron created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D4405
AFFECTED FILES
hgext/commitextras.py
CHANGE DETAILS
diff --git
valentin.gatienbaron created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Before this change, it doesn't add these extra fields when loaded
alongside another extension that does a bunch of things, including
wrapping
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG3fec8aa9b454: resolve: make condition clearer, and able to
handle a new flag (authored by valentin.gatienbaron, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
valentin.gatienbaron created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D4447
AFFECTED FILES
tests/test-resolve.t
CHANGE DETAILS
diff --git
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGa80b8832720d: resolve: ui.config - ui.configbool, for
better validation (authored by valentin.gatienbaron, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
valentin.gatienbaron created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D4446
AFFECTED FILES
mercurial/commands.py
CHANGE DETAILS
diff --git
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG213c0493cea0: resolve: test that we suggest a valid hg
command (authored by valentin.gatienbaron, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG56469d475341: resolve: add config to make hg resolve not
re-merge by default (authored by valentin.gatienbaron, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG5d00e6061ba2: resolve: add a flag for the default behavior
of re-merging (authored by valentin.gatienbaron, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
valentin.gatienbaron updated this revision to Diff 10658.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D4378?vs=10576=10658
REVISION DETAIL
https://phab.mercurial-scm.org/D4378
AFFECTED FILES
mercurial/commands.py
tests/test-completion.t
valentin.gatienbaron updated this revision to Diff 10659.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D4379?vs=10577=10659
REVISION DETAIL
https://phab.mercurial-scm.org/D4379
AFFECTED FILES
mercurial/commands.py
mercurial/configitems.py
valentin.gatienbaron added a comment.
Thanks for accepting (some of) my other changes.
I added a couple of simple tests. I could add one for the hint, but I figured
it's probably not worth it?
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D4378
To:
valentin.gatienbaron updated this revision to Diff 12340.
valentin.gatienbaron edited the summary of this revision.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D5187?vs=12331=12340
REVISION DETAIL
https://phab.mercurial-scm.org/D5187
AFFECTED FILES
valentin.gatienbaron created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
So one can add text without hardcoding the indentation it will need.
REPOSITORY
rHG Mercurial
REVISION DETAIL
valentin.gatienbaron created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Currently, one has to look at the code.
A few things are suboptimal:
- probably not translatable
- some lines don't seem to be wrapped (they
valentin.gatienbaron added a comment.
I actually ran the tests, but didn't see the style error, because the test in
question is among the several ones that never pass for me. Fixed now.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D5187
To:
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGe928bedf0919: help: describe what ui.tweakdefaults changes,
concretely (authored by valentin.gatienbaron, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
valentin.gatienbaron created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Measuring this in one of my repos:
a = repo.dirstate
before = datetime.datetime.now()
ignore = a._ignore
after =
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGa91398dc73ab: identify: when using -T, avoid unnecessary
remote bookmarks query (authored by valentin.gatienbaron, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
valentin.gatienbaron added a comment.
> In this case, we'll have to load 'bookmarks' if --bookmarks is set. I have
> no idea if `default and not ui.quiet` should be handled in the same way.
>
> Can you send a followup?
Do you mean `hg id remote-url -Tjson -B` should show the
valentin.gatienbaron updated this revision to Diff 11564.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D4819?vs=11515=11564
REVISION DETAIL
https://phab.mercurial-scm.org/D4819
AFFECTED FILES
mercurial/commands.py
CHANGE DETAILS
diff --git
valentin.gatienbaron created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D4839
AFFECTED FILES
mercurial/commands.py
CHANGE DETAILS
diff --git
valentin.gatienbaron created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Instead of all the time when operating on a remote repo. This
perf regression was introduced in
valentin.gatienbaron created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
I didn't display bookmarks when `default and not ui.quiet`: it seems
strange for templates to depend on --id or -q, and it would take more
code for
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGc9026e9297e3: identify: only query remote bookmarks if
needed (authored by valentin.gatienbaron, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGfcad7fdc6474: identify: show remote bookmarks in `hg id url
-Tjson -B` (authored by valentin.gatienbaron, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGf28812c708a5: revset: fix commonancestor test so it
demonstrates correct behavior (authored by valentin.gatienbaron, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG823f34acfd46: revset: make heads(commonancestors(x + x^))
be x^, not x (authored by valentin.gatienbaron, committed by ).
CHANGED PRIOR TO COMMIT
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG0561e69ed9f1: revset: reword commonancestor()s help
(authored by valentin.gatienbaron, committed by ).
CHANGED PRIOR TO COMMIT
https://phab.mercurial-scm.org/D4740?vs=11357=11367#toc
REPOSITORY
rHG
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG572cd30eaffb: revset: add test demonstrating a bug with
commonancestor() (authored by valentin.gatienbaron, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG3bc4fce0167f: revset: remove part of the commonancestors()
comment (authored by valentin.gatienbaron, committed by ).
CHANGED PRIOR TO COMMIT
https://phab.mercurial-scm.org/D4739?vs=11356=11365#toc
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG84c61c1593c4: revset: add tests of
heads(commonancestors(..)) (authored by valentin.gatienbaron, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGcb5134f2318a: revset: make commonancestors(x + x^) be
::(x^), not ::x (authored by valentin.gatienbaron, committed by ).
CHANGED PRIOR TO COMMIT
https://phab.mercurial-scm.org/D4738?vs=11355=11364#toc
valentin.gatienbaron created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
So they can compute the hg version for instance.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D4768
AFFECTED FILES
valentin.gatienbaron created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D4738
AFFECTED FILES
mercurial/revset.py
tests/test-revset.t
CHANGE DETAILS
diff --git
valentin.gatienbaron created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
The problem is that hg log -r 'head()' is every changeset in the
repository, because in this test repository, every changeset has a
different
valentin.gatienbaron created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
The second-to-last one shows the same bug as commonancestors(..): the
result should be 8, not 9.
REPOSITORY
rHG Mercurial
REVISION DETAIL
valentin.gatienbaron created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
The new version seems a bit more consistent with other doc comments,
and feels clearer to me (doesn't explain "commonancestors(set)" as
"common
valentin.gatienbaron created this revision.
Herald added subscribers: mercurial-devel, mjpieters.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
The reason is that:
- it shows up in "hg help revset", but it doesn't look like documentation
targeted at users
- it doesn't make
valentin.gatienbaron created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D4742
AFFECTED FILES
mercurial/revset.py
tests/test-revset.t
CHANGE DETAILS
diff --git
valentin.gatienbaron created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Specifically, 9 is clearly not in "::8 and ::9".
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D4737
AFFECTED FILES
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGff8f4c73d9ad: logtoprocess: define $HG for children
processes (authored by valentin.gatienbaron, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
valentin.gatienbaron updated this revision to Diff 13270.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D5493?vs=13229=13270
REVISION DETAIL
https://phab.mercurial-scm.org/D5493
AFFECTED FILES
mercurial/help/hgignore.txt
mercurial/help/patterns.txt
valentin.gatienbaron added a comment.
Alright, I think I did what you asked for.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D5493
To: valentin.gatienbaron, #hg-reviewers
Cc: yuja, foozy, mercurial-devel
___
valentin.gatienbaron updated this revision to Diff 13229.
valentin.gatienbaron edited the summary of this revision.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D5493?vs=13011=13229
REVISION DETAIL
https://phab.mercurial-scm.org/D5493
AFFECTED FILES
valentin.gatienbaron added a comment.
Sorry, it took me a while to come back to this. I renamed the syntax to
rootglob.
I haven't handled your other remark, however I noticed that globs in
.gitignore can be rooted [1]. I had looked for a precedent for syntax for
rooting a glob last
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG4fab8a7d2d72: match: support rooted globs in hgignore
(authored by valentin.gatienbaron, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
valentin.gatienbaron created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D5448
AFFECTED FILES
mercurial/commands.py
CHANGE DETAILS
diff --git
valentin.gatienbaron created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D5447
AFFECTED FILES
tests/test-bookmarks-pushpull.t
CHANGE DETAILS
diff --git
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG357bd3ecf1b2: test-bookmarks-pushpull: add failing test of
issue4700 (authored by valentin.gatienbaron, committed by ).
CHANGED PRIOR TO COMMIT
https://phab.mercurial-scm.org/D5447?vs=12894=12928#toc
valentin.gatienbaron updated this revision to Diff 12938.
valentin.gatienbaron edited the summary of this revision.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D5449?vs=12895=12938
REVISION DETAIL
https://phab.mercurial-scm.org/D5449
AFFECTED FILES
valentin.gatienbaron added a comment.
I'd prefer not to have unpredictable aborts where, when they happen, the
solution is "try again". A year or two ago, the "remote heads changed during
push" errors were like that, and they were annoying.
I tried the batching approach, and it seems to
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG55e8da487b8a: wireproto: in batch queries, support queries
with immediate responses (authored by valentin.gatienbaron, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
valentin.gatienbaron added a comment.
Thanks!
> IIRC, listkeys is a newer command than lookup. If the peer doesn't support
listkeys, I suspect this batch query would fail. In that case, maybe listkeys
has to be skipped if the peer doesn't support it and if --bookmark is not
specified.
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGbad05a6afdc8: pull: fix inconsistent view of bookmarks
during pull (issue4700) (authored by valentin.gatienbaron, committed by ).
CHANGED PRIOR TO COMMIT
valentin.gatienbaron created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
listkeys and pushkey return without querying the remote when the
remote doesn't support such queries. Before this change, the batching
code didn't
valentin.gatienbaron updated this revision to Diff 12581.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D5294?vs=12580=12581
REVISION DETAIL
https://phab.mercurial-scm.org/D5294
AFFECTED FILES
contrib/import-checker.py
CHANGE DETAILS
diff --git
valentin.gatienbaron added a comment.
Thanks. FWIW, re2 options allow to choose an encoding which is latin1 or utf8
(https://github.com/google/re2/blob/master/re2/re2.h#L609). Presumably latin1
means that "." matches a byte, which would seem more compatible with re, but
python bindings
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGdd028bca9221: tests: make test-check-module-imports more
robust (authored by valentin.gatienbaron, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
valentin.gatienbaron created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
It fails for me with (among other things):
tests/test-commandserver.t:19: relative import of stdlib module
tests/test-lfs-serve.t:108:
valentin.gatienbaron updated this revision to Diff 12580.
valentin.gatienbaron edited the summary of this revision.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D5294?vs=12579=12580
REVISION DETAIL
https://phab.mercurial-scm.org/D5294
AFFECTED FILES
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG557d3509da55: tests: make test-alias.t pass with re2
(authored by valentin.gatienbaron, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
valentin.gatienbaron abandoned this revision.
valentin.gatienbaron added a comment.
will be subsumed by a more thorough change
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D5273
To: valentin.gatienbaron, #hg-reviewers
Cc: yuja, mercurial-devel
valentin.gatienbaron updated this revision to Diff 12564.
valentin.gatienbaron edited the summary of this revision.
valentin.gatienbaron retitled this revision from "hgignore: faster conversion
from globs to regexp" to "hgignore: conversion glob into regex faster".
REPOSITORY
rHG Mercurial
valentin.gatienbaron created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Locally, these "non-ASCII character in alias" errors don't show up,
though I get them when the alias is defined at the command line rather
than in
valentin.gatienbaron created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
In a .hgignore, "glob:foo" always means "**/foo". This cannot be
avoided because there is no syntax like "^" in regexes to say you
don't want the
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGa658f97c1ce4: censor: use a reasonable amount of memory
(authored by valentin.gatienbaron, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
valentin.gatienbaron created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Before this change, trying to censor some random revision uses an ever
increasing amount of memory (I stopped at 20GB, but it was by no means
valentin.gatienbaron updated this revision to Diff 11039.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D4582?vs=11021=11039
REVISION DETAIL
https://phab.mercurial-scm.org/D4582
AFFECTED FILES
hgext/censor.py
CHANGE DETAILS
diff --git
valentin.gatienbaron added a comment.
Ok. I added the b'', as this change created a small conflict later.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D5447
To: valentin.gatienbaron, #hg-reviewers
Cc: yuja, mercurial-devel
valentin.gatienbaron updated this revision to Diff 12894.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D5447?vs=12891=12894
REVISION DETAIL
https://phab.mercurial-scm.org/D5447
AFFECTED FILES
tests/test-bookmarks-pushpull.t
CHANGE DETAILS
diff
valentin.gatienbaron added a comment.
I went this way in part because it's fairly simple change, and might be
useful in other circumstances (to interpret pulling a tag as actually pulling
the tag itself perhaps, though I don't know concretely how that would work).
AFAIK, the protocol is
valentin.gatienbaron created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
which can result in bad status output.
Concretely, this seems to be easily triggered by having a build system
watching the filesystem for
valentin.gatienbaron created this revision.
Herald added a reviewer: durin42.
Herald added a reviewer: martinvonz.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
The problem is that hg merge/update/etc work the following way:
1. figure
valentin.gatienbaron created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
To get, for instance:
...
\ 6.6% 4.08s lock.py:__exit__ line 1566: ...
| 6.5% 4.01s exchange.py:close
valentin.gatienbaron updated this revision to Diff 15352.
valentin.gatienbaron retitled this revision from "profiling: add an option to
show actual time spent" to "profiling: show actual time spent in hotpath
display".
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG0ae593e791fb: profiling: show actual time spent in hotpath
display (authored by valentin.gatienbaron, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
valentin.gatienbaron added a comment.
Oh yeah, I didn't really consider the default. I clearly prefer "true", so
I'll change it. Maybe it's not even worth having an option. I think the only
advantage of not printing this column is to have 5 more columns available for
the code excerpt at the
Closed by commit rHG773b02226e93: merge: fix race that could cause wrong size
in dirstate (authored by valentin.gatienbaron).
This revision was automatically updated to reflect the committed changes.
This revision was not accepted when it landed; it landed in state "Needs
Review".
REPOSITORY
Closed by commit rHG55b724df1a64: worker: support parallelization of functions
with return values (authored by valentin.gatienbaron).
This revision was automatically updated to reflect the committed changes.
This revision was not accepted when it landed; it landed in state "Needs
Review".
Closed by commit rHGd9a50456ea3d: tests: show how the dirstate can end up
containing wrong information (authored by valentin.gatienbaron).
This revision was automatically updated to reflect the committed changes.
This revision was not accepted when it landed; it landed in state "Needs
Review".
Closed by commit rHG055c3e2c44f0: revlog: speed up isancestor (authored by
valentin.gatienbaron).
This revision was automatically updated to reflect the committed changes.
This revision was not accepted when it landed; it landed in state "Needs
Review".
REPOSITORY
rHG Mercurial
CHANGES SINCE
Closed by commit rHG3e42fc243741: dagop: fix documentation of reachableroots
(authored by valentin.gatienbaron).
This revision was automatically updated to reflect the committed changes.
This revision was not accepted when it landed; it landed in state "Needs
Review".
REPOSITORY
rHG Mercurial
valentin.gatienbaron updated this revision to Diff 15461.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D6474?vs=15326=15461
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D6474/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D6474
valentin.gatienbaron edited the summary of this revision.
valentin.gatienbaron updated this revision to Diff 15463.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D6475?vs=15327=15463
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D6475/new/
valentin.gatienbaron created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Currently worker supports running functions that return a progress
iterator. Generalize it to handle function that return a progress
iterator then
valentin.gatienbaron added inline comments.
INLINE COMMENTS
> martinvonz wrote in context.py:1806
> Was this necessary for this patch? Why?
This change is needed to get the size of the written data in merge.batchget.
> durin42 wrote in merge.py:1805
> I'm a little confused by this - it looks
valentin.gatienbaron added inline comments.
INLINE COMMENTS
> martinvonz wrote in context.py:1769
> Does overlayworkingfilectx also need to implement this function?
This is used only by rebase, and given that rebase seems to be very well tested
and that the tests pass, empirically, the answer
valentin.gatienbaron created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
The previous revset couldn't be correct as it is symmetric in
and , but reachableroots has no such symmetry. It makes a
difference with for
valentin.gatienbaron created this revision.
Herald added a reviewer: indygreg.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Currently, it is implemented on top of commonancestorsheads.
Implement it on top of reachableroots instead, as
Closed by commit rHGd29db0a0c4eb: update: fix spurious unclean status bug shown
by previous commit (authored by valentin.gatienbaron).
This revision was automatically updated to reflect the committed changes.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
1 - 100 of 288 matches
Mail list logo