On 2017-11-04 07:57, Yuya Nishihara wrote:
> On Fri, 03 Nov 2017 17:28:27 -0700, Gregory Szorc wrote:
>> # HG changeset patch
>> # User Gregory Szorc
>> # Date 1509755155 25200
>> # Fri Nov 03 17:25:55 2017 -0700
>> # Branch stable
>> # Node ID
abuehl added inline comments.
INLINE COMMENTS
> bitmanipulation.h:34
> c[2] = (x >> 8) & 0xff;
> - c[3] = (x) & 0xff;
> + c[3] = (x)&0xff;
> }
this one looks bad
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1069
To: durin42, #hg-reviewers
Cc:
abuehl added a comment.
In addition, Mercurial is not using the ...W Windows API functions.
I think, for example
https://phab.mercurial-scm.org/diffusion/HG/browse/default/mercurial/cext/osutil.c;da8bdeb1be28b976909a963c89e974264686e2bb$1207
would have to be changed to call
abuehl added a comment.
In https://phab.mercurial-scm.org/D851#14301, @indygreg wrote:
> In https://phab.mercurial-scm.org/D851#14300, @abuehl wrote:
>
> > What about file I/O done via Python lib (e.g. python27.dll)?
>
>
> I /think/ this works at the process - not DLL - level.
abuehl added a comment.
What about file I/O done via Python lib (e.g. python27.dll)?
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D851
To: indygreg, #hg-reviewers
Cc: abuehl, mercurial-devel
___
Mercurial-devel
abuehl added a comment.
In https://phab.mercurial-scm.org/D588#9989, @indygreg wrote:
> Would it be safe to keep the ``os.stat()`` code and return if the file
doesn't exist? That at least allows us to do the "is directory" and "file
missing" check with a single system call. That will
abuehl added inline comments.
INLINE COMMENTS
> win32.py:537
> +if e.errno == errno.ENOENT:
> +raise
> +
why continue on errors != ENOENT ?
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D588
To: indygreg, #hg-reviewers, quark
Cc: abuehl,
abuehl added a comment.
In https://phab.mercurial-scm.org/D588#9989, @indygreg wrote:
> OK. I failed to grok the unlink semantics on Windows. I'll need to read up
on MSDN.
I doubt this is documented on MSDN, but in case you find it there, please
share the link (perhaps add it on
abuehl added a comment.
In https://phab.mercurial-scm.org/D588#9925, @quark wrote:
> I can confirm `os.unlink` may succeed without actually removing the file:
>
> >>> from mercurial import util
> >>> f=util.posixfile('c:\\users\\quark\\a.txt', 'w')
> >>>
On 2017-09-01 08:16, Adrian Buehlmann wrote:
> Ugh. Can I reply to a phabricator notification by email?
>
> Adding gregory.sz...@gmail.com manually, as I'm not sure replaying to
> those nasty phabricator emails is going to work...
>
> On 2017-09-01 00:32, indygreg (Gregory Szo
Ugh. Can I reply to a phabricator notification by email?
Adding gregory.sz...@gmail.com manually, as I'm not sure replaying to
those nasty phabricator emails is going to work...
On 2017-09-01 00:32, indygreg (Gregory Szorc) wrote:
> indygreg created this revision.
> Herald added a subscriber:
On 2017-07-10 22:00, Kevin Bullock wrote:
> Greetings, Mercurial hackers!
>
> We've set up an instance of Phabricator that we're going to experiment with
> for code reviews. At this time, we're not planning on using any of the other
> features of Phabricator, and the use of Phabricator for
On 2017-06-05 05:38, Matt Harbison wrote:
> # HG changeset patch
> # User Matt Harbison
> # Date 1495503902 14400
> # Mon May 22 21:45:02 2017 -0400
> # Node ID eaed97a21942af11c122607bf37f7399c68cae9d
> # Parent ecc27f3123ea173f2dc66e20abbedad5741ea5e1
>
On 2017-05-08 06:39, Matt Harbison wrote:
> # HG changeset patch
> # User Matt Harbison
> # Date 1494183520 14400
> # Sun May 07 14:58:40 2017 -0400
> # Node ID 36d9a659b9d76837faaf73fde3f5c5455231c2f9
> # Parent c6cbd0b66465bcaa41f03c9498555f04d3dfbe7c
> hghave:
On 2016-08-25 20:11, tt...@fb.com wrote:
> # HG changeset patch
> # User Tony Tung
> # Date 1472148645 25200
> # Thu Aug 25 11:10:45 2016 -0700
> # Node ID 625f3bb4833b47c4d35754fced91f37b077f7866
> # Parent 2efc5a05d80a6d4253767f2ce0c2fb062ba83cb6
> util: move
15 matches
Mail list logo