D6449: help: clarify overlap of revlog header and first revlog entry

This revision was automatically updated to reflect the committed changes. Closed by commit rHGbfd65b5e070b: help: clarify overlap of revlog header and first revlog entry (authored by ngoldbaum, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6442: help: include subtopic in error message if passed

This revision was automatically updated to reflect the committed changes. Closed by commit rHGad55a0a5894f: help: include subtopic in error message if passed (authored by ngoldbaum, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6441: help: check if a subtopic exists and raise an error if it doesn't (issue6145)

This revision was automatically updated to reflect the committed changes. Closed by commit rHGa84564b1a0b1: help: check if a subtopic exists and raise an error if it doesnt (issue6145) (authored by ngoldbaum, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6449: help: clarify overlap of revlog header and first revlog entry

ngoldbaum created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6449 AFFECTED FILES mercurial/help/internals/revlogs.txt CHANGE DETAILS diff --git

D6442: help: include subtopic in error message if passed

ngoldbaum updated this revision to Diff 15269. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6442?vs=15259=15269 REVISION DETAIL https://phab.mercurial-scm.org/D6442 AFFECTED FILES mercurial/help.py tests/test-help.t CHANGE DETAILS diff --git

D6441: help: check if a subtopic exists and raise an error if it doesn't (issue6145)

ngoldbaum updated this revision to Diff 15268. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6441?vs=15258=15268 REVISION DETAIL https://phab.mercurial-scm.org/D6441 AFFECTED FILES mercurial/help.py CHANGE DETAILS diff --git a/mercurial/help.py

D6441: help: check if a subtopic exists and raise an error if it doesn't (issue6145)

ngoldbaum added inline comments. INLINE COMMENTS > martinvonz wrote in help.py:689-695 > I avoid for-else for the same reason, but how about this: > > if not any(subtopic in names for names, header, doc in subtopics[name]): > raise error.UnknownCommand(name) OK, I agree that's clearer.

D6442: help: include subtopic in error message if passed

ngoldbaum updated this revision to Diff 15259. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6442?vs=15253=15259 REVISION DETAIL https://phab.mercurial-scm.org/D6442 AFFECTED FILES mercurial/help.py tests/test-help.t CHANGE DETAILS diff --git

D6441: help: check if a subtopic exists and raise an error if it doesn't (issue6145)

ngoldbaum updated this revision to Diff 15258. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6441?vs=15246=15258 REVISION DETAIL https://phab.mercurial-scm.org/D6441 AFFECTED FILES mercurial/help.py CHANGE DETAILS diff --git a/mercurial/help.py

D6441: help: check if a subtopic exists and raise an error if it doesn't (issue6145)

ngoldbaum added inline comments. INLINE COMMENTS > av6 wrote in help.py:689-695 > This made me remember that for-else statement exists. I left this as-is because I find for-else statements hard to read (I never remember what it means!) and find this to be clearer even if there's a bit more

D6442: help: include subtopic in error message if passed

ngoldbaum updated this revision to Diff 15253. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6442?vs=15247=15253 REVISION DETAIL https://phab.mercurial-scm.org/D6442 AFFECTED FILES mercurial/help.py tests/test-help.t CHANGE DETAILS diff --git

D6442: help: include subtopic in error message if passed

ngoldbaum added inline comments. INLINE COMMENTS > av6 wrote in help.py:826 > Concatenating things is not the best option when it comes to i18n, but even > if it were, I think it would make sense to only show here the subtopic, if > it's provided. If people are curious about internals.foobar

D6442: help: include subtopic in error message if passed

ngoldbaum created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6442 AFFECTED FILES mercurial/help.py tests/test-help.t CHANGE DETAILS diff --git

D6441: help: check if a subtopic exists and raise an error if it doesn't (issue6145)

ngoldbaum created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6441 AFFECTED FILES mercurial/help.py CHANGE DETAILS diff --git a/mercurial/help.py

[PATCH STABLE] log: mention ui.logtemplate in the help text

# HG changeset patch # User Nathan Goldbaum <ngold...@illinois.edu> # Date 1502897089 18000 # Wed Aug 16 10:24:49 2017 -0500 # Branch stable # Node ID a1db17e964beee1a839769507818a50a5de3c9a3 # Parent 7686cbb0ba4138c56d038d8d82ccc052bf9b60d7 log: mention ui.logtemplate in the help text

[PATCH stable] tag: clarify warning about making a tag on a branch head

# HG changeset patch # User Nathan Goldbaum <ngold...@illinois.edu> # Date 1477951952 18000 # Mon Oct 31 17:12:32 2016 -0500 # Branch stable # Node ID ec11aa398c707b524b7e15994b5bf74bba6bc119 # Parent 69ffbbe73dd03df0d1a00bdb2bc083fdb73ede09 tag: clarify warning about making

[PATCH v5] crecord: add an event that scrolls the selected line to the top of the screen

# HG changeset patch # User Nathan Goldbaum <ngold...@illinois.edu> # Date 1474383830 18000 # Tue Sep 20 10:03:50 2016 -0500 # Node ID da914962b6c3f55c3f14cd7b82a4c0204c2d6a0d # Parent 769aee32fae0f7eb8768ea2e90780af4e9a92761 crecord: add an event that scrolls the selected line to t

Re: [PATCH 2 of 2 v3] crecord: add an event that scrolls the selected line to the top of the screen

On Tuesday, September 20, 2016, Pierre-Yves David < pierre-yves.da...@ens-lyon.org> wrote: > > > On 09/20/2016 12:23 AM, Nathan Goldbaum wrote: > >> # HG changeset patch >> # User Nathan Goldbaum <ngold...@illinois.edu> >> # Date 1474321033 18000 >>

Re: [PATCH 1 of 2 v3] crecord: delete commented line

Ah, oops, thank you! I will send a v4 with just the one new commit. On Mon, Sep 19, 2016 at 5:04 PM, Sean Farley <s...@farley.io> wrote: > Nathan Goldbaum <nathan12...@gmail.com> writes: > > > # HG changeset patch > > # User Nathan Goldbaum <ngold...@illinois

[PATCH 1 of 2 v3] crecord: delete commented line

# HG changeset patch # User Nathan Goldbaum <ngold...@illinois.edu> # Date 1473871187 18000 # Wed Sep 14 11:39:47 2016 -0500 # Node ID dec5dfcbd772a9f51674067ad18dff6d9bad78cf # Parent 2c302c6544511b37abe61ee2cc5278e4f61d5e71 crecord: delete commented line diff -r 2c302c654

[PATCH 1 of 2 v2] crecord: delete commented line

# HG changeset patch # User Nathan Goldbaum <ngold...@illinois.edu> # Date 1473871187 18000 # Wed Sep 14 11:39:47 2016 -0500 # Node ID dec5dfcbd772a9f51674067ad18dff6d9bad78cf # Parent 2c302c6544511b37abe61ee2cc5278e4f61d5e71 crecord: delete commented line diff -r 2c302c654

[PATCH 2 of 2 v2] crecord: add an event that scrolls the selected line to the top of the screen

# HG changeset patch # User Nathan Goldbaum <ngold...@illinois.edu> # Date 1473965349 18000 # Thu Sep 15 13:49:09 2016 -0500 # Node ID 3d1c9a829692bfb65ee269b236e2d695d9fed2b3 # Parent dec5dfcbd772a9f51674067ad18dff6d9bad78cf crecord: add an event that scrolls the selected line to t

[PATCH 2 of 2] crecord: add an event that scrolls the selected line to the top of the screen

# HG changeset patch # User Nathan Goldbaum <ngold...@illinois.edu> # Date 1473871467 18000 # Wed Sep 14 11:44:27 2016 -0500 # Node ID 9698a2565e5bed4a07d8fbbfc9d1c77e840ad787 # Parent dec5dfcbd772a9f51674067ad18dff6d9bad78cf crecord: add an event that scrolls the selected line to t