Re: Output buffering on Windows 10

2018-06-14 Thread Simon Farnsworth
I’d like to discuss a problem which results in console output not working correctly on Windows 10 and not having done so since late may 2017! The actual cause is due to a changeset by Simon Farnsworth in the beginning of february last year (changeset 3a4c0905f357): util: always

D477: revlog: add option to mmap revlog index

2017-08-24 Thread simonfar (Simon Farnsworth)
simonfar added inline comments. INLINE COMMENTS > test-revlog-mmapindex.t:12-13 > + > +mmap index which is now more than 4k long > + $ hg log -l 5 -T '{rev}\n' --config experimental.mmapindexthreshold=4k > + 100 Two things: 1. Can you add a `ui.debug()` or similar so that you can show that

D476: util: add an mmapread method

2017-08-23 Thread simonfar (Simon Farnsworth)
simonfar added inline comments. INLINE COMMENTS > util.py:413 > +try: > +return mmap.mmap(fp.fileno(), 0, access=mmap.ACCESS_READ) > +except ValueError: # cannot mmap an empty file As per comment on https://phab.mercurial-scm.org/D477 - do we want this to be raw, or

D477: revlog: add option to mmap revlog index

2017-08-23 Thread simonfar (Simon Farnsworth)
simonfar added inline comments. INLINE COMMENTS > revlog.py:343 > +if self._mmapindex: > +indexdata = util.buffer(util.mmapread(f)) > +else: Is there any reason for `mmapread` to not immediately wrap the data in a `util.buffer` for you? REPOSITORY rHG

Re: D119: color: add autoterminfo option to prefer terminfo over ansi for non-windows

2017-07-18 Thread simonfar (Simon Farnsworth)
simonfar added a comment. Looks good to me, though. INLINE COMMENTS > color.py:259-264 > elif realmode == 'terminfo': > _terminfosetup(ui, mode) > if not ui._terminfoparams: > ## FIXME Shouldn't we return None in this case too? > modewarn() >

Re: Hidden Commits in 4.3

2017-04-05 Thread Simon Farnsworth
ZldOrwdJ_KM0pKS9tZ5M=NFt0PtRadAIuciZ1Qg6kefWsdRxaXeOt_aG7bSnFTcQ= -- Simon Farnsworth ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Re: [PATCH 4 of 4 V2] obsolete: allow cycles

2017-03-25 Thread Simon Farnsworth
replaced the use of date with hashfunc(marker) (where hashfunc is a randomly chosen crypto hash), would people still have concerns? In other words, if we take the semantics of "date" away, and treat "date" as a random number that happens to always ex

[PATCH v2 stable] subrepo: move prompts out of the if (issue5505)

2017-03-20 Thread Simon Farnsworth
# HG changeset patch # User Simon Farnsworth <simon...@fb.com> # Date 1490009815 25200 # Mon Mar 20 04:36:55 2017 -0700 # Branch stable # Node ID 43fbb6661cfe578135791a3caff1473846c17899 # Parent 10c0ee33853539bd2721a05d4753785c2494d243 subrepo: move prompts out of the if (iss

Re: [PATCH] subrepo: move prompts out of the if (issue5505)

2017-03-17 Thread Simon Farnsworth
On 17/03/2017 17:28, FUJIWARA Katsunori wrote: At Fri, 17 Mar 2017 13:10:57 -0700, Simon Farnsworth wrote: # HG changeset patch # User Simon Farnsworth <simon...@fb.com> # Date 1489781443 25200 # Fri Mar 17 13:10:43 2017 -0700 # Node ID 0ccc212fc0224209864e8c902920a91acd1bc414 #

Re: Dropping support for Python 2.6 on Windows

2017-03-16 Thread Simon Farnsworth
we're likely to only be running the test suite, not also getting feedback from real users. -- Simon Farnsworth ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Re: [PATCH 2 of 3 V3] chgcache: implement a smartcache layer

2017-03-08 Thread Simon Farnsworth
proofpoint.com/v2/url?u=https-3A__www.mercurial-2Dscm.org_mailman_listinfo_mercurial-2Ddevel=DwIGaQ=5VD0RTtNlTh3ycd41b3MUw=mEgSWILcY4c4W3zjApBQLA=reQmKdchqeMVRwrhw7ZqWyDvfs90FzZDm_PbdOvq4oo=DZWjoUWpkqSpspZkpl_xGThGgkNdeyF3WiYgAFIIKnM= -- Simon Farnsworth ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

[PATCH 7 of 7] hgk: set a blocked tag when the user invokes view

2017-03-06 Thread Simon Farnsworth
# HG changeset patch # User Simon Farnsworth <simon...@fb.com> # Date 1488799672 28800 # Mon Mar 06 03:27:52 2017 -0800 # Node ID a24141da65e18e293bcd62f85f05050f01815942 # Parent 5b8f7a33145a182a4d4985972a8e4425eb20908f hgk: set a blocked tag when the user invokes view diff --git a

[PATCH 3 of 7] dispatch: set a blockedtag when running an external alias

2017-03-06 Thread Simon Farnsworth
# HG changeset patch # User Simon Farnsworth <simon...@fb.com> # Date 1488799544 28800 # Mon Mar 06 03:25:44 2017 -0800 # Node ID 6cb267dc6b8156333413b6bbadc819807d73241c # Parent 1c0e78f6c4db0c43799ee7d2fe68290c9f172849 dispatch: set a blockedtag when running an external alias diff

[PATCH 2 of 7] patch: set a blockedtag when running an external filter

2017-03-06 Thread Simon Farnsworth
# HG changeset patch # User Simon Farnsworth <simon...@fb.com> # Date 1488799529 28800 # Mon Mar 06 03:25:29 2017 -0800 # Node ID 1c0e78f6c4db0c43799ee7d2fe68290c9f172849 # Parent dc84da3efb972a86375c59fbb859bc31fc2d6335 patch: set a blockedtag when running an external filter diff

[PATCH 1 of 7] sshpeer: set a blockedtag when starting ssh

2017-03-06 Thread Simon Farnsworth
# HG changeset patch # User Simon Farnsworth <simon...@fb.com> # Date 1488799509 28800 # Mon Mar 06 03:25:09 2017 -0800 # Node ID dc84da3efb972a86375c59fbb859bc31fc2d6335 # Parent bca31954883ec7ffd16ee940bb84f12f60d286c8 sshpeer: set a blockedtag when starting ssh So that th

[PATCH] filemerge: tag merge tool for blocked times

2017-03-06 Thread Simon Farnsworth
# HG changeset patch # User Simon Farnsworth <simon...@fb.com> # Date 1488799180 28800 # Mon Mar 06 03:19:40 2017 -0800 # Node ID bca31954883ec7ffd16ee940bb84f12f60d286c8 # Parent b4cd912d7704cd976e1bee3a3c927e0e578ec88f filemerge: tag merge tool for blocked times Merge tools ca

[PATCH] hook: give exthooks tags for blocking time

2017-03-06 Thread Simon Farnsworth
# HG changeset patch # User Simon Farnsworth <simon...@fb.com> # Date 1488798555 28800 # Mon Mar 06 03:09:15 2017 -0800 # Node ID 9bdc781849eb9bba369cf9698cb8a1f5aef2b966 # Parent b4cd912d7704cd976e1bee3a3c927e0e578ec88f hook: give exthooks tags for blocking time The ui.system autogen

Re: [PATCH 9 of 9 pager v2] tests: prove that ignore works

2017-02-16 Thread Simon Farnsworth
EgSWILcY4c4W3zjApBQLA=CJ1L5Gx6iWAEndbgZQfzQvR8cqQ7iXJ7f9BNw2tH77I=zrhcVF0k6zjVEr8tds1cdSaECURlK-z9TgSyekYiFN8= -- Simon Farnsworth ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Re: [PATCH 1 of 9 pager] pager: move pager-initiating code into core

2017-02-16 Thread Simon Farnsworth
ractive console features? ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://urldefense.proofpoint.com/v2/url?u=https-3A__www.mercurial-2Dscm.org_mailman_listinfo_mercurial-2Ddevel=DwIGaQ=5VD0RTtNlTh3ycd41b3MUw=mEgSWILcY4c4W3zjApBQLA=Zi

Re: [PATCH 05 of 10 v5] ui: log time spent blocked on stdio

2017-02-16 Thread Simon Farnsworth
On 15/02/2017 22:06, Simon Farnsworth wrote: diff --git a/tests/test-logtoprocess.t b/tests/test-logtoprocess.t --- a/tests/test-logtoprocess.t +++ b/tests/test-logtoprocess.t @@ -61,10 +61,10 @@ > logtoprocess= > pager= > [logtoprocess] - > uiblocked=echo &quo

Re: help: I broke test-gendoc-ro.t and I have no idea how

2017-02-15 Thread Simon Farnsworth
omanian words and the English arguments - or you could decide to accept this warning for now until the Romanian translation is updated. -- Simon Farnsworth ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

[PATCH 09 of 10 v5] extdiff: log time spent in external diff program

2017-02-15 Thread Simon Farnsworth
# HG changeset patch # User Simon Farnsworth <simon...@fb.com> # Date 1487194446 28800 # Wed Feb 15 13:34:06 2017 -0800 # Node ID c17e5f194dca47819ca2d636a3c9cfdf02733ba7 # Parent 124f329bc78f53abce06a1e8e6244fcdcc551e34 extdiff: log time spent in external diff program We can't fix th

[PATCH 10 of 10 v5] histedit: log the time taken to read in the commands list

2017-02-15 Thread Simon Farnsworth
# HG changeset patch # User Simon Farnsworth <simon...@fb.com> # Date 1487194446 28800 # Wed Feb 15 13:34:06 2017 -0800 # Node ID b9cf9ffdf15f67b42e87272e2fb328102e8284ba # Parent c17e5f194dca47819ca2d636a3c9cfdf02733ba7 histedit: log the time taken to read in the commands list If

[PATCH 08 of 10 v5] crecord: log blocked time waiting for curses input

2017-02-15 Thread Simon Farnsworth
# HG changeset patch # User Simon Farnsworth <simon...@fb.com> # Date 1487194446 28800 # Wed Feb 15 13:34:06 2017 -0800 # Node ID 124f329bc78f53abce06a1e8e6244fcdcc551e34 # Parent ce6e773a6719fab87fa098021aac72b42709aa33 crecord: log blocked time waiting for curses input We want t

[PATCH 05 of 10 v5] ui: log time spent blocked on stdio

2017-02-15 Thread Simon Farnsworth
# HG changeset patch # User Simon Farnsworth <simon...@fb.com> # Date 1487195406 28800 # Wed Feb 15 13:50:06 2017 -0800 # Node ID 1487dd34f44315371738b13519cc4af1c81a7b07 # Parent 4d0b19ca8a56341fe2a77fd243232185ab4bf5e0 ui: log time spent blocked on stdio We use a wrapper around Mer

[PATCH 06 of 10 v5] ui: time calls to ui.system

2017-02-15 Thread Simon Farnsworth
# HG changeset patch # User Simon Farnsworth <simon...@fb.com> # Date 1487194152 28800 # Wed Feb 15 13:29:12 2017 -0800 # Node ID 1ae8bc5565b680008d82e93bee9455432b6ba0b2 # Parent 1487dd34f44315371738b13519cc4af1c81a7b07 ui: time calls to ui.system We want to know when we're b

[PATCH 04 of 10 v5] contrib: add a write microbenchmark to perf.py

2017-02-15 Thread Simon Farnsworth
# HG changeset patch # User Simon Farnsworth <simon...@fb.com> # Date 1487192846 28800 # Wed Feb 15 13:07:26 2017 -0800 # Node ID 4d0b19ca8a56341fe2a77fd243232185ab4bf5e0 # Parent f3a219226ba0658f72801329d07c1ba516152b70 contrib: add a write microbenchmark to perf.py I'm addin

[PATCH 03 of 10 v5] ui: provide a mechanism to track and log blocked time

2017-02-15 Thread Simon Farnsworth
# HG changeset patch # User Simon Farnsworth <simon...@fb.com> # Date 1487193465 28800 # Wed Feb 15 13:17:45 2017 -0800 # Node ID f3a219226ba0658f72801329d07c1ba516152b70 # Parent 1c71bddbe01e76c1c48b5479ff67d47645afd7b6 ui: provide a mechanism to track and log blocked time We want

[PATCH 02 of 10 v5] mercurial: switch to util.timer for all interval timings

2017-02-15 Thread Simon Farnsworth
# HG changeset patch # User Simon Farnsworth <simon...@fb.com> # Date 1487193459 28800 # Wed Feb 15 13:17:39 2017 -0800 # Node ID 1c71bddbe01e76c1c48b5479ff67d47645afd7b6 # Parent 36ad17f00656ef853e0bd7b79e9cd98b58c92a16 mercurial: switch to util.timer for all interval timings util

[PATCH 01 of 10 v5] util: introduce timer()

2017-02-15 Thread Simon Farnsworth
# HG changeset patch # User Simon Farnsworth <simon...@fb.com> # Date 1487188439 28800 # Wed Feb 15 11:53:59 2017 -0800 # Node ID 36ad17f00656ef853e0bd7b79e9cd98b58c92a16 # Parent afaf3c2b129c8940387fd9928ae4fdc28259d13c util: introduce timer() As documented for timeit.default

Re: [PATCH 2 of 2] lock: include Linux pid namespace identifier in prefix

2017-02-13 Thread Simon Farnsworth
ree of admin control of their own system, they can get a slight performance boost by switching locking to local-only (as there's no longer one RTT delay for each flock() call). At least, until they forget they did that, and use a second host for a concurrent operation...

Re: [PATCH 1 of 8 v4] mercurial: use best available timer for perf measurements

2017-02-13 Thread Simon Farnsworth
On 13/02/2017 18:49, Pulkit Goyal wrote: On Mon, Feb 13, 2017 at 10:59 PM, Simon Farnsworth <simon...@fb.com <mailto:simon...@fb.com>> wrote: # HG changeset patch # User Simon Farnsworth <simon...@fb.com <mailto:simon...@fb.com>> # Date 1486994849 28800

Re: [PATCH 2 of 8 v4] ui: provide a mechanism to track and log blocked time

2017-02-13 Thread Simon Farnsworth
On 13/02/2017 18:06, Bryan O'Sullivan wrote: On Mon, Feb 13, 2017 at 9:29 AM, Simon Farnsworth <simon...@fb.com <mailto:simon...@fb.com>> wrote: +duration = (util.timer() - starttime) * 1000 +key += '_blocked' +self._blockedtimes[key] += dura

Re: [PATCH 7 of 8 v4] extdiff: log time spent in external diff program

2017-02-13 Thread Simon Farnsworth
On 13/02/2017 18:04, Bryan O'Sullivan wrote: On Mon, Feb 13, 2017 at 9:29 AM, Simon Farnsworth <simon...@fb.com <mailto:simon...@fb.com>> wrote: +with ui.timeblockedsection('extdiff'): +ui.system(cmdline, cwd=tmproot) Why not simply instrument ui.sys

Re: [PATCH 8 of 8 v4] histedit: log the time taken to read in the commands list

2017-02-13 Thread Simon Farnsworth
On 13/02/2017 18:03, Bryan O'Sullivan wrote: On Mon, Feb 13, 2017 at 9:29 AM, Simon Farnsworth <simon...@fb.com <mailto:simon...@fb.com>> wrote: histedit: log the time taken to read in the commands list If we're being fed an external command list (histedi

Re: [PATCH 4 of 8 v4] ui: log time spent blocked on stdio

2017-02-13 Thread Simon Farnsworth
On 13/02/2017 18:00, Bryan O'Sullivan wrote: On Mon, Feb 13, 2017 at 9:29 AM, Simon Farnsworth <simon...@fb.com <mailto:simon...@fb.com>> wrote: The perfwrite microbenchmark shifts to: Linux: ! wall 3.316087 comb 0.90 user 0.81 sys 0.09 (best of 3) Mac

[PATCH 8 of 8 v4] histedit: log the time taken to read in the commands list

2017-02-13 Thread Simon Farnsworth
# HG changeset patch # User Simon Farnsworth <simon...@fb.com> # Date 1486994849 28800 # Mon Feb 13 06:07:29 2017 -0800 # Node ID b7557fd38e32b4d82b992003a242cd2a7c9496c5 # Parent 0727b4d77849fbefbf1ce1de6d9fe22ad2c5e1bd histedit: log the time taken to read in the commands list If

[PATCH 6 of 8 v4] crecord: log blocked time waiting for curses input

2017-02-13 Thread Simon Farnsworth
# HG changeset patch # User Simon Farnsworth <simon...@fb.com> # Date 1486994849 28800 # Mon Feb 13 06:07:29 2017 -0800 # Node ID 67a55b66a69520f84552cf3c1a7d93202c3f43da # Parent 74a43a6466712c42799528a25c4ca74eb2d25919 crecord: log blocked time waiting for curses input We want t

[PATCH 7 of 8 v4] extdiff: log time spent in external diff program

2017-02-13 Thread Simon Farnsworth
# HG changeset patch # User Simon Farnsworth <simon...@fb.com> # Date 1486994849 28800 # Mon Feb 13 06:07:29 2017 -0800 # Node ID 0727b4d77849fbefbf1ce1de6d9fe22ad2c5e1bd # Parent 67a55b66a69520f84552cf3c1a7d93202c3f43da extdiff: log time spent in external diff program We can't fix th

[PATCH 5 of 8 v4] ui: log time spent blocked on editor

2017-02-13 Thread Simon Farnsworth
# HG changeset patch # User Simon Farnsworth <simon...@fb.com> # Date 1486994849 28800 # Mon Feb 13 06:07:29 2017 -0800 # Node ID 74a43a6466712c42799528a25c4ca74eb2d25919 # Parent 923dcef529e523b391e26840cfa9ea6fd53c4131 ui: log time spent blocked on editor The user's editor is outsi

[PATCH 3 of 8 v4] contrib: add a write microbenchmark to perf.py

2017-02-13 Thread Simon Farnsworth
# HG changeset patch # User Simon Farnsworth <simon...@fb.com> # Date 1486994849 28800 # Mon Feb 13 06:07:29 2017 -0800 # Node ID 5a595ee2509989e440d70eb0e134fea915a0a8d6 # Parent 00f01e9a24bc050ab5cbbfc5a8dc99e992e31d2b contrib: add a write microbenchmark to perf.py I'm addin

[PATCH 4 of 8 v4] ui: log time spent blocked on stdio

2017-02-13 Thread Simon Farnsworth
# HG changeset patch # User Simon Farnsworth <simon...@fb.com> # Date 1486994849 28800 # Mon Feb 13 06:07:29 2017 -0800 # Node ID 923dcef529e523b391e26840cfa9ea6fd53c4131 # Parent 5a595ee2509989e440d70eb0e134fea915a0a8d6 ui: log time spent blocked on stdio We use a wrapper around Mer

[PATCH 2 of 8 v4] ui: provide a mechanism to track and log blocked time

2017-02-13 Thread Simon Farnsworth
# HG changeset patch # User Simon Farnsworth <simon...@fb.com> # Date 1486994849 28800 # Mon Feb 13 06:07:29 2017 -0800 # Node ID 00f01e9a24bc050ab5cbbfc5a8dc99e992e31d2b # Parent 88b51cd7e8e3764af542c25d79a33f5cbda37ac6 ui: provide a mechanism to track and log blocked time We want

[PATCH 1 of 8 v4] mercurial: use best available timer for perf measurements

2017-02-13 Thread Simon Farnsworth
# HG changeset patch # User Simon Farnsworth <simon...@fb.com> # Date 1486994849 28800 # Mon Feb 13 06:07:29 2017 -0800 # Node ID 88b51cd7e8e3764af542c25d79a33f5cbda37ac6 # Parent a0e3d808690d57d1c9dff840e0b8ee099526397b mercurial: use best available timer for perf measur

Re: [PATCH 1 of 8 v3] mercurial: use timeit.default_timer for interval measurement

2017-02-12 Thread Simon Farnsworth
On 11/02/2017 23:40, Bryan O'Sullivan wrote: On Fri, Feb 10, 2017 at 1:06 PM, Simon Farnsworth <simon...@fb.com <mailto:simon...@fb.com>> wrote: # Parent 1f51b4658f21bbb797e922d155c1046eddccf91d mercurial: use timeit.default_timer for interval measurement In Python 2

[PATCH 6 of 8 v3] crecord: log blocked time waiting for curses input

2017-02-10 Thread Simon Farnsworth
# HG changeset patch # User Simon Farnsworth <simon...@fb.com> # Date 1486760569 28800 # Fri Feb 10 13:02:49 2017 -0800 # Node ID 7650c3dee1cab050f3835ae95590636473b58874 # Parent 8e20c41fe4903745b668ae3de58a0d3e9514a78e crecord: log blocked time waiting for curses input We want t

[PATCH 4 of 8 v3] ui: log time spent blocked on stdio

2017-02-10 Thread Simon Farnsworth
# HG changeset patch # User Simon Farnsworth <simon...@fb.com> # Date 1486760435 28800 # Fri Feb 10 13:00:35 2017 -0800 # Node ID dbe4c89f86d75130fabcde8ac2f4ce18ef6d356e # Parent 838c119320b457e9dfcc45d3d8a50a48d5ea5243 ui: log time spent blocked on stdio We use a wrapper around Mer

[PATCH 3 of 8 v3] contrib: add a write microbenchmark to perf.py

2017-02-10 Thread Simon Farnsworth
# HG changeset patch # User Simon Farnsworth <simon...@fb.com> # Date 1486760403 28800 # Fri Feb 10 13:00:03 2017 -0800 # Node ID 838c119320b457e9dfcc45d3d8a50a48d5ea5243 # Parent 25b4512a095b2f3788b255274a15d68dbc10f7b4 contrib: add a write microbenchmark to perf.py I'm addin

[PATCH 5 of 8 v3] ui: log time spent blocked on editor

2017-02-10 Thread Simon Farnsworth
# HG changeset patch # User Simon Farnsworth <simon...@fb.com> # Date 1486760569 28800 # Fri Feb 10 13:02:49 2017 -0800 # Node ID 8e20c41fe4903745b668ae3de58a0d3e9514a78e # Parent dbe4c89f86d75130fabcde8ac2f4ce18ef6d356e ui: log time spent blocked on editor The user's editor is outsi

[PATCH 2 of 8 v3] ui: provide a mechanism to track and log blocked time

2017-02-10 Thread Simon Farnsworth
# HG changeset patch # User Simon Farnsworth <simon...@fb.com> # Date 1486757727 28800 # Fri Feb 10 12:15:27 2017 -0800 # Node ID 25b4512a095b2f3788b255274a15d68dbc10f7b4 # Parent bd40abfb4e5dbaf6e373636c8e7bab7a6bf34e17 ui: provide a mechanism to track and log blocked time We want

[PATCH 1 of 8 v3] mercurial: use timeit.default_timer for interval measurement

2017-02-10 Thread Simon Farnsworth
# HG changeset patch # User Simon Farnsworth <simon...@fb.com> # Date 1486748338 28800 # Fri Feb 10 09:38:58 2017 -0800 # Node ID bd40abfb4e5dbaf6e373636c8e7bab7a6bf34e17 # Parent 1f51b4658f21bbb797e922d155c1046eddccf91d mercurial: use timeit.default_timer for interval measurement In

[PATCH 5 of 6 v2] extdiff: log time spent in external diff program

2017-02-09 Thread Simon Farnsworth
# HG changeset patch # User Simon Farnsworth <simon...@fb.com> # Date 1486676255 28800 # Thu Feb 09 13:37:35 2017 -0800 # Node ID acb1103ff1de3c9c40a4b1c6b19ca65161329d02 # Parent ff695f191c30036c1171d8509f55ec60d19e0614 extdiff: log time spent in external diff program We can't fix th

[PATCH 2 of 6 v2] ui: log time spent blocked on stdio

2017-02-09 Thread Simon Farnsworth
# HG changeset patch # User Simon Farnsworth <simon...@fb.com> # Date 1486676409 28800 # Thu Feb 09 13:40:09 2017 -0800 # Node ID be7dac985b12af413b43fa9685e29a90f80de4ef # Parent ec1dac3c0d5fc7d0d15af324b345958a41000960 ui: log time spent blocked on stdio We use a wrapper around Mer

[PATCH 3 of 6 v2] ui: log time spent blocked on editor

2017-02-09 Thread Simon Farnsworth
# HG changeset patch # User Simon Farnsworth <simon...@fb.com> # Date 1486676443 28800 # Thu Feb 09 13:40:43 2017 -0800 # Node ID e21b9166fc2cdcda22a071de30f97b44c5796da1 # Parent be7dac985b12af413b43fa9685e29a90f80de4ef ui: log time spent blocked on editor The user's editor is outsi

[PATCH 6 of 6 v2] histedit: log the time taken to read in the commands list

2017-02-09 Thread Simon Farnsworth
# HG changeset patch # User Simon Farnsworth <simon...@fb.com> # Date 1486676306 28800 # Thu Feb 09 13:38:26 2017 -0800 # Node ID f8b12c890147ebce0c06663f478cd76b89f6beab # Parent acb1103ff1de3c9c40a4b1c6b19ca65161329d02 histedit: log the time taken to read in the commands list If

[PATCH 1 of 6 v2] ui: provide a mechanism to track and log blocked time

2017-02-09 Thread Simon Farnsworth
# HG changeset patch # User Simon Farnsworth <simon...@fb.com> # Date 1486675708 28800 # Thu Feb 09 13:28:28 2017 -0800 # Node ID ec1dac3c0d5fc7d0d15af324b345958a41000960 # Parent 1f51b4658f21bbb797e922d155c1046eddccf91d ui: provide a mechanism to track and log blocked time We want

[PATCH 4 of 6 v2] crecord: log blocked time waiting for curses input

2017-02-09 Thread Simon Farnsworth
# HG changeset patch # User Simon Farnsworth <simon...@fb.com> # Date 1486676200 28800 # Thu Feb 09 13:36:40 2017 -0800 # Node ID ff695f191c30036c1171d8509f55ec60d19e0614 # Parent e21b9166fc2cdcda22a071de30f97b44c5796da1 crecord: log blocked time waiting for curses input We want t

[PATCH] zeroconf: fail nicely on IPv6 only system

2017-02-08 Thread Simon Farnsworth
# HG changeset patch # User Simon Farnsworth <simon...@fb.com> # Date 1486570121 28800 # Wed Feb 08 08:08:41 2017 -0800 # Node ID a847eb00fcfeffce458e11b80ad38d4d4e7a700f # Parent d50cda2a403786836d1f0d5c99401599dc4f43ec zeroconf: fail nicely on IPv6 only system zeroconf only kno

Re: [PATCH] pager: exit cleanly on SIGPIPE (BC)

2017-02-08 Thread Simon Farnsworth
This replaces "dispatch: treat SIGPIPE as a termination signal (BC)". I'm now debugging test-paths.t, so that I can stop being acclimatised to the red failure prompt after running tests, to improve my chances of noticing this sort of issue. Simon On 08/02/2017 15:47, Simon Farnsw

[PATCH] pager: exit cleanly on SIGPIPE (BC)

2017-02-08 Thread Simon Farnsworth
# HG changeset patch # User Simon Farnsworth <simon...@fb.com> # Date 1486568650 28800 # Wed Feb 08 07:44:10 2017 -0800 # Node ID d50cda2a403786836d1f0d5c99401599dc4f43ec # Parent 1f51b4658f21bbb797e922d155c1046eddccf91d pager: exit cleanly on SIGPIPE (BC) Changeset aaa751585325 r

Re: [PATCH] dispatch: treat SIGPIPE as a termination signal (BC)

2017-02-08 Thread Simon Farnsworth
Please scrub this - it breaks `hg serve`. I'll send a v2 shortly, that moves the SIGPIPE handling into pager and thus has no BC implications. On 07/02/2017 20:08, Simon Farnsworth wrote: # HG changeset patch # User Simon Farnsworth <simon...@fb.com> # Date 1486498104 28800 # Tue Feb

Re: [PATCH] dispatch: treat SIGPIPE as a termination signal (BC)

2017-02-07 Thread Simon Farnsworth
rable (and justifies the BC marker). It tells you that where old Mercurial would continue processing after your stdin feed or stdout capture died unexpectedly, this Mercurial now quits. Excerpts from Simon Farnsworth's message of 2017-02-07 12:08:29 -0800: # HG changeset patch # User Sim

Re: [PATCH] pager: backed out changeset aaa751585325

2017-02-07 Thread Simon Farnsworth
com/v2/url?u=https-3A__www.mercurial-2Dscm.org_mailman_listinfo_mercurial-2Ddevel=DwIGaQ=5VD0RTtNlTh3ycd41b3MUw=mEgSWILcY4c4W3zjApBQLA=Kkdsd1P9qEpbCBrbRyenM6kQC-sD5CNSJJxglAJzfec=lRjI_yaSrj_N7KUWb3_WFaRF_2KzfxHikgvyHTXS-Lg= -- Simon Farnsworth ___ Mercuria

[PATCH] dispatch: treat SIGPIPE as a termination signal (BC)

2017-02-07 Thread Simon Farnsworth
# HG changeset patch # User Simon Farnsworth <simon...@fb.com> # Date 1486498104 28800 # Tue Feb 07 12:08:24 2017 -0800 # Node ID e1150763706818fffa62c81a72a88574d20caea1 # Parent 1f51b4658f21bbb797e922d155c1046eddccf91d dispatch: treat SIGPIPE as a termination signal (BC) pager prev

Re: Backwards compatibility before all else? [was Re: [PATCH v2] pager: migrate heavily-used extension into core]

2017-02-07 Thread Simon Farnsworth
se, we should be able to keep our users happy while still improving. -- Simon Farnsworth ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

[PATCH v3] util: always force line buffered stdout when stdout is a tty (BC)

2017-02-03 Thread Simon Farnsworth
# HG changeset patch # User Simon Farnsworth <simon...@fb.com> # Date 1486163427 28800 # Fri Feb 03 15:10:27 2017 -0800 # Node ID 08b6e1bb20ca6bd1465a3d22bab49debfe776bae # Parent 1f51b4658f21bbb797e922d155c1046eddccf91d util: always force line buffered stdout when stdout is a t

Re: [PATCH 2 of 6 v2] util: add an elapsed time wrapper

2017-02-03 Thread Simon Farnsworth
On 03/02/2017 23:00, Bryan O'Sullivan wrote: On Fri, Feb 3, 2017 at 2:55 PM, Simon Farnsworth <simon...@fb.com <mailto:simon...@fb.com>> wrote: We already capture start and exit times in the external wrapper process - so your added detail of measuring "useful work&

Re: [PATCH 2 of 6 v2] util: add an elapsed time wrapper

2017-02-03 Thread Simon Farnsworth
On 03/02/2017 22:36, Bryan O'Sullivan wrote: On Fri, Feb 3, 2017 at 2:26 PM, Simon Farnsworth <simon...@fb.com <mailto:simon...@fb.com>> wrote: Assuming the community doesn't object strongly, I'll redo to be unconditionally measuring time (and only condition

Re: [PATCH 2 of 6 v2] util: add an elapsed time wrapper

2017-02-03 Thread Simon Farnsworth
ss today. It looks like I met goal 2 at the expense of goal 1, and I'm going to need to rework to get a nicer compromise in place between the goals. -- Simon Farnsworth ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

[PATCH 3 of 6 v2] util: always force line buffered stdout when stdout is a tty (BC)

2017-02-02 Thread Simon Farnsworth
# HG changeset patch # User Simon Farnsworth <simon...@fb.com> # Date 1486063056 28800 # Thu Feb 02 11:17:36 2017 -0800 # Node ID 722c309600ed9596a02674b04cb2caa9a65e8918 # Parent 12d0ac224bb34691d44a2cead5b9795a6cfc2490 util: always force line buffered stdout when stdout is a t

[PATCH 6 of 6 v2] extdiff: measure blocked time

2017-02-02 Thread Simon Farnsworth
# HG changeset patch # User Simon Farnsworth <simon...@fb.com> # Date 1486063056 28800 # Thu Feb 02 11:17:36 2017 -0800 # Node ID c85a13e4bbc3a26b6bf6f502c207f5491eb0889f # Parent 581cb462ae6eb9ae95fdd64ec55df2b58ab6233a extdiff: measure blocked time Log the time spent in the externa

[PATCH 5 of 6 v2] crecord: log blocked time waiting for curses input

2017-02-02 Thread Simon Farnsworth
# HG changeset patch # User Simon Farnsworth <simon...@fb.com> # Date 1486063056 28800 # Thu Feb 02 11:17:36 2017 -0800 # Node ID 581cb462ae6eb9ae95fdd64ec55df2b58ab6233a # Parent a590327ef7a47e1390bcef0eef686c40ffc4894d crecord: log blocked time waiting for curses input We want t

[PATCH 2 of 6 v2] util: add an elapsed time wrapper

2017-02-02 Thread Simon Farnsworth
# HG changeset patch # User Simon Farnsworth <simon...@fb.com> # Date 1486063056 28800 # Thu Feb 02 11:17:36 2017 -0800 # Node ID 12d0ac224bb34691d44a2cead5b9795a6cfc2490 # Parent f443bd95a948aaed36e81edb884085fc2f0f5acf util: add an elapsed time wrapper We want to log the time

[PATCH 1 of 6 v2] pager: don't terminate with extreme prejudice on SIGPIPE (BC)

2017-02-02 Thread Simon Farnsworth
# HG changeset patch # User Simon Farnsworth <simon...@fb.com> # Date 1486063056 28800 # Thu Feb 02 11:17:36 2017 -0800 # Node ID f443bd95a948aaed36e81edb884085fc2f0f5acf # Parent abf029200e198878a4576a87e095bd8d77d9cea9 pager: don't terminate with extreme prejudice on SIGPI

Re: [PATCH 1 of 5] pager: stdout is line buffered by default

2017-01-20 Thread Simon Farnsworth
On 20/01/2017 12:56, Yuya Nishihara wrote: On Thu, 19 Jan 2017 11:02:07 -0800, Simon Farnsworth wrote: # HG changeset patch # User Simon Farnsworth <simon...@fb.com> # Date 1484835774 28800 # Thu Jan 19 06:22:54 2017 -0800 # Node ID 76123ae2e0ccaa58db3d4fc26b75b7251e13ad16 #

[PATCH 1 of 5] pager: stdout is line buffered by default

2017-01-19 Thread Simon Farnsworth
# HG changeset patch # User Simon Farnsworth <simon...@fb.com> # Date 1484835774 28800 # Thu Jan 19 06:22:54 2017 -0800 # Node ID 76123ae2e0ccaa58db3d4fc26b75b7251e13ad16 # Parent 036c37bd3ec189480647ff568cee9e0b43a5bc81 pager: stdout is line buffered by default pager only start

[PATCH 5 of 5] crecord: log blocked time waiting for curses input

2017-01-19 Thread Simon Farnsworth
# HG changeset patch # User Simon Farnsworth <simon...@fb.com> # Date 1484850980 28800 # Thu Jan 19 10:36:20 2017 -0800 # Node ID 9684b31c29f3f17096ead595fef50b687d518b1c # Parent 93221dde2fad942c4f920dab1f346da71ac8033d crecord: log blocked time waiting for curses input We want t

[PATCH] fsmonitor: be robust in the face of bad state

2016-11-25 Thread Simon Farnsworth
# HG changeset patch # User Simon Farnsworth <simon...@fb.com> # Date 1480087846 28800 # Fri Nov 25 07:30:46 2016 -0800 # Node ID 0ca34f1b83da754246ee33e01c4f7d6652061f5d # Parent a3163433647108b7bec8fc45896db1c20b18ab21 fsmonitor: be robust in the face of bad state fsmonitor could

Re: [PATCH evolve v2] tests: use curl instead of wget

2016-10-25 Thread Simon Farnsworth
On 25/10/2016 13:23, Simon Farnsworth wrote: # HG changeset patch # User Simon Farnsworth <simon...@fb.com> # Date 1477397752 25200 # Tue Oct 25 05:15:52 2016 -0700 # Branch stable # Node ID f65f9acac6c69e6f2eb90b2ed9b51d818a046f67 # Parent 970a4c13ebc320a034bc0aff21e0ef0a84157a92 test

[PATCH evolve v2] tests: use curl instead of wget

2016-10-25 Thread Simon Farnsworth
# HG changeset patch # User Simon Farnsworth <simon...@fb.com> # Date 1477397752 25200 # Tue Oct 25 05:15:52 2016 -0700 # Branch stable # Node ID f65f9acac6c69e6f2eb90b2ed9b51d818a046f67 # Parent 970a4c13ebc320a034bc0aff21e0ef0a84157a92 tests: use curl instead of wget curl is su

Re: [PATCH evolve] tests: use curl instead of wget

2016-10-25 Thread Simon Farnsworth
, and putting /etc/mercurial in place on developer systems. In turn, we build an in-house Mercurial package that bundles up all our extensions and Mercurial itself into a nice atomic lump for chef to play with. -- Simon Farnsworth ___ Mercurial-devel mailing

Re: [PATCH evolve] tests: use curl instead of wget

2016-10-25 Thread Simon Farnsworth
On 25/10/2016 02:34, Matt Harbison wrote: On Mon, 24 Oct 2016 09:37:27 -0400, Simon Farnsworth <simon...@fb.com> wrote: On 24/10/2016 14:32, Pierre-Yves David wrote: On 10/24/2016 03:26 PM, Simon Farnsworth wrote: # HG changeset patch # User Simon Farnsworth <simon...@fb.co

Re: [PATCH evolve] tests: use curl instead of wget

2016-10-24 Thread Simon Farnsworth
On 24/10/2016 14:32, Pierre-Yves David wrote: On 10/24/2016 03:26 PM, Simon Farnsworth wrote: # HG changeset patch # User Simon Farnsworth <simon...@fb.com> # Date 1477315431 25200 # Mon Oct 24 06:23:51 2016 -0700 # Branch stable # Node ID 5fbaca977cd43dfd806a3f452543ef0ed4

[PATCH evolve] tests: use curl instead of wget

2016-10-24 Thread Simon Farnsworth
# HG changeset patch # User Simon Farnsworth <simon...@fb.com> # Date 1477315431 25200 # Mon Oct 24 06:23:51 2016 -0700 # Branch stable # Node ID 5fbaca977cd43dfd806a3f452543ef0ed4a4732e # Parent 970a4c13ebc320a034bc0aff21e0ef0a84157a92 tests: use curl instead of wget curl is su

[PATCH] tests: fix test-casefolding.t

2016-10-21 Thread Simon Farnsworth
# HG changeset patch # User Simon Farnsworth <simon...@fb.com> # Date 1477063876 -3600 # Fri Oct 21 16:31:16 2016 +0100 # Node ID 1e6f773db8acf006cbfd09205b57e70252faafb8 # Parent 260af19891f2bed679a662be07d1379bb8207592 tests: fix test-casefolding.t The message had changed, but th

[PATCH 2 of 2 v3] evolve: lock the working copy early in next and prev (issue5244)

2016-10-16 Thread Simon Farnsworth
# HG changeset patch # User Simon Farnsworth <simon...@fb.com> # Date 1476636773 25200 # Sun Oct 16 09:52:53 2016 -0700 # Node ID 778468237ecf195c4eb1d87bc4f7b5d30e538c63 # Parent ee284d7c5faa5d9f17853f51c17883844b985c58 evolve: lock the working copy early in next and prev (issue5244)

[PATCH 1 of 2 v3] evolve: indent cmdnext and cmdprev ready for locking change (issue5244)

2016-10-16 Thread Simon Farnsworth
# HG changeset patch # User Simon Farnsworth <simon...@fb.com> # Date 1475939661 25200 # Sat Oct 08 08:14:21 2016 -0700 # Node ID ee284d7c5faa5d9f17853f51c17883844b985c58 # Parent 5383671ef612a1764bbbed13a7ef2d339d0a9c2d evolve: indent cmdnext and cmdprev ready for locking change (iss

Re: [PATCH 1 of 2] evolve: indent cmdnext and cmdprev ready for locking change (issue5244)

2016-10-16 Thread Simon Farnsworth
On 16/10/2016 15:46, Pierre-Yves David wrote: On 10/16/2016 04:25 PM, Simon Farnsworth wrote: # HG changeset patch # User Simon Farnsworth <simon...@fb.com> # Date 1475939661 25200 # Sat Oct 08 08:14:21 2016 -0700 # Node ID ee284d7c5faa5d9f17853f51c17883844b985c58 #

[PATCH 2 of 2 v2] evolve: lock the working copy early in next and prev (issue5244)

2016-10-16 Thread Simon Farnsworth
# HG changeset patch # User Simon Farnsworth <simon...@fb.com> # Date 1476627823 25200 # Sun Oct 16 07:23:43 2016 -0700 # Node ID 99c560f7d07d3d08b83f5f1802fc329d67e5de2e # Parent ee284d7c5faa5d9f17853f51c17883844b985c58 evolve: lock the working copy early in next and prev (issue5244)

[PATCH 1 of 2 v2] evolve: indent cmdnext and cmdprev ready for locking change (issue5244)

2016-10-16 Thread Simon Farnsworth
# HG changeset patch # User Simon Farnsworth <simon...@fb.com> # Date 1475939661 25200 # Sat Oct 08 08:14:21 2016 -0700 # Node ID ee284d7c5faa5d9f17853f51c17883844b985c58 # Parent 5383671ef612a1764bbbed13a7ef2d339d0a9c2d evolve: indent cmdnext and cmdprev ready for locking change (iss

Re: [PATCH 2 of 2] evolve: lock the working copy early in next and prev (issue5244)

2016-10-16 Thread Simon Farnsworth
On 16/10/2016 12:43, Pierre-Yves David wrote: On 10/08/2016 05:18 PM, Simon Farnsworth wrote: # HG changeset patch # User Simon Farnsworth <simon...@fb.com> # Date 1475939634 25200 # Sat Oct 08 08:13:54 2016 -0700 # Node ID 8a0c9c0158b3e9574a4571af3dce9978844b825d #

[PATCH] templater: handle division by zero in arithmetic

2016-10-09 Thread Simon Farnsworth
# HG changeset patch # User Simon Farnsworth <simon...@fb.com> # Date 1476025760 25200 # Sun Oct 09 08:09:20 2016 -0700 # Node ID ad830281f2cd1a6fd2249813a8a1ceddf3d0d2e8 # Parent 8e42dfde93d10e099040e9b57c70b7774235d883 templater: handle division by zero in arithmetic For now, jus

Re: [PATCH v2] templater: provide arithmetic operations on integers

2016-10-09 Thread Simon Farnsworth
On 09/10/2016 16:51, Yuya Nishihara wrote: On Sun, 9 Oct 2016 05:53:25 -0700, Simon Farnsworth wrote: # HG changeset patch # User Simon Farnsworth <simon...@fb.com> # Date 1476017464 25200 # Sun Oct 09 05:51:04 2016 -0700 # Node ID 2e2c959de0fe2c17bf6c5f47c01035a36f13c593 #

[PATCH v2] templater: provide arithmetic operations on integers

2016-10-09 Thread Simon Farnsworth
# HG changeset patch # User Simon Farnsworth <simon...@fb.com> # Date 1476017464 25200 # Sun Oct 09 05:51:04 2016 -0700 # Node ID 2e2c959de0fe2c17bf6c5f47c01035a36f13c593 # Parent dbcef8918bbdd8a64d9f79a37bcfa284a26f3a39 templater: provide arithmetic operations on integers The ter

Re: [PATCH RFC] templater: provide ring operations on integers

2016-10-08 Thread Simon Farnsworth
This is RFC because I have no idea what I'm doing in the parser. If someone at the sprint has 5 minutes available to educate me, I can update this to a better version. On 08/10/2016 18:24, Simon Farnsworth wrote: # HG changeset patch # User Simon Farnsworth <simon...@fb.com> # Date 1475

[PATCH RFC] templater: provide ring operations on integers

2016-10-08 Thread Simon Farnsworth
# HG changeset patch # User Simon Farnsworth <simon...@fb.com> # Date 1475943860 25200 # Sat Oct 08 09:24:20 2016 -0700 # Node ID e89699ba5c9f0bf883bfae7c485e50219b90b2f9 # Parent 91a3c58ecf938ed675f5364b88f0d663f12b0047 templater: provide ring operations on integers The termwidth te

[PATCH 1 of 2] evolve: indent cmdnext and cmdprev ready for locking change (issue5244)

2016-10-08 Thread Simon Farnsworth
# HG changeset patch # User Simon Farnsworth <simon...@fb.com> # Date 1475939661 25200 # Sat Oct 08 08:14:21 2016 -0700 # Node ID ee284d7c5faa5d9f17853f51c17883844b985c58 # Parent 5383671ef612a1764bbbed13a7ef2d339d0a9c2d evolve: indent cmdnext and cmdprev ready for locking change (iss

[PATCH 2 of 2] evolve: lock the working copy early in next and prev (issue5244)

2016-10-08 Thread Simon Farnsworth
# HG changeset patch # User Simon Farnsworth <simon...@fb.com> # Date 1475939634 25200 # Sat Oct 08 08:13:54 2016 -0700 # Node ID 8a0c9c0158b3e9574a4571af3dce9978844b825d # Parent ee284d7c5faa5d9f17853f51c17883844b985c58 evolve: lock the working copy early in next and prev (issue5244)

Re: [PATCH] merge: add conflict labels to merge command

2016-10-08 Thread Simon Farnsworth
On 08/10/2016 11:37, Pierre-Yves David wrote: On 10/08/2016 11:35 AM, Simon Farnsworth wrote: On 08/10/2016 11:31, Pierre-Yves David wrote: On 10/08/2016 10:26 AM, Simon Farnsworth wrote: # HG changeset patch # User Simon Farnsworth <simon...@fb.com> # Date 1475855510 25200 # Fri

Re: [PATCH] merge: add conflict labels to merge command

2016-10-08 Thread Simon Farnsworth
On 08/10/2016 11:31, Pierre-Yves David wrote: On 10/08/2016 10:26 AM, Simon Farnsworth wrote: # HG changeset patch # User Simon Farnsworth <simon...@fb.com> # Date 1475855510 25200 # Fri Oct 07 08:51:50 2016 -0700 # Node ID 9293c425580b06b3ab10f9648b35e4a982cc5c67 #

  1   2   >