D3665: graph: improve graph output by using Unicode characters

johnstiles added a comment. Thanks for the assist, @smf ! I appreciate it. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3665 To: johnstiles, #hg-reviewers, spectral, indygreg Cc: quark, spectral, indygreg, smf, yuja, mercurial-devel

D3665: graph: improve graph output by using Unicode characters

johnstiles added a comment. 朗 Next patch, emoji! REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3665 To: johnstiles, #hg-reviewers, spectral, indygreg Cc: quark, spectral, indygreg, smf, yuja, mercurial-devel

D3665: graph: improve graph output by using Unicode characters

johnstiles added a comment. Thanks for the concrete feedback. I've uploaded a new diff. The (EXPERIMENTAL) tag has been added and I am now using `hg export` to generate the diff. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3665 To: johnstiles,

D3665: graph: improve graph output by using Unicode characters

johnstiles added a comment. I don’t disagree with your premise, but the comments section of this patch are not really the right venue for this discussion. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3665 To: johnstiles, #hg-reviewers, spectral Cc: quark,

D3665: graph: improve graph output by using Unicode characters

johnstiles added a comment. Looks like your font is missing the dashed vertical line, and has an oddly small regular-circle glyph. I don't recognize the font at all so I can't really speak much more to that. Fortunately though... (a) it's an extension which isn't on by default (b)

D3665: graph: improve graph output by using Unicode characters

johnstiles added a comment. For what it's worth, it works great on Linux, so no need to feel sad. That's my primary dev environment. If you aren't interested in actually testing the extension itself I'm not sure why you are posting here, but thank you for the feedback about `type con`

D3665: graph: improve graph output by using Unicode characters

johnstiles added a comment. Can you provide a screenshot of the actual Windows behavior? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3665 To: johnstiles, #hg-reviewers, spectral Cc: quark, spectral, indygreg, smf, yuja, mercurial-devel

D3665: graph: improve graph output by using Unicode characters

johnstiles added a comment. Are you capable of running the extension? The output of `type` is irrelevant to me. The behavior of python.exe when outputting to the Windows shell is all that really matters here. If `encoding.encoding` reports UTF8, it should work or there's an Hg issue. If

D3665: graph: improve graph output by using Unicode characters

johnstiles added a comment. What are you trying to demonstrate here? I'm lost. In https://phab.mercurial-scm.org/D3665#58858, @quark wrote: > Maybe I should change cmd.exe font. But here's what I got pasting the text into the console: > > F103261: cmd.png

D3665: graph: improve graph output by using Unicode characters

johnstiles added a comment. In https://phab.mercurial-scm.org/D3665#58828, @smf wrote: > I've looked this over today and have queued this up :-) Unfortunately, though, the metadata doesn't seem right? I'm not getting your name or email (nor timestamp) for the patch. Do you want me to

D3665: graph: improve graph output by using Unicode characters

johnstiles added a comment. I have put together an album of various fonts from my discussions with @yuja earlier in the thread: https://imgur.com/a/xFkj4zv I'm a Menlo or DejaVu guy myself. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3665 To:

D3665: graph: improve graph output by using Unicode characters

johnstiles added a comment. Side note: I'm unfamiliar with the lingo here, what's +0 on a feature? Indifference? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3665 To: johnstiles, #hg-reviewers, spectral Cc: spectral, indygreg, smf, yuja, mercurial-devel

D3665: graph: improve graph output by using Unicode characters

to risk having the feature rejected at the end of the process and having nothing to show for it. In https://phab.mercurial-scm.org/D3665#58616, @smf wrote: > johnstiles (John Stiles) writes: > > > johnstiles added a comment. > > > > Hi there @indygr

D3665: graph: improve graph output by using Unicode characters

johnstiles added a comment. Hi there @indygreg and @yuja -- are you happy with the diff as it currently stands? Do you think this needs any additional work? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3665 To: johnstiles, #hg-reviewers Cc: indygreg, smf,

D3665: graph: improve graph output by using Unicode characters

johnstiles added a comment. How do the new glyphs look in PuTTY with Deja Vu? Is there anything else that you need me to look at in this patch? Just let me know if there's anything I need to do to keep things progressing. :) REPOSITORY rHG Mercurial REVISION DETAIL

D3665: graph: improve graph output by using Unicode characters

johnstiles added a comment. OK, I've fixed the latest nits in this diff, as well as changing the circle characters as discussed to: U+25CB○ <- changeset U+25CC◌ <- obsolete (as before) U+25CD◍ <- active REPOSITORY rHG Mercurial REVISION DETAIL

D3665: graph: improve graph output by using Unicode characters

johnstiles added a comment. I experimented some more in Linux and got some surprisingly different outcomes. Fallback rules definitely vary! Anyway, I think these glyphs are going to work the best across the widest variety of fonts. They are in the same character group so they should all be

D3665: graph: improve graph output by using Unicode characters

johnstiles added a comment. I'm finding that on OS X, the following two glyphs get good results in almost every font, and great results in Menlo and DejaVu Sans Mono. I wish they popped a little more in Ubuntu Mono but they are still better than the current choices. I'll switch over to

D3665: graph: improve graph output by using Unicode characters

johnstiles added a comment. In https://phab.mercurial-scm.org/D3665#57735, @indygreg wrote: > I think this is a cool idea! I could nitpick some of the glyph choices (e.g. U+233E ⌾ is really small and harder to read than `@` and U+25CC ◌ looks like a circle and therefore the standard

D3665: graph: improve graph output by using Unicode characters

johnstiles added a comment. In https://phab.mercurial-scm.org/D3665#57678, @indygreg wrote: > I installed Dejavu Sans Mono from https://dejavu-fonts.github.io/ and it works great! That's great to hear! How do you like it? It's a pretty simple extension but it definitely

D3665: graph: improve graph output by using Unicode characters

johnstiles added a comment. In https://phab.mercurial-scm.org/D3665#57675, @indygreg wrote: > FWIW, this isn't rendering nicely with PuTTY on Windows 10. The U+25EF ◯ glyph is being truncated on the right side. I'm also seeing empty squares for U+233E ⌾ and other code points. Using

D3665: graph: improve graph output by using Unicode characters

johnstiles added a comment. A proper warning is now issued when the encoding is not UTF-8, or when East-Asian ambiguous characters will be rendered as wide characters. The tests have been updated to check these warnings. Yuya, I believe this should address everything we discussed. Let me

D3665: graph: improve graph output by using Unicode characters

johnstiles added a comment. In https://phab.mercurial-scm.org/D3665#57649, @smf wrote: > johnstiles (John Stiles) writes: > > > johnstiles added a comment. > > > > yuya, I believe these patches should address all of your concerns except for `encodi

D3665: graph: improve graph output by using Unicode characters

johnstiles added a comment. yuya, I believe these patches should address all of your concerns except for `encoding._wide`. I am not sure what your expectation is for that. I don't think it would make sense to silently disable the extension if `encoding._wide` is set; IMO that would cause

D3665: graph: improve graph output by using Unicode characters

johnstiles updated this revision to Diff 8920. johnstiles added a comment. Corrected indenting issue. (In converting from 2-space to 4-space indents, I misaligned this block.) REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3665?vs=8919=8920 REVISION

D3665: graph: improve graph output by using Unicode characters

johnstiles updated this revision to Diff 8919. johnstiles added a comment. Addressed warnings found by test-check-code.t. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3665?vs=8918=8919 REVISION DETAIL https://phab.mercurial-scm.org/D3665 AFFECTED

D3665: graph: improve graph output by using Unicode characters

johnstiles updated this revision to Diff 8918. johnstiles added a comment. Converted non-ASCII characters to `\xNN' form for Python 3 compatibility. Converted sys.stdout.encoding to encoding.encoding. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3665: graph: improve graph output by using Unicode characters

johnstiles created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This extension beautifies log -G output by using Unicode characters. A terminal with UTF-8 support and a monospace Unicode font are required. REPOSITORY

D3655: graph: add outputgraph() function, called by ascii() to printthe graph to the ui.

This revision was automatically updated to reflect the committed changes. Closed by commit rHG24e517600b29: graph: add outputgraph() function, called by ascii() to print (authored by johnstiles, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3655: graph: add outputgraph() function, called by ascii() to printthe graph to the ui.

johnstiles created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This allows a cleaner entrypoint for extensions to tweak the graph output without needing to rewrite all of ascii(), or needing to manually guess where the