[PATCH] fix: fix grammar/typos in hg help -e fix

# HG changeset patch # User timeless # Date 1578597560 18000 # Thu Jan 09 14:19:20 2020 -0500 # Node ID b8915d7827251d9383879b3de1d17d0773645dc6 # Parent cb2e2b095dc930a37e4de824138e8f5133295c96 fix: fix grammar/typos in hg help -e fix diff -r cb2e2b095dc9 -r b8915d782725 hgext/fix.py

test-convert-bzr-directories.t fails

Mercurial Distributed SCM (version 4.4+11-7ebf850d3166+20171103) Bazaar 2.5.1 -- a free distributed version-control tool --- /home/timeless/hg/crewplan/tests/test-convert-bzr-directories.t +++ /home/timeless/hg/crewplan/tests/test-convert-bzr-directories.t.err @@ -56,12 +56,56 @@ converting

Re: Better release notes

Sean Farley wrote: Some good points there. Though, I didn't think we were talking about the commit message in general but rather with the special note tag: summary: change foo to bar Some technical details. More blah werd. :: notes This would be a highly curated message. Almost as if it

Re: [PATCH] histedit: improve documentation and behaviour of dates (issue4820)

Fwiw, recently someone identified that if's are roughly as expensive as method calls. I /think/ that means it'd be better for: +if self.firstdate(): +commitopts['date'] = ctx.date() +else: +commitopts['date'] = max(ctx.date(), oldctx.date()) to be managed

Re: [PATCH] bookmarks: fix HG_PENDING handling

fwiw, I really don't have the resources to push either of these forward. I was just trying to call attention to the problem. ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org

[PATCH] run-tests: improve diff intelligence [RFC]

# HG changeset patch # User timeless <timel...@mozdev.org> # Date 1487565093 0 # Mon Feb 20 04:31:33 2017 + # Node ID b04c501c22d75f368e69b3b533f71e16c17ea8b6 # Parent 693a5bb478543a986808264e586073a3ceedc38f # Available At https://bitbucket.org/timeless/mercurial-crew #

Re: [PATCH] transaction: enable hardlink backups for non-windows systems

Augie Fackler wrote: > I'm hesitant to take this because as of 10.12 macOS is pushing people > towards CIFS instead of AFP, Interesting > so this issue feels more likely to come up there. > Also, isn't it possible to mount CIFS volumes in the filesystem space on > Linux? I was going to

Re: test-merge-changedelete.t fails with my hgmerge

Bryan O'Sullivan wrote: > A long time ago, the default external merge program that we looked for was > called hgmerge, and there's still backwards compatibility code in > filemerge.py to support it. Yeah, I have some vague recollection of this. What's odd is that I'm pretty sure my hgmerge script

Re: Better release notes

Sean Farley wrote: > I assume that these commit messages were from employees with commit > access? If that's true, then that's a bit different than patch-based > review where we can edit and review the commit message / notes. Well, we had two sources: 1. Mozilla upstream, where in theory messages

Re: [PATCH 1 of 8 v4] mercurial: use best available timer for perf measurements

On Mon, Feb 13, 2017 at 12:29 PM, Simon Farnsworth wrote: > mercurial: use best available timer for perf measurements > > As documented for timer.default_timer, there are better timers available for > performance measures on some platforms. These timers don't have a set epoch, >

[PATCH] localrepo: change HG_PENDING handling

# HG changeset patch # User timeless <timel...@mozdev.org> # Date 1487089673 0 # Tue Feb 14 16:27:53 2017 + # Node ID 8d10b4c0cd6eb85098ec903c802a9602eda3a2f1 # Parent f2ad0d8047009e6e58ab1fa34ae7107714f5dc30 # Available At https://bitbucket.org/timeless/mercurial-crew #

Re: [PATCH 2 of 2 stable] debian: update copyright years

timeless wrote: > We should really write a test for this sort of thing. Yes it's a bit > silly, but it'd be helpful to catch it faster than 13 months late... Augie Fackler wrote: > Sure, but carefully, for the reasons expressed in > https://www.mercurial-scm.org/pipermail/mercuria

Inconsistent HG_PENDING handling

bookmarks.py if 'HG_PENDING' in encoding.environ: try: bkfile = repo.vfs('bookmarks.pending') dirstate.py def _trypending(root, vfs, filename): '''Open file to be read according to HG_PENDING environment variable This opens '.pending' of specified 'filename' only

Re: [PATCH 2 of 2 stable] debian: update copyright years

We should really write a test for this sort of thing. Yes it's a bit silly, but it'd be helpful to catch it faster than 13 months late... ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org

Re: Better release notes

FWIW, @nokia, I looked at our commit message based changelog and decided it wasn't useful, so I maintained a curated list. Yes, it's frustrating that one has to do it, but it's much better than most alternatives. One release fwiw: http://browser.garage.maemo.org/news/4/

[PATCH] help: replace patterns with matching

# HG changeset patch # User timeless <timel...@mozdev.org> # Date 1485239979 0 # Tue Jan 24 06:39:39 2017 + # Branch stable # Node ID efe7a979f88411014449f28cc3cc873187d2e0f8 # Parent 7bfe02b57695900ef996989286c1fdc2a13aec82 # Available At https://bitbucket.org/timeless/mercuria

Re: [PATCH] util: add length argument to util.buffer()

Yuya Nishihara wrote: > On Sun, 15 Jan 2017 17:04:24 +0530, Pulkit Goyal wrote: >> # HG changeset patch >> # User Pulkit Goyal <7895pul...@gmail.com> >> # Date 1484404515 -19800 >> # Sat Jan 14 20:05:15 2017 +0530 >> # Node ID 087be8a1c7a0452beee36ca23d7978d107b72315 >> # Parent

Re: [PATCH V3] rebase: fail-fast the pull if working dir is not clean (BC)

Gregory Szorc wrote: > Your reasoning about users wanting extra context to help them debug is sound. > But I'm surprised nobody mentioned that the "error.Abort" exception takes an > optional keyword "hint" argument that prints an extra message to provide that > context. > When we know why an

Re: [PATCH 5 of 5] test-obsolete: stabilize output on platforms without 'serve' support

I like this series (I've been thinking about doing things like it for a while) ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Re: [PATCH] rebase: fail-fast pull if working dir is not clean

Thanks for this. I've been meaning to do it... ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Re: [PATCH 2 of 3] chg: start server at a unique address

Jun Wu wrote: > Pid namespace breaks mercurial lock, which is a symlink with the content > "host:pid". Would adjusting the format to: host:pid:starttime:boottime fix this? Sadly, it seems like process start time is actually stored as jiffies since system boot on Linux, and NTP can make

Re: [PATCH] error: make it clear that ProgrammingError is for mercurial developers

Thanks ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Re: [PATCH 1 of 2] error: add ProgrammingError

Jun Wu wrote: > +class ProgrammingError(RuntimeError): > +"""Raised if a developer has made some mistake""" I object to "developer" you probably mean "mercurial (core or extension) developer", not "generic developer". ___ Mercurial-devel mailing

Re: [PATCH 02 of 10 shelve-ext] shelve: add an ability to write json to a new type of shelve files

We should probably have check-code complain about it and explain why we don't want it. Self-documenting code is our friend. ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Re: [PATCH 1 of 5] posix: move checkexec test file to .hg/cache

Gregory Szorc wrote: > The only scenario I can think of is someone who has moved .hg to another > filesystem and symlinked .hg in the working directory to it. I guess that's > plausible. Ugh. I can picture doing this. It's possible I've already done it...

Re: [PATCH V2] evolve: improve error message if unstable changes are disallowed

I'm not going to stop this from going in, it's definitely an improvement. >> @@ -3299,7 +3301,8 @@ >> head = repo[heads.first()] >> if _disallowednewunstable(repo, revs): >> raise error.Abort(_("cannot fold chain not ending with a head "\ >> -"or

Re: [PATCH 1 of 2] dispatch: move part of callcatch to scmutil

fwiw, it is possible to keep blame for this if you really wanted to. The approach is: 7ef2ebf5cdf91192a66b461ff56f653a65e65dd7->x x: copy scmutil.py -> scmutil_.py 7ef2ebf5cdf91192a66b461ff56f653a65e65dd7->y y: copy dispatch.py-> scmutil_.py delete lines from scmutil_.py x+y->z z: resolve

Re: [PATCH 7 of 8] crecord: change help text for the space key dynamically

Jun Wu wrote: > +_('space: unselect') if selected else _('space: select'), I favor deselect (13million) over unselect (2.5million) -- numbers from Google. ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org

Re: [PATCH 6 of 8] crecord: rewrite status line text (BC)

Jun Wu wrote: > Select hunks to apply. [x]=selected **=collapsed c: confirm q: abort That's pretty good, but could we use a pipe* before ` [x]`? Possibly omitting the `.`, either as: Select hunks to apply | [x]=selected **=collapsed c: confirm q: abort or Select hunks to apply. |

Re: [PATCH evolve-ext] evolve: improve error message if unstable changes are disallowed

Mateusz Kwapich wrote: > Pulkit wrote: >> +raise error.Abort(_("cannot prune in the middle of a stack\n"\ >> +"new unstable changesets are not allowed")) > This error doesn't have hint - maybe we could use it for that purpose. I should spend some time

Re: [PATCH 01 of 10 layering] dirstateguard: move to new module so I can break some layering violations

Yuya Nishihara wrote: > Is copy-and-remove a preferred way for this kind of refactoring? I have > an unsent patch that splits revset.py, so I want to know which is better. Augie Fackler wrote: > I'd prefer it slightly, because it makes the blame history a little bit more > intact in the long

Can we automatically recognize when we should be fulfilling our deprecation promsie?

Augie Fackler wrote: > We said we'd delete this after 3.8. It's time. > -ui.deprecwarn("missing attribute '%s', use @command decorator " > - "to register '%s'" % (attr, cmd), '3.8') It feels like we should be able to have a test which complains if we have deprecwarns

Re: [PATCH 3 of 9] chgserve: pre-import extensions

Jun Wu wrote: > (pretend to be timeless) not bad, but... >> pre-importing extensions does not have side effects. > do the parsing for this is (pre-importing [extensions]) does not: pre-importing (e

Re: Checking for conflict before merge

Notably hg up -C . will leave .rej / .orig files... Offhand, I'd probably play w/ the `share` extension or something, and basically have a working repository which I could blow away each time to avoid worrying too much about the working directory getting dirty.

Re: [PATCH 08 of 10] repair: migrate revlogs during upgrade

Gregory Szorc wrote: > +return changelog.changelog(repo.svfs) > +elif path.endswith('00manifest.i'): Does mercurial use `else` after `return` or does it omit them? > + store replacement complete; repository was inconsistent for 0.0s Do we want to allow tests to run a bit slower

Re: [PATCH 05 of 10] repair: obtain and validate requirements for upgraded repo

Gregory Szorc wrote: > +'missing: %s') % ', '.join(sorted(missingreqs))) I'd argue ', ' should be _(', '), although we probably don't manage this well or consistently... Also, is it too early to start talking about -T support? -- See `hg debuginstall`...

Re: [PATCH 04 of 10] repair: identify repository deficiencies

Gregory Szorc wrote: > A command that upgrades repositories but doesn't say what it is doing shouldn't it still mention that it isn't doing the work? ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org

Re: [PATCH 2 of 8] py3: add os.fsdecode() as pycompat.fsdecode()

Pulkit Goyal wrote: > +# In Python 2, fsdecode() have a very chances to recieve bytes. So it's receive ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Re: [PATCH] help: show help for disabled extensions(issue5228)

Pulkit Goyal wrote: > This patch does not exactly solve issue5228 but it results in a better If it doesn't solve the issue, should the issue be tagged in the commit summary? ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org

Re: [PATCH 2 of 2] commands: introduce `hg display`

Gregory Szorc wrote: > @@ -2019,6 +2026,13 @@ Dish up an empty repo; serve it cold. >diff repository (or selected files) > > > + > + display > + > + > + show various repository information > + > + > >export > Will /help/display list the views it supports?

Re: [PATCH 1 of 5 STABLE] tests: invoke printenv.py via sh -c for test portability

timeless wrote: > I'm sure this is already in, but wouldn't it be better to use a > $PYTHON than `sh -c`? FUJIWARA Katsunori wrote: > I don't have strong opinion for using "sh -c". > > But, if we use $PYTHON instead of `sh -c` (= backing d19787db6fe0 > out),

Re: [PATCH 3 of 4] tests: merge 'test-push-validation.t' into 'test-push.t'

Pierre-Yves David wrote: > tests: merge 'test-push-validation.t' into 'test-push.t' > > That test file is very small and is merge with the new 'test-push.t'. No logic > is changed but repository name are update to avoid collision. > > We don't register this as a copy because is actually a "ypoc"

Re: Topics [was: news from the topic experiment]

Sean Farley wrote: > For what it's worth, I've started to work on another repo implementing > what Erik suggested. It removes 'stacks' (since that's obviously out of > scope) and implements a topic-like branch workflow. So far, it's been a > good experiment and requires very little change. I'll

to abort / to continue (UX)

timeless wrote: > technically this isn't wonderful, if you use bookmarks, `hg up -C .` > isn't equivalent to `hg up -C {currentbookmark}`, and if you're using > hg-git or something that puts significant weight on your active > bookmark, this can lead you into some very unfortunate we

Re: [PATCH v5] copy: distinguish "file exists" cases and add a hint (BC)

Kevin Bullock wrote: > I'm not totally clear on what our approach to translations during a freeze is > either. I'm going by the freeze rules on the wiki, and the fact that > translation always happens on stable anyway, both of which lead me to believe > it should be okay? We should probably

Re: [PATCH 1 of 5 STABLE] tests: invoke printenv.py via sh -c for test portability

I'm sure this is already in, but wouldn't it be better to use a $PYTHON than `sh -c`? On Fri, Oct 28, 2016 at 2:16 PM, FUJIWARA Katsunori wrote: > # HG changeset patch > # User FUJIWARA Katsunori > # Date 1477676685 -32400 > # Sat Oct 29

[PATCH 1 of 3] rebase: rename merge to mergemod

# HG changeset patch # User timeless <timel...@mozdev.org> # Date 1478112967 0 # Wed Nov 02 18:56:07 2016 + # Node ID 78cf30254354eafb993ed7f226eb70d7b7abb6dc # Parent b032a7b676c6637b2ac6f3ef29431013b15a08f9 # Available At https://bitbucket.org/timeless/mercurial-crew #

[PATCH 2 of 3] cmdutil: refactor checkunresolved

# HG changeset patch # User timeless <timel...@mozdev.org> # Date 1478112353 0 # Wed Nov 02 18:45:53 2016 + # Node ID 8dae4ad6767cf3456dd2fc4b2a7b478d855091f7 # Parent 78cf30254354eafb993ed7f226eb70d7b7abb6dc # Available At https://bitbucket.org/timeless/mercurial-crew #

[PATCH 3 of 3] rebase: check for conflicts before continuing

# HG changeset patch # User timeless <timel...@mozdev.org> # Date 1478113169 0 # Wed Nov 02 18:59:29 2016 + # Node ID e9528bc734ce94456dd2389b4ea318278139c206 # Parent 8dae4ad6767cf3456dd2fc4b2a7b478d855091f7 # Available At https://bitbucket.org/timeless/mercurial-crew #

Re: [PATCH] hgweb: fix the MRO in Python 3

> Is there a checkcode test for this? Martijn Pieters wrote: > No, but tests simply fail when you make this mistake. > In this *specific case* that was only visible in the Python 3 tests because > the base classes used in Python 2 were old-style classes, so in *Python 2* > the base class order

Re: [PATCH 15 of 16] copies: make _checkcopies handle copy sequences spanning the TCA (issue4028)

> + note: possible conflict - f3b was renamed multiple times to: > + f3e > + f3d >merging f4e and f4a to f4e >warning: can't find ancestor for 'f3d' copied from 'f3b'! I know this isn't where the message was introduced, but I'm having a hard time understanding "renamed multiple

Re: [PATCH 07 of 16] copies: detect graft-like merges

Gábor Stefanik wrote: > +# overridden We still need to know a real common ancestor in this case We You're missing periods before `We` twice in this line... ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org

Re: [PATCH RFC] perf: add asv benchmarks

On Wed, Oct 12, 2016 at 4:35 AM, Philippe Pepiot wrote: > +"show_commit_url": "https://www.selenic.com/hg/rev/;, Not a review, but I believe this should be: https://www.mercurial-scm.org/repo/hg/ ___ Mercurial-devel

Re: [PATCH RFC] commands: introduce `hg display`

I'm +1 to this proposal :-) ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Re: [PATCH] store: py26 compat, don't use a dict comprehension

Martijn Pieters wrote: > store: py26 compat, don't use a dict comprehension > -cmap = {x:x for x in asciistr} Can we checkcode this? ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org

Re: [PATCH RFC] templater: provide ring operations on integers

Simon Farnsworth wrote: > @@ -33,6 +33,9 @@ > +"+": (10, None, None, ("+", 10), None), > +"-": (10, None, ("negate", 10), ("-", 10), None), > +"*": (12, None, None, ("*", 12), None), Is it reasonable for me to ask for some user facing documentation of this? Possibly just an example.

Re: [PATCH 2 of 8] bisect: rename 'check_code' to match our naming scheme

Pierre-Yves David wrote: > bisect: rename 'check_code' to match our naming scheme I think you mean check_state ;-) > -def check_state(state, interactive=True): > +def checkstate(state, interactive=True): ___ Mercurial-devel mailing list

Re: [PATCH 7 of 8] bisect: build a displayer only once

Pierre-Yves David wrote: > There is multiple spot using this, building it early will help to extract more fwiw this should be `there are multiple places` -- [are (plural verb), multiple (plural hint), plural-noun] should all agree; `places` is a better noun than `spots`.

Re: [PATCH WIP] help: show help content for disabled extension

Have we considered supporting `hg help churn.churn` where the first churn is a (possibly) disabled extension name, and the second is the name of a command within that extension? I'm not saying we should do this right away, but I can see some advantages to being able to support it later...

Re: [PATCH] hgweb: fix the MRO in Python 3

Is there a checkcode test for this? ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Re: [PATCH 2 of 7] copies: update _checkcopies to work in a rotated DAG

Gábor Stefanik wrote: > copies: update _checkcopies to work in a rotated DAG I'd argue this should be tagged (BC). I absolutely support this change, it should be changed, it is a bug. But the reason I'd argue that it's a change is that a repository constructed along this path will result in a

Re: [PATCH 3 of 3] revlog: read index data using mmap

http://bugs.python.org/issue16212 Title: mmap() dumps core upon resizing the underlying file Type: crash Stage: needs patch Components: IO Versions: Python 3.4, Python 3.2, Python 3.3 > It's not specific to the zero size truncation, it's enough if the file size > decreases beyond a page border.

Re: [PATCH 02 of 11] copies: limit is an optimization, and doesn't provide guarantees (issue4028)

As noted elsewhere, the issue tag should only be applied to the commit that actually fixes the issue, not any commits leading up to that commit. ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org

Re: [PATCH 01 of 11] copies: style fixes and add comment (issue4028)

> @@ -331,7 +331,8 @@ > m2 = c2.manifest() > ma = ca.manifest() > > -copy1, copy2, = {}, {} > +# see checkcopies documentation below for these dicts > +copy1, copy2 = {}, {} I've been meaning to ask: Do we know why this is a -1+2 instead of a -0+1 diff?

Re: [PATCH 00 of 11 ] graft: support grafting across move/copy (issue4028)

You shouldn't be sending part 0, that's been deprecated for a while. I wonder why your system encouraged it... ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Re: [PATCH] copy: distinguish "file exists" cases and add a hint (BC)

Pierre-Yves David wrote: > I'm curious about the timeless reasoning around using "replace" for a pure > book keeping operation that does not replace the file content. (But not > challenging that timeless is most probably right). Timeless can you > elaborate a bit ? It rep

Re: [PATCH 3 of 3] demandimport: error out early on missing attribute of non package (issue5373)

ent module isn't a package, all valid attributes must be >> obtained >> from it. We can raise ImportError early if any attributes not found. > > > This seems fine. I've pushed it. > > I assume this superseed timeless series about reject? > > -- > Pierre-Yves D

Re: [PATCH 3 of 3 v3] demandimport: reject contextlib._GeneratorContextManager on Py < 3.2

Siddharth Agarwal wrote: > As a general thing I don't think we should be spending time trying to fix > this implementation of demandimport on Python 3 at all. This isn't really about python3, it's just about foreign code that expects a certain object to look a certain way, but because of

[PATCH 2 of 3 v3] demandimport: replace distutils.msvc9compiler ignore with reject

# HG changeset patch # User timeless <timel...@mozdev.org> # Date 1474484334 0 # Wed Sep 21 18:58:54 2016 + # Node ID adb54fd7d90f0ca607432ed7ae884da55ec427de # Parent 33884775ee4b22109085387b0317aa17db73c483 # Available At https://bitbucket.org/timeless/mercurial-crew #

[PATCH 3 of 3 v3] demandimport: reject contextlib._GeneratorContextManager on Py < 3.2

# HG changeset patch # User timeless <timel...@mozdev.org> # Date 1474429683 0 # Wed Sep 21 03:48:03 2016 + # Node ID 0070696439eab002f6dd32bcb40eb671daff800a # Parent adb54fd7d90f0ca607432ed7ae884da55ec427de # Available At https://bitbucket.org/timeless/mercurial-crew #

[PATCH 1 of 3 v3] demandimport: suppport rejecting modules based on requested properties

# HG changeset patch # User timeless <timel...@mozdev.org> # Date 1474484347 0 # Wed Sep 21 18:59:07 2016 + # Node ID 33884775ee4b22109085387b0317aa17db73c483 # Parent 982fe7cdb28bb263a96b1bc2c9c3b8aedb025ab6 # Available At https://bitbucket.org/timeless/mercurial-crew #

Re: [PATCH 3 of 3 v2] demandimport: reject contextlib._GeneratorContextManager on Py < 3.2

please hold off on v2. I'd like to try a v3 that handles distutils.msvc9compiler -- it turns out that processfromlist might really be too late and that I may have to really split out the iteration of fromlist into two places. ___ Mercurial-devel mailing

Re: [PATCH 5 of 5] demandimport: reject contextlib._GeneratorContextManager on Py < 3.2

Yuya Nishihara wrote: > Can't we simply ignore 'contextlib' ? I had a patch that did that. It felt gross (it clearly wasn't very elegant) > Since contextlib is imported by demandimport.py, there's no benefit to delay > importing contextlib. So, demandimport could just return a given module if

[PATCH 1 of 3 v2] demandimport: refactor processfromlist to ensure consistent handling

# HG changeset patch # User timeless <timel...@mozdev.org> # Date 1474429251 0 # Wed Sep 21 03:40:51 2016 + # Node ID 32a4cb17f935c570817249721401e0d62033987d # Parent 982fe7cdb28bb263a96b1bc2c9c3b8aedb025ab6 # Available At https://bitbucket.org/timeless/mercurial-crew #

[PATCH 3 of 3 v2] demandimport: reject contextlib._GeneratorContextManager on Py < 3.2

# HG changeset patch # User timeless <timel...@mozdev.org> # Date 1474429683 0 # Wed Sep 21 03:48:03 2016 + # Node ID b2d5ad899bbb3c6eace4547b975c84f155066f0b # Parent 20111b4d031e63596b93e162af9b8ca3ff1c98af # Available At https://bitbucket.org/timeless/mercurial-crew #

[PATCH 3 of 3] help: add sections for revsets

# HG changeset patch # User timeless <timel...@mozdev.org> # Date 1474478613 0 # Wed Sep 21 17:23:33 2016 + # Node ID 692f1e17fb708d83e6022fc1ef1fb69366d7ee45 # Parent 2ed8375eb6ca1fe2f00fac49f1b9c79d705a522a # Available At https://bitbucket.org/timeless/mercurial-crew #

[PATCH 1 of 3] help: clarify quotes are needed for filesets.size expressions

# HG changeset patch # User timeless <timel...@mozdev.org> # Date 1474475617 0 # Wed Sep 21 16:33:37 2016 + # Node ID 40410e96c0a2de344edd5a25a7d996731124ee45 # Parent 285a8c3e53f2183438f0cdbc238e4ab851d0d110 # Available At https://bitbucket.org/timeless/mercurial-crew #

[PATCH 2 of 3] help: move revsets.## documentation into infix section

# HG changeset patch # User timeless <timel...@mozdev.org> # Date 1474478585 0 # Wed Sep 21 17:23:05 2016 + # Node ID 2ed8375eb6ca1fe2f00fac49f1b9c79d705a522a # Parent 40410e96c0a2de344edd5a25a7d996731124ee45 # Available At https://bitbucket.org/timeless/mercurial-crew #

[PATCH 2 of 5] tests: clarify demandimport disabled state

# HG changeset patch # User timeless <timel...@mozdev.org> # Date 1474429177 0 # Wed Sep 21 03:39:37 2016 + # Node ID 982fe7cdb28bb263a96b1bc2c9c3b8aedb025ab6 # Parent 24d85146985b7d2fef3c27b97d4be983e57ae5c7 # Available At https://bitbucket.org/timeless/mercurial-crew #

[PATCH 5 of 5] demandimport: reject contextlib._GeneratorContextManager on Py < 3.2

# HG changeset patch # User timeless <timel...@mozdev.org> # Date 1474429683 0 # Wed Sep 21 03:48:03 2016 + # Node ID e07c3d398573f74a2e382deb06462bdc15ed437f # Parent 894cc47eb82a85d167f5717c9fe0a31392e5bb97 # Available At https://bitbucket.org/timeless/mercurial-crew #

[PATCH 17 of 17] tests: favor single quotes for wrapping hg help

# HG changeset patch # User timeless <timel...@mozdev.org> # Date 1474415360 0 # Tue Sep 20 23:49:20 2016 + # Node ID 07306ec6e0c4e0accdaf3efee348361f36910295 # Parent 0f8eca5689fad5be2cef54141c8185b8bd5639f3 # Available At https://bitbucket.org/timeless/mercurial-crew #

[PATCH 14 of 17] obsolete: use single quotes in use warning

# HG changeset patch # User timeless <timel...@mozdev.org> # Date 1474415299 0 # Tue Sep 20 23:48:19 2016 + # Node ID 7deb4156b10a2dc83fc0278fb5f9fcb42eb17f25 # Parent 745cb8e2928b177706cfee03f298ed0873c9d538 # Available At https://bitbucket.org/timeless/mercurial-crew #

[PATCH 13 of 17] localrepo: use single quotes in use warning

# HG changeset patch # User timeless <timel...@mozdev.org> # Date 1474415288 0 # Tue Sep 20 23:48:08 2016 + # Node ID 745cb8e2928b177706cfee03f298ed0873c9d538 # Parent 07753ca55667d0079f2418084dbf4ebab523cb35 # Available At https://bitbucket.org/timeless/mercurial-crew #

[PATCH 15 of 17] util: use single quotes in use warning

# HG changeset patch # User timeless <timel...@mozdev.org> # Date 1474415310 0 # Tue Sep 20 23:48:30 2016 + # Node ID 91d602cb454e0f5a7133e8302fa0cf1d86c7bfbe # Parent 7deb4156b10a2dc83fc0278fb5f9fcb42eb17f25 # Available At https://bitbucket.org/timeless/mercurial-crew #

[PATCH 16 of 17] samplehgrcs: use single quotes in use warning

# HG changeset patch # User timeless <timel...@mozdev.org> # Date 1474415340 0 # Tue Sep 20 23:49:00 2016 + # Node ID 0f8eca5689fad5be2cef54141c8185b8bd5639f3 # Parent 91d602cb454e0f5a7133e8302fa0cf1d86c7bfbe # Available At https://bitbucket.org/timeless/mercurial-crew #

[PATCH 12 of 17] help: use single quotes in use warning

# HG changeset patch # User timeless <timel...@mozdev.org> # Date 1474415266 0 # Tue Sep 20 23:47:46 2016 + # Node ID 07753ca55667d0079f2418084dbf4ebab523cb35 # Parent b9f5707703a6167686435348dc095a94c22b44b5 # Available At https://bitbucket.org/timeless/mercurial-crew #

[PATCH 05 of 17] pager: use single quotes in use warning

# HG changeset patch # User timeless <timel...@mozdev.org> # Date 1474415089 0 # Tue Sep 20 23:44:49 2016 + # Node ID 8086d07155c64bd12d28437eb0e403601293be9a # Parent 0ce8fb6cabe0657d1da7f741870bf9050f32fd9c # Available At https://bitbucket.org/timeless/mercurial-crew #

[PATCH 08 of 17] histedit: use single quotes in use warning

# HG changeset patch # User timeless <timel...@mozdev.org> # Date 1474415125 0 # Tue Sep 20 23:45:25 2016 + # Node ID 912436c3e806e4715a7a9f7af78895f91a3e6c32 # Parent 45ccea8f0646176c5e9801113f91df201bd9be31 # Available At https://bitbucket.org/timeless/mercurial-crew #

[PATCH 06 of 17] mq: use single quotes in use warning

# HG changeset patch # User timeless <timel...@mozdev.org> # Date 1474415099 0 # Tue Sep 20 23:44:59 2016 + # Node ID 2da79d8f58abd0b83dd605e65d26b16c31aab5ff # Parent 8086d07155c64bd12d28437eb0e403601293be9a # Available At https://bitbucket.org/timeless/mercurial-crew #

[PATCH 04 of 17] rebase: use single quotes in use warning

# HG changeset patch # User timeless <timel...@mozdev.org> # Date 1474415068 0 # Tue Sep 20 23:44:28 2016 + # Node ID 0ce8fb6cabe0657d1da7f741870bf9050f32fd9c # Parent ca073d2379d406e610450b957a955bf05ebf64f3 # Available At https://bitbucket.org/timeless/mercurial-crew #

[PATCH 10 of 17] serve: use single quotes in use warning

# HG changeset patch # User timeless <timel...@mozdev.org> # Date 1474415222 0 # Tue Sep 20 23:47:02 2016 + # Node ID 2134ed21fb04e4f1d0585ca46896b2698bd3cf70 # Parent 3f18ad2b5443cad55dd5e720a16ff03638e1878f # Available At https://bitbucket.org/timeless/mercurial-crew #

[PATCH 01 of 17] remove: specify hg in added warning

# HG changeset patch # User timeless <timel...@mozdev.org> # Date 1472852760 0 # Fri Sep 02 21:46:00 2016 + # Node ID 31e48b2f0db6a01c6c7f64a54d12719c48033eed # Parent 285a8c3e53f2183438f0cdbc238e4ab851d0d110 # Available At https://bitbucket.org/timeless/mercurial-crew #

[PATCH 02 of 17] update: use single quotes in use warning

# HG changeset patch # User timeless <timel...@mozdev.org> # Date 1472852973 0 # Fri Sep 02 21:49:33 2016 + # Node ID 00192f6bab14f19bfd58738b732ea1a2d24317ea # Parent 31e48b2f0db6a01c6c7f64a54d12719c48033eed # Available At https://bitbucket.org/timeless/mercurial-crew #

[PATCH 03 of 17] push: update help hint to point to config.paths section

# HG changeset patch # User timeless <timel...@mozdev.org> # Date 1474402358 0 # Tue Sep 20 20:12:38 2016 + # Node ID ca073d2379d406e610450b957a955bf05ebf64f3 # Parent 00192f6bab14f19bfd58738b732ea1a2d24317ea # Available At https://bitbucket.org/timeless/mercurial-crew #

Re: [PATCH V3] update: warn if cwd was deleted

Yeah, cwd is especially foreign for Windows users. Perhaps: current directory was removed (consider changing to repo root: %s) On Sep 7, 2016 3:43 PM, "Kevin Bullock" wrote: > > On Sep 5, 2016, at 05:32, Stanislau Hlebik wrote: > > > > # HG

Re: [PATCH V3] update: warn if cwd was deleted

There should probably be a colon after "root" On Sep 5, 2016 6:33 AM, "Stanislau Hlebik" wrote: > # HG changeset patch > # User Stanislau Hlebik > # Date 1473071480 25200 > # Mon Sep 05 03:31:20 2016 -0700 > # Node ID b43aa94306b8f50852a8176afec3839aa3826467 >

[PATCH] crecord: properly handle files with No newline at eof (issue5268)

# HG changeset patch # User timeless <timel...@mozdev.org> # Date 1472847337 0 # Fri Sep 02 20:15:37 2016 + # Node ID 68a20f02785b24f08b13e21ffc9e2a05031b07f8 # Parent f148bfa40489269be2e48046734f81065129847a # Available At https://bitbucket.org/timeless/mercurial-crew #

Re: [PATCH 4 of 8 v2] commands: stop abusing int-ness of Python booleans

Can we change ">1" to ">=2" to make this clearer? On Aug 31, 2016 5:33 PM, "Augie Fackler" wrote: > > > On Aug 31, 2016, at 17:19, Kevin Bullock org> wrote: > > > >> On Aug 30, 2016, at 15:16, Augie Fackler wrote: > >> > >> #

Re: [PATCH 8 of 8 v2] help: mark boolean flags with a ^ and explain that they can be negated (RFC)

> options ([+] can be repeated, [?] are flags): This is closer to how I was envisioning it. > Having --no-noninteractive seems really sad. We could make --noninteractive > hidden and then advertise --no-interactive as the long version. Agreed > Also, I don't think --no-no-backup is a good

Re: [PATCH 8 of 8 v2] help: mark boolean flags with a ^ and explain that they can be negated (RFC)

In principle you shouldn't use multi occur to guard this. if multioccur: -header += (_(" ([+] can be repeated)")) +m = _( +" ([+] can be repeated, flags marked ^ can be negated with --no-)") +header += (m) It's too hard for me you write the correct logic

  1   2   >