pulkit abandoned this revision.
pulkit added a comment.
In https://phab.mercurial-scm.org/D1678#29063, @yuja wrote:
> > Since we are calling them at each command level, it will be better to
call unhidehashlikerevs() in `scmutil.revrange|revsingle`.
>
> I thought about that, but
yuja added a comment.
> Since we are calling them at each command level, it will be better to call
unhidehashlikerevs() in `scmutil.revrange|revsingle`.
I thought about that, but `scmutil.rev*()` would have to return new filtered
`repo`
object, which didn't seem nice. And mutating a
pulkit added a comment.
In https://phab.mercurial-scm.org/D1678#28729, @yuja wrote:
> In https://phab.mercurial-scm.org/D1678#28686, @pulkit wrote:
>
> > @yuja am I headed in the right direction? (I am not sure about whether
the API's I changed are used by extensions or not)
>
>
yuja added a comment.
In https://phab.mercurial-scm.org/D1678#28686, @pulkit wrote:
> @yuja am I headed in the right direction? (I am not sure about whether the
API's I changed are used by extensions or not)
Sort of, but I was thinking of a simpler one. Just parse specs twice,
pulkit added a subscriber: yuja.
pulkit added a comment.
@yuja am I headed in the right direction? (I am not sure about whether the
API's I changed are used by extensions or not)
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1678
To: pulkit, #hg-reviewers
Cc:
pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This is a part of series where we move logic around so that we can get the
tree
at a higher level function such as repo.anyrevs(). This will help us in
reading
