D2226: progress: use %d to format ints instead of %s

2018-02-14 Thread yuja (Yuya Nishihara)
yuja added a comment. Maybe we want `'%d'`, not `'% d'`? The latter means to use `' '` in place of `'+'` sign. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2226 To: durin42, #hg-reviewers, indygreg Cc: yuja, indygreg, mercurial-devel

D2226: progress: use %d to format ints instead of %s

2018-02-13 Thread durin42 (Augie Fackler)
durin42 added a comment. In https://phab.mercurial-scm.org/D2226#36921, @indygreg wrote: > Ugh. Maybe `.format()` would be better here. We can use that in 3.5 for bytes, right? Python 3.6.2 (default, Jul 17 2017, 17:35:42) [GCC 4.2.1 Compatible Apple LLVM 8.1.0

D2226: progress: use %d to format ints instead of %s

2018-02-13 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG7f5108e58083: progress: use %d to format ints instead of %s (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2226: progress: use %d to format ints instead of %s

2018-02-13 Thread indygreg (Gregory Szorc)
indygreg accepted this revision. indygreg added a comment. This revision is now accepted and ready to land. Ugh. Maybe `.format()` would be better here. We can use that in 3.5 for bytes, right? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2226 To: durin42,

D2226: progress: use %d to format ints instead of %s

2018-02-13 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Due to behavioral changes between '% Ns' and '% Nd' this has some unfortunate extra dancing. I'm not sure of a better way to solve this problem. REPOSITORY