Re: [PATCH RFC] ui: add support for a tweakdefaults knob

2017-06-20 Thread Pierre-Yves David
On 06/20/2017 03:53 AM, Augie Fackler wrote: On Jun 19, 2017, at 11:32 AM, Pierre-Yves David wrote: I'm not sure what is your concerns here can you elaborate? We have about 200 known config option in core. That seems a manageable number of object.

Re: [PATCH RFC] ui: add support for a tweakdefaults knob

2017-06-19 Thread Augie Fackler
> On Jun 19, 2017, at 11:32 AM, Pierre-Yves David > wrote: > >>> >>> I'm not sure what is your concerns here can you elaborate? We have about >>> 200 known config option in core. That seems a manageable number of object. >> >> Sorry, I just felt it's

Re: [PATCH RFC] ui: add support for a tweakdefaults knob

2017-06-19 Thread Pierre-Yves David
On 06/19/2017 04:58 PM, Yuya Nishihara wrote: On Mon, 19 Jun 2017 16:04:41 +0200, Pierre-Yves David wrote: There have been talk about such registry of option for quite some time (including at the 4.2 central sprint). David Demelier ping me about this[1] again 10 days ago and found some time

Re: [PATCH RFC] ui: add support for a tweakdefaults knob

2017-06-19 Thread Yuya Nishihara
On Mon, 19 Jun 2017 16:04:41 +0200, Pierre-Yves David wrote: > >> There have been talk about such registry of option for quite some time > >> (including at the 4.2 central sprint). David Demelier ping me about > >> this[1] again 10 days ago and found some time to poke at it yesterday. > >> > >> It

Re: [PATCH RFC] ui: add support for a tweakdefaults knob

2017-06-19 Thread Yuya Nishihara
On Sun, 18 Jun 2017 21:59:28 -0400, Augie Fackler wrote: > > > On Jun 17, 2017, at 01:01, Yuya Nishihara wrote: > > > >>> I have no idea how we should process values which are only set in > >>> untrusted > >>> config. Using hasconfig(untrusted=True) might be a bit safer, but

Re: [PATCH RFC] ui: add support for a tweakdefaults knob

2017-06-19 Thread David Soria Parra
On Sat, Jun 17, 2017 at 12:14:22AM +0900, Yuya Nishihara wrote: > On Wed, 14 Jun 2017 21:37:21 -0400, Augie Fackler wrote: > > # HG changeset patch > > # User Augie Fackler > > # Date 1497488194 14400 > > # Wed Jun 14 20:56:34 2017 -0400 > > # Node ID

Re: [PATCH RFC] ui: add support for a tweakdefaults knob

2017-06-18 Thread Augie Fackler
> On Jun 18, 2017, at 21:59, Augie Fackler wrote: > >> >> On Jun 17, 2017, at 01:01, Yuya Nishihara wrote: >> I have no idea how we should process values which are only set in untrusted config. Using hasconfig(untrusted=True) might be a bit safer,

Re: [PATCH RFC] ui: add support for a tweakdefaults knob

2017-06-18 Thread Pierre-Yves David
On 06/15/2017 05:48 PM, Yuya Nishihara wrote: On Thu, 15 Jun 2017 11:21:33 -0400, Augie Fackler wrote: On Jun 15, 2017, at 11:19, Yuya Nishihara wrote: On Wed, 14 Jun 2017 21:37:21 -0400, Augie Fackler wrote: # HG changeset patch # User Augie Fackler # Date

Re: [PATCH RFC] ui: add support for a tweakdefaults knob

2017-06-16 Thread Yuya Nishihara
On Fri, 16 Jun 2017 19:26:00 -0400, Augie Fackler wrote: > > On Jun 16, 2017, at 11:14, Yuya Nishihara wrote: > > On Wed, 14 Jun 2017 21:37:21 -0400, Augie Fackler wrote: > >> # HG changeset patch > >> # User Augie Fackler > >> # Date 1497488194 14400 > >> #

Re: [PATCH RFC] ui: add support for a tweakdefaults knob

2017-06-16 Thread Augie Fackler
> On Jun 16, 2017, at 11:14, Yuya Nishihara wrote: > > On Wed, 14 Jun 2017 21:37:21 -0400, Augie Fackler wrote: >> # HG changeset patch >> # User Augie Fackler >> # Date 1497488194 14400 >> # Wed Jun 14 20:56:34 2017 -0400 >> # Node ID

Re: [PATCH RFC] ui: add support for a tweakdefaults knob

2017-06-16 Thread Yuya Nishihara
On Wed, 14 Jun 2017 21:37:21 -0400, Augie Fackler wrote: > # HG changeset patch > # User Augie Fackler > # Date 1497488194 14400 > # Wed Jun 14 20:56:34 2017 -0400 > # Node ID 0e5ea7a86a8021d02218c35b07366ac6081ab3fb > # Parent 3abba5bc34546951b11b1bd3f5e5c77b90d950d1 >

Re: [PATCH RFC] ui: add support for a tweakdefaults knob

2017-06-15 Thread Martin von Zweigbergk via Mercurial-devel
On Thu, Jun 15, 2017 at 8:19 AM, Yuya Nishihara wrote: > On Wed, 14 Jun 2017 21:37:21 -0400, Augie Fackler wrote: >> # HG changeset patch >> # User Augie Fackler >> # Date 1497488194 14400 >> # Wed Jun 14 20:56:34 2017 -0400 >> # Node ID

Re: [PATCH RFC] ui: add support for a tweakdefaults knob

2017-06-15 Thread Martin von Zweigbergk via Mercurial-devel
On Wed, Jun 14, 2017 at 6:37 PM, Augie Fackler wrote: > # HG changeset patch > # User Augie Fackler > # Date 1497488194 14400 > # Wed Jun 14 20:56:34 2017 -0400 > # Node ID 0e5ea7a86a8021d02218c35b07366ac6081ab3fb > # Parent

Re: [PATCH RFC] ui: add support for a tweakdefaults knob

2017-06-15 Thread Yuya Nishihara
On Thu, 15 Jun 2017 11:21:33 -0400, Augie Fackler wrote: > > On Jun 15, 2017, at 11:19, Yuya Nishihara wrote: > > On Wed, 14 Jun 2017 21:37:21 -0400, Augie Fackler wrote: > >> # HG changeset patch > >> # User Augie Fackler > >> # Date 1497488194 14400 > >> #

Re: [PATCH RFC] ui: add support for a tweakdefaults knob

2017-06-15 Thread Augie Fackler
> On Jun 15, 2017, at 11:19, Yuya Nishihara wrote: > > On Wed, 14 Jun 2017 21:37:21 -0400, Augie Fackler wrote: >> # HG changeset patch >> # User Augie Fackler >> # Date 1497488194 14400 >> # Wed Jun 14 20:56:34 2017 -0400 >> # Node ID

Re: [PATCH RFC] ui: add support for a tweakdefaults knob

2017-06-15 Thread Yuya Nishihara
On Wed, 14 Jun 2017 21:37:21 -0400, Augie Fackler wrote: > # HG changeset patch > # User Augie Fackler > # Date 1497488194 14400 > # Wed Jun 14 20:56:34 2017 -0400 > # Node ID 0e5ea7a86a8021d02218c35b07366ac6081ab3fb > # Parent 3abba5bc34546951b11b1bd3f5e5c77b90d950d1 >

Re: [PATCH RFC] ui: add support for a tweakdefaults knob

2017-06-15 Thread Augie Fackler
> On Jun 15, 2017, at 01:14, Martin von Zweigbergk > wrote: > > At what config level is the tweaking done? It's done really late, because it's plausible that the user-level or repo-level hgrc would contain ui.tweakdefaults=True. It checks for all the config entries it

Re: [PATCH RFC] ui: add support for a tweakdefaults knob

2017-06-14 Thread Martin von Zweigbergk via Mercurial-devel
On Wed, Jun 14, 2017 at 6:37 PM, Augie Fackler wrote: > # HG changeset patch > # User Augie Fackler > # Date 1497488194 14400 > # Wed Jun 14 20:56:34 2017 -0400 > # Node ID 0e5ea7a86a8021d02218c35b07366ac6081ab3fb > # Parent

Re: [PATCH RFC] ui: add support for a tweakdefaults knob

2017-06-14 Thread Siddharth Agarwal
On 6/14/17 6:37 PM, Augie Fackler wrote: # HG changeset patch # User Augie Fackler # Date 1497488194 14400 # Wed Jun 14 20:56:34 2017 -0400 # Node ID 0e5ea7a86a8021d02218c35b07366ac6081ab3fb # Parent 3abba5bc34546951b11b1bd3f5e5c77b90d950d1 ui: add support for a

Re: [PATCH RFC] ui: add support for a tweakdefaults knob

2017-06-14 Thread Sean Farley
Sean Farley writes: > Augie Fackler writes: > >> # HG changeset patch >> # User Augie Fackler >> # Date 1497488194 14400 >> # Wed Jun 14 20:56:34 2017 -0400 >> # Node ID 0e5ea7a86a8021d02218c35b07366ac6081ab3fb >> # Parent

Re: [PATCH RFC] ui: add support for a tweakdefaults knob

2017-06-14 Thread Sean Farley
Augie Fackler writes: > # HG changeset patch > # User Augie Fackler > # Date 1497488194 14400 > # Wed Jun 14 20:56:34 2017 -0400 > # Node ID 0e5ea7a86a8021d02218c35b07366ac6081ab3fb > # Parent 3abba5bc34546951b11b1bd3f5e5c77b90d950d1 > ui: add support