https://bz.mercurial-scm.org/show_bug.cgi?id=5393

            Bug ID: 5393
           Summary: run-tests.py uses pipe.wait()
           Product: Mercurial
           Version: unspecified
          Hardware: PC
                OS: Mac OS
            Status: UNCONFIRMED
          Severity: feature
          Priority: wish
         Component: Mercurial
          Assignee: bugzi...@selenic.com
          Reporter: fij...@gmail.com
                CC: mercurial-de...@selenic.com

pipe.wait() is unreliable way to do those things. From the docs:

Warning This will deadlock when using stdout=PIPE and/or stderr=PIPE and the
child process generates enough output to a pipe such that it blocks waiting for
the OS pipe buffer to accept more data. Use communicate() to avoid that.

Don't ask me why it can't just be implemented as communicate() then, but it is
what it is. I think it's a cause of some deadlocks every now and again while
running tests

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Reply via email to