Re: [PATCH] hgweb: don't try to wrap mod_wsgi loggers

2020-10-01 Thread Yuya Nishihara
On Wed, 30 Sep 2020 09:16:27 -0700, Ludovic Chabant wrote: > > It might be better to test isinstance(stream, io.RawIOBase). If the stream > > is a RawIOBase, write() should return the number of bytes written. > > I'm not super familiar with Python C/native extension code, but it doesn't > look

Re: [PATCH] hgweb: don't try to wrap mod_wsgi loggers

2020-09-30 Thread Ludovic Chabant
> It might be better to test isinstance(stream, io.RawIOBase). If the stream > is a RawIOBase, write() should return the number of bytes written. I'm not super familiar with Python C/native extension code, but it doesn't look to me like the mod_wsgi.Log type is inheriting from an io base class?

Re: [PATCH] hgweb: don't try to wrap mod_wsgi loggers

2020-09-30 Thread Yuya Nishihara
On Tue, 29 Sep 2020 14:32:21 -0700, Ludovic Chabant wrote: > # HG changeset patch > # User Ludovic Chabant > # Date 1601413962 25200 > # Tue Sep 29 14:12:42 2020 -0700 > # Node ID f8726d166fcaa0d690f6783146172758b2e14deb > # Parent 80bf7b1ada15622ea45b8ecc5647404f5acb2905 > hgweb: don't try

[PATCH] hgweb: don't try to wrap mod_wsgi loggers

2020-09-29 Thread Ludovic Chabant
# HG changeset patch # User Ludovic Chabant # Date 1601413962 25200 # Tue Sep 29 14:12:42 2020 -0700 # Node ID f8726d166fcaa0d690f6783146172758b2e14deb # Parent 80bf7b1ada15622ea45b8ecc5647404f5acb2905 hgweb: don't try to wrap mod_wsgi loggers diff --git a/mercurial/utils/procutil.py