Re: [PATCH] phabricator: drop support for the deprecated `phabricator.token` config

On Sat, 12 May 2018 14:53:38 -0400, Gregory Szorc wrote: On Sat, May 12, 2018 at 8:18 AM, Augie Fackler wrote: > On May 11, 2018, at 9:31 PM, Matt Harbison wrote: > > BTW, are there any plans to move this into the

Re: [PATCH] phabricator: drop support for the deprecated `phabricator.token` config

On Sat, 12 May 2018 17:34:33 -0400, Julien Cristau wrote: Hi, On Fri, May 11, 2018 at 21:16:09 -0400, Matt Harbison wrote: # HG changeset patch # User Matt Harbison # Date 1526004793 14400 # Thu May 10 22:13:13 2018 -0400 # Node ID

Re: [PATCH] phabricator: drop support for the deprecated `phabricator.token` config

Hi, On Fri, May 11, 2018 at 21:16:09 -0400, Matt Harbison wrote: > # HG changeset patch > # User Matt Harbison > # Date 1526004793 14400 > # Thu May 10 22:13:13 2018 -0400 > # Node ID 35b230be2610a6ba4b6d6b60e228ec4a8ddfdfae > # Parent

Re: [PATCH] phabricator: drop support for the deprecated `phabricator.token` config

On Sat, May 12, 2018 at 8:18 AM, Augie Fackler wrote: > > > > On May 11, 2018, at 9:31 PM, Matt Harbison > wrote: > > > > BTW, are there any plans to move this into the bundled extensions? > > Broadly, yes. The big blocker is having a testing story,

Re: [PATCH] phabricator: drop support for the deprecated `phabricator.token` config

> On May 12, 2018, at 11:46 AM, Matt Harbison wrote: > > On Sat, 12 May 2018 11:18:18 -0400, Augie Fackler wrote: > >> >> >>> On May 11, 2018, at 9:31 PM, Matt Harbison wrote: >>> >>> I dabbled with Reviewboard this week,

Re: [PATCH] phabricator: drop support for the deprecated `phabricator.token` config

On Sat, 12 May 2018 11:18:18 -0400, Augie Fackler wrote: On May 11, 2018, at 9:31 PM, Matt Harbison wrote: I dabbled with Reviewboard this week, but I like how this can download a series, remember what review a commit is associated with, etc.

Re: [PATCH] phabricator: drop support for the deprecated `phabricator.token` config

> On May 11, 2018, at 9:31 PM, Matt Harbison wrote: > > BTW, are there any plans to move this into the bundled extensions? Broadly, yes. The big blocker is having a testing story, because right now the “best” options I’ve heard are: 1) use a docker container to spin

Re: [PATCH] phabricator: drop support for the deprecated `phabricator.token` config

On Fri, May 11, 2018 at 8:01 PM, Matt Harbison wrote: > On Fri, 11 May 2018 22:51:27 -0400, Yuya Nishihara wrote: > > On Fri, 11 May 2018 21:31:48 -0400, Matt Harbison wrote: >> >>> > phabricator: drop support for the deprecated `phabricator.token` config

Re: [PATCH] phabricator: drop support for the deprecated `phabricator.token` config

On Fri, 11 May 2018 22:51:27 -0400, Yuya Nishihara wrote: On Fri, 11 May 2018 21:31:48 -0400, Matt Harbison wrote: > phabricator: drop support for the deprecated `phabricator.token` config BTW, are there any plans to move this into the bundled extensions? Perhaps someone

Re: [PATCH] phabricator: drop support for the deprecated `phabricator.token` config

On Fri, 11 May 2018 21:31:48 -0400, Matt Harbison wrote: > > phabricator: drop support for the deprecated `phabricator.token` config > > BTW, are there any plans to move this into the bundled extensions? Perhaps someone will have to spend some time on making it testable. FWIW, the new config

Re: [PATCH] phabricator: drop support for the deprecated `phabricator.token` config

On Fri, 11 May 2018 21:16:09 -0400, Matt Harbison wrote: > # HG changeset patch > # User Matt Harbison > # Date 1526004793 14400 > # Thu May 10 22:13:13 2018 -0400 > # Node ID 35b230be2610a6ba4b6d6b60e228ec4a8ddfdfae > # Parent

Re: [PATCH] phabricator: drop support for the deprecated `phabricator.token` config

On Fri, 11 May 2018 21:16:09 -0400, Matt Harbison wrote: # HG changeset patch # User Matt Harbison # Date 1526004793 14400 # Thu May 10 22:13:13 2018 -0400 # Node ID 35b230be2610a6ba4b6d6b60e228ec4a8ddfdfae # Parent

[PATCH] phabricator: drop support for the deprecated `phabricator.token` config

# HG changeset patch # User Matt Harbison # Date 1526004793 14400 # Thu May 10 22:13:13 2018 -0400 # Node ID 35b230be2610a6ba4b6d6b60e228ec4a8ddfdfae # Parent 3ac950cd597857af7797f75bb3a6b4c3694cc79c phabricator: drop support for the deprecated `phabricator.token`