Re: [PATCH] py3: handle os.environ.get() case in module loader

2016-09-04 Thread Yuya Nishihara
On Sat, 3 Sep 2016 21:14:37 +0530, Pulkit Goyal wrote: > os.environ for py2 and os.environb for py3, in that case rather having > util.envrion, it will be better to convert environ to environb using > the transformer. What say? We'll need util.environ or pycompat.environ anyway because there is

Re: [PATCH] py3: handle os.environ.get() case in module loader

2016-09-03 Thread Pulkit Goyal
os.environ for py2 and os.environb for py3, in that case rather having util.envrion, it will be better to convert environ to environb using the transformer. What say? On Thu, Aug 18, 2016 at 1:59 PM, Yuya Nishihara wrote: > On Wed, 17 Aug 2016 10:46:01 -0700, Siddharth Agarwal

Re: [PATCH] py3: handle os.environ.get() case in module loader

2016-08-18 Thread Yuya Nishihara
On Wed, 17 Aug 2016 10:46:01 -0700, Siddharth Agarwal wrote: > On 8/17/16 10:21, Gregory Szorc wrote: > > WindowsUTF8Plan has existed for years without any movement. Addressing > > that will require a massive refactor. Since it isn't on our radar, I > > think it is out of scope for Python 3

Re: [PATCH] py3: handle os.environ.get() case in module loader

2016-08-17 Thread Gregory Szorc
On Wed, Aug 17, 2016 at 10:04 AM, Siddharth Agarwal wrote: > On 8/4/16 20:26, Siddharth Agarwal wrote: > >> >> I agree with Greg -- this makes things more complicated than necessary. >> We should just have a helper (e.g. util.environ) that gets assigned to >> os.environ on

Re: [PATCH] py3: handle os.environ.get() case in module loader

2016-08-17 Thread Siddharth Agarwal
On 8/4/16 20:26, Siddharth Agarwal wrote: I agree with Greg -- this makes things more complicated than necessary. We should just have a helper (e.g. util.environ) that gets assigned to os.environ on py2 and os.environb on py3. (And with possibly different behavior on Windows, similar to