Re: [PATCH] revert: do not reverse hunks in interactive when REV is not parent (issue5096)

2017-11-03 Thread Martin von Zweigbergk via Mercurial-devel
On Fri, Nov 3, 2017 at 1:09 PM, Augie Fackler wrote: > Should we add a release notes directive like this: > > .. feature:: > > When interactive revert is run against a revision other than the working > directory parent, the diff shown is the diff to *apply* to the working >

Re: [PATCH] revert: do not reverse hunks in interactive when REV is not parent (issue5096)

2017-11-03 Thread Augie Fackler
Should we add a release notes directive like this: .. feature:: When interactive revert is run against a revision other than the working directory parent, the diff shown is the diff to *apply* to the working directory, rather than the diff to *discard* from the working copy. This is in

Re: [PATCH] revert: do not reverse hunks in interactive when REV is not parent (issue5096)

2017-11-03 Thread Martin von Zweigbergk via Mercurial-devel
Queued, thanks! On Fri, Nov 3, 2017 at 9:34 AM, Denis Laxalde wrote: > # HG changeset patch > # User Denis Laxalde > # Date 1509716857 -3600 > # Fri Nov 03 14:47:37 2017 +0100 > # Node ID 095ef7f12cb36330d5e2b35b6c93fe27f6c1aacc > # Parent

[PATCH] revert: do not reverse hunks in interactive when REV is not parent (issue5096)

2017-11-03 Thread Denis Laxalde
# HG changeset patch # User Denis Laxalde # Date 1509716857 -3600 # Fri Nov 03 14:47:37 2017 +0100 # Node ID 095ef7f12cb36330d5e2b35b6c93fe27f6c1aacc # Parent 7ebf850d3166a64ff33b4b85adb481b533ddbf86 # Available At http://hg.logilab.org/users/dlaxalde/hg #

Re: [PATCH] revert: do not reverse hunks in interactive when REV is not parent (issue5096)

2016-10-08 Thread Pierre-Yves David
On 09/30/2016 06:39 PM, Martin von Zweigbergk via Mercurial-devel wrote: This looks great to me. I think Pierre-Yves wanted to discuss this in person at the sprint, and since the sprint is only a week away, I can wait. I won't be at the sprint, but Augie/durin42 will be and I saw that he also

Re: [PATCH] revert: do not reverse hunks in interactive when REV is not parent (issue5096)

2016-09-30 Thread Martin von Zweigbergk via Mercurial-devel
This looks great to me. I think Pierre-Yves wanted to discuss this in person at the sprint, and since the sprint is only a week away, I can wait. I won't be at the sprint, but Augie/durin42 will be and I saw that he also was confused about the current behavior. I still haven't heard from anyone